Re: [PATCH v2] drm/amdgpu: Enable SDMA utilization for Arcturus

2020-09-11 Thread Felix Kuehling
Am 2020-09-11 um 5:33 p.m. schrieb Mukul Joshi: > SDMA utilization calculations are enabled/disabled by > writing to SDMAx_PUB_DUMMY_REG2 register. Currently, > enable this only for Arcturus. > > Signed-off-by: Mukul Joshi Reviewed-by: Felix Kuehling > --- >

Re: [PATCH v2 2/3] drm/amdkfd: Add process eviction counters to sysfs

2020-09-11 Thread Felix Kuehling
Am 2020-09-11 um 4:10 p.m. schrieb Philip Cox: > Add per-process eviction counters to sysfs to keep track of > how many eviction events have happened for each process. > > v2: rename the stats dir, and track all evictions per process, per device. > > Signed-off-by: Philip Cox Some more comments

[PATCH] drm/amdgpu: Workaround RCC_DEV0_EPF0_STRAP0 access issue for SRIOV

2020-09-11 Thread Rohit Khaire
Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c b/drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c index 7429f30398b9..fdfa075e6d5a 100644 ---

[PATCH v2] drm/amdgpu: Enable SDMA utilization for Arcturus

2020-09-11 Thread Mukul Joshi
SDMA utilization calculations are enabled/disabled by writing to SDMAx_PUB_DUMMY_REG2 register. Currently, enable this only for Arcturus. Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-11 Thread Luben Tuikov
On 2020-09-08 16:09, Luben Tuikov wrote: > On 2020-09-07 04:07, Daniel Vetter wrote: >> On Mon, Sep 07, 2020 at 10:06:08AM +0200, Daniel Vetter wrote: >>> On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: > > Convert to

[PATCH v2 2/3] drm/amdkfd: Add process eviction counters to sysfs

2020-09-11 Thread Philip Cox
Add per-process eviction counters to sysfs to keep track of how many eviction events have happened for each process. v2: rename the stats dir, and track all evictions per process, per device. Signed-off-by: Philip Cox --- .../drm/amd/amdkfd/kfd_device_queue_manager.c | 9 ++

Re: [PATCH v2 3/4] drm/amd/display: Add pipe_state tracepoint

2020-09-11 Thread Rodrigo Siqueira
On 09/11, Kazlauskas, Nicholas wrote: > On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: > > This commit introduces a trace mechanism for struct pipe_ctx by adding a > > middle layer struct in the amdgpu_dm_trace.h for capturing the most > > important data from struct pipe_ctx and showing its

[PATCH 2/2] drm/amdgpu: More accurate description of a function param

2020-09-11 Thread Oak Zeng
Add more accurate description of the pe parameter of function amdgpu_vm_sdma_udpate and amdgpu_vm_cpu_update Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/2] drm/amdgpu: Add comment to function amdgpu_ttm_alloc_gart

2020-09-11 Thread Oak Zeng
Add comments to refect what function does Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 63e5414..8b70445

Re: [PATCH v2 1/4] drm/amd/display: Rework registers tracepoint

2020-09-11 Thread Rodrigo Siqueira
On 09/11, Kazlauskas, Nicholas wrote: > On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: > > amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason, > > this commits abstract these two events by using DECLARE_EVENT_CLASS and > > create an instance of it for each one of these events.

Re: [PATCH] drm/amdgpu: Enable SDMA utilization for Arcturus

2020-09-11 Thread Felix Kuehling
Am 2020-09-11 um 12:27 p.m. schrieb Mukul Joshi: > SDMA utilization calculations are enabled/disabled by > writing to SDMAx_PUB_DUMMY_REG2 register. Currently, > enable this only for Arcturus. > > Signed-off-by: Mukul Joshi > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 10 ++ > 1 file

Re: [PATCH v2 1/4] drm/amd/display: Rework registers tracepoint

2020-09-11 Thread Kazlauskas, Nicholas
On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason, this commits abstract these two events by using DECLARE_EVENT_CLASS and create an instance of it for each one of these events. Signed-off-by: Rodrigo Siqueira This looks

Re: [PATCH v2 3/4] drm/amd/display: Add pipe_state tracepoint

2020-09-11 Thread Kazlauskas, Nicholas
On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: This commit introduces a trace mechanism for struct pipe_ctx by adding a middle layer struct in the amdgpu_dm_trace.h for capturing the most important data from struct pipe_ctx and showing its data via tracepoint. This tracepoint was added to

Re: [PATCH v2 3/3] drm/amd/display: Move disable interrupt into commit tail

2020-09-11 Thread Kazlauskas, Nicholas
On 2020-09-11 12:27 p.m., Aurabindo Pillai wrote: [Why] Since there is no need for accessing crtc state in the interrupt handler, interrupts need not be disabled well in advance, and can be moved to commit_tail where it should be. Signed-off-by: Aurabindo Pillai ---

Re: [PATCH 2/3] drm/amd/display: Refactor to prevent crtc state access in DM IRQ handler

2020-09-11 Thread Aurabindo Pillai
On Wed, 2020-09-09 at 11:00 -0400, Kazlauskas, Nicholas wrote: > On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote: > > [Why]Currently commit_tail holds global locks and wait for > > dependencies which isagainst the DRM API contracts. Inorder to fix > > this, IRQ handler should be ableto run

[PATCH] drm/amdgpu: Enable SDMA utilization for Arcturus

2020-09-11 Thread Mukul Joshi
SDMA utilization calculations are enabled/disabled by writing to SDMAx_PUB_DUMMY_REG2 register. Currently, enable this only for Arcturus. Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 0/3] Refactor DM IRQ handling

2020-09-11 Thread Aurabindo Pillai
Changes in V2: * fix memory leak. Interrupts are disabled too early in DM's atomic_commit() which can cause issues in certain situations with non blocking commits timing out on flip_done interrupt. The early disabling of interrupts were necessary due to interrupts accessing crtc state directly.

[PATCH v2 1/3] drm/amdgpu: Move existing pflip fields into separate struct

2020-09-11 Thread Aurabindo Pillai
[Why] To refactor DM IRQ management, all fields used by IRQ is best moved to a separate struct so that main amdgpu_crtc struct need not be changed Location of the new struct shall be in DM Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 ++-

[PATCH v2 2/3] drm/amd/display: Refactor to prevent crtc state access in DM IRQ handler

2020-09-11 Thread Aurabindo Pillai
[Why] Currently commit_tail holds global locks and wait for dependencies which is against the DRM API contracts. Inorder to fix this, IRQ handler should be able to run without having to access crtc state. Required parameters are copied over so that they can be directly accessed from the interrupt

[PATCH v2 3/3] drm/amd/display: Move disable interrupt into commit tail

2020-09-11 Thread Aurabindo Pillai
[Why] Since there is no need for accessing crtc state in the interrupt handler, interrupts need not be disabled well in advance, and can be moved to commit_tail where it should be. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 41 ++- 1 file

[PATCH v2 4/4] drm/amd/display: Add tracepoint for capturing clocks state

2020-09-11 Thread Rodrigo Siqueira
The clock state update is the source of many problems, and capturing this sort of information helps debug. This commit introduces tracepoints for capturing clock values and also add traces in DCE, DCN1, DCN2x, and DCN3. Co-developed-by: Nicholas Kazlauskas Signed-off-by: Nicholas Kazlauskas

[PATCH v2 0/4] Enlarge tracepoints in the display component

2020-09-11 Thread Rodrigo Siqueira
Debug issues related to display can be a challenge due to the complexity around this topic and different source of information might help in this process. We already have support for tracepoints inside the display component, i.e., we have the basic functionalities available and we just need to

[PATCH v2 2/4] drm/amd/display: Add tracepoint for amdgpu_dm

2020-09-11 Thread Rodrigo Siqueira
Debug amdgpu_dm could be a complicated task, therefore, this commit adds tracepoints in some convenient functions such as plane and connector check inside amdgpu_dm. Co-developed-by: Nicholas Kazlauskas Signed-off-by: Nicholas Kazlauskas Signed-off-by: Rodrigo Siqueira ---

[PATCH v2 3/4] drm/amd/display: Add pipe_state tracepoint

2020-09-11 Thread Rodrigo Siqueira
This commit introduces a trace mechanism for struct pipe_ctx by adding a middle layer struct in the amdgpu_dm_trace.h for capturing the most important data from struct pipe_ctx and showing its data via tracepoint. This tracepoint was added to dc.c and dcn10_hw_sequencer, however, it can be added

[PATCH v2 1/4] drm/amd/display: Rework registers tracepoint

2020-09-11 Thread Rodrigo Siqueira
amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason, this commits abstract these two events by using DECLARE_EVENT_CLASS and create an instance of it for each one of these events. Signed-off-by: Rodrigo Siqueira --- .../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 55

[PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-11 Thread YueHaibing
If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: ‘raven_device_info’ defined but not used [-Wunused-const-variable=] static const struct kfd_device_info raven_device_info = { ^

[PATCH] drm/amd/display: Remove set but used 'temp'

2020-09-11 Thread Ye Bin
Addresses the following gcc warning with "make W=1": In file included from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../dmub_srv.h:67:0, from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn21.c:26: drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../inc/dmub_cmd.h: In function

Re: [PATCH] drm/radeon: revert "Prefer lower feedback dividers"

2020-09-11 Thread Nirmoy
I don't know much about display code but this is Acked-by: Nirmoy Das as Sonny confirmed that the revert fixes display corruption. On 9/11/20 9:35 AM, Christian König wrote: Ping, we need to revert this ASAP. Christian. Am 09.09.20 um 13:16 schrieb Christian König: Turns out this breaks

Re: [PATCH] drm/radeon: revert "Prefer lower feedback dividers"

2020-09-11 Thread Christian König
Ping, we need to revert this ASAP. Christian. Am 09.09.20 um 13:16 schrieb Christian König: Turns out this breaks a lot of different hardware. This reverts commit 522ff3a8b6d73a31084b4b087b458f7fa0ac1e14. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_display.c | 2 +-

RE: [PATCH] drm/amdgpu: Update RAS init handling

2020-09-11 Thread Zhang, Hawking
[AMD Public Use] + { + dev_warn(psp->adev->dev, "RAS Init Status: 0x%X\n", ras_cmd->ras_status); + } Please remove the redundant bracket. Other than that, the patch is Reviewed-by: Hawking Zhang