Re: [PATCH 01/11] drm/ttm: add ttm_bo_pin()/ttm_bo_unpin() v2

On Tue, Sep 22, 2020 at 09:31:58PM +0800, Christian König wrote: > As an alternative to the placement flag add a > pin count to the ttm buffer object. > > v2: add dma_resv_assert_help() calls > > Signed-off-by: Christian König Series look good for me as well. Reviewed-by: Huang Rui Only one

RE: [PATCH] drm/amdgpu: remove gpu_info fw support for sienna_cichlid etc.

[AMD Public Use] Patch is Reviewed-by: Likun Gao Regards, Likun -Original Message- From: Jiansong Chen Sent: Wednesday, September 23, 2020 12:11 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Gao, Likun ; Chen, Jiansong (Simon) Subject: [PATCH] drm/amdgpu: remove gpu_info fw

[PATCH] drm/amdgpu: remove gpu_info fw support for sienna_cichlid etc.

Remove gpu_info fw support for sienna_cichlid etc., since the information can be retrieved from discovery binary. Signed-off-by: Jiansong Chen Change-Id: I4cb42aae5d680f28209122bb37962a2291ef785f --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++ 1 file changed, 2 insertions(+), 8

Re: [PATCH 01/11] drm/ttm: add ttm_bo_pin()/ttm_bo_unpin() v2

On Tue, 22 Sep 2020 at 23:32, Christian König wrote: > > As an alternative to the placement flag add a > pin count to the ttm buffer object. These all look good to me, nice cleanup. For the series: Reviewed-by: Dave Airlie ___ amd-gfx mailing list

dcn20_validate_bandwidth warnings.

My system log is full of warnings about dcn20_validate_bandwidth (see below.) This is with RX 5500 XT device running amd gpupro driver. 20.30-1109583 amdgpu-dkms 1:5.6.5.24-1109583 This seems to coincide with a screen full of pixel noise, and seems triggered when going in, or out of a sleep/idle

Re: [PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter

On 22/09/2020 21:33, Alex Deucher wrote: >> +/** >> + * DOC: pixel_encoding (string) >> + * Specify the initial pixel encoding used by a connector. >> + */ >> +static char amdgpu_pixel_encoding[MAX_INPUT]; >> +MODULE_PARM_DESC(pixel_encoding, "Override pixel encoding"); >>

Re: [PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter

On Tue, Sep 22, 2020 at 3:34 PM James Ettle wrote: > > Exposes the pixel encoding as the DRM property "pixel encoding" > and the module parameter pixel_encoding. > > The DRM property may take values "auto" (current behaviour > when a display is plugged in), "rgb" for RGB, or "ycbcr444" for >

[PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter

Exposes the pixel encoding as the DRM property "pixel encoding" and the module parameter pixel_encoding. The DRM property may take values "auto" (current behaviour when a display is plugged in), "rgb" for RGB, or "ycbcr444" for YCbCr 4:4:4. The module parameter may only be set on boot and is of

Re: [PATCH] drm/amdgpu/display: fix CFLAGS setup for DCN30

Acked-by: Nirmoy Das On 9/22/20 5:36 PM, Alex Deucher wrote: Properly handle clang and older versions of gcc. Fixes: e77165bf7b02a3 ("drm/amd/display: Add DCN3 blocks to Makefile") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 18 -- 1

[PATCH v2] Add PP_FEATURE_MASK comments

Documents PP_FEATURE_MASK enum. Provides instructions on how to use ppfeaturemasks. v2: Improved enum definitions. Adds kernel command line parameters to ppfeaturemask instructions. Signed-off-by: Ryan Taylor Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 28

Re: [PATCH] gpu/drm/radeon: fix spellint typo in comments

Applied with subject typo fixed. Thanks! Alex On Tue, Sep 22, 2020 at 10:07 AM Ernst Sjöstrand wrote: > > There is a typo in your patch subject. ;-) > > Regards > //Ernst > > Den tis 22 sep. 2020 kl 15:11 skrev Wang Qing : >> >> Modify the comment typo: "definately" -> "definitely". >> >>

Re: [PATCH v2] drm/amd/display: optimize code runtime a bit

Applied. Thanks! Alex On Tue, Sep 22, 2020 at 3:52 AM Bernard Zhao wrote: > > In the function dal_ddc_service_query_ddc_data, > get rid of dal_ddc_i2c_payloads_destroy, call > dal_vector_destruct() directly. > This change is to make the code run a bit fast. > > Signed-off-by: Bernard Zhao >

Re: [PATCH] drm/amd:fix typoes in comments

Applied. Thanks! Alex On Tue, Sep 22, 2020 at 9:11 AM Bernard Zhao wrote: > > Change the comment typo: "programm" -> "program". > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 4 ++-- >

Re: [PATCH] drm/radeon:fix typoes in comments

Applied. Thanks! Alex On Tue, Sep 22, 2020 at 9:11 AM Bernard Zhao wrote: > > Change the comment typo: "programm" -> "program". > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/radeon/uvd_v1_0.c | 4 ++-- > drivers/gpu/drm/radeon/uvd_v2_2.c | 2 +- > drivers/gpu/drm/radeon/uvd_v4_2.c

Re: [PATCH] drm/amd/display: Fix dcn30_optc.o unknown argument with clang

On Mon, Sep 21, 2020 at 6:12 PM Anthony Benware wrote: > > [Why] > Clang can't compile dcn30_optc.o with '-mpreferred-stack-boundary=4' > > [How] > use '-mstack-alignment=4' if Clang is CC and '-mpreferred-stack-boundary=4' > if CC is not Clang > > Signed-off-by: Anthony Benware Thanks for the

[PATCH] drm/amdgpu/display: fix CFLAGS setup for DCN30

Properly handle clang and older versions of gcc. Fixes: e77165bf7b02a3 ("drm/amd/display: Add DCN3 blocks to Makefile") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3] amdgpu: Add initial kernel documentation for the amd_ip_block_type structure

On Mon, Sep 21, 2020 at 11:55 AM Ryan Taylor wrote: > > From: Ryan Taylor > > Added IP block section to amdgpu.rst. > Added more documentation to amd_ip_funcs. > Created documentation for amd_ip_block_type. > > v2: Provides a more detailed DOC section on IP blocks. > v3: Clarifies the IP block

Re: [PATCH] drm/amd/display: Simplify condition in try_disable_dsc

On Tue, Sep 22, 2020 at 3:47 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:637:8: > warning: logical not is only applied to the left hand side of this > comparison [-Wlogical-not-parentheses] >

Re: [PATCH] drm/amdgpu: Add uid info to process BO list

On Tue, Sep 22, 2020 at 10:39 AM Chauhan, Madhav wrote: > > [AMD Public Use] > > -Original Message- > From: Christian König > Sent: Tuesday, September 22, 2020 6:25 PM > To: Chauhan, Madhav ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Surampalli,

RE: [PATCH] drm/amdgpu: Add uid info to process BO list

[AMD Public Use] -Original Message- From: Christian König Sent: Tuesday, September 22, 2020 6:25 PM To: Chauhan, Madhav ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Surampalli, Kishore ; Patel, Mihir ; Saleem, Athar ; Sharma, Shashank Subject: Re:

Re: [PATCH AUTOSEL 5.4 13/15] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

On Mon, Sep 21, 2020 at 04:48:05PM +0200, Michel Dänzer wrote: On 2020-09-21 4:40 p.m., Sasha Levin wrote: From: Michel Dänzer [ Upstream commit 2f228aab21bbc74e90e267a721215ec8be51daf7 ] Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: *

Re: [PATCH] gpu/drm/radeon: fix spellint typo in comments

There is a typo in your patch subject. ;-) Regards //Ernst Den tis 22 sep. 2020 kl 15:11 skrev Wang Qing : > Modify the comment typo: "definately" -> "definitely". > > Signed-off-by: Wang Qing > --- > drivers/gpu/drm/radeon/radeon_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

RE: [PATCH] drm/amdkfd: fix wanting in print statement

[AMD Public Use] Definitely. Reviewed-by: Kent Russell . > -Original Message- > From: Alex Deucher > Sent: Tuesday, September 22, 2020 9:59 AM > To: Russell, Kent > Cc: amd-gfx list ; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdkfd: fix wanting in print statement > > Can I

Re: [PATCH] drm/amdkfd: fix wanting in print statement

Can I get an RB? On Tue, Sep 22, 2020 at 9:56 AM Russell, Kent wrote: > > [AMD Public Use] > > Thanks Alex, sorry about that! > > Kent > > > -Original Message- > > From: amd-gfx On Behalf Of Alex > > Deucher > > Sent: Monday, September 21, 2020 5:33 PM > > To: amd-gfx list > > Cc:

RE: [PATCH] drm/amdkfd: fix wanting in print statement

[AMD Public Use] Thanks Alex, sorry about that! Kent > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Monday, September 21, 2020 5:33 PM > To: amd-gfx list > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdkfd: fix wanting in print statement > >

amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

Hi, I noticed a call trace (attached) when starting my machine (ThinkPad L14). This machine is new and I am still working on it's configuration but visually noticeable is that scrolling in xterms with SHIFT-PgUp/PgDn is broken. Using the mouse wheel works. It seems the call trace has been

[PATCH 07/11] drm/qxl: switch over to the new pin interface

Stop using TTM_PL_FLAG_NO_EVICT. Signed-off-by: Christian König Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.h | 1 - drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +-- drivers/gpu/drm/qxl/qxl_object.c | 44

[PATCH 11/11] drm/ttm: remove TTM_PL_FLAG_NO_EVICT

Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 11 +++ include/drm/ttm/ttm_placement.h | 1 - 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 04/11] drm/vmwgfx: switch over to the new pin interface v2

Stop using TTM_PL_FLAG_NO_EVICT. v2: fix unconditional pinning Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 49 +++--- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c| 4 +-

[PATCH 10/11] drm/ttm: remove ttm_bo_create

Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 40 include/drm/ttm/ttm_bo_api.h | 24 -- 2 files changed, 64 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 06/11] drm/vram-helper: switch over to the new pin interface

Stop using TTM_PL_FLAG_NO_EVICT. Signed-off-by: Christian König Acked-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 37 +++ include/drm/drm_gem_vram_helper.h | 3 --- 2 files changed, 9 insertions(+), 31 deletions(-) diff --git

[PATCH 03/11] drm/vmwgfx: stop using ttm_bo_create

Implement in the driver instead since it is the only user of that function. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 42 ++ drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 6 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 4 +++

[PATCH 09/11] drm/amdgpu: switch over to the new pin interface

Stop using TTM_PL_FLAG_NO_EVICT. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 8 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 5 ++-

[PATCH 08/11] drm/radeon: switch over to the new pin interface

Stop using TTM_PL_FLAG_NO_EVICT. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 1 - drivers/gpu/drm/radeon/radeon_display.c | 9 ++ drivers/gpu/drm/radeon/radeon_object.c | 37 ++--- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

[PATCH 02/11] drm/vmwgfx: remove unused placement combination

Just some dead code cleanup. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 1 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 30 -- 2 files changed, 31 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

[PATCH 01/11] drm/ttm: add ttm_bo_pin()/ttm_bo_unpin() v2

As an alternative to the placement flag add a pin count to the ttm buffer object. v2: add dma_resv_assert_help() calls Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 9 ++--- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 +- include/drm/ttm/ttm_bo_api.h | 26

[PATCH 05/11] drm/nouveau: switch over to the new pin interface

Stop using TTM_PL_FLAG_NO_EVICT. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 48 +++--- drivers/gpu/drm/nouveau/nouveau_bo.h | 3 -- drivers/gpu/drm/nouveau/nouveau_chan.c | 2 +- 3 files changed, 13 insertions(+), 40 deletions(-) diff

Re: [PATCH umr] Fix register name lookup for sdma POLL_REGMEM packet

[AMD Official Use Only - Internal Distribution Only] Hi Xiaojie, I've pushed your patch out to main. In reviewing the SDMA opcode I actually noticed a couple of other minor things to fix up so I've pushed that out too. Cheers, Tom From: Yuan, Xiaojie

[PATCH] gpu/drm/radeon: fix spellint typo in comments

Modify the comment typo: "definately" -> "definitely". Signed-off-by: Wang Qing --- drivers/gpu/drm/radeon/radeon_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index f60fae0..3d6e2cd ---

[PATCH] drm/radeon:fix typoes in comments

Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/radeon/uvd_v1_0.c | 4 ++-- drivers/gpu/drm/radeon/uvd_v2_2.c | 2 +- drivers/gpu/drm/radeon/uvd_v4_2.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amd:fix typoes in comments

Change the comment typo: "programm" -> "program". Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++--

Re: [PATCH] drm/amdgpu: Add uid info to process BO list

Am 22.09.20 um 12:38 schrieb Chauhan, Madhav: [AMD Public Use] -Original Message- From: Koenig, Christian Sent: Tuesday, September 22, 2020 12:15 PM To: Chauhan, Madhav ; amd-gfx@lists.freedesktop.org Cc: Surampalli, Kishore ; Patel, Mihir ; Sharma, Shashank ; Deucher, Alexander ;

RE: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

[AMD Public Use] [AMD Public Use] Hi @Chen, JingWen, CAP firmware will be only used for SRIOV. So please just add specific code path under SRIOV to initialize that firmware. Do not introduce SRIOV specific code for the most PSP firmware you are not used in

RE: [PATCH] drm/amdgpu: Add uid info to process BO list

[AMD Public Use] -Original Message- From: Koenig, Christian Sent: Tuesday, September 22, 2020 12:15 PM To: Chauhan, Madhav ; amd-gfx@lists.freedesktop.org Cc: Surampalli, Kishore ; Patel, Mihir ; Sharma, Shashank ; Deucher, Alexander ; Saleem, Athar Subject: Re: [PATCH] drm/amdgpu:

RE: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

[AMD Public Use] [AMD Public Use] Hi Hawking, We may need other features in PSP in the future, e.g. load cap fw. So we can't skip the whole psp_init_microcode. Best Regards, JingWen Chen From: Deng, Emily Sent: Tuesday, September 22, 2020 6:22 PM To: Wang, Kevin(Yang) ; Zhang, Hawking ;

RE: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

[AMD Public Use] Hi Kevin and Hawking, I think both you are right. But currently we haven't good method to handle this. It seems need to re-arch the whole driver, not only refer to this patch. Only refer to this patch, I think it is OK. Best wishes Emily Deng From: amd-gfx On Behalf Of Wang,

RE: [PATCH 1/1] drm/amdgpu: fix hdp register access error

[AMD Public Use] Thanks. Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Tuesday, September 22, 2020 17:10 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Yang, Stanley Subject: [PATCH 1/1] drm/amdgpu: fix hdp register access error

[PATCH 1/1] drm/amdgpu: fix hdp register access error

mmHDP_READ_CACHE_INVALIDATE register is in HDP not in NBIO Signed-off-by: Stanley.Yang Change-Id: I4375a8a67d3a13f9605479e169169e22dd5833d1 --- drivers/gpu/drm/amd/amdgpu/nv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH] drm/amd/display: Simplify condition in try_disable_dsc

Clang warns: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:637:8: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] && !params[i].clock_force_enable == DSC_CLK_FORCE_DEFAULT) {

Re:Re: [PATCH] drm/amd/display: optimize code runtime a bit

From: Alex Deucher Date: 2020-09-22 03:33:20 To: Bernard Zhao Cc: Harry Wentland ,Leo Li ,Alex Deucher ,"Christian König" ,David Airlie ,Daniel Vetter ,Rodrigo Siqueira ,Jun Lei ,Aric Cyr ,Wenjing Liu ,abdoulaye berthe ,Michael Strauss ,Brandon Syu ,Martin Leung ,amd-gfx list ,Maling

[PATCH v2] drm/amd/display: optimize code runtime a bit

In the function dal_ddc_service_query_ddc_data, get rid of dal_ddc_i2c_payloads_destroy, call dal_vector_destruct() directly. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao Changes since V1: *get rid of dal_ddc_i2c_payloads_destroy, call dal_vector_destruct()

Re: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

[AMD Public Use] Embedding these SRIOV check into the underlying functions is in many places, which is not conducive to subsequent code optimization and maintenance. It took a long time to clean up the SMU code before, but now some new checks have been introduced into the SMU code. I think a

RE: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

[AMD Public Use] 1. Please do not add the amdgpu_sriov_vf check in every psp fw init_microcode function. psp_init_microcode is the entry point for all kinds of psp fw microcode initialization. 2. I'd like to get a whole picture on all the sequence you want to skip from guest side so that we

[PATCH 1/2] drm/amd/pm: Skip use smc fw data in SRIOV

smc fw is not needed in SRIOV, thus driver should not try to get smc fw data. Signed-off-by: Jingwen Chen --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 61 ++- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

[PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

smc, sdma, sos, ta and asd fw is not used in SRIOV. Skip them to accelerate sw_init for navi12. v2: skip above fw in SRIOV for vega10 and sienna_cichlid Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

Re: [PATCH] drm/amdgpu: Add uid info to process BO list

Am 21.09.20 um 21:55 schrieb Chauhan, Madhav: [AMD Public Use] -Original Message- From: Christian König Sent: Tuesday, September 22, 2020 12:54 AM To: Chauhan, Madhav ; amd-gfx@lists.freedesktop.org Cc: Surampalli, Kishore ; Patel, Mihir ; Sharma, Shashank ; Deucher, Alexander ;