[PATCH] drm/amdgpu: VCN 3.0 multiple queue ring reset

2020-12-02 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index 4f718ee803d0..3eaabcfca94a 100644 ---

Re: [PATCH 2/2] drm: amdgpu: fix a kernel-doc markup

2020-12-02 Thread Alex Deucher
On Wed, Dec 2, 2020 at 3:45 AM Christian König wrote: > > Am 02.12.20 um 09:27 schrieb Mauro Carvalho Chehab: > > The function name at kernel-doc markup doesn't match the name > > of the function: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1534: warning: expecting > > prototype for

[pull] amdgpu drm-fixes-5.10

2020-12-02 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit b65054597872ce3aefbc6a666385eabdf9e288da: Linux 5.10-rc6 (2020-11-29 15:50:50 -0800) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.10-2020-12-02 for you to fetch

Re: [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Zack Rusin
> On Dec 2, 2020, at 11:03, Daniel Vetter wrote: > > On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote: >> >> >> >>> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: >>> >>> Hi >>> >>> Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 21:59 schrieb Zack Rusin:

RE: [PATCH] drm/amdgpu/powerplay: parse fan table for CI asics

2020-12-02 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, December 3, 2020 4:18 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: parse fan table

Re: [PATCH 2/2] drm/amd/display: add cursor pitch check

2020-12-02 Thread Alex Deucher
On Wed, Dec 2, 2020 at 4:33 PM Kazlauskas, Nicholas wrote: > > On 2020-12-02 4:09 p.m., Simon Ser wrote: > > Replace the width check with a pitch check, which matches DM internals. > > Add a new check to make sure the pitch (in pixels) matches the width. > > > > Signed-off-by: Simon Ser > > Cc:

Re: [PATCH] drm/amd/display: add debug logs for dm_crtc_helper_atomic_check

2020-12-02 Thread Alex Deucher
On Wed, Dec 2, 2020 at 4:06 PM Simon Ser wrote: > > Instead of silently failing the atomic check, explain what happened via > a debug log. This makes it easier for user-space to figure out why > something failed. > > Signed-off-by: Simon Ser > Cc: Alex Deucher > Cc: Harry Wentland > Cc:

Re: [PATCH 2/2] drm/amd/display: add cursor pitch check

2020-12-02 Thread Kazlauskas, Nicholas
On 2020-12-02 4:09 p.m., Simon Ser wrote: Replace the width check with a pitch check, which matches DM internals. Add a new check to make sure the pitch (in pixels) matches the width. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas Series is:

[PATCH 2/2] drm/amd/display: add cursor pitch check

2020-12-02 Thread Simon Ser
Replace the width check with a pitch check, which matches DM internals. Add a new check to make sure the pitch (in pixels) matches the width. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19

[PATCH 1/2] drm/amd/display: use FB pitch to fill dc_cursor_attributes

2020-12-02 Thread Simon Ser
Instead of relying on pitch (in pixels) == width, use the FB pitch. This is less confusing to readers, and works correctly if we ever support FBs with a pitch (in pixels) != width. This also makes the code symmetrical with fill_plane_buffer_attributes. Signed-off-by: Simon Ser Cc: Alex Deucher

[PATCH 0/2] drm/amd/display: add cursor pitch check

2020-12-02 Thread Simon Ser
We were checking the FB width/height, but were not checking its pitch. This has been tested by running Sway. Simon Ser (2): drm/amd/display: use FB pitch to fill dc_cursor_attributes drm/amd/display: add cursor pitch check .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21

[PATCH] drm/amd/display: add debug logs for dm_crtc_helper_atomic_check

2020-12-02 Thread Simon Ser
Instead of silently failing the atomic check, explain what happened via a debug log. This makes it easier for user-space to figure out why something failed. Signed-off-by: Simon Ser Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas ---

[PATCH] drm/amdgpu/powerplay: parse fan table for CI asics

2020-12-02 Thread Alex Deucher
Set up all the parameters required for SMU fan control if supported. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=201539 Signed-off-by: Alex Deucher --- .../amd/pm/powerplay/hwmgr/processpptables.c | 103 +- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-12-02 Thread Greg KH
On Wed, Dec 02, 2020 at 01:02:06PM -0500, Andrey Grodzovsky wrote: > > On 12/2/20 12:34 PM, Greg KH wrote: > > On Wed, Dec 02, 2020 at 10:48:01AM -0500, Andrey Grodzovsky wrote: > > > On 11/11/20 10:34 AM, Greg KH wrote: > > > > On Wed, Nov 11, 2020 at 10:13:13AM -0500, Andrey Grodzovsky wrote: >

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-12-02 Thread Andrey Grodzovsky
On 12/2/20 1:20 PM, Greg KH wrote: On Wed, Dec 02, 2020 at 01:02:06PM -0500, Andrey Grodzovsky wrote: On 12/2/20 12:34 PM, Greg KH wrote: On Wed, Dec 02, 2020 at 10:48:01AM -0500, Andrey Grodzovsky wrote: On 11/11/20 10:34 AM, Greg KH wrote: On Wed, Nov 11, 2020 at 10:13:13AM -0500, Andrey

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-12-02 Thread Andrey Grodzovsky
On 12/2/20 12:34 PM, Greg KH wrote: On Wed, Dec 02, 2020 at 10:48:01AM -0500, Andrey Grodzovsky wrote: On 11/11/20 10:34 AM, Greg KH wrote: On Wed, Nov 11, 2020 at 10:13:13AM -0500, Andrey Grodzovsky wrote: On 11/10/20 12:59 PM, Greg KH wrote: On Tue, Nov 10, 2020 at 12:54:21PM -0500,

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-12-02 Thread Greg KH
On Wed, Dec 02, 2020 at 10:48:01AM -0500, Andrey Grodzovsky wrote: > > On 11/11/20 10:34 AM, Greg KH wrote: > > On Wed, Nov 11, 2020 at 10:13:13AM -0500, Andrey Grodzovsky wrote: > > > On 11/10/20 12:59 PM, Greg KH wrote: > > > > On Tue, Nov 10, 2020 at 12:54:21PM -0500, Andrey Grodzovsky wrote:

Re: [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Daniel Vetter
On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote: > > > > > On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: > > > > Hi > > > > Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: > >> Hi > >> Am 30.11.20 um 21:59 schrieb Zack Rusin: > >>> > >>> > On Nov 24, 2020, at 06:38, Thomas Zimmermann

Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal

2020-12-02 Thread Andrey Grodzovsky
On 11/11/20 10:34 AM, Greg KH wrote: On Wed, Nov 11, 2020 at 10:13:13AM -0500, Andrey Grodzovsky wrote: On 11/10/20 12:59 PM, Greg KH wrote: On Tue, Nov 10, 2020 at 12:54:21PM -0500, Andrey Grodzovsky wrote: Hi, back to this after a long context switch for some higher priority stuff. So

Re: [PATCH] tests/amdgpu: Fix a typo

2020-12-02 Thread Luben Tuikov
Thanks Alex. Regards, Luben On 2020-12-01 09:42, Deucher, Alexander wrote: > [AMD Official Use Only - Internal Distribution Only] > > > Reviewed-by: Alex Deucher > > libdrm uses gitlab MRs now: > https://gitlab.freedesktop.org/mesa/drm/-/merge_requests >

Re: [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Zack Rusin
> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote: > > Hi > > Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: >> Hi >> Am 30.11.20 um 21:59 schrieb Zack Rusin: >>> >>> On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 15:02 schrieb Alex Deucher: On Wed, Dec 2, 2020 at 3:53 AM Thomas Zimmermann wrote: Hi Am 02.12.20 um 09:43 schrieb Christian König: Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch

Re: [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 09:01 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 21:59 schrieb Zack Rusin: On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Alex Deucher
On Wed, Dec 2, 2020 at 3:53 AM Thomas Zimmermann wrote: > > Hi > > Am 02.12.20 um 09:43 schrieb Christian König: > > Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: > >> Hi > >> > >> Am 01.12.20 um 11:40 schrieb Christian König: > >>> Reviewed-by: Christian König on patch #1 > >>> and #15. > >>>

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 09:43 schrieb Christian König: Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD

Re: [PATCH 2/2] drm: amdgpu: fix a kernel-doc markup

2020-12-02 Thread Christian König
Am 02.12.20 um 09:27 schrieb Mauro Carvalho Chehab: The function name at kernel-doc markup doesn't match the name of the function: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1534: warning: expecting prototype for amdgpu_debugfs_print_bo_info(). Prototype was for amdgpu_bo_print_info()

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Christian König
Am 02.12.20 um 08:59 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD tree? Alex is usually the one who picks such stuff

[PATCH 2/2] drm: amdgpu: fix a kernel-doc markup

2020-12-02 Thread Mauro Carvalho Chehab
The function name at kernel-doc markup doesn't match the name of the function: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1534: warning: expecting prototype for amdgpu_debugfs_print_bo_info(). Prototype was for amdgpu_bo_print_info() instead Fix it. Signed-off-by: Mauro Carvalho

[PATCH 0/2] Fix some kernel-doc markups with wrong identifiers

2020-12-02 Thread Mauro Carvalho Chehab
After applying this patch over next-20201201: https://lore.kernel.org/linux-doc/cover.1606823973.git.mchehab+hua...@kernel.org/T/#m0072adc6eb1af595a31fcc3b019cb81ab28c7b9f There are a couple of new warnings that the kernel-doc prototype doesn't match the documented function. This series

Re: [PATCH v2 18/20] drm/virtgpu: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:40AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert virtgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

Re: [PATCH v2 14/20] drm/qxl: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:36AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert qxl to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

Re: [PATCH v2 05/20] drm/cirrus: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:27AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert cirrus to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

Re: [PATCH v2 04/20] drm/bochs: Remove references to struct drm_device.pdev

2020-12-02 Thread Gerd Hoffmann
On Tue, Dec 01, 2020 at 11:35:26AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert bochs to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann > --- >

Re: [PATCH 14/15] drm/vmwgfx: Remove references to struct drm_device.pdev

2020-12-02 Thread Thomas Zimmermann
Hi Am 30.11.20 um 21:59 schrieb Zack Rusin: On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote: Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Roland Scheidegger ---

Re: [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:40 schrieb Christian König: Reviewed-by: Christian König on patch #1 and #15. Acked-by: Christian König on patch #2 and #16. Could you add these patches to the AMD tree? Best regards Thomas Regards, Christian. Am 01.12.20 um 11:35 schrieb Thomas Zimmermann: