RE: [PATCH 2/2] drm/amd/display: enable idle optimizations for linux (MALL stutter)

2020-12-17 Thread Feng, Kenneth
[AMD Public Use] [AMD Public Use] Hi Bhawanpreet, With the two patches, I still can't see that dc_allow_idle_optimizations(struct dc *dc, bool allow) is called with allow = true after modprobe and startx. Is there anything else missing? Best Regards Kenneth From: amd-gfx On Behalf Of Lakha,

[PATCH] drm/amd/pm: bump Sienna Cichlid smu_driver_if version to match latest pmfw

2020-12-17 Thread Evan Quan
This can suppress the annoying but unharmful prompts. Change-Id: I50bc5f9bd21572f51af4ff4c9e1946d1a441b714 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h

RE: [PATCH] drm/amd/pm: add pptable_funcs documentation (v2)

2020-12-17 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Thanks for adding this. Except one comment below, the patch is reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Ryan Taylor Sent: Friday, December 18, 2020 3:09 AM To: amd-gfx@lists.freedesktop.org Cc: Taylor,

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-17 Thread Aurabindo Pillai
On Thu, Dec 17, 2020 at 14:11, Alex Deucher wrote: On Mon, Dec 14, 2020 at 5:21 PM Aurabindo Pillai wrote: [Why] Adds a module parameter to enable experimental freesync video mode modeset optimization. Enabling this mode allows the driver to skip a full modeset when freesync

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Andrey Grodzovsky
On 12/17/20 3:42 PM, Daniel Vetter wrote: On Thu, Dec 17, 2020 at 8:19 PM Andrey Grodzovsky wrote: On 12/17/20 7:01 AM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 07:20:02PM -0500, Andrey Grodzovsky wrote: On 12/16/20 6:15 PM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 7:26 PM Andrey

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Andrey Grodzovsky
On 12/17/20 3:48 PM, Daniel Vetter wrote: On Thu, Dec 17, 2020 at 9:38 PM Andrey Grodzovsky wrote: On 12/17/20 3:10 PM, Christian König wrote: [SNIP] By eliminating such users, and replacing them with local maps which are strictly bound in how long they can exist (and hence we can

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Daniel Vetter
On Thu, Dec 17, 2020 at 9:38 PM Andrey Grodzovsky wrote: > > > On 12/17/20 3:10 PM, Christian König wrote: > > [SNIP] > By eliminating such users, and replacing them with local maps which > > are strictly bound in how long they can exist (and hence we can > > serialize against them

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Daniel Vetter
On Thu, Dec 17, 2020 at 8:19 PM Andrey Grodzovsky wrote: > > > On 12/17/20 7:01 AM, Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 07:20:02PM -0500, Andrey Grodzovsky wrote: > >> On 12/16/20 6:15 PM, Daniel Vetter wrote: > >>> On Wed, Dec 16, 2020 at 7:26 PM Andrey Grodzovsky > >>> wrote: >

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Andrey Grodzovsky
On 12/17/20 3:10 PM, Christian König wrote: [SNIP] By eliminating such users, and replacing them with local maps which are strictly bound in how long they can exist (and hence we can serialize against them finishing in our hotunplug code). Not sure I see how serializing against BO map/unmap

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Christian König
[SNIP] By eliminating such users, and replacing them with local maps which are strictly bound in how long they can exist (and hence we can serialize against them finishing in our hotunplug code). Not sure I see how serializing against BO map/unmap helps - our problem as you described is that

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Andrey Grodzovsky
On 12/17/20 7:01 AM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 07:20:02PM -0500, Andrey Grodzovsky wrote: On 12/16/20 6:15 PM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 7:26 PM Andrey Grodzovsky wrote: On 12/16/20 12:12 PM, Daniel Vetter wrote: On Wed, Dec 16, 2020 at 5:18 PM

Re: [bug report]: Black screen in 5.10

2020-12-17 Thread Alex Deucher
On Thu, Dec 17, 2020 at 1:14 PM Klaus Kusche wrote: > > > Hello, > > On 17/12/2020 16:17, Alex Deucher wrote: > > On Thu, Dec 17, 2020 at 10:15 AM Klaus Kusche > > wrote: > >> With kernel 5.10.x, both the internal notebook display and any external > >> screen > >> become black (or go to the

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2020-12-17 Thread Alex Deucher
On Mon, Dec 14, 2020 at 5:21 PM Aurabindo Pillai wrote: > > [Why] > Adds a module parameter to enable experimental freesync video mode modeset > optimization. Enabling this mode allows the driver to skip a full modeset when > freesync compatible modes are requested by the userspace. This

[PATCH] drm/amd/pm: add pptable_funcs documentation (v2)

2020-12-17 Thread Ryan Taylor
Documents the hooks in struct pptable_funcs. v2: Improved documentation accuracy. Signed-off-by: Ryan Taylor --- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 525 1 file changed, 525 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h

Re: [v2] drm/amdgpu: skip vram operation for BAMACO runtime

2020-12-17 Thread Alex Deucher
On Mon, Dec 14, 2020 at 5:13 AM Lazar, Lijo wrote: > > [AMD Public Use] > > >-Original Message- > >From: amd-gfx On Behalf Of Likun > >Gao > >Sent: Monday, December 14, 2020 1:08 PM > >To: amd-gfx@lists.freedesktop.org > >Cc: Deucher, Alexander ; Gao, Likun > >; Feng, Kenneth ; Zhang, >

Re: [bug report]: Black screen in 5.10

2020-12-17 Thread Klaus Kusche
Hello, On 17/12/2020 16:17, Alex Deucher wrote: > On Thu, Dec 17, 2020 at 10:15 AM Klaus Kusche > wrote: >> With kernel 5.10.x, both the internal notebook display and any external >> screen >> become black (or go to the "off" state?) when the kernel boots >> (one or two seconds after the VGA

Re: [PATCH 2/2] drm/amd/display: enable idle optimizations for linux (MALL stutter)

2020-12-17 Thread Lakha, Bhawanpreet
[AMD Public Use] Actually, I will drop the guards and if we see issues related to this, we can block it. Bhawan From: Lakha, Bhawanpreet Sent: December 17, 2020 12:32 PM To: Deucher, Alexander ; Kazlauskas, Nicholas Cc: amd-gfx@lists.freedesktop.org Subject:

Re: [PATCH 2/2] drm/amd/display: enable idle optimizations for linux (MALL stutter)

2020-12-17 Thread Lakha, Bhawanpreet
[AMD Public Use] I would but MALL is not fully validated so it might cause underflow issues if we keep it enabled by default. I can create a feature flag mask if that helps? Bhawan From: Deucher, Alexander Sent: December 17, 2020 12:04 PM To: Lakha, Bhawanpreet

Re: [PATCH 2/2] drm/amd/display: enable idle optimizations for linux (MALL stutter)

2020-12-17 Thread Deucher, Alexander
[AMD Public Use] Can we drop the Kconfig? With that, the series is: Acked-by: Alex Deucher From: Bhawanpreet Lakha Sent: Thursday, December 17, 2020 11:54 AM To: Kazlauskas, Nicholas ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org ; Lakha, Bhawanpreet

[PATCH 2/2] drm/amd/display: enable idle optimizations for linux (MALL stutter)

2020-12-17 Thread Bhawanpreet Lakha
[Why] We can only use this feature when the display is idle. When active vblank irq count is 0 we know all the displays are idle. [How] -Add a active vblank irq counter -Update the counter when we enable/disable vblank irq -if vblank irq count is 0 we can consider mall stutter Change-Id:

[PATCH 1/2] drm/amd/display: Update idle optimization handling

2020-12-17 Thread Bhawanpreet Lakha
From: Joshua Aberback [How] - use dc interface instead of hwss interface in cursor functions, to keep dc->idle_optimizations_allowed updated - add dc interface to check if idle optimizations might apply to a plane Change-Id: I130107b6428b4afd73a1a177ef0f8125e0d877e6 Signed-off-by: Joshua

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v2)

2020-12-17 Thread Lucas Stach
Hi Luben, Am Freitag, dem 11.12.2020 um 15:36 -0500 schrieb Luben Tuikov: > On 2020-12-10 4:31 a.m., Lucas Stach wrote: > > Hi Luben, > > > > Am Mittwoch, den 09.12.2020, 21:14 -0500 schrieb Luben Tuikov: > > > This patch does not change current behaviour. > > > > > > The driver's job timeout

Re: [bug report]: Black screen in 5.10

2020-12-17 Thread Alex Deucher
On Thu, Dec 17, 2020 at 10:15 AM Klaus Kusche wrote: > > > Hello, > > I don't know where and how to report amdgpu bugs > as the freedesktop.org bugzilla is closed... https://gitlab.freedesktop.org/drm/amd/-/issues > > My problem: > > With kernel 5.10.x, both the internal notebook display and

[bug report]: Black screen in 5.10

2020-12-17 Thread Klaus Kusche
Hello, I don't know where and how to report amdgpu bugs as the freedesktop.org bugzilla is closed... My problem: With kernel 5.10.x, both the internal notebook display and any external screen become black (or go to the "off" state?) when the kernel boots (one or two seconds after the VGA

Re: [PATCH v2 1/1] drm/amdgpu: clean up bo in vce and vcn test

2020-12-17 Thread Christian König
Am 08.12.20 um 20:39 schrieb Nirmoy: On 12/8/20 8:04 PM, Christian König wrote: Am 08.12.20 um 19:59 schrieb Nirmoy Das: BO created with amdgpu_bo_create_reserved() wasn't clean properly before, which causes: [   21.056218] WARNING: CPU: 0 PID: 7 at drivers/gpu/drm/ttm/ttm_bo.c:518

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2020-12-17 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 07:20:02PM -0500, Andrey Grodzovsky wrote: > > On 12/16/20 6:15 PM, Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 7:26 PM Andrey Grodzovsky > > wrote: > > > > > > On 12/16/20 12:12 PM, Daniel Vetter wrote: > > > > On Wed, Dec 16, 2020 at 5:18 PM Christian König > > >