RE: [PATCH] drm/amdgpu: drop ras ta firmware loading for non-ras asic

2021-01-03 Thread Zhang, Hawking
[AMD Public Use] Btw, the original purpose for the asic type check is to prevent any further atombios call for RAS capability check. But it's not necessary to be there. We shall consider to change it in a more reasonable approach by dropping the asic type check. Regards, Hawking

RE: [PATCH] drm/amdgpu: drop ras ta firmware loading for non-ras asic

2021-01-03 Thread Zhang, Hawking
[AMD Public Use] Then we can refine the wording, or make this to be debug message, although the message already states explicitly this is "optional". Split amdgpu_ras_checked_support may not be a good idea since this is strictly not correct - RAS is not necessarily bind to ASIC type.

RE: [PATCH] drm/amdgpu: drop ras ta firmware loading for non-ras asic

2021-01-03 Thread Chen, Guchun
[AMD Public Use] Hi Hawking, Yes, these kernel messages are indeed not harmful, but some audiences may feel confused on this, as they will guess why kernel said " ras ta ucode is not available " during boot up, and furthermore, if the users miss some FWs? So this is to exclude the confusion

RE: [PATCH] drm/amdgpu: drop ras ta firmware loading for non-ras asic

2021-01-03 Thread Zhang, Hawking
[AMD Public Use] We shall check ras ta firmware image size or/and ras ta binary start address to exclude ASICs that don't support ras. Introduce asic type check here is unnecessary and the functional also need to be modified every time we add a new asic with ras capablility. Kernel message

[PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-01-03 Thread Xiaogang . Chen
From: Xiaogang Chen amdgpu DM handles INTERRUPT_LOW_IRQ_CONTEXT interrupt(hpd, hpd_rx) by using work queue and uses single work_struct. If previous interrupt has not been handled new interrupts(same type) will be discarded and driver just sends "amdgpu_dm_irq_schedule_work FAILED" message out.

[PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address.

2021-01-03 Thread Xiaogang . Chen
From: Xiaogang Chen drm_dp_check_and_send_link_address discovers MST device topology. It can return both positive and negative values. When it returns positive values there is no error found. If it returns negative values there is error found, such as get NAK , timeout, etc. Following

[PATCH] drm/amdgpu: drop ras ta firmware loading for non-ras asic

2021-01-03 Thread Guchun Chen
Otherwise, below confused message is always printed during boot for asics without ras feature, but with common ta firmware. amdgpu: RAS: optional ras ta ucode is not available Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++--

Re: [PATCH] drm/amdgpu: fix potential NULL pointer when check_atom_bios() fails

2021-01-03 Thread Christian König
Am 31.12.20 um 09:47 schrieb Jiawei Gu: Asic funcs pointer needs being checked whether is NULL. Because when check_atom_bios() fails in req_init_data handshake, asic funcs pointer is not initialized yet. Mhm, I'm wondering if we shouldn't change the init sequence then. The asic_funcs is

Re: [PATCH v2] drm/amdgpu: Do not change amdgpu framebuffer format during page flip

2021-01-03 Thread Christian König
Am 29.12.20 um 22:10 schrieb Zhan Liu: [Why] Driver cannot change amdgpu framebuffer (afb) format while doing page flip. Force system doing so will cause ioctl error, and result in breaking several functionalities including FreeSync. If afb format is forced to change during page flip, following

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-03 Thread Mike Lothian
Hi You're probably best reporting the bug here: https://gitlab.freedesktop.org/drm/amd/-/issues Attach the output of dmesg from both Radeon and AMDGPU and the compositor / Wayland logs (as you're not using X) Cheers Mike On Sun, 3 Jan 2021, 06:32 Davide Corrado, wrote: > hello, I'd like