Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 22:13 schrieb Felix Kuehling: Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here

Re: [pull] amdgpu drm-next-5.12

2021-01-14 Thread Dave Airlie
On Fri, 15 Jan 2021 at 07:22, Alex Deucher wrote: > > Hi Dave, Daniel, > > More new stuff for 5.12. > > The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: > > drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug > 210921) (2021-01-08 15:18:57 -0500) >

Re: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-01-14 Thread Chen, Xiaogang
On 1/14/2021 1:24 AM, Grodzovsky, Andrey wrote: > > > On 1/14/21 12:11 AM, Chen, Xiaogang wrote: >> On 1/12/2021 10:54 PM, Grodzovsky, Andrey wrote: >>> >>> On 1/4/21 1:01 AM, Xiaogang.Chen wrote: From: Xiaogang Chen amdgpu DM handles INTERRUPT_LOW_IRQ_CONTEXT interrupt(hpd,

RE: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-14 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Horace Chen Sent: Thursday, January 14, 2021 9:37 PM To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian ;

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-14 Thread Mikhail Gavrilov
On Thu, 14 Jan 2021 at 18:56, Christian König wrote: > Unfortunately not of hand. > > I also don't see any bug reports from other people and can't reproduce > the last backtrace you send out TTM here. Because only the most desperate will install kernels with enabled debug flags and then load the

[pull] amdgpu drm-next-5.12

2021-01-14 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 5.12. The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug 210921) (2021-01-08 15:18:57 -0500) are available in the Git repository at:

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Felix Kuehling
Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: > On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: >> Am 14.01.21 um 12:52 schrieb Daniel Vetter: >>> [SNIP] > I had a new idea, i wanted to think more about it but have not yet, > anyway here it is. Adding a new callback

[pull] amdgpu, amdkfd drm-fixes-5.11

2021-01-14 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.11. The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.11-2021-01-14 for you to

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 08:08:06PM +0100, Christian König wrote: > Am 14.01.21 um 17:36 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 5:01 PM Christian König > > wrote: > > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > > > [SNIP] > > > > > So I think we have to somehow solve this in the

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 17:36 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at

Re: [PATCH 0/8] amdgpu/pm: Powerplay API for smu

2021-01-14 Thread Alex Deucher
On Tue, Jan 12, 2021 at 10:28 PM Darren Powell wrote: > > === Description === > Patches to add the Powerplay API to smu and simplify dpm/pm calling code > > * Version 2 Updates > 0001: updated the structure name to swsmu_pm_funcs > 0002: No Changes > 0003: changed error return value of

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 8:51 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c:3141:30-39: > WARNING: Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied all 4 patches. Thanks! Alex >

Re: [PATCH] drm/amdgpu: Repeat assignment to max_slave_planes

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 4:29 AM ZhiJie.Zhang wrote: > > Signed-off-by: ZhiJie.Zhang Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c >

Re: [PATCH 06/10] drm: amd: amdgpu_dm.h: fix a wrong kernel-doc markup

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 2:53 AM Mauro Carvalho Chehab wrote: > > There's a missing colon, causing the markup to be ignored, > solving those warnings: > > ../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:340: warning: > Incorrect use of kernel-doc format: *

Re: [PATCH 2/2] drm/amdgpu: set job guilty if reset skipped

2021-01-14 Thread Alex Deucher
On Thu, Jan 14, 2021 at 9:48 AM Andrey Grodzovsky wrote: > > Reviewed-by: Andrey Grodzovsky > > Andrey > > On 1/14/21 8:37 AM, Horace Chen wrote: > > If 2 jobs on 2 different ring timed out the at a very > > short period, the reset for second job will be skipped > > because the reset is already

Re: [PATCH 22/30] drm/amd/display/dc/core/dc_link: Fix a couple of function documentation issues

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:214: warning: > Function parameter or member 'link' not described in 'dc_link_detect_sink' >

Re: [PATCH 21/30] drm/amd/display/dc/core/dc_resource: Demote some kernel-doc abuses

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1710: warning: > Function parameter or member 'old_stream' not described in > 'dc_is_stream_unchanged' >

Re: [PATCH 20/30] drm/amd/display/dc/core/dc: Fix a bunch of documentation misdemeanours

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:287: warning: Cannot > understand > * >

Re: [PATCH 18/30] drm/amd/display/dc/core/dc_link: Move some local data from the stack to the heap

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function > ‘dc_link_construct’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:1588:1: warning: the > frame size of

Re: [PATCH 17/30] drm/amd/display/dc/dce60/dce60_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:1115:23: > warning: no previous prototype for ‘dce60_create_resource_pool’ > [-Wmissing-prototypes] >

Re: [PATCH 15/30] drm/amd/display/dc/dce80/dce80_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:1126:23: > warning: no previous prototype for ‘dce80_create_resource_pool’ > [-Wmissing-prototypes] >

Re: [PATCH 14/30] drm/amd/display/dc/dce80/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:29: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_8_0_sh_mask.h:9546:58: > warning:

Re: [PATCH 13/30] drm/amd/display/dc/dce60/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28: > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: > warning: initialized

Re: [PATCH 12/30] drm/amd/display/dc/dce100/dce100_resource: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:537:3: > note: in

Re: [PATCH 11/30] drm/amd/display/dc/dce100/Makefile: Ignore -Woverride-init warning

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_10_0_sh_mask.h:5084:45: >

Re: [PATCH 10/30] drm/amd/display/dc/core/dc: Staticise local function 'apply_ctx_interdependent_lock'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:806:6: warning: no > previous prototype for ‘apply_ctx_interdependent_lock’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li >

Re: [PATCH 09/30] drm/amd/display/dc/dce112/dce112_resource: Include our own header file containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:883:6: > warning: no previous prototype for ‘dce112_validate_bandwidth’ > [-Wmissing-prototypes] >

Re: [PATCH 08/30] drm/amd/display/dc/core/dc_link_dp: Staticify local function 'linkRateInKHzToLinkRateMultiplier'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3710:19: warning: > no previous prototype for ‘linkRateInKHzToLinkRateMultiplier’ > [-Wmissing-prototypes] >

Re: [PATCH 07/30] drm/amd/display/dc/core/dc_link: Remove unused variable 'status'

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function > ‘query_hdcp_capability’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:599:28: warning: > variable

Re: [PATCH 06/30] drm/amd/display/dc/core/dc_resource: Staticify local functions

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1120:5: warning: > no previous prototype for ‘shift_border_left_to_dst’ [-Wmissing-prototypes] >

Re: [PATCH 05/30] drm/amd/display/modules/info_packet/info_packet: Correct kernel-doc formatting

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/info_packet/info_packet.c:412: > warning: Cannot understand > * >

Re: [PATCH 04/30] drm/amd/display/modules/power/power_helpers: Staticify local functions

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:281:6: > warning: no previous prototype for ‘fill_iram_v_2’ [-Wmissing-prototypes] >

Re: [PATCH 03/30] drm/amd/display/dmub/src/dmub_dcn30: Include our own header containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn30.c:83:6: warning: > no previous prototype for ‘dmub_dcn30_backdoor_load’ [-Wmissing-prototypes] >

Re: [PATCH 02/30] drm/amd/include/renoir_ip_offset: Mark top-level IP_BASE as __maybe_unused

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../include/renoir_ip_offset.h:226:29: warning: > ‘UVD0_BASE’ defined but not used [-Wunused-const-variable=] >

Re: [PATCH 01/30] drm/amd/display/dc/dc_helper: Include our own header, containing prototypes

2021-01-14 Thread Alex Deucher
On Wed, Jan 13, 2021 at 3:08 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:299:10: warning: no > previous prototype for ‘generic_reg_get’ [-Wmissing-prototypes] >

Re: [PATCH 28/40] drm/amd/display/dc/calcs/dce_calcs: Demote non-conformant kernel-doc function headers

2021-01-14 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2753: warning: > Function parameter or member 'vbios' not described in > 'is_display_configuration_supported' >

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Jerome Glisse
On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: > Am 14.01.21 um 12:52 schrieb Daniel Vetter: > > [SNIP] > > > > I had a new idea, i wanted to think more about it but have not yet, > > > > anyway here it is. Adding a new callback to dma fence which ask the > > > > question can it

Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl'

2021-01-14 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function > ‘calculate_bandwidth’: >

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > [SNIP] > >> So I think we have to somehow solve this in the kernel or we will go in > >> circles all the time. > >> > >>> So from that pov I think the kernel should at most deal with an >

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at most deal with an hmm_fence for cross-process communication and maybe some standard wait primitives

Re: [PATCH 00/30] [Set 13] Finally rid W=1 warnings from GPU

2021-01-14 Thread Lee Jones
On Wed, 13 Jan 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > 0 out of 5000 left! > > LAST SET! You're all clean. Can you believe it!? Ah, fair warning for

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:08 PM Christian König wrote: > Am 14.01.21 um 15:23 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 3:13 PM Christian König > > wrote: > >> Am 14.01.21 um 14:57 schrieb Daniel Vetter: > >>> On Thu, Jan 14, 2021 at 2:37 PM Christian König > >>> wrote: > Am

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 15:23 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 3:13 PM Christian König wrote: Am 14.01.21 um 14:57 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more

Re: [PATCH 2/2] drm/amdgpu: set job guilty if reset skipped

2021-01-14 Thread Andrey Grodzovsky
Reviewed-by: Andrey Grodzovsky Andrey On 1/14/21 8:37 AM, Horace Chen wrote: If 2 jobs on 2 different ring timed out the at a very short period, the reset for second job will be skipped because the reset is already in progress. But it doesn't mean the second job is not guilty since it also

Re: [PATCH 1/2] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-14 Thread Andrey Grodzovsky
On 1/14/21 8:37 AM, Horace Chen wrote: Fix a racing issue when jobs on 2 rings timeout simultaneously. If 2 rings timed out at the same time, the amdgpu_device_gpu_recover will be reentered. Then the adev->gmc.xgmi.head will be grabbed by 2 local linked list, which may cause wild pointer

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 3:13 PM Christian König wrote: > > Am 14.01.21 um 14:57 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 2:37 PM Christian König > > wrote: > >> Am 14.01.21 um 12:52 schrieb Daniel Vetter: > >>> [SNIP] > > I had a new idea, i wanted to think more about it but have

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 14:57 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here it is. Adding a new callback to dma fence which ask the

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 2:56 PM Christian König wrote: > > Am 14.01.21 um 01:22 schrieb Mikhail Gavrilov: > > On Tue, 12 Jan 2021 at 01:45, Christian König > > wrote: > >> But what you have in your logs so far are only unrelated symptoms, the > >> root of the problem is that somebody is leaking

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: > > Am 14.01.21 um 12:52 schrieb Daniel Vetter: > > [SNIP] > >>> I had a new idea, i wanted to think more about it but have not yet, > >>> anyway here it is. Adding a new callback to dma fence which ask the > >>> question can it dead lock ?

Re: [drm:dm_plane_helper_prepare_fb [amdgpu]] *ERROR* Failed to pin framebuffer with error -12

2021-01-14 Thread Christian König
Am 14.01.21 um 01:22 schrieb Mikhail Gavrilov: On Tue, 12 Jan 2021 at 01:45, Christian König wrote: But what you have in your logs so far are only unrelated symptoms, the root of the problem is that somebody is leaking memory. What you could do as well is to try to enable kmemleak I captured

Re: [PATCH 06/10] drm: amd: amdgpu_dm.h: fix a wrong kernel-doc markup

2021-01-14 Thread Christian König
Am 14.01.21 um 08:53 schrieb Mauro Carvalho Chehab: There's a missing colon, causing the markup to be ignored, solving those warnings: ../drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:340: warning: Incorrect use of kernel-doc format: * @active_vblank_irq_count

Re: [PATCH] drm/amdgpu: change the fence ring wait timeout

2021-01-14 Thread Christian König
Am 14.01.21 um 03:00 schrieb Deng, Emily: [AMD Official Use Only - Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, January 13, 2021 10:03 PM To: Sun, Roy ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: change

HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here it is. Adding a new callback to dma fence which ask the question can it dead lock ? Any time a GPU driver has pending page fault (ie something calling into the mm)

Re: [PATCH 1/2] drm/amdgpu: Add Secure Display TA header file

2021-01-14 Thread Paul Menzel
Dear Jinzhou, Am 14.01.21 um 08:29 schrieb Su, Jinzhou (Joe): Thanks so much for your review. Answer your Question inline. Please check. An email client, following standards when responding and citing messages correctly, would be nice. -Original Message- From: Paul Menzel

RE: [PATCH] drm/amdgpu: toggle on DF Cstate after finishing xgmi injection

2021-01-14 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Thursday, January 14, 2021 15:55 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: toggle on DF Cstate after

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Christian König
Am 14.01.21 um 06:34 schrieb Felix Kuehling: Am 2021-01-11 um 11:29 a.m. schrieb Daniel Vetter: On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote: Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: Am 2021-01-08 um 11:06 a.m.

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 11:49 AM Christian König wrote: > > Am 13.01.21 um 17:56 schrieb Jerome Glisse: > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > >> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > >>> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: >

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Christian König
Am 13.01.21 um 17:56 schrieb Jerome Glisse: On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 10:26 AM Daniel Vetter wrote: > > On Thu, Jan 14, 2021 at 4:27 AM Jerome Glisse wrote: > > > > On Wed, Jan 13, 2021 at 09:31:11PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > > > > On Fri, Jan 08, 2021 at 03:40:07PM +0100,

Re: [PATCH] drm/amd/display: Simplify bool comparison

2021-01-14 Thread Jani Nikula
On Wed, 13 Jan 2021, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_cm.c:580:23-31: > WARNING: Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_cm.c | 2 +-

Re: mclk stuck at low state

2021-01-14 Thread Tom Psyborg
On 14/01/2021, Alex Deucher wrote: > On Wed, Jan 13, 2021 at 8:51 AM Tom Psyborg > wrote: >> >> Hi >> >> I see the message didn't make it to the mailing list? Any reason for >> that? > > No idea. I never saw it until now. > >> >> On 10/01/2021, Tom Psyborg wrote: >> > Hi >> > >> > Have an

[PATCH] drm/amdgpu: Repeat assignment to max_slave_planes

2021-01-14 Thread ZhiJie.Zhang
Signed-off-by: ZhiJie.Zhang --- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c index 3f63822b8e28..9a86d43a6233 100644

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:27 AM Jerome Glisse wrote: > > On Wed, Jan 13, 2021 at 09:31:11PM +0100, Daniel Vetter wrote: > > On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 07, 2021 at 11:25:41AM -0500,

Re: [PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2021-01-14 Thread Pekka Paalanen
On Mon, 4 Jan 2021 16:07:58 -0500 Aurabindo Pillai wrote: > [Why] > Adds a module parameter to enable experimental freesync video mode modeset > optimization. Enabling this mode allows the driver to skip a full modeset when > freesync compatible modes are requested by the userspace. This