Re: [PATCH 1/1] drm/amdkfd: Enable userptr support when KFD is enabled

2021-01-17 Thread Christian König
Am 15.01.21 um 19:24 schrieb Felix Kuehling: ROCm user mode depends on userptr support. Without it, KFD is basically useless. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig

Re: [PATCH] drm/amdgpu: change the fence ring wait timeout

2021-01-17 Thread Christian König
Mhm, we could change amdgpu_fence_wait_empty() to timeout. But I think that waiting forever here is intentional and the right thing to do. What happens is that we wait for the hardware to make sure that nothing is writing to any memory before we unload the driver. Now the VCN block has

RE: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

2021-01-17 Thread Lazar, Lijo
[AMD Public Use] Reviewed-by: Lijo Lazar Thanks, Lijo -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Saturday, January 16, 2021 5:28 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX the

RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving(V2)

2021-01-17 Thread Quan, Evan
Considering the gfxoff status is always in dynamic switch, it's absolutely right we will never have a reliable way to know the exact current gfxoff status. The status we can see is always the one of last moment. However, the case we want to cover(also the one we see mostly) is we know the

RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving(V2)

2021-01-17 Thread Lazar, Lijo
[AMD Public Use] This is not guaranteed to work reliably. By the time driver fetches and reports say status 0 (in GFXOFF), there could be a doorbell interrupt which changes the status to 1 (Transition out of GFX State). If there is no requirement to report the instantaneous status, better to

[PATCH] drm/amd/amdgpu: remove redundant flush_delayed_work

2021-01-17 Thread Jingwen Chen
When using cancel_delayed_work_sync, there's no need to flush_delayed_work first. This sequence can lead to a redundant loop of work executing. Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 - 1 file changed, 1 deletion(-) diff --git

RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving(V2)

2021-01-17 Thread Chen, Guchun
[AMD Public Use] Series are: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Quan, Evan Sent: Monday, January 18, 2021 9:55 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Quan, Evan Subject: [PATCH 1/2] drm/amd/pm: fulfill the API for

RE: [PATCH] drm/amdgpu: change the fence ring wait timeout

2021-01-17 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Koenig, Christian >Sent: Thursday, January 14, 2021 9:50 PM >To: Deng, Emily ; Sun, Roy ; >amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: change the fence ring wait timeout > >Am 14.01.21 um

[PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving(V2)

2021-01-17 Thread Evan Quan
Support Navi1x gfxoff state retrieving. V2: some cosmetic fixes Change-Id: I57aa506b82dc122bbead708c580a4720e536cfce Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 2 ++ .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 1 +

[PATCH 2/2] drm/amd/pm: fulfill the API for Sienna Cichlid gfxoff state retrieving

2021-01-17 Thread Evan Quan
Support Sienna Cichlid gfxoff state retrieving. Change-Id: I952b652a41a33cdaa05e5294b17a8cfa45a18818 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c

RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving

2021-01-17 Thread Quan, Evan
Thanks, I will correct them. BR Evan -Original Message- From: Chen, Guchun Sent: Friday, January 15, 2021 5:51 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving

RE: [PATCH 1/2] drm/amd/pm: fulfill the API for navi1x gfxoff state retrieving

2021-01-17 Thread Quan, Evan
[AMD Public Use] This will help gfxoff related issue debugging. Similar implementations were already added for APUs. BR Evan -Original Message- From: Chen, Jiansong (Simon) Sent: Friday, January 15, 2021 11:01 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ;

RE: [PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

2021-01-17 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Saturday, January 16, 2021 7:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: remove unused message

Re: [PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-17 Thread Aurabindo Pillai
-- Thanks & Regards, Aurabindo Pillai On Wed, Jan 6, 2021 at 15:02, "Kazlauskas, Nicholas" wrote: On 2021-01-04 4:08 p.m., Aurabindo Pillai wrote: [Why] Inorder to enable freesync video mode, driver adds extra modes based on preferred modes for common freesync frame rates. When commiting