Re: [PATCH 1/1] drm/amdkfd: Fix recursive lock warnings

2021-02-16 Thread philip yang
On 2021-02-16 3:22 p.m., Felix Kuehling wrote: memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c

[PATCH] drm/amd/display: Old sequence for HUBP blank

2021-02-16 Thread Aurabindo Pillai
This reverts commit be7af780ef3cbb8fe1004db48dc66caf2da595cd because the new proposed sequence for HUBP blanking causes regressions. This change brings back the old sequence. Signed-off-by: Aurabindo Pillai Signed-off-by: Bhawanpreet Lakha --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 36

[PATCH 1/1] drm/amdkfd: Fix recursive lock warnings

2021-02-16 Thread Felix Kuehling
memalloc_nofs_save/restore are no longer sufficient to prevent recursive lock warnings when holding locks that can be taken in MMU notifiers. Use memalloc_noreclaim_save/restore instead. Fixes: f920e413ff9c ("mm: track mmu notifiers in fs_reclaim_acquire/release") CC: Daniel Vetter

Re: [PATCH] drm/amdgpu: fix an error code in init_pmu_entry_by_type_and_add()

2021-02-16 Thread Alex Deucher
On Tue, Feb 16, 2021 at 2:35 PM Dan Carpenter wrote: > > If the kmemdup() fails then this should return a negative error code > but it currently returns success. > > Fixes: b4a7db71ea06 ("drm/amdgpu: add per device user friendly xgmi events > for vega20") > Signed-off-by: Dan Carpenter > --- >

Re: [PATCH 2/2] drm/amdkfd: Cleanup kfd_process if init_cwsr_apu fails

2021-02-16 Thread philip yang
Reviewed-by: Philip Yang for the series. On 2021-02-12 1:40 a.m., Felix Kuehling wrote: If init_cwsr_apu fails, we currently leave the kfd_process structure in place anyway. The next kfd_open will then succeed, using the existing kfd_process structure. Fix that

[PATCH] drm/amdgpu: fix an error code in init_pmu_entry_by_type_and_add()

2021-02-16 Thread Dan Carpenter
If the kmemdup() fails then this should return a negative error code but it currently returns success. Fixes: b4a7db71ea06 ("drm/amdgpu: add per device user friendly xgmi events for vega20") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 4 +++-

Re: [PATCH 1/1] drm/radeon: fix compilation error

2021-02-16 Thread Nirmoy
On 2/16/21 4:23 PM, Christian König wrote: Am 16.02.21 um 16:22 schrieb Nirmoy Das: Fixes below compilation error: conflicting types for ‘r100_debugfs_mc_info_init’ Fixes: 6f8672d6523bfe38e ("drm/radeon: do not use drm middle layer for debugfs") Signed-off-by: Nirmoy Das Reported-by: Mark

[PATCH] drm/amdgpu/display: restore AUX_DPHY_TX_CONTROL for DCN2.x

2021-02-16 Thread Alex Deucher
Commit 098214999c8f added fetching of the AUX_DPHY register values from the vbios, but it also changed the default values in the case when there are no values in the vbios. This causes problems with displays with high refresh rates. To fix this, switch back to the original default value for

[PATCH] drm/scheduler: Fix hang when sched_entity released

2021-02-16 Thread Andrey Grodzovsky
Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run

RE: [PATCH 00/14] DC Patches Feb 15th, 2021

2021-02-16 Thread Wheeler, Daniel
[AMD Public Use] Hi all, This week this patchset was tested on a HP Envy 360, with Ryzen 5 4500U, on the following display types (via usb-c to dp/dvi/hdmi/vga): 4k 60z, 1440p 144hz, 1680*1050 60hz, internal eDP 1080p 60hz Tested on a Sapphire Pulse RX5700XT on the following display types (via

Re: [PATCH 1/1] drm/radeon: fix compilation error

2021-02-16 Thread Alex Deucher
On Tue, Feb 16, 2021 at 10:22 AM Nirmoy Das wrote: > > Fixes below compilation error: > conflicting types for ‘r100_debugfs_mc_info_init’ > > Fixes: 6f8672d6523bfe38e ("drm/radeon: do not use drm middle layer for > debugfs") > Signed-off-by: Nirmoy Das > Reported-by: Mark Broadworth > --- > Hi

Re: [PATCH 1/1] drm/radeon: fix compilation error

2021-02-16 Thread Christian König
Am 16.02.21 um 16:22 schrieb Nirmoy Das: Fixes below compilation error: conflicting types for ‘r100_debugfs_mc_info_init’ Fixes: 6f8672d6523bfe38e ("drm/radeon: do not use drm middle layer for debugfs") Signed-off-by: Nirmoy Das Reported-by: Mark Broadworth Reviewed-by: Christian König

[PATCH 1/1] drm/radeon: fix compilation error

2021-02-16 Thread Nirmoy Das
Fixes below compilation error: conflicting types for ‘r100_debugfs_mc_info_init’ Fixes: 6f8672d6523bfe38e ("drm/radeon: do not use drm middle layer for debugfs") Signed-off-by: Nirmoy Das Reported-by: Mark Broadworth --- Hi Alex, Can you please squash this with the "Fixes" commit. I am not

Re: [PATCH 1/1] drm/amdgpu: mark local function as static

2021-02-16 Thread Alex Deucher
On Tue, Feb 16, 2021 at 9:40 AM Nirmoy Das wrote: > > Mark amdgpu_ras_debugfs_create_ctrl_node() as static. > > Fixes: 0ec7b4385 ("drm/amdgpu: do not keep debugfs dentry") > Reported-by: kernel test robot > Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher > --- >

[PATCH 1/1] drm/amdgpu: mark local function as static

2021-02-16 Thread Nirmoy Das
Mark amdgpu_ras_debugfs_create_ctrl_node() as static. Fixes: 0ec7b4385 ("drm/amdgpu: do not keep debugfs dentry") Reported-by: kernel test robot Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/radeon: OLAND boards don't have VCE

2021-02-16 Thread Christian König
Am 16.02.21 um 15:09 schrieb Alex Deucher: Disable it on those boards. No functional change, this just removes the message about VCE failing to initialize. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=197327 Signed-off-by: Alex Deucher Reviewed-by: Christian König ---

[PATCH] drm/radeon: OLAND boards don't have VCE

2021-02-16 Thread Alex Deucher
Disable it on those boards. No functional change, this just removes the message about VCE failing to initialize. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=197327 Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_asic.c | 3 +++ drivers/gpu/drm/radeon/radeon_vce.c | 1 -