[AMD Official Use Only - Internal Distribution Only]
Hi, Andrey,
ok, I have changed it and uploaded V2 patch.
Thanks,
Jack
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, March 12, 2021 1:04 PM
To: Alex Deucher ; Zhang, Jack (Jian)
; Maling list - DRI developers
Cc:
re-insert Bailing jobs to avoid memory leak.
Signed-off-by: Jack Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 8 ++--
drivers/gpu/drm/panfrost/panfrost_job.c| 2 +-
drivers/gpu/drm/scheduler/sched_main.c | 8 +++-
Check panfrost driver at panfrost_scheduler_stop,
and panfrost_job_timedout - they also terminate prematurely
in both places so probably worth adding this there too.
Andrey
On 2021-03-11 11:13 p.m., Alex Deucher wrote:
+dri-devel
Please be sure to cc dri-devel when you send out gpu scheduler
[AMD Public Use]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Kenneth Feng
Sent: Thursday, March 11, 2021 2:59 PM
To: amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth
Subject: [PATCH v2] drm/amd/pm: workaround for audio noise issue
On some Intel platforms,
+dri-devel
Please be sure to cc dri-devel when you send out gpu scheduler patches.
On Thu, Mar 11, 2021 at 10:57 PM Jack Zhang wrote:
>
> re-insert Bailing jobs to avoid memory leak.
>
> Signed-off-by: Jack Zhang
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++-
>
[AMD Official Use Only - Internal Distribution Only]
Series is:
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Hawking
Zhang
Sent: Thursday, March 11, 2021 10:53 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking
Subject: [PATCH 2/2] drm/amdgpu:
re-insert Bailing jobs to avoid memory leak.
Signed-off-by: Jack Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 8 ++--
drivers/gpu/drm/scheduler/sched_main.c | 8 +++-
include/drm/gpu_scheduler.h| 1 +
4
driver needs to query umc_info_v3_3 for ecc capability
in sienna_cichlid
Signed-off-by: Hawking Zhang
Reviewed-by: Likun Gao
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 28 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--
2 files changed, 25 insertions(+), 7
new member introduced in umc_info v3_3 to indicate
ECC capability
Signed-off-by: Hawking Zhang
Reviewed-by: Likun Gao
---
drivers/gpu/drm/amd/include/atomfirmware.h | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h
[AMD Public Use]
We don't need this as a generic ppt_func. Reset functionalities are changing
over programs and this could be valid only for Arcturus. Please move it to
Arcturus swsmu late init.
Thanks,
Lijo
-Original Message-
From: amd-gfx On Behalf Of shaoyunl
Sent: Thursday,
[AMD Official Use Only - Internal Distribution Only]
Ping .
-Original Message-
From: Liu, Shaoyun
Sent: Thursday, March 11, 2021 12:16 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun
Subject: [PATCH] drm/amdgpu: Enable light SBR in XGMI+passthrough configuration
This is to fix
On Thu, 11 Mar 2021 at 17:10, Alex Deucher wrote:
>
> On Thu, Mar 11, 2021 at 10:02 AM Alexandre Desnoyers wrote:
> >
> > On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote:
> > >
> > > On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote:
> > > >
> > > > On Wed, 10 Mar 2021 at 18:06, Alex Deucher
The Thunk change that uses the updated capability bit is available here:
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/7cdd63475c36bb9f49bb960f90f9a8cdb7e80a21
ROCr will check the KFD API version in order to know whether the SRAM
ECC capability reported by the Thunk is
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Rajneesh Bhardwaj
-Original Message-
From: amd-gfx On Behalf Of Oak Zeng
Sent: Wednesday, March 10, 2021 10:29 PM
To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: Zeng, Oak
Subject: [PATCH 2/2]
Fixes the following memory leak in dc_link_construct():
unreferenced object 0xa03e81471400 (size 1024):
comm "amd_module_load", pid 2486, jiffies 4294946026 (age 10.544s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00
This is to fix the commit dda9bbb26c7 where it only enable the light SMU
on normal device init. This feature actually need to be enabled after ASIC
been reset as well.
Signed-off-by: shaoyunl
Change-Id: Ie7ee02cd3ccdab3522aad9a02f681963e211ed44
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7
From: Colin Ian King
The variable result is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
On Tue, Mar 9, 2021 at 11:46 AM Harish Kasiviswanathan
wrote:
>
> This reverts commit 73bf5cad2696fe3a21f70101821405db839ea18e.
>
> Fixed in newer firmware
>
> Signed-off-by: Harish Kasiviswanathan
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 ---
> 1
I would use a more meaningful name then
amdgpu_device_correct_karma and also put some comment
above describing the algorithm (just as in the patch description).
Other then that looks good to me -
Reviewed-by: Andrey Grodzovsky andrey.grodzov...@amd.com
Andrey
On 2021-03-11 10:37 a.m., Jack
On Thu, Mar 11, 2021 at 10:02 AM Alexandre Desnoyers wrote:
>
> On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote:
> >
> > On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote:
> > >
> > > On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote:
> > > >
> > > > On Wed, Mar 10, 2021 at 11:37 AM Daniel
Applied. Thanks!
Alex
On Tue, Feb 9, 2021 at 7:50 AM Christian König wrote:
>
> Reviewed-by: Christian König for the series.
>
> Am 09.02.21 um 13:44 schrieb Sebastian Andrzej Siewior:
> > Folks,
> >
> > in the discussion about preempt count consistency across kernel
> > configurations:
> >
>
[Why]
Previous tdr design treats the first job in job_timeout as the bad job.
But sometimes a later bad compute job can block a good gfx job and
cause an unexpected gfx job timeout because gfx and compute ring share
internal GC HW mutually.
[How]
This patch implements an advanced tdr mode.It
[AMD Official Use Only - Internal Distribution Only]
hi，Andrey and Christian，
V8 patch is uploaded.
Thanks，
Jack
发件人: amd-gfx 代表 Zhang, Jack (Jian)
发送时间: 2021年3月11日星期四 下午8:20
收件人: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey; Liu, Monk; Deng, Emily;
Applied. Thanks!
Alex
On Thu, Mar 11, 2021 at 4:28 AM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in a drm debug message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1
[Why]
Previous tdr design treats the first job in job_timeout as the bad job.
But sometimes a later bad compute job can block a good gfx job and
cause an unexpected gfx job timeout because gfx and compute ring share
internal GC HW mutually.
[How]
This patch implements an advanced tdr mode.It
On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote:
>
> On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote:
> >
> > On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote:
> > >
> > > On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote:
> > > >
> > > > Disabling GFXOFF via the quirk list fixes a
On 11.03.21 15:41, Deucher, Alexander wrote:
[AMD Public Use]
Booting kernels on certain AMD platforms takes 2-3 minutes with the patch in
the subject. Reverting it restores quick boot times (few seconds). Any ideas?
Hi,
We just discovered latent BUGs in ACPI code whereby ACPI tables are
Due to some hickups with some of the early election emails and the large
spike in membership registrations the elections committee decided to
extend the membership deadline by one week to Mar 18, 2021.
If you have not renewed your membership please do so by Thursday, Mar 18
at
[AMD Public Use]
Booting kernels on certain AMD platforms takes 2-3 minutes with the patch in
the subject. Reverting it restores quick boot times (few seconds). Any ideas?
Thanks,
Alex
[0.00] Linux version 5.11.0-7490c004ae7e (jenkins@24dbd4b4380b) (gcc
(Ubuntu
On Thu, 11 Mar 2021, Daniel Vetter wrote:
> On Mon, Mar 08, 2021 at 09:19:32AM +, Lee Jones wrote:
> > On Fri, 05 Mar 2021, Roland Scheidegger wrote:
> >
> > > The vmwgfx ones look all good to me, so for
> > > 23-53: Reviewed-by: Roland Scheidegger
> > > That said, they were already signed
From: Colin Ian King
There is a spelling mistake in a drm debug message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
On Wed, Feb 17, 2021 at 11:53 AM Harry Wentland wrote:
>
> On 2021-02-16 12:28 p.m., Alex Deucher wrote:
> > Commit 098214999c8f added fetching of the AUX_DPHY register
> > values from the vbios, but it also changed the default values
> > in the case when there are no values in the vbios. This
This reverts commit c6d2b0fbb893d5c7dda405aa0e7bcbecf1c75f98.
This patch is a workaround for a hardware bug, but I don't
know that we've actually seen the hw bug triggered in practice,
meanwhile a number of people have reported that this causes
suspend and resume issues.
Bug:
On 2021-03-11 1:10 p.m., Simon Ser wrote:
> On Thursday, March 11th, 2021 at 10:05 AM, Michel Dänzer
> wrote:
>
>> On 2021-03-11 9:57 a.m., Simon Ser wrote:
>>> On Wednesday, March 10th, 2021 at 6:20 PM, Michel Dänzer
>>> wrote:
On 2021-03-10 3:50 p.m., Simon Ser wrote:
>
On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote:
>
> On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote:
> >
> > On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote:
> > >
> > > Disabling GFXOFF via the quirk list fixes a hardware lockup in
> > > Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83.
> > >
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Kenneth Feng
Sent: Thursday, March 11, 2021 1:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Feng, Kenneth
Subject: [PATCH v2] drm/amd/pm: workaround for
On Mon, Mar 08, 2021 at 09:19:32AM +, Lee Jones wrote:
> On Fri, 05 Mar 2021, Roland Scheidegger wrote:
>
> > The vmwgfx ones look all good to me, so for
> > 23-53: Reviewed-by: Roland Scheidegger
> > That said, they were already signed off by Zack, so not sure what
> > happened here.
>
>
On Wed, Mar 03, 2021 at 08:42:31AM +0100, Christian König wrote:
> Am 03.03.21 um 01:27 schrieb Colin King:
> > From: Colin Ian King
> >
> > Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can
> > copy back uninitialised data in value_tmp that pointer *value points
> > to. This
On Thu, Mar 04, 2021 at 08:46:26AM +0100, Christian König wrote:
> Hi Oak,
>
> as far as I know some architectures like PowerPC/ARM/MIPS need that. And we
> at least officially support PowerPC and ARM and MIPS is best effort and
> shouldn't break if possible.
>
> Thomas just recently had a whole
On 3/4/21 6:58 PM, Felix Kuehling wrote:
Am 2021-03-01 um 3:46 a.m. schrieb Thomas Hellström (Intel):
On 3/1/21 9:32 AM, Daniel Vetter wrote:
On Wed, Jan 06, 2021 at 10:01:09PM -0500, Felix Kuehling wrote:
From: Philip Yang
Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to
[AMD Official Use Only - Internal Distribution Only]
hi?Christian?
Good idea?thank you for these efforts.
I will update in next version.
Jack
From: Koenig, Christian
Sent: Thursday, March 11, 2021 6:41:05 PM
To: Zhang, Jack (Jian) ;
On Thursday, March 11th, 2021 at 10:05 AM, Michel Dänzer
wrote:
> On 2021-03-11 9:57 a.m., Simon Ser wrote:
> > On Wednesday, March 10th, 2021 at 6:20 PM, Michel Dänzer
> > wrote:
> >> On 2021-03-10 3:50 p.m., Simon Ser wrote:
> >>
> >>> Changes in v2: drop "amd/display: fail on cursor plane
Hi Sebastian,
Am 10.03.21 um 18:47 schrieb Sebastian Andrzej Siewior:
On 2021-02-09 18:43:54 [+0100], Christian König wrote:
to be honest I'm thinking about that for quite some time now and I don't
think that this is possible without a severe rewrite of the driver.
The problem is simply that
Am 11.03.21 um 06:58 schrieb Jack Zhang:
[Why]
Previous tdr design treats the first job in job_timeout as the bad job.
But sometimes a later bad compute job can block a good gfx job and
cause an unexpected gfx job timeout because gfx and compute ring share
internal GC HW mutually.
[How]
This
On Tue, Mar 9, 2021 at 7:34 PM Christian König wrote:
> Am 09.03.21 um 18:59 schrieb Alex Deucher:
>
> There has been quite some effort for this already for generic PASID
> interface etc.. But it looks like that effort is stalled by now.
>
> Anyway at least I'm perfectly fine to have the IOMMUv2
[AMD Public Use]
Reviewed-by: Huang Rui
-Original Message-
From: Su, Jinzhou (Joe)
Sent: Tuesday, March 9, 2021 10:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray ; Su, Jinzhou (Joe)
Subject: [PATCH] drm/amdgpu: update secure display TA header
update secure display TA header
On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote:
>
> On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote:
> >
> > Disabling GFXOFF via the quirk list fixes a hardware lockup in
> > Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83.
> >
> > Signed-off-by: Daniel Gomez
> > ---
> >
> > This patch is a
On 2021-03-11 9:57 a.m., Simon Ser wrote:
> On Wednesday, March 10th, 2021 at 6:20 PM, Michel Dänzer
> wrote:
>> On 2021-03-10 3:50 p.m., Simon Ser wrote:
>>
>>> Changes in v2: drop "amd/display: fail on cursor plane without an
>>> underlying plane". This retains the current behavior instead.
>>
On Wednesday, March 10th, 2021 at 6:20 PM, Michel Dänzer
wrote:
> On 2021-03-10 3:50 p.m., Simon Ser wrote:
>
> > Changes in v2: drop "amd/display: fail on cursor plane without an
> > underlying plane". This retains the current behavior instead.
>
> Patches 2 & 3 (and possibly 4? not sure)
Am 11.03.21 um 04:29 schrieb Oak Zeng:
ioremap_cache is not supported on some architecture
such as s390. Put the codes into a #ifdef to fix
some compile error reported by test robot.
Signed-off-by: Oak Zeng
Reported-by: Kernel test robot
Reviewed-by: Christian König for the series.
---
Alternatively changing all callers to give MAX_INT as parameter when
they don't care is the preferred variant, but a bit more work.
Christian.
Am 11.03.21 um 04:24 schrieb Grodzovsky, Andrey:
You can just rename drm_sched_resubmit_jobs to
drm_sched_resubmit_jobs_imp and create a wrapper
Am 10.03.21 um 23:13 schrieb Felix Kuehling:
On 2021-03-09 11:50 a.m., Felix Kuehling wrote:
Using 'imply AMD_IOMMU_V2' does not guarantee that the driver can link
against the exported functions. If the GPU driver is built-in but the
IOMMU driver is a loadable module, the kfd_iommu.c file is
52 matches
Mail list logo
