From: Aric Cyr
This version brings along following fixes:
- Populate socclk entries for dcn2.1
- hide VGH asic specific structs
- Add kernel doc to crc_rd_wrk field
- revert max lb lines change
- Log DMCUB trace buffer events
- Fix debugfs link_settings entry
- revert max lb use by default for
From: Jake Wang
[Why & How]
Link index doesn't always correspond to the appropriate eDP instance.
We can assume lower link index is a lower eDP instance and set panel
control instance accordingly.
Signed-off-by: Jake Wang
Reviewed-by: Nicholas Kazlauskas
Acked-by: Qingqing Zhuo
---
From: Alvin Lee
[Why]
Change set_drr to pass in the entire dc_crtc_timing_adjust
structure instead of passing in the parameters individually.
This is to more easily pass in required parameters in the
adjust structure when it gets updated.
Signed-off-by: Alvin Lee
Reviewed-by: Jun Lei
From: Anthony Koo
Signed-off-by: Anthony Koo
Reviewed-by: Anthony Koo
Acked-by: Solomon Chiu
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
From: Anson Jacob
[Why]
On NAVI14 CONFIG_UBSAN reported shift-out-of-bounds at
display_rq_dlg_calc_20v2.c:304:38
rq_param->misc.rq_c.blk256_height is 0 when chroma(*_c) is invalid.
dml_log2 returns -1023 for log2(0), although log2(0) is undefined.
Which ended up as:
From: David Galiffi
[Why]
When performing clock recovery, if a pre-emphasis adjustment is
requested, but voltage swing remains constant, the the retry counter
will not be reset. This can lead to prematurely failing link training.
[How]
Reset the clock recovery retry counter if an adjustment is
From: Victor Lu
[why]
The amdgpu_dm IRQ handlers are not freed during the IRQ teardown.
[how]
Add function to deallocate IRQ handlers on amdgpu_dm_irq_fini step.
Signed-off-by: Victor Lu
Reviewed-by: Roman Li
Acked-by: Solomon Chiu
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 51
From: Fangzhi Zuo
1. Catch invalid link_rate and link_count settings
2. Call dc interface to overwrite preferred link settings, and wait
until next stream update to apply the new settings.
Signed-off-by: Fangzhi Zuo
Reviewed-by: Nicholas Kazlauskas
Acked-by: Solomon Chiu
---
From: Dmytro Laktyushkin
This is causing a pstate change underflow regression for
unknown reason
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Eric Bernstein
Acked-by: Solomon Chiu
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 2 --
From: Dmytro Laktyushkin
Some hardware revisions do have a max number of lines limitation
not honouring which can cause pstate switch underflow.
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Eric Bernstein
Acked-by: Solomon Chiu
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c |
From: Wayne Lin
[Why]
Receive warning message below:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:380: warning: Function
parameter or member 'crc_rd_wrk' not described in 'amdgpu_display_manager'
[How]
Add documentation for crc_rd_wrk.
Reported-by: Stephen Rothwell
Signed-off-by: Wayne
From: "Leo (Hanghong) Ma"
[Why]
We want to log DMCUB trace buffer events as Linux kernel traces.
[How]
Register an IRQ handler for DMCUB outbox0 interrupt in amdgpu_dm,
and log the messages in the DMCUB tracebuffer to a new DMCUB
TRACE_EVENT as soon as we receive the outbox0 IRQ from DMCUB FW.
From: Dmytro Laktyushkin
The pmfw structs are specific to the asic and should not be
present in base clk_mgr struct
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Eric Yang
Acked-by: Solomon Chiu
---
.../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 116 +-
From: Roman Li
[Why]
Dcn2.1 socclk entries in bandwidth params are not initialized.
They are not used now, but will be needed for dml validation.
[How]
Populate socclk bw params from dpm clock table
Signed-off-by: Roman Li
Reviewed-by: Dmytro Laktyushkin
Acked-by: Solomon Chiu
---
This DC patchset brings improvements in multiple areas. In summary, we
highlight:
* Populate socclk entries for dcn2.1
* hide VGH asic specific structs
* Add kernel doc to crc_rd_wrk field
* revert max lb lines change
* Log DMCUB trace buffer events
* Fix debugfs link_settings entry
* revert
On Fri, Mar 19, 2021 at 10:45:10PM +0100, Mario Kleiner wrote:
> On Fri, Mar 19, 2021 at 10:16 PM Ville Syrjälä
> wrote:
> >
> > On Fri, Mar 19, 2021 at 10:03:13PM +0100, Mario Kleiner wrote:
> > > These are 16 bits per color channel unsigned normalized formats.
> > > They are supported by at
[AMD Official Use Only - Internal Distribution Only]
The Update patch has been submitted.
Regards,
Bindu
From: Michel Dänzer
Sent: Friday, March 19, 2021 6:31 AM
To: R, Bindu ; Lakha, Bhawanpreet ;
amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhou1,
On Fri, Mar 19, 2021 at 10:16 PM Ville Syrjälä
wrote:
>
> On Fri, Mar 19, 2021 at 10:03:13PM +0100, Mario Kleiner wrote:
> > These are 16 bits per color channel unsigned normalized formats.
> > They are supported by at least AMD display hw, and suitable for
> > direct scanout of Vulkan swapchain
On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote:
>
> On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote:
> > On 2021-03-19 10:22 a.m., Alex Deucher wrote:
> > > On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
> > >>
> > >> AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
> > >> to
On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote:
> On 2021-03-19 10:22 a.m., Alex Deucher wrote:
> > On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
> >>
> >> AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
> >> to ensure no display backlight will flicker at low user brightness
>
This is causing a deadlock in amdgpu_ttm_access_memory during the
PtraceAccess test in kfdtest. Unfortunately it doesn't get flagged by
LOCKDEP. See the kernel log snippet below. I don't have a good
explanation what's going on other than maybe some data structure corruption.
With this patch
Hi Dave, Daniel,
New stuff for 5.13.
The following changes since commit 6e80fb8ab04f6c4f377e2fd422bdd1855beb7371:
drm/amdgpu: Set reference clock to 100Mhz on Renoir (v2) (2021-02-18 16:43:09
-0500)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
On Fri, Mar 19, 2021 at 10:03:13PM +0100, Mario Kleiner wrote:
> These are 16 bits per color channel unsigned normalized formats.
> They are supported by at least AMD display hw, and suitable for
> direct scanout of Vulkan swapchain images in the format
> VK_FORMAT_R16G16B16A16_UNORM.
>
>
This is intended to enable direct high-precision scanout and pageflip
of Vulkan swapchain images in format VK_FORMAT_R16G16B16A16_UNORM.
Expose DRM_FORMAT_XRGB16161616, DRM_FORMAT_ARGB16161616,
DRM_FORMAT_XBGR16161616 and DRM_FORMAT_ABGR16161616 as 16 bpc
unsigned normalized formats. These allow
This is needed to avoid warnings with linebuffer depth 36 bpp.
Testing on a Polaris11, DCE-11.2 on a 10 bit HDR-10 monitor
showed no obvious problems, and this 12 bpc limit is consistent
with what other function in the DCE bit depth reduction path use.
Signed-off-by: Mario Kleiner
---
Testing with the photometer shows that at least Raven Ridge DCN-1.0
does not achieve more than 10 bpc effective output precision with a
16 bpc unorm surface of type SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616,
unless linebuffer depth is increased from LB_PIXEL_DEPTH_30BPP to
LB_PIXEL_DEPTH_36BPP.
Add the necessary format definition, bandwidth and pixel size mappings,
prescaler setup, and pixelformat selection, following the logic
already present for SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616.
The new SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616 is implemented as the
old
These are 16 bits per color channel unsigned normalized formats.
They are supported by at least AMD display hw, and suitable for
direct scanout of Vulkan swapchain images in the format
VK_FORMAT_R16G16B16A16_UNORM.
Signed-off-by: Mario Kleiner
---
drivers/gpu/drm/drm_fourcc.c | 4
Hi,
this patch series adds the fourcc's for 16 bit fixed point unorm
framebuffers to the core, and then an implementation for AMD gpu's
with DisplayCore.
This is intended to allow for pageflipping to, and direct scanout of,
Vulkan swapchain images in the format VK_FORMAT_R16G16B16A16_UNORM.
I
On 2021-03-19 8:49 a.m., Maxime Ripard wrote:
All the drivers that support the HDR metadata property have a similar
function to compare the metadata from one connector state to the next,
and force a mode change if they differ.
All these functions run pretty much the same code, so let's turn it
This caused a regression in kfdtest in a large-buffer stress test after
memory allocation for user pages fails:
[17359.536303] amdgpu: init_user_pages: Failed to get user pages: -16
[17359.543746] BUG: kernel NULL pointer dereference, address:
[17359.551494] #PF: supervisor
On 2021-03-11 9:22 a.m., Alex Deucher wrote:
On Wed, Feb 17, 2021 at 11:53 AM Harry Wentland wrote:
On 2021-02-16 12:28 p.m., Alex Deucher wrote:
Commit 098214999c8f added fetching of the AUX_DPHY register
values from the vbios, but it also changed the default values
in the case when
On Fri, Mar 19, 2021 at 2:47 PM Christian König
wrote:
>
>
>
> Am 19.03.21 um 19:26 schrieb Harry Wentland:
> > On 2021-03-19 2:13 p.m., Alex Deucher wrote:
> >> + Harry, Nick
> >>
> >> On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
> >>>
> >>> Fixes the following W=1 kernel build warning(s):
Fix size comparison in the resource cursor.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h
index
On Fri, Mar 19, 2021 at 07:53:48PM +0100, Christian König wrote:
> Am 19.03.21 um 18:52 schrieb Daniel Vetter:
> > On Fri, Mar 19, 2021 at 03:08:57PM +0100, Christian König wrote:
> > > Don't print a warning when we fail to allocate a page for swapping things
> > > out.
> > >
> > > Also rely on
On 2021-03-19 2:19 p.m., Nirmoy wrote:
ping.
On 3/17/21 11:52 AM, Nirmoy Das wrote:
Replace GFP_KERNEL with GFP_ATOMIC as dcn20_resource_construct()
can't sleep.
Partially fixes: https://bugzilla.kernel.org/show_bug.cgi?id=212311
as dcn20_resource_construct() also calls into SMU functions
On 2021-03-19 2:18 p.m., Alex Deucher wrote:
Ping?
On Thu, Mar 18, 2021 at 10:18 PM Alex Deucher wrote:
Move the function protoype to the right header and guard
the call with CONFIG_DRM_AMD_DC_DCN as DSC is only available
with DCN.
Fixes: a03f6c0e26b2 ("drm/amd/display: Add changes for
Am 19.03.21 um 18:52 schrieb Daniel Vetter:
On Fri, Mar 19, 2021 at 03:08:57PM +0100, Christian König wrote:
Don't print a warning when we fail to allocate a page for swapping things out.
Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS.
Uh this part doesn't make
Am 19.03.21 um 19:26 schrieb Harry Wentland:
On 2021-03-19 2:13 p.m., Alex Deucher wrote:
+ Harry, Nick
On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In
function
On Fri, Mar 19, 2021 at 2:26 PM Harry Wentland wrote:
>
> On 2021-03-19 2:13 p.m., Alex Deucher wrote:
> > + Harry, Nick
> >
> > On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
> >>
> >> Fixes the following W=1 kernel build warning(s):
> >>
> >>
On Fri, Mar 19, 2021 at 3:04 AM Shirish S wrote:
>
> refactor AMDGPU_PP_SENSOR_GPU_LOAD to ensure code consistency with other
> commands
>
> Signed-off-by: Shirish S
Reviewed-by: Alex Deucher
> ---
> .../gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c| 13 ++---
> 1 file changed, 6
On 2021-03-19 2:13 p.m., Alex Deucher wrote:
+ Harry, Nick
On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
‘calculate_bandwidth’:
On 2021-03-19 4:24 a.m., Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17:
warning: no previous prototype for ‘dce80_aux_engine_create’
[-Wmissing-prototypes]
On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17:
> warning: no previous prototype for ‘dce80_aux_engine_create’
> [-Wmissing-prototypes]
>
ping.
On 3/17/21 11:52 AM, Nirmoy Das wrote:
Replace GFP_KERNEL with GFP_ATOMIC as dcn20_resource_construct()
can't sleep.
Partially fixes: https://bugzilla.kernel.org/show_bug.cgi?id=212311
as dcn20_resource_construct() also calls into SMU functions which does
mutex_lock().
Signed-off-by:
Ping?
On Thu, Mar 18, 2021 at 10:18 PM Alex Deucher wrote:
>
> Move the function protoype to the right header and guard
> the call with CONFIG_DRM_AMD_DC_DCN as DSC is only available
> with DCN.
>
> Fixes: a03f6c0e26b2 ("drm/amd/display: Add changes for dsc bpp in 16ths and
> unify bw
+ Harry, Nick
On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
> ‘calculate_bandwidth’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1:
On Thu, Mar 18, 2021 at 2:36 PM Bjorn Helgaas wrote:
>
> On Tue, Mar 16, 2021 at 03:28:51PM -0400, Alex Deucher wrote:
> > From: Marcin Bachry
> >
> > Renoir needs a similar delay.
>
> See
> https://lore.kernel.org/linux-pci/20210311125322.GA216@bjorn-Precision-5520/
>
> This is becoming a
On Fri, Mar 19, 2021 at 08:24:07AM +, Lee Jones wrote:
> On Thu, 18 Mar 2021, Daniel Vetter wrote:
>
> > On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote:
> > >
> > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote:
> > > >
> > > > On Thu, 11 Mar 2021, Lee Jones wrote:
> > > >
> > > > >
On Fri, Mar 19, 2021 at 03:08:57PM +0100, Christian König wrote:
> Don't print a warning when we fail to allocate a page for swapping things out.
>
> Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS.
Uh this part doesn't make sense. Especially since you only do it for
[AMD Official Use Only - Internal Distribution Only]
+ Leo
From: amd-gfx on behalf of Christian
König
Sent: Friday, March 19, 2021 10:08 AM
To: Liu, Leo ; amd-gfx@lists.freedesktop.org
; dri-de...@lists.freedesktop.org
Subject: [PATCH] drm/ttm: stop warning
[AMD Public Use]
Yeah, the reset method is independent of whether we can use BACO for runtime
PM. We can use BACO for power saving and use mode1 for reset. Is there some
issue I'm missing?
Alex
From: amd-gfx on behalf of Lazar, Lijo
Sent: Friday, March
[AMD Official Use Only - Internal Distribution Only]
Series is:
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Evan Quan
Sent: Friday, March 19, 2021 2:53 AM
To: amd-gfx@lists.freedesktop.org
Cc: Quan, Evan
Subject: [PATCH 2/2] drm/amd/pm: label these
On 2021-03-19 10:22 a.m., Alex Deucher wrote:
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
to ensure no display backlight will flicker at low user brightness
settings. However this value is quite bright, so for devices that do
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another drive-by fix I found when fixing DP AUX adapter across the kernel
> tree - make sure we don't leak resources (and by proxy-AUX adapters) on
> failures in
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Just another issue I noticed while correcting usages of
> drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the
> steps in
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another driver I found that seems to forget to unregister it's DP AUX
> device. Let's fix this by adding anx6345_bridge_detach().
>
> Signed-off-by: Lyude Paul
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Just another drive-by fix I noticed while going through the tree to cleanup
> DP aux adapter registration - make sure we unregister the DP AUX dev if
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since encoder mappings for connectors are exposed to userspace, we should
> be attaching the encoder before exposing the connector to userspace. Just a
> drive-by
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another case of linking an encoder to a connector after the connector's
> been registered. The proper place to do this is before connector
> registration, so
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Surprisingly, this bridge actually registers it's AUX adapter at the
> correct time already. Nice job! However, it does forget to actually
> unregister the AUX
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since this is a bridge, we don't start out with a respective DRM device.
> Likewise this means we don't have a connector, which also means that we
> should be following
All the drivers that implement HDR output call pretty much the same
function to initialise the hdr_output_metadata property, and while the
creation of that property is in a helper, every driver uses the same
code to attach it.
Provide a helper for it as well
Signed-off-by: Maxime Ripard
---
Hey Lyude,
Thanks for the patch
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> And finally, convert all of the code in drm_dp_mst_topology.c over to using
> drm_err() and drm_dbg*(). Note that this refactor would have been a lot
> more complicated to have tried writing a coccinelle script
On Thu, 18 Mar 2021, Daniel Vetter wrote:
> On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote:
> >
> > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote:
> > >
> > > On Thu, 11 Mar 2021, Lee Jones wrote:
> > >
> > > > On Thu, 11 Mar 2021, Daniel Vetter wrote:
> > > >
> > > > > On Mon, Mar 08,
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This is a resend of the remaining patches.
All of these patches have been sent before.
Lee Jones (19):
drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
drm/nouveau/dispnv50/disp:
Hey Lyude,
Thanks for the patch,
On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make sure that we can also add ratelimited versions of these macros in
> order to retain some of the previous debugging output
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
‘calculate_bandwidth’:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning:
the frame size of 1216 bytes is larger than 1024 bytes
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:527:17:
warning: no previous prototype for ‘dce80_aux_engine_create’
[-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:565:20:
warning: no
All the drivers that support the HDR metadata property have a similar
function to compare the metadata from one connector state to the next,
and force a mode change if they differ.
All these functions run pretty much the same code, so let's turn it into
an helper that can be shared across those
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
‘bw_calcs_init’:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning:
the frame size of 1336 bytes is larger than 1024 bytes [-Wframe-larger-than=]
From: Dave Stevenson
Now that we can export deeper colour depths, add in the signalling
for HDR metadata.
Signed-off-by: Dave Stevenson
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 53 ++
drivers/gpu/drm/vc4/vc4_hdmi.h | 3 ++
2 files
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Since this is one of the few functions in drm_dp_mst_topology.c that
> doesn't have any way of getting access to a drm_device, let's pass the
> drm_dp_mst_topology_mgr down to this function so that it can use
>
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log, and ensured all of our logging uses a
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
>
> AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
> to ensure no display backlight will flicker at low user brightness
> settings. However this value is quite bright, so for devices that do not
> implement the ACPI ATIF
>
Don't print a warning when we fail to allocate a page for swapping things out.
Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_tt.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Evan,
this is a laptop with RENOIR hardware (Ryzen 4800H) and a discrete GPU
RX5500. There is an external monitor connected to the HDMI port (which
is attached to the iGPU afaict).
I would be happy to test further and help in nailing this one ;)
Greetings
Harey
Am 19.03.21 um 03:10
That is unused for quite some time now.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
Am 19.03.21 um 02:38 schrieb Deng, Emily:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Christian König
Sent: Thursday, March 18, 2021 7:52 PM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the page fault issue in
[AMD Public Use]
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Friday, March 19, 2021 2:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Quan, Evan
Subject: [PATCH 2/2] drm/amdgpu: disable runpm if other reset method not runpm
capable is chosen
Otherwise, the runpm will
[AMD Official Use Only - Internal Distribution Only]
Hi, Evan,
It is better to replace all nv_asic_supports_baco callings with
amdgpu_dpm_is_baco_supported, and remove nv_asic_supports_baco function.
>>> static bool nv_asic_supports_baco(struct amdgpu_device *adev) {
>>> - struct
On 2021-03-19 1:44 a.m., R, Bindu wrote:
>
> Hi All,
> Thanks for the inputs, have updated the patch to include these changes.
Updated where? I can't find an updated patch.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast |
Otherwise, the runpm will be always enabled on a BACO capable target
even the reset method was forced as like mode1.
Change-Id: If6bf55c533e91470c9c83383788466161608f68d
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
Use other APIs which are with the same functionality but much
more clean.
Change-Id: I5e9e0ab5d39b49b02434f18e12392b13931396be
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/nv.c | 20 +
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 9 ---
[AMD Official Use Only - Internal Distribution Only]
Hi, Emily,
What about refine struct amdgpu_irq_src with refcount? Your change could
fix this issue, but it is unreadable.
Best Regards
Dennis Li
-Original Message-
From: amd-gfx On Behalf Of Deng, Emily
Sent: Friday, March 19,
AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
to ensure no display backlight will flicker at low user brightness
settings. However this value is quite bright, so for devices that do not
implement the ACPI ATIF
ATIF_FUNCTION_QUERY_BRIGHTNESS_TRANSFER_CHARACTERISTICS
functionality the
refactor AMDGPU_PP_SENSOR_GPU_LOAD to ensure code consistency with other
commands
Signed-off-by: Shirish S
---
.../gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c| 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
Also drop unnecessary header file and declarations.
Change-Id: I877b48c32c599534798e14e271c3e700b0d6ebf6
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 1 -
drivers/gpu/drm/amd/amdgpu/nv.c | 1 -
No need to have special handlings for swSMU supported ASICs.
Change-Id: I1ec552c6a2a4283cf6ab3acfe6c0753bfcca57a9
Signed-off-by: Evan Quan
---
.../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 134 +++---
.../gpu/drm/amd/include/kgd_pp_interface.h| 14 ++
89 matches
Mail list logo
