RE: [PATCH] drm/amdgpu: Fix build warnings

[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking From: Lazar, Lijo Sent: Wednesday, March 24, 2021 13:19 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei Subject: [PATCH] drm/amdgpu: Fix build warnings [AMD Public Use] Fix header guard and make internal

[PATCH] drm/amdgpu: Fix build warnings

[AMD Public Use] Fix header guard and make internal functions static. Fixes the below warnings: drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu_reset.h:24:9: warning: '__AMDUGPU_RESET_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]

[PATCH] drm/amdgpu: Fix check for RAS support

Use positive logic to check for RAS support. Rename the function to actually indicate what it is testing for. Essentially, make the function a predicate with the correct name. Cc: Stanley Yang Cc: Alexander Deucher Signed-off-by: Luben Tuikov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 15

RE: [PATCH] drm/amdgpu: move vram recover into sriov full access

[AMD Official Use Only - Internal Distribution Only] Reviewed by: Monk.Liu -- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Horace Chen Sent: Wednesday, March 24, 2021 12:18 PM To:

Re: [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h

Reviewed-by: Rodrigo Siqueira On 03/23, Anson Jacob wrote: > Removing code that is not used at the moment. > > Signed-off-by: Anson Jacob > --- > .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 37 --- > 1 file changed, 37 deletions(-) > > diff --git

RE: [PATCH] drm/amdgpu/pm: mark pcie link/speed arrays as const

[AMD Public Use] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, March 24, 2021 11:51 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Dave Airlie Subject: [PATCH] drm/amdgpu/pm: mark pcie link/speed arrays as const

[pull] amdgpu, amdkfd, radeon drm-next-5.13

Hi Dave, Daniel, Same as the last one, but with typo in one of the sign offs fixed. The following changes since commit 6e80fb8ab04f6c4f377e2fd422bdd1855beb7371: drm/amdgpu: Set reference clock to 100Mhz on Renoir (v2) (2021-02-18 16:43:09 -0500) are available in the Git repository at:

[PATCH] drm/amdgpu/pm: mark pcie link/speed arrays as const

They are read only. Noticed-by: Dave Airlie Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 4 ++-- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c | 4 ++-- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c | 4 ++--

RE: [PATCH 1/2] drm/amdgpu: use zero as start for dummy resource walks

[AMD Official Use Only - Internal Distribution Only] I don’t think so. Start is offset here. We get the valid physical address from pages_addr[offset] when we update mapping. Btw, what issue we are seeing? -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: 2021年3月23日

Re: [PATCH] drm/amd/display: Use DRM_DEBUG_DP

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Tuikov, Luben Sent: Tuesday, March 23, 2021 4:26 PM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Wentland, Harry ; Deucher, Alexander Subject: [PATCH]

RE: [PATCH] drm/amd/pm: Update aldebaran pmfw interface

Reviewed-by: Feifei Xu From: Lazar, Lijo Sent: Tuesday, March 23, 2021 9:07 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei ; Feng, Kenneth ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: Update aldebaran pmfw interface [AMD Public Use] Update aldebaran PMFW

[PATCH] Revert "drm/amd/display: To modify the condition in indicating branch device"

This breaks HDMI audio. This reverts commit 9413b23fadad3861f5afd626ac44ef83ad8068ab. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1536 Signed-off-by: Alex Deucher Cc: Martin Tsai Cc: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 +++- 1 file changed,

[PATCH v2] drm/amd/display: Use DRM_DEBUG_DP

Convert IRQ-based prints from DRM_DEBUG_DRIVER to the appropriate DRM log type, since IRQ-based prints drown out the rest of the driver's DRM_DEBUG_DRIVER messages. v2: Update as per feedback to fine-tune for each type of DRM log level. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Luben

[PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h

Removing code that is not used at the moment. Signed-off-by: Anson Jacob --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 37 --- 1 file changed, 37 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH] drm/amdgpu: Add new PF2VF flags for VF register access method

Add 3 sub flags to notify guest for indirect access of gc, mmhub and ih Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h| 11 +++ drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 17 +++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: Use DRM_DEBUG_DP

Convert IRQ-based prints from DRM_DEBUG_DRIVER to DRM_DEBUG_DP, as the latter is not used in drm/amd prior to this patch and since IRQ-based prints drown out the rest of the driver's DRM_DEBUG_DRIVER messages. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Luben Tuikov ---

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher wrote: > > On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: > > > > From: Mark Yacoub > > > > On initializing the framebuffer, call drm_any_plane_has_format to do a > > check if the modifier is supported. drm_any_plane_has_format calls > >

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 14:56:54, Christian König wrote: > Am 23.03.21 um 14:41 schrieb Michal Hocko: [...] > > Anyway, I am wondering whether the overall approach is sound. Why don't > > you simply use shmem as your backing storage from the beginning and pin > > those pages if they are used by the

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 14:06:25, Christian König wrote: > Am 23.03.21 um 13:37 schrieb Michal Hocko: > > On Tue 23-03-21 13:21:32, Christian König wrote: [...] > > > Ideally I would like to be able to trigger swapping out the shmem page I > > > allocated immediately after doing the copy. > > So let me

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 14:15:05, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 01:04:03PM +0100, Michal Hocko wrote: > > On Tue 23-03-21 12:48:58, Christian König wrote: > > > Am 23.03.21 um 12:28 schrieb Daniel Vetter: > > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > > > > I

Re: [PATCH] drm/dp_mst: Enhance DP MST topology logging

Sorry for the wait! Review comments below On Thu, 2021-03-18 at 11:55 -0400, Eryk Brol wrote: > [why] > MST topology print was missing fec logging and pdt printed > as an int wasn't clear. vcpi and payload info were also logged as an > arbitrary series of ints which require the user to know the

Re: [PATCH] drm/amdgpu/display: fix clkmgr for SI

Found the fixes tag for this: Fixes: f4a5cbdcb1 ("drm/amd/display: hide VGH asic specific structs") The series is Acked-by: Nirmoy Das On 3/23/21 6:06 PM, Alex Deucher wrote: It looks like the SI case was missed. Need to return the clkmgr struct for SI. Signed-off-by: Alex Deucher ---

Re: [PATCH][next] drm/amd/display/dc/calcs/dce_calcs: Fix allocation size for dceip and vbios

On Tue, 23 Mar 2021, Colin King wrote: > From: Colin Ian King > > Currently the allocations for dceip and vbios are based on the size of > the pointer rather than the size of the data structures, causing heap > issues. Fix this by using the correct allocation sizes. > > Addresses-Coverity:

[PATCH] drm/amdgpu/display: fix memory leak for dimgrey cavefish

We need to clean up the dcn3 clk_mgr. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c index

[PATCH] drm/amdgpu: remove unused variables

Leftover from the GPU reset rework. Remove them. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

[PATCH] drm/amdgpu/display: fix clkmgr for SI

It looks like the SI case was missed. Need to return the clkmgr struct for SI. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 13:21:32, Christian König wrote: > Am 23.03.21 um 13:04 schrieb Michal Hocko: > > On Tue 23-03-21 12:48:58, Christian König wrote: > > > Am 23.03.21 um 12:28 schrieb Daniel Vetter: > > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > > > > On Mon 22-03-21

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 12:51:13, Christian König wrote: > > > Am 23.03.21 um 12:46 schrieb Michal Hocko: > > On Tue 23-03-21 12:28:20, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > [...] > > > > > > fs_reclaim_acquire is there to make sure lockdep

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 12:28:20, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: [...] > > > > fs_reclaim_acquire is there to make sure lockdep understands that this > > > > is a shrinker and that it checks all the dependencies for us like if > > > > we'd be in real

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue 23-03-21 12:48:58, Christian König wrote: > Am 23.03.21 um 12:28 schrieb Daniel Vetter: > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > > On Mon 22-03-21 20:34:25, Christian König wrote: [...] > > > > My only concern is that if I could rely on memalloc_no* being used

Re: [PATCH 1/2] drm/amdgpu: use zero as start for dummy resource walks

[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Tuesday, March 23, 2021 10:54 AM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy ; Chen, Guchun Subject: [PATCH 1/2] drm/amdgpu:

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

On 23/03/2021 14.04, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc warns about an sprintf() that uses the same buffer as source > and destination, which is undefined behavior in C99: > > drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function > 'amdgpu_securedisplay_debugfs_write':

Re: [PATCH] drm/amd/display: Use DRM_DEBUG_DP

Thanks for converting these away from _DRIVER. On 2021-03-23 10:26 a.m., Alex Deucher wrote: On Mon, Mar 22, 2021 at 8:31 PM Luben Tuikov wrote: Convert IRQ-based prints from DRM_DEBUG_DRIVER to DRM_DEBUG_DP, as the latter is not used in drm/amd prior to this patch and since IRQ-based prints

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 16:13 schrieb Michal Hocko: On Tue 23-03-21 14:56:54, Christian König wrote: Am 23.03.21 um 14:41 schrieb Michal Hocko: [...] Anyway, I am wondering whether the overall approach is sound. Why don't you simply use shmem as your backing storage from the beginning and pin those

Re: [PATCH 2/2] drm/amdgpu: re-apply "use the new cursor in the VM code""

Tested on Navi1x with "piglit run opengl results/test". The series is Tested-by: Nirmoy Das from my side. Curious to know how this holds up against Guchun's Vulkan cts test. Regards, Nirmoy On 3/23/21 3:54 PM, Christian König wrote: Now that we found the underlying problem we can

Re: [PATCH] amdgpu: fix gcc -Wrestrict warning

Applied. Thanks! Alex On Tue, Mar 23, 2021 at 9:04 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc warns about an sprintf() that uses the same buffer as source > and destination, which is undefined behavior in C99: > > drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function >

Re: Amdgpu kernel oops and freezing on system suspend and hibernate

Alex, thanks for the hint, but... Is this patch intended for kernel 5.11.8? I applied the patch against 5.11.8 and it is freezing again: Mär 23 16:18:51 obelix kernel: [drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out! Mär 23 16:18:51 obelix kernel:

Re: [PATCH] gpu: drm: amd: Remove duplicate includes

Same patch was already applied recently. Thanks, Alex On Mon, Mar 22, 2021 at 9:19 PM Wan Jiabing wrote: > > ../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included > at line 32, so remove them. > > Signed-off-by: Wan Jiabing > --- >

Re: [PATCH] gpu: drm: amd: Remove duplicate include of dce110_resource.h

The same patch was already applied recently. Thanks! Alex On Mon, Mar 22, 2021 at 9:10 PM Wan Jiabing wrote: > > dce110/dce110_resource.h has been included at line 58, so remove > the duplicate include at line 64. > > Signed-off-by: Wan Jiabing > --- >

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

On Wed, Mar 10, 2021 at 5:14 PM Mark Yacoub wrote: > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate that the >

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub wrote: > > From: Mark Yacoub > > On initializing the framebuffer, call drm_any_plane_has_format to do a > check if the modifier is supported. drm_any_plane_has_format calls > dm_plane_format_mod_supported which is extended to validate that the >

Re: [PATCH] amdgpu: avoid incorrect %hu format string

Applied. Thanks! Alex On Mon, Mar 22, 2021 at 7:55 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out that the %hu format string does not match the type > of the variables here: > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type > 'unsigned

Re: [PATCH] drivers: gpu: Remove duplicate include of amdgpu_hdp.h

Applied. Thanks! Alex On Mon, Mar 22, 2021 at 8:10 AM Christian König wrote: > > > > Am 22.03.21 um 13:02 schrieb Wan Jiabing: > > amdgpu_hdp.h has been included at line 91, so remove > > the duplicate include. > > > > Signed-off-by: Wan Jiabing > > Acked-by: Christian König > > > --- > >

Re: [PATCH] drm/amdkfd: Fix cat debugfs hang_hws file causes system crash bug

Applied. Thanks! Alex On Sun, Mar 21, 2021 at 5:33 AM Qu Huang wrote: > > Here is the system crash log: > [ 1272.884438] BUG: unable to handle kernel NULL pointer dereference at > (null) > [ 1272.88] IP: [< (null)>] (null) > [ 1272.884447] PGD 825b09067 PUD 8267c8067 PMD

[PATCH 1/2] drm/amdgpu: use zero as start for dummy resource walks

When we don't have a physically backing store we should use zero instead of the virtual start address since that isn't necessary a valid physical one. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] drm/amdgpu: re-apply "use the new cursor in the VM code""

Now that we found the underlying problem we can re-apply this patch. This reverts commit 867fee7f8821ff42e7308088cf0c3450ac49c17c. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 55 +- 1 file changed, 18 insertions(+), 37 deletions(-) diff

Re: [PATCH] drm/amdgpu: remove irq_src->data handling

On Fri, Mar 19, 2021 at 8:25 AM Christian König wrote: > > That is unused for quite some time now. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 5 - > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 1 - > 2 files changed, 6

Re: [PATCH v2] drm/radeon: don't evict if not initialized

Applied. Thanks! Alex On Mon, Mar 22, 2021 at 3:40 AM Christian König wrote: > > Am 21.03.21 um 16:19 schrieb Tong Zhang: > > TTM_PL_VRAM may not initialized at all when calling > > radeon_bo_evict_vram(). We need to check before doing eviction. > > > > [2.160837] BUG: kernel NULL pointer

RE: [PATCH 01/44] drm/amdgpu: replace per_device_list by array

[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Monday, March 22, 2021 6:58 AM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Cc: Sierra Guiza, Alejandro (Alex) > Subject: [PATCH

Re: [PATCH] drm/amd/display: Use DRM_DEBUG_DP

On Mon, Mar 22, 2021 at 8:31 PM Luben Tuikov wrote: > > Convert IRQ-based prints from DRM_DEBUG_DRIVER to > DRM_DEBUG_DP, as the latter is not used in drm/amd > prior to this patch and since IRQ-based prints > drown out the rest of the driver's > DRM_DEBUG_DRIVER messages. > > Cc: Harry Wentland

[PATCH][next] drm/amd/display/dc/calcs/dce_calcs: Fix allocation size for dceip and vbios

From: Colin Ian King Currently the allocations for dceip and vbios are based on the size of the pointer rather than the size of the data structures, causing heap issues. Fix this by using the correct allocation sizes. Addresses-Coverity: ("Wrong size of argument") Fixes: a2a855772210

RE: [PATCH 2/2] drm/amdgpu: Introduce new SETUP_TMR interface

[AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Zeng, Oak Sent: Monday, March 22, 2021 7:33 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhang, Hawking Subject: Re: [PATCH 2/2] drm/amdgpu: Introduce new SETUP_TMR interface [AMD Official Use Only -

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 14:41 schrieb Michal Hocko: On Tue 23-03-21 14:06:25, Christian König wrote: Am 23.03.21 um 13:37 schrieb Michal Hocko: On Tue 23-03-21 13:21:32, Christian König wrote: [...] Ideally I would like to be able to trigger swapping out the shmem page I allocated immediately after

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue, Mar 23, 2021 at 01:04:03PM +0100, Michal Hocko wrote: > On Tue 23-03-21 12:48:58, Christian König wrote: > > Am 23.03.21 um 12:28 schrieb Daniel Vetter: > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > > > I think this is where I don't get yet what Christian tries to

[PATCH] drm/amd/pm: Update aldebaran pmfw interface

[AMD Public Use] Update aldebaran PMFW interfaces to version 0x6 Signed-off-by: Lijo Lazar lijo.la...@amd.com --- .../gpu/drm/amd/pm/inc/smu13_driver_if_aldebaran.h| 11 +-- drivers/gpu/drm/amd/pm/inc/smu_v13_0.h| 2 +- 2 files changed, 10

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 13:37 schrieb Michal Hocko: On Tue 23-03-21 13:21:32, Christian König wrote: Am 23.03.21 um 13:04 schrieb Michal Hocko: On Tue 23-03-21 12:48:58, Christian König wrote: Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote:

[PATCH] amdgpu: fix gcc -Wrestrict warning

From: Arnd Bergmann gcc warns about an sprintf() that uses the same buffer as source and destination, which is undefined behavior in C99: drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function 'amdgpu_securedisplay_debugfs_write':

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 13:04 schrieb Michal Hocko: On Tue 23-03-21 12:48:58, Christian König wrote: Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: On Mon 22-03-21 20:34:25, Christian König wrote: [...] My only concern is that if I could

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Mon 22-03-21 20:34:25, Christian König wrote: > Am 22.03.21 um 18:02 schrieb Daniel Vetter: > > On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: > > > On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > > > > On Mon, Mar 22, 2021 at 02:49:27PM +0100, Daniel Vetter wrote: > > > > > On Sun, Mar

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue, Mar 23, 2021 at 12:51:13PM +0100, Christian König wrote: > > > Am 23.03.21 um 12:46 schrieb Michal Hocko: > > On Tue 23-03-21 12:28:20, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > > [...] > > > > > > fs_reclaim_acquire is there to make sure

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 12:46 schrieb Michal Hocko: On Tue 23-03-21 12:28:20, Daniel Vetter wrote: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: [...] fs_reclaim_acquire is there to make sure lockdep understands that this is a shrinker and that it checks all the dependencies for us

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

Am 23.03.21 um 12:28 schrieb Daniel Vetter: On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: On Mon 22-03-21 20:34:25, Christian König wrote: Am 22.03.21 um 18:02 schrieb Daniel Vetter: On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: On Mon 22-03-21 14:05:48, Matthew Wilcox

Re: [PATCH] drm/amd/dispaly: fix deadlock issue in amdgpu reset

+ Harry and Nick On 2021-03-22 9:42 p.m., Yu, Lang wrote: [AMD Official Use Only - Internal Distribution Only] -Original Message- From: Grodzovsky, Andrey Sent: Monday, March 22, 2021 11:01 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: > On Mon 22-03-21 20:34:25, Christian König wrote: > > Am 22.03.21 um 18:02 schrieb Daniel Vetter: > > > On Mon, Mar 22, 2021 at 5:06 PM Michal Hocko wrote: > > > > On Mon 22-03-21 14:05:48, Matthew Wilcox wrote: > > > > > On Mon, Mar

RE: [PATCH] drm/amdgpu: Enable recovery on aldebaran

[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking From: Lazar, Lijo Sent: Tuesday, March 23, 2021 18:55 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei Subject: [PATCH] drm/amdgpu: Enable recovery on aldebaran [AMD Public Use] Add aldebaran to devices which

[PATCH] drm/amdgpu: Enable recovery on aldebaran

[AMD Public Use] Add aldebaran to devices which support recovery Signed-off-by: Lijo Lazar lijo.la...@amd.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

RE: [PATCH] drm/amdgpu: re-apply "use the new cursor in the VM code""

[AMD Public Use] Hi Christian, Thanks for your patience. Unluckily, after applying below patch, vulkan cts test on my side is negative. The same gfxhub page fault and kernel bug along with amdgpu_vm_update_ptes calltrace is observed. I will send the full log to you privately soon. I suggest

Re: [PATCH] drm/amdgpu: re-apply "use the new cursor in the VM code""

I tested ./piglit run opengl results/test multiple times. Once I got gfx time out error but without kernel freeze. I can't reproduce it any more. Regards, Nirmoy On 3/22/21 2:11 PM, Chen, Guchun wrote: [AMD Public Use] Hi Christian, I will conduct one stress test for this tomorrow. Would

RE: [PATCH] drm/amd/pm: fix gpu reset failure by MP1 state setting

[AMD Public Use] Thanks! Reviewed-by: Evan Quan -Original Message- From: Chen, Guchun Sent: Tuesday, March 23, 2021 1:50 PM To: amd-gfx@lists.freedesktop.org; Lazar, Lijo ; Chen, Jiansong (Simon) ; Quan, Evan Cc: Chen, Guchun Subject: [PATCH] drm/amd/pm: fix gpu reset failure by

[PATCH] drm/amdgpu/display: fix dmub invalid register read

DMCUB_SCRATCH_0 sometimes contains 0xdeadbeef during initialization. If this is detected, return 0 instead. This prevents wrong bit-flags from being read. The main impact of this bug is in the status check loop in dmub_srv_wait_for_auto_load. As it is waiting for the device to become ready,

Re: [PATCH] drm/amd: Fix a typo in two different sentences

On 3/22/21 2:06 PM, Bhaskar Chowdhury wrote: > > s/defintion/definition/ .two different places. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/amd/include/atombios.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH] drm/amd: Fix a typo in two different sentences

s/defintion/definition/ .two different places. Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/amd/include/atombios.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atombios.h b/drivers/gpu/drm/amd/include/atombios.h index

[PATCH] gpu: drm: amd: Remove duplicate includes

../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included at line 32, so remove them. Signed-off-by: Wan Jiabing --- .../gpu/drm/amd/display/dc/gpio/dce110/hw_factory_dce110.c| 4 1 file changed, 4 deletions(-) diff --git

[PATCH] gpu: drm: amd: Remove duplicate include of dce110_resource.h

dce110/dce110_resource.h has been included at line 58, so remove the duplicate include at line 64. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c