Before dma_resv_lock(bo->base.resv, NULL) in amdgpu_bo_release_notify(),
the bo->base.resv lock may be held by ttm_mem_evict_first(),
and the VRAM mem will be evicted, mem region was replaced
by Gtt mem region. amdgpu_bo_release_notify() will then
hold the bo->base.resv lock, and SDMA will get an
Hi Everyone,
On latest amd-staging-drm-next, the below patch is causing errors at
boot time and should be reverted.
Error on boot on Vega 10.
[ +0.007084] loop1: detected capacity change from 327992 to 0
[ +0.244709] amdgpu :63:00.0: [drm:amdgpu_ring_test_helper [amdgpu]]
*ERROR* ring
patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
Hi Dave, Daniel,
New stuff for 5.13. There are two small patches for ttm and scheduler
that were dependencies for amdgpu changes.
The following changes since commit 2cbcb78c9ee5520c8d836c7ff57d1b60ebe8e9b7:
Merge tag 'amd-drm-next-5.13-2021-03-23' of
Applied. Thanks!
Alex
On Thu, Apr 1, 2021 at 11:26 AM Wan Jiabing wrote:
>
> struct mod_hdcp is declared twice. One is declared at 33rd line.
> The blew one is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
> ---
> drivers/gpu/drm/amd/display/modules/inc/mod_hdcp.h | 2 --
>
Current code already contains the fix.
Alex
On Thu, Apr 1, 2021 at 9:09 AM Christian König
wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot
> > Signed-off-by: Rasmus
This code has been dropped.
Alex
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix checkpatch.pl warning:
> Too many leading tabs - consider code refactoring
> WARNING: Too many leading tabs - consider code refactoring
> + for (j = 0; j <
Applied. Thanks!
Alex
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix patch check warning:
> WARNING: suspect code indent for conditional statements (8, 17)
> + if (obj && obj->use < 0) {
> +DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n",
> obj->head.name);
>
Applied. Thanks!
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix patch check warning:
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> + buf = kmalloc(MAX_KFIFO_SIZE * sizeof(*buf), GFP_KERNEL);
>
> Signed-off-by: Bernard Zhao
> ---
>
On 2021-04-01 10:22 a.m., Alex Deucher wrote:
Use uintptr_t rather than uint64_t.
Signed-off-by: Alex Deucher
Cc: Dave Airlie
Cc: Harry Wentland
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1
This reverts commit 34a33d4683cba7ba63c894132efb1998c0217631.
34a33d4683cba7ba63c894132efb1998c0217631 was a driver workaround
when PSP firmware was not ready. Now the PSP fw is ready so we
revert this driver workaround.
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 9
patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
Use amdgpu_gmc_vram_pa and amdgpu_gmc_vram_cpu_pa
to simplify codes. No logic change.
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 3 +--
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 3 +--
Add one function to calculate BO's GPU physical address.
And another function to calculate BO's CPU physical address.
v2: Use functions vs macros (Christian)
Use more proper function names (Christian)
Signed-off-by: Oak Zeng
Suggested-by: Lijo Lazar
---
This reverts commit 34a33d4683cba7ba63c894132efb1998c0217631.
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 9 -
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 --
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 21 ++---
This new interface passes both virtual and physical address
to PSP. It is backword compatible with old interface.
v2: use a function to simply tmr physical address calc (Lijo)
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 12 +---
On 2021-03-30 10:28 p.m., Alex Deucher wrote:
Missing check for CONFIG_DRM_AMD_DC_DCN.
Fixes: 752106f5c5cd ("drm/amd/display: Set max TTU on DPG enable")
Signed-off-by: Alex Deucher
Cc: Wesley Chalmers
Cc: Stephen Rothwell
Reviewed-by: Harry Wentland
Harry
---
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Mukul Joshi
Regards,
Mukul
-Original Message-
From: Lin, Amber
Sent: Tuesday, March 30, 2021 5:03 PM
To: amd-gfx@lists.freedesktop.org
Cc: Joshi, Mukul ; Lin, Amber
Subject: [PATCH] drm/amdkfd: Avoid null pointer in
On Thu, Apr 1, 2021 at 10:08 AM Smith John wrote:
>
> Hi, when I killed an OpenCL host process, the kernels it launched were not
> terminated, and still run.
>
> My OpenCL runtime is AMDGPU-PRO 20.20. OS Ubuntu 18.04.5 with Linux Kernel
> 5.4.53
>
> I was wondering if it was a bug or the
Ping?
On Tue, Mar 30, 2021 at 10:28 PM Alex Deucher wrote:
>
> Missing check for CONFIG_DRM_AMD_DC_DCN.
>
> Fixes: 752106f5c5cd ("drm/amd/display: Set max TTU on DPG enable")
> Signed-off-by: Alex Deucher
> Cc: Wesley Chalmers
> Cc: Stephen Rothwell
> ---
>
[AMD Public Use]
Hi all,
This week this patchset was tested on a HP Envy 360, with Ryzen 5 4500U, on the
following display types (via usb-c to dp/dvi/hdmi/vga):
4k 60z, 1440p 144hz, 1680*1050 60hz, internal eDP 1080p 60hz
Tested on a Sapphire Pulse RX5700XT on the following display types (via
From: Aric Cyr
DC version 3.2.130 brings improvements in multiple areas.
In summary, we highlight:
- Firmware release 0.0.59
- Fixes on display experiences for 4k TVs, register mask missing, etc.
- Enhancements on MST, code cleaning and debug messages.
Signed-off-by: Aric Cyr
Reviewed-by:
From: Anthony Koo
[How]
add params to send FEC status to firmware
Signed-off-by: Anthony Koo
Reviewed-by: Anthony Koo
Acked-by: Qingqing Zhuo
---
drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git
From: Nicholas Kazlauskas
[Why & How]
Pipe input DSC bpc has a type mismatch with maximum DSC
input bpc - align the maximum with the pipe input type,
unsigned integer.
When checking the type we shoudl also check for an
implicit value of 0 and align with what the spreadsheet
does - default to
From: Mikita Lipski
[why/how]
Skip logic that sets preffered link settings
and just retrain with new link_settings from Debugfs
Signed-off-by: Mikita Lipski
Reviewed-by: Mikita Lipski
Acked-by: Harry Wentland
Acked-by: Qingqing Zhuo
---
[Why]
DCN3 is not reusing DCN1 mask_sh_list, causing
SURFACE_FLIP_INT_MASK missing in the mapping.
[How]
Add the corresponding entry to DCN3 list.
Signed-off-by: Qingqing Zhuo
Reviewed-by: Nicholas Kazlauskas
Acked-by: Qingqing Zhuo
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hubp.h | 1 +
From: Victor Lu
[why]
Currently to view the DCC_EN bit the entire DTN log
must be dumped. A compact method to view the DCC_EN
bit is desirable.
[how]
Introduce new debugfs interface that only dumps the
DCC_EN bit.
Example usage:
cat /sys/kernel/debug/dri/0/amdgpu_dm_dcc_en
Signed-off-by:
From: Mikita Lipski
[Why]
The driver always wants to synchronize streams
to the first edge of master's vsync pulse.
In order to determine that we can read timing
flags that are used to program vsync.
Master stream's vsync polarity - Multi Display Stream Synchronization edge:
Negative
From: Harry VanZyllDeJong
[WHY]
When on the desktop freesync is not enabled,
doing a frame stretch causes the TV to display
undesired output.
[HOW]
By changing the logic so that when ever fresync
is supported the TV is notified we are in fressync
instead on a non fresync state.
Signed-off-by:
From: Mikita Lipski
[Why]
Need to be able to trigger software hotplug for MST connectors
[How]
For unplug the driver calls to disable topologies manager
that connector is attached to. For plugging in it does the
whole rediscovery of all connectors in drm device and enbles their
topologies if
From: Mikita Lipski
[why/how]
Due to compiler optimization the values would be
passed to the division function uninitialized
causing a div by zero. Initialize the numerator
and denominator to 0 and 1 to prevent division
by zero.
Signed-off-by: Mikita Lipski
Reviewed-by: Mikita Lipski
From: Wayne Lin
[Why]
Commit 04f6f5baec25ce76b8b6e1af63c54b6042c16716
("drm/amd/display: Add kernel doc to crc_rd_wrk
field") adds kernel doc for crc_rd_wrk field in
amdgpu_dm.h but it's incorrectly formatted.
Make htmldocs warns:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:398: warning:
From: Harry Wentland
[Why]
Add debug flag for an option to disable min fclk.
Signed-off-by: Harry Wentland
Reviewed-by: Harry Wentland
Acked-by: Qingqing Zhuo
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 4 ++--
drivers/gpu/drm/amd/display/dc/dc.h
From: Aurabindo Pillai
[Why]
Functionality of LTTPR is reporter through the DPCD register
[How]
Expose a interface in debugfs to read the current status of
LTTPR as reported from the device's DPCD register
Signed-off-by: Aurabindo Pillai
Reviewed-by: Rodrigo Siqueira
Acked-by: Qingqing Zhuo
From: Harry Wentland
[Why]
Add debug prints for SMU messages with regard to
versions, clocks, and more.
Signed-off-by: Harry Wentland
Reviewed-by: Harry Wentland
Reviewed-by: Robin Singh
Acked-by: Qingqing Zhuo
---
.../display/dc/clk_mgr/dcn301/dcn301_smu.c| 29 ---
1
From: Jake Wang
[Why]
We need to keep track of the number of eDP links to
properly enumerate edp panel control instance.
[How]
Added dc_edp_id_count to dc_context to keep track of
number of eDP links.
Signed-off-by: Jake Wang
Reviewed-by: Nicholas Kazlauskas
Acked-by: Qingqing Zhuo
---
From: Leo Li
[Why]
The OTG_VUPDATE_KEEPOUT register and fields is
available on DCN10, and named the same in DCN20.
[How]
Move register definition and programming function
to dcn10 optc.
There is no functional change.
Signed-off-by: Leo Li
Reviewed-by: Harry Wentland
Acked-by: Qingqing
From: Robin Singh
[why]
There is case when the userspace like IGT test updates the custom
timings, i.e. the number of active lines CRTC property value,
and without committing the change, followed by
resetting the display, creating FB and plane to the pipe
and committing. The NULL pointer of
From: "David (Dingchen) Zhang"
[why]
In MST setup, we'd use MST downstream AUX to
dump the DPRX CRCs from sink device.
[how]
Assign the mst_port->aux to read DPCD registers.
Signed-off-by: David (Dingchen) Zhang
Reviewed-by: Harry Wentland
Acked-by: Qingqing Zhuo
---
From: Anson Jacob
[Why/How]
Fix cast from pointer to integer of different size error
from dmub/src/dmub_srv.c
Signed-off-by: Anson Jacob
Reviewed-by: Rodrigo Siqueira
Acked-by: Qingqing Zhuo
---
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Wyatt Wood
[Why]
Today a parameter is passed to dmub_srv_send_gpint_command
which specifies the max amount of time to wait for the command
to be acked.
This parameter instead specifies the number of times to check if
the command was acked.
We wish to add a lower bound to the timeout, which
From: Wyatt Wood
[Why]
GPINT command to get PSR state from FW times out.
[How]
Add retry to get valid PSR state.
Signed-off-by: Wyatt Wood
Reviewed-by: Anthony Koo
Acked-by: Qingqing Zhuo
---
drivers/gpu/drm/amd/display/dc/dc_types.h | 3 +-
This DC patchset brings improvements in multiple areas.
In summary, we highlight:
* Firmware release 0.0.59
* Fixes on display experiences for 4k TVs, register mask missing, etc.
* Enhancements on MST, code cleaning and debug messages.
---
Anson Jacob (1):
drm/amd/display: Fix 32 bit
struct mod_hdcp is declared twice. One is declared at 33rd line.
The blew one is not needed. Remove the duplicate.
Signed-off-by: Wan Jiabing
---
drivers/gpu/drm/amd/display/modules/inc/mod_hdcp.h | 2 --
1 file changed, 2 deletions(-)
diff --git
There's no "xorg.conf" on my system.
On Wed, 31 Mar 2021 at 20:01, Alex Deucher wrote:
> Does disabling pageflipping via the xorg.conf help?
>
> Alex
>
> On Wed, Mar 31, 2021 at 1:40 PM Christian König
> wrote:
> >
> > Yeah, agree that must be some kind of bug in the upper layer of the
>
patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
Use uintptr_t rather than uint64_t.
Signed-off-by: Alex Deucher
Cc: Dave Airlie
Cc: Harry Wentland
---
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
Hi, when I killed an OpenCL host process, the kernels it launched were not
terminated, and still run.
My OpenCL runtime is AMDGPU-PRO 20.20. OS Ubuntu 18.04.5 with Linux Kernel
5.4.53
I was wondering if it was a bug or the driver did not implement this
"watchdog" mechanism.
On Fri, 26 Mar 2021, Lyude Paul wrote:
> Since it's been asked quite a few times on some of the various DP
> related patch series I've submitted to use the new DRM printk helpers,
> and it technically wasn't really trivial to do this before due to the
> lack of a consistent way to find a
On Fri, 26 Mar 2021, Lyude Paul wrote:
> * The @dev field should be set to a pointer to the device that implements
> the
> - * AUX channel.
> + * AUX channel. As well, the @drm_dev field should be set to the _device
> + * that will be using this AUX channel as early as possible. For many
>
patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
Keep sparse happy by preserving the __user annotation when casting.
Reported-by: kernel test robot
Signed-off-by: Rasmus Villemoes
Reviewed-by: Christian König
Going over old patches and stumbled over that once.
Alex did you missed to pick
Am 29.03.21 um 17:28 schrieb Alex Deucher:
> Applied. Thanks!
>
> Alex
Nice to hear that ^^
One quick question: Here do I find the amd-gfx dev branch?
Kind regards,
Werner Sembach
>
> On Fri, Mar 26, 2021 at 10:59 AM Harry Wentland
> wrote:
>>
>>
>> On 2021-03-24 4:23 p.m., Alex Deucher
[AMD Official Use Only - Internal Distribution Only]
Reivewed-by: Dennis Li
-Original Message-
From: Stanley.Yang
Sent: Thursday, April 1, 2021 7:14 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Clements, John
; Li, Dennis ; Yang, Stanley
Subject: [PATCH Review 1/1]
]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 0e16683876aa..d9d292c79cfa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++
]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Monk Liu
Thanks
--
Monk Liu | Cloud-GPU Core team
--
-Original Message-
From: Deng, Emily
Sent: Thursday, April 1, 2021 2:04 PM
To: Liu,
Acked-by: Nirmoy Das
On 3/30/21 11:42 AM, Emily Deng wrote:
From: "Emily.Deng"
For vf assigned to guest VM, after FLR, the msix table will be reset.
As the flr is done on host driver. The qemu and vfio driver don't know
this, and the msix is still enable from qemu and vfio driver side.
So if
Restarting the *display manager* service works and, more importantly, makes
the bug no longer reproducible.
Restarting the *window manager* doesn't work.
*Changing* display manager makes the bug still reproducible.
Maybe this is due to xorg-server, isn't it?
On Wed, 31 Mar 2021 at 16:55,
[AMD Official Use Only - Internal Distribution Only]
Hi Monk,
Could you help to review this patch?
Best wishes
Emily Deng
>-Original Message-
>From: Deng, Emily
>Sent: Wednesday, March 31, 2021 5:02 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH]
[AMD Official Use Only - Internal Distribution Only]
Hi Monk,
Could you help to review this patch?
Best wishes
Emily Deng
>-Original Message-
>From: Deng, Emily
>Sent: Wednesday, March 31, 2021 5:01 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH 4/6]
[AMD Official Use Only - Internal Distribution Only]
Hi Monk,
Could you help to review this patch?
Best wishes
Emily Deng
>-Original Message-
>From: Deng, Emily
>Sent: Wednesday, March 31, 2021 5:01 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH 2/6]
[AMD Official Use Only - Internal Distribution Only]
Hi Monk,
Could you help to review this patch?
Best wishes
Emily Deng
>-Original Message-
>From: Deng, Emily
>Sent: Wednesday, March 31, 2021 5:01 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Cc: Min, Frank
>Subject:
[AMD Official Use Only - Internal Distribution Only]
Series Reviewed-by: Emily.Deng
>-Original Message-
>From: amd-gfx On Behalf Of Peng
>Ju Zhou
>Sent: Wednesday, March 31, 2021 1:20 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Zhao, Jiange
>Subject: [PATCH 4/4] drm/amdgpu: indirect
65 matches
Mail list logo
