RE: [PATCH 1/2] drm/amdgpu/acpi: fix typo in ATCS handling

2021-05-26 Thread Sundararaju, Sathishkumar
[AMD Official Use Only - Internal Distribution Only] Tested-by: Sathishkumar S Reviewed-by: Sathishkumar S -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, May 26, 2021 8:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2]

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

2021-05-26 Thread Christian König
Am 26.05.21 um 02:40 schrieb Luben Tuikov: On Context Query2 IOCTL return the correctable and uncorrectable errors in O(1) fashion, from cached values, and schedule a delayed work function to calculate and cache them for the next such IOCTL. v2: Cancel pending delayed work at ras_fini(). Cc:

[PATCH] drm/amdgpu: Fix Gstreamer api vaapih264enc missing

2021-05-26 Thread Li, Xin (Justin)
since vcn decoding ring is not required, so just disable it. Cc: Alex.Deucher Cc: Christian.Konig Signed-off-by: Li.Xin.Justin Signed-off-by: Frank.Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 25 ++--- 2 files

[PATCH 6/7] drm/amdgpu: remove unused code

2021-05-26 Thread Nirmoy Das
Remove unused code related to shadow BO. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 29 -- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 --- 2 files changed, 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

[PATCH 5/7] drm/amdgpu: switch to amdgpu_bo_vm for shadow pointer

2021-05-26 Thread Nirmoy Das
The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are shadowed, so switch to shadow pointer of amdgpu_bo_vm. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 27 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 16 ++-- 2 files

[PATCH 4/7] drm/amdgpu: create shadow bo directly

2021-05-26 Thread Nirmoy Das
Shadow BOs are only needed by VM code so create it directly within the vm code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 1/7] drm/amdgpu: add amdgpu_bo_vm bo type

2021-05-26 Thread Nirmoy Das
Add new BO subclass that will be used by amdgpu vm code. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 32 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 10 +++ 2 files changed, 42 insertions(+) diff --git

[PATCH v2 7/7] drm/amdgpu: do not allocate entries separately

2021-05-26 Thread Nirmoy Das
Allocate PD/PT entries while allocating VM BOs and use that instead of allocating those entries separately. v2: create a new var for num entries. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 34 +++--- 1 file changed, 20 insertions(+), 14

[PATCH 2/7] drm/amdgpu: move shadow bo validation to VM code

2021-05-26 Thread Nirmoy Das
Do the shadow bo validation in the VM code as VM code knows/owns shadow BOs. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 23 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 2 files changed, 9 insertions(+), 19 deletions(-) diff --git

[PATCH 3/7] drm/amdgpu: use amdgpu_bo_vm for vm code

2021-05-26 Thread Nirmoy Das
Use amdgpu_bo_vm subclass for creating BOs related to PD/PT. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 43 ++ 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

RE: [PATCH] drm/amdgpu: Correctly clear GCEA error status

2021-05-26 Thread Clements, John
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: John Clements -Original Message- From: Joshi, Mukul Sent: Wednesday, May 26, 2021 4:20 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John ; Li, Dennis ; Joshi, Mukul Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/amdgpu: Disable page fault retry for beige_goby

2021-05-26 Thread Zhou1, Tao
[AMD Official Use Only] Reviewed-by: Tao Zhou mailto:tao.zh...@amd.com>> From: Chengming Gui Sent: Wednesday, May 26, 2021 3:48 PM To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack ; Zhou1, Tao ; Chen, Jiansong (Simon) ; Zhang, Hawking Subject: [PATCH]

Re: radeon ring 0 test failed on arm64

2021-05-26 Thread Christian König
Hi Robin, Am 25.05.21 um 22:09 schrieb Robin Murphy: On 2021-05-25 14:05, Alex Deucher wrote: On Tue, May 25, 2021 at 8:56 AM Peter Geis wrote: On Tue, May 25, 2021 at 8:47 AM Alex Deucher wrote: On Tue, May 25, 2021 at 8:42 AM Peter Geis wrote: Good Evening, I am stress testing

RE: [PATCH v2] drm/amdgpu: fix metadata_size for ubo ioctl queries

2021-05-26 Thread Das, Nirmoy
[AMD Official Use Only] Reviewed-by: Nirmoy Das -Original Message- From: Zhang, Morris Sent: Wednesday, May 26, 2021 5:11 AM To: amd-gfx@lists.freedesktop.org; Das, Nirmoy Subject: [PATCH v2] drm/amdgpu: fix metadata_size for ubo ioctl queries Although the

[PATCH] drm/amd/pm: retain the fine grain tuning parameters after resume

2021-05-26 Thread Xiaojian Du
This patch is to retain the fine grain tuning parameters after resume for legacy APU, it will cover Raven/Raven2/Picasso. Signed-off-by: Xiaojian Du --- .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 3 ++- .../drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 21 +++ 2 files

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

2021-05-26 Thread Chen, JingWen
Hi Monk, New patch submitted according to your suggestion Best Regards, JingWen Chen -Original Message- From: Liu, Monk Sent: Wednesday, May 26, 2021 3:24 PM To: Chen, JingWen ; amd-gfx@lists.freedesktop.org Cc: Zhao, Victor ; Chen, JingWen Subject: RE: [PATCH] drm/amd/amdgpu:save

[PATCHv2] drm/amd/amdgpu:save psp ring wptr to avoid attack

2021-05-26 Thread Jingwen Chen
From: Victor Zhao [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify change and add detailed reason Change-Id:

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

2021-05-26 Thread Liu, Monk
[AMD Official Use Only] >>+ ring->ring_wptr = psp_write_ptr_reg; Put the cache mechanism into the callbacks please >>+ ring->ring_wptr = 0; It is not needed At last, try to put more details in the comment to let people know why we need this PSP WPTR cache mechanism Thanks

RE: [PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

2021-05-26 Thread Deng, Emily
[AMD Official Use Only] Reviewed-by: Emily Deng >-Original Message- >From: amd-gfx On Behalf Of Jingwen >Chen >Sent: Wednesday, May 26, 2021 2:55 PM >To: amd-gfx@lists.freedesktop.org >Cc: Chen, JingWen ; Zhao, Victor >; Liu, Monk >Subject: [PATCH] drm/amd/amdgpu:save psp ring wptr in

RE: [PATCH 2/2] drm/amdgpu/acpi: make ATPX/ATCS structures global

2021-05-26 Thread Lazar, Lijo
[Public] -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, May 26, 2021 8:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/acpi: make ATPX/ATCS structures global They are global ACPI methods, so maybe the

[PATCH] drm/amd/amdgpu:save psp ring wptr in SRIOV to avoid attack

2021-05-26 Thread Jingwen Chen
From: Victor Zhao save psp ring wptr in SRIOV to avoid attack to avoid extra changes to MP0_SMN_C2PMSG_102 reg Change-Id: Idee78e8c1c781463048f2f6311fdc70488ef05b2 Signed-off-by: Victor Zhao Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 +

<    1   2