Hi,
In the display core, we utilize floats and doubles units for calculating
modesetting parameters. One side effect of our approach to use double-precision
is the fact that we spread multiple FPU access across our driver, which means
that we can accidentally clobber user space FPU state.
#
DC invokes DC_FPU_START/END in multiple parts of the code; this can
create a situation where we invoke this FPU operation in a nested way or
exit too early. For avoiding this situation, this commit adds a
mechanism where dc_fpu_begin/end manages the access to
kernel_fpu_begin/end.
Change since
The display core files rely on FPU, which requires to be compiled with
special flags. Ideally, we don't want these FPU operations spread around
the DC code; nevertheless, it happens in the current source. This commit
introduces a new directory inside DML for centralizing shared DCN
functions that
DC invokes DC_FPU_START/END in multiple parts of the code; this can
create a situation where we invoke this FPU operation in a nested way or
exit too early. For avoiding this situation, this commit adds a
mechanism where dc_fpu_begin/end manages the access to
kernel_fpu_begin/end.
Change since
To fully isolate FPU operations in a single place, we must avoid
situations where compilers spill FP values to registers due to FP enable
in a specific C file. Note that even if we isolate all FPU functions in
a single file and call its interface from other files, the compiler
might enable the use
[Public]
Reviewed-by: Roman Li
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, July 21, 2021 6:18 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/display: only enable aux backlight control for OLED
panels
We've
[AMD Official Use Only]
Sounds good, Thanks for clarifying. Thanks for the input Guchun.
Best,
Ryan
From: Alex Deucher
Sent: Monday, July 26, 2021 9:58 AM
To: Taylor, Ryan
Cc: Chen, Guchun ; kernel test robot ;
Daniel Vetter ; Siqueira, Rodrigo
; amd-gfx list
[AMD Official Use Only]
Given that amdgpu_vkms contains code from both dce_virtual and vkms should the
identifier be changed to GPL-2.0+ OR MIT like in amdgpu_res_cursor.h?
Best,
Ryan
From: Alex Deucher
Sent: Monday, July 26, 2021 9:21 AM
To: Chen, Guchun
Cc:
[Public]
Reviewed-by: Alex Deucher
From: Vishwakarma, Pratik
Sent: Monday, July 26, 2021 8:33 AM
To: Deucher, Alexander ; Lazar, Lijo
; amd-gfx@lists.freedesktop.org
Cc: Vishwakarma, Pratik
Subject: [PATCH] drm/amdgpu: Rename amdgpu_acpi_is_s0ix_supported
On Mon, Jul 26, 2021 at 10:45 AM Edgardo Gho wrote:
>
> Hello all,
> Not sure if this is the proper place to report this issue.
> I'm using an AMD A8-3500M with AMD Radeon HD 6620G.
> I'm testing with several recent kernels (5.11 , 5.13) on different distros
> (Ubuntu, Tinycore).
> On all of
[Public]
Hi all,
This week this patchset was tested on the following systems:
HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p
60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI),
1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)
AMD
On Mon, Jul 26, 2021 at 12:39 PM Taylor, Ryan wrote:
>
> [AMD Official Use Only]
>
>
> Given that amdgpu_vkms contains code from both dce_virtual and vkms should
> the identifier be changed to GPL-2.0+ OR MIT like in amdgpu_res_cursor.h?
Most of the code is from vkms so match vkms.
Alex
>
>
Rename amdgpu_acpi_is_s0ix_supported to better explain
functionality by renaming to amdgpu_acpi_is_s0ix_active
Signed-off-by: Pratik Vishwakarma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4
On Fri, Jul 23, 2021 at 10:07 PM Chen, Guchun wrote:
>
> [Public]
>
> Look copy right statement is missed in both amdgpu_vkms.c and amdgpu_vkms.h.
It's there, it just uses the newer SPDX license identifier.
Alex
>
> Regards,
> Guchun
>
> -Original Message-
> From: amd-gfx On Behalf
Hello all,
Not sure if this is the proper place to report this issue.
I'm using an AMD A8-3500M with AMD Radeon HD 6620G.
I'm testing with several recent kernels (5.11 , 5.13) on different
distros (Ubuntu, Tinycore).
On all of them I have the same issue. When the video resolution change
(for
[AMD Official Use Only]
Hi Alex & Lijo,
For now, those code for updating OD table are in smu_cmn.c. And they can only
be called from _ppt.c.
So, unless we split some code from smu_cmn.c and move them to upper
layer(suggested by Lijo before), otherwise this cannot be performed.
So, definitely
[Public]
Hi Guchun,
Currently, the smu->user_dpm_profile.flags seems only used to flag whether we
are in a process restoring the user customized settings(power limit/fan
settings/od settings etc). We could either drop it or expand its usage. Let me
consider more and make a follow-up patch for
[AMD Official Use Only]
Thanks for reminder. As I confirmed, the OD settings will be reset to default
after gpu reset.
As smu->adev->in_suspend is 0 during gpu reset. And that will reset OD settings
to default.
BR
Evan
> -Original Message-
> From: Matt Coffin
> Sent: Saturday, July
18 matches
Mail list logo
