Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

Am 02.08.21 um 07:16 schrieb Guchun Chen: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as it's

[PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as it's part of driver shutdown, and should never b

RE: [PATCH] drm/amdgpu: adjust fence driver enable sequence

[Public] Hi Lothian, Thanks for your report. I have a following fix for this problem, will send it out soon for review. Regards, Guchun From: amd-gfx On Behalf Of Mike Lothian Sent: Sunday, August 1, 2021 7:57 PM To: Gao, Likun Cc: amd-gfx list ; Zhang, Hawking Subject: Re: [PATCH] drm/amd

RE: [PATCH] drm/amdgpu: Fix channel_index table layout for Aldebaran

[Public] /* number of umc channel instance with memory map register access */ -#define UMC_V6_7_CHANNEL_INSTANCE_NUM 4 +#define UMC_V6_7_UMC_INSTANCE_NUM 4 /* number of umc instance with memory map register access */ -#define UMC_V6_7_UMC_INSTANCE_NUM 8 +#define

[PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS

correct smu feature mapping: FEATURE_DATA_CALCULATIONS Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 + drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu

RE: Re: AMD A8 3500M LVDS with CH7511B goes off on resolution change (randomly)

Hi Alex, thanks for replying. I reported the issue ( https://gitlab.freedesktop.org/drm/amd/-/issues/1665 ) but have not got much help there. I notice when the issue happens LCD backlight goes off, so I measured the Backlight Enable cable and it goes from 5V to 0V.. so I suspected maybe it was j

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Hi Thomas, > > > > 1) IRQ_NOTCONNECTED > > > > We do not have this check in drm_irq today and we should avoid spreading > > it all over. We are either carrying it forever or we wil lsee patches > > floating in to drop the check again. > > The current use in the kernel is minimal: > > https://eli

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Hi Sam Am 31.07.21 um 20:50 schrieb Sam Ravnborg: Hi Thomas, On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote: DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces. DRM provides IRQ he

Re: [PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_unpopulate()

Am 31.07.21 um 10:13 schrieb Tuo Li: The variable ttm is assigned to the variable gtt, and the variable gtt is checked in: if (gtt && gtt->userptr) This indicates that both ttm and gtt can be NULL. If so, a null-pointer dereference will occur: if (ttm->page_flags & TTM_PAGE_FLAG_SG) Also,

Re: [PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_populate()

Am 31.07.21 um 10:04 schrieb Tuo Li: The variable ttm is assigned to the variable gtt, and the variable gtt is checked in: if (gtt && gtt->userptr) This indicates that both ttm and gtt can be NULL. If so, a null-pointer dereference will occur: if (ttm->page_flags & TTM_PAGE_FLAG_SG) Also,

Re: [PATCH] drm/amdgpu: adjust fence driver enable sequence

Hi This patch is causing me issues on my Skylake/Tonga PRIME laptop, reverting sorts it More details here: https://gitlab.freedesktop.org/drm/amd/-/issues/1668 Cheers Mike On Wed, 28 Jul 2021 at 05:07, Likun Gao wrote: > From: Likun Gao > > Fence driver was enabled per ring when sw init on