RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] Reviewed-by: John Clements From: Li, Candice Sent: Tuesday, August 3, 2021 11:06 AM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf [Public] Signed-off-by: Candice Li

RE: [PATCH] drm/amd/pm: update smu v13.0.1 firmware header

[AMD Official Use Only] Reviewed-by: Aaron Liu -- Best Regards Aaron Liu > -Original Message- > From: Hou, Xiaomeng (Matthew) > Sent: Tuesday, August 3, 2021 11:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Aaron ; Deucher, Alexander > ; Huang, Ray ; Hou, > Xiaomeng (Matthew)

RE: [PATCH] drm/amd/pm: update smu v13.0.1 firmware header

[AMD Official Use Only] Reviewed-by: Huang Rui -Original Message- From: Hou, Xiaomeng (Matthew) Sent: Tuesday, August 3, 2021 11:16 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Aaron ; Deucher, Alexander ; Huang, Ray ; Hou, Xiaomeng (Matthew) Subject: [PATCH] drm/amd/pm: update

[PATCH] drm/amd/pm: update smu v13.0.1 firmware header

Update smu v13.0.1 firmware header for yellow carp. Signed-off-by: Xiaomeng Hou --- drivers/gpu/drm/amd/pm/inc/smu_v13_0_1_pmfw.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v13_0_1_pmfw.h b/drivers/gpu/drm/amd/pm/inc/smu_v13_0_1_pmfw.h

[PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] Signed-off-by: Candice Li candice...@amd.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 253 1 file changed, 78 insertions(+), 175 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

[Public] Hi Alex, I submitted the patch before your message, I will take care of this next time. Regards, Guchun -Original Message- From: Alex Deucher Sent: Monday, August 2, 2021 9:35 PM To: Chen, Guchun Cc: Christian König ; amd-gfx@lists.freedesktop.org; Gao, Likun ; Koenig,

[PATCH] drm/amdgpu: Fix vm free pts race when process exiting

Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid link list corruption with crash backtrace: [ 2290.505111] list_del corruption. next->prev should be 9b2514ec0018, but was 4e03280211010f04 [ 2290.505154] kernel BUG at lib/list_debug.c:56! [ 2290.505176] invalid opcode:

Re: [PATCH 0/3] drm/amdgpu: modernize virtual display feature

On Tue, Jul 27, 2021 at 8:11 PM Ryan Taylor wrote: > > The amdgpu vkms interface provides a virtual KMS interface for several use > cases: devices without display hardware, platforms where the actual display > hardware is not useful (e.g., servers), SR-IOV virtual functions, device >

Re: Re: AMD A8 3500M LVDS with CH7511B goes off on resolution change (randomly)

On Sun, Aug 1, 2021 at 5:48 PM wrote: > > Hi Alex, thanks for replying. > I reported the issue ( https://gitlab.freedesktop.org/drm/amd/-/issues/1665 ) > but have not got much help there. > I notice when the issue happens LCD backlight goes off, so I measured the > Backlight Enable cable and it

Re: [PATCH] gpu/drm/amd: Remove duplicated include of drm_drv.h

On Mon, Aug 2, 2021 at 3:32 AM zhouchuangao wrote: > > Duplicate include header file > line 28: #include > line 44: #include > > Signed-off-by: zhouchuangao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks

On Mon, Aug 2, 2021 at 10:24 AM Emil Velikov wrote: > > Hi Jim, > > On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > > > +struct dyndbg_bitdesc { > > + /* bitpos is inferred from index in containing array */ > > + char *prefix; > > + char *help; > AFAICT these two should also

Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param

On Mon, Aug 2, 2021 at 10:18 AM Emil Velikov wrote: > > Hi Jim, > > On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > > > Use of this new data member will be rare, it might be worth redoing > > this as a separate/sub-type to keep the base case. > > > > Signed-off-by: Jim Cromie > > --- > >

[PATCH] drm/amdgpu: don't enable baco on boco platforms in runpm

If the platform uses BOCO, don't use BACO in runtime suspend. We could end up executing the BACO path if the platform supports both. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1669 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2

Re: [PATCH] drm/amdgpu: check CG flag before querying CG status

On Mon, Aug 2, 2021 at 5:31 AM Lang Yu wrote: > > For ASICs which don't supoort clock gating, querying CG status > may cause a hardware hang issue. So add a CG flag check to exit > directly in such a case. > > Signed-off-by: Lang Yu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + >

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

Hi, Thanks for having a stab at this, it's a massive complex topic to solve. Do you have the the HTML rendered somewhere for convenience? On Fri, Jul 30, 2021 at 04:41:29PM -0400, Harry Wentland wrote: > Use the new DRM RFC doc section to capture the RFC previously only > described in the cover

[PATCH] drm/amdkfd: AIP mGPUs best prefetch location for xnack on

For xnack on, if range ACCESS or ACCESS_IN_PLACE (AIP) by single GPU, or range is ACCESS_IN_PLACE by mGPUs and all mGPUs connection on xgmi same hive, the best prefetch location is prefetch_loc GPU. Otherwise, the best prefetch location is always CPU because GPU can not map vram of other GPUs

Re: [PATCH v4 5/7] i915/gvt: control pr_debug("gvt:")s with bits in parameters/debug_gvt

Hi Jim, On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > DYNDBG_BITMAP_DESC(__gvt_debug, "dyndbg bitmap desc", > { "gvt: cmd: ", "command processing" }, > { "gvt: core: ", "core help" }, > { "gvt: dpy: ", "display help" }, > { "gvt: el: ", "help" }, >

Re: [Intel-gfx] [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks

Hi Jim, On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > +struct dyndbg_bitdesc { > + /* bitpos is inferred from index in containing array */ > + char *prefix; > + char *help; AFAICT these two should also be constant, right? > +int param_set_dyndbg(const char *instr, const

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

I've just tested it and it seem to fix my issue Feel free to add my Tested-by: Mike Lothian On Mon, 2 Aug 2021 at 14:35, Alex Deucher wrote: > On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > > > [Public] > > > > Thank you, Christian. > > > > Regarding fence_drv.initialized, it looks

Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param

Hi Jim, On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > Use of this new data member will be rare, it might be worth redoing > this as a separate/sub-type to keep the base case. > > Signed-off-by: Jim Cromie > --- > include/linux/moduleparam.h | 11 +-- > 1 file changed, 9

Re: [PATCH 09/14] drm/radeon: Convert to Linux IRQ interfaces

On Tue, Jul 27, 2021 at 2:27 PM Thomas Zimmermann wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > DRM IRQ callbacks are now being called directly or inlined. > >

[PATCH] drm/amdkfd: support file backed SVM range

HMM migrate helper migrate_vma_pages do not migrate file backed pages to replace it with device pages because the pages are used by file cache. We can not migrate the file backed range to VRAM, otherwise CPU access range will not trigger page fault to migrate updated data from VRAM back to system

Re: [PATCH] drm/radeon: Update pitch for page flip

On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: > > On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: > > Am 02.08.21 um 09:43 schrieb Zhenneng Li: > > > When primary bo is updated, crtc's pitch may > > > have not been updated, this will lead to show > > > disorder content when

Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote: > @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct > trampoline_header *th) > if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT)) > th->flags |= TH_FLAGS_SME_ACTIVE; > > - if (sev_es_active()) { > + if

[PATCH] drm/radeon: Update pitch for page flip

When primary bo is updated, crtc's pitch may have not been updated, this will lead to show disorder content when user changes display mode, we update crtc's pitch in page flip to avoid this bug. This refers to amdgpu's pageflip. Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc:

Re: [PATCH 08/11] mm: Remove the now unused mem_encrypt_active() function

On Tue, Jul 27, 2021 at 05:26:11PM -0500, Tom Lendacky wrote: > The mem_encrypt_active() function has been replaced by prot_guest_has(), > so remove the implementation. > > Signed-off-by: Tom Lendacky Reviewed-by: Joerg Roedel

Re: [PATCH 09/11] x86/sev: Remove the now unused mem_encrypt_active() function

On Tue, Jul 27, 2021 at 05:26:12PM -0500, Tom Lendacky wrote: > The mem_encrypt_active() function has been replaced by prot_guest_has(), > so remove the implementation. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Signed-off-by: Tom Lendacky Reviewed-by: Joerg Roedel

Re: [PATCH 05/11] x86/sev: Replace occurrences of sev_active() with prot_guest_has()

On Tue, Jul 27, 2021 at 05:26:08PM -0500, Tom Lendacky wrote: > Replace occurrences of sev_active() with the more generic prot_guest_has() > using PATTR_GUEST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c > where PATTR_SEV will be used. If future support is added for other memory >

Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has()

Le 28/07/2021 à 00:26, Tom Lendacky a écrit : Replace occurrences of mem_encrypt_active() with calls to prot_guest_has() with the PATTR_MEM_ENCRYPT attribute. What about https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210730114231.23445-1-w...@kernel.org/ ? Christophe Cc:

Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has()

On Tue, Jul 27, 2021 at 05:26:05PM -0500, Tom Lendacky wrote: > Introduce an x86 version of the prot_guest_has() function. This will be > used in the more generic x86 code to replace vendor specific calls like > sev_active(), etc. > > While the name suggests this is intended mainly for guests, it

Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features

On Tue, Jul 27, 2021 at 05:26:04PM -0500, Tom Lendacky wrote: > In prep for other protected virtualization technologies, introduce a > generic helper function, prot_guest_has(), that can be used to check > for specific protection attributes, like memory encryption. This is > intended to eliminate

Re: [PATCH 04/11] x86/sme: Replace occurrences of sme_active() with prot_guest_has()

On Tue, Jul 27, 2021 at 05:26:07PM -0500, Tom Lendacky wrote: > Replace occurrences of sme_active() with the more generic prot_guest_has() > using PATTR_HOST_MEM_ENCRYPT, except for in arch/x86/mm/mem_encrypt*.c > where PATTR_SME will be used. If future support is added for other memory >

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > [Public] > > Thank you, Christian. > > Regarding fence_drv.initialized, it looks to a bit redundant, anyway let me > look into this more. Does this patch fix this bug? https://gitlab.freedesktop.org/drm/amd/-/issues/1668 If so, please add:

[PATCH] drm/amdgpu: check CG flag before querying CG status

For ASICs which don't supoort clock gating, querying CG status may cause a hardware hang issue. So add a CG flag check to exit directly in such a case. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

Hi Am 28.07.21 um 16:03 schrieb Alex Deucher: On Wed, Jul 28, 2021 at 6:27 AM Christian König wrote: Am 27.07.21 um 20:27 schrieb Thomas Zimmermann: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

Hi Sam Am 01.08.21 um 22:24 schrieb Sam Ravnborg: Hi Thomas, 1) IRQ_NOTCONNECTED We do not have this check in drm_irq today and we should avoid spreading it all over. We are either carrying it forever or we wil lsee patches floating in to drop the check again. The current use in the kernel

Re: [PATCH] drm/radeon: Update pitch for page flip

On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: > Am 02.08.21 um 09:43 schrieb Zhenneng Li: > > When primary bo is updated, crtc's pitch may > > have not been updated, this will lead to show > > disorder content when user changes display mode, > > we update crtc's pitch in page

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

[Public] Thank you, Christian. Regarding fence_drv.initialized, it looks to a bit redundant, anyway let me look into this more. Regards, Guchun -Original Message- From: Christian König Sent: Monday, August 2, 2021 2:56 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao, Likun

Re: [PATCH] drm/radeon: Update pitch for page flip

Am 02.08.21 um 09:43 schrieb Zhenneng Li: When primary bo is updated, crtc's pitch may have not been updated, this will lead to show disorder content when user changes display mode, we update crtc's pitch in page flip to avoid this bug. This refers to amdgpu's pageflip. Alex is the expert to

[PATCH] gpu/drm/amd: Remove duplicated include of drm_drv.h

Duplicate include header file line 28: #include line 44: #include Signed-off-by: zhouchuangao --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index

Re: [PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_populate()

Thanks for your feedback! We will remove the null tests according to your advice and prepare a V2 patch. Best wishes, Tuo Li On 2021/8/2 1:19, Christian König wrote: Am 31.07.21 um 10:04 schrieb Tuo Li: The variable ttm is assigned to the variable gtt, and the variable gtt is checked in:   

Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS

[AMD Official Use Only] From: Lazar, Lijo Sent: Monday, August 2, 2021 3:41 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS On 8/2/2021 8:23 AM,

Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS

On 8/2/2021 8:23 AM, Kevin Wang wrote: correct smu feature mapping: FEATURE_DATA_CALCULATIONS Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 + drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +-- 2 files changed, 2 insertions(+), 2

Re: [PATCH v2 7/7] drm/connector: add ref to drm_connector_get in iter docs

Pushed this one doc patch with Daniel's R-b on IRC.

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

Am 02.08.21 um 07:16 schrieb Guchun Chen: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as