RE: [PATCH] drm/amdgpu: don't enable baco on boco platforms in runpm

[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, August 3, 2021 12:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu: don't enable baco on boco platforms in >

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[Public] Thanks John. As in the same context, it's meaningless that two mutex target almost the same thing. Regards, Guchun From: Clements, John Sent: Wednesday, August 4, 2021 11:34 AM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Li, Candice ; Lazar, Lijo Subject:

RE: [PATCH] drm/amdgpu: add DID for beige goby

[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, August 4, 2021 3:39 AM To: amd-gfx@lists.freedesktop.org Cc: Gui, Jack ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: add DID for beige goby From:

[PATCH] drm/amdgpu: Add driver version

From: David M Nieto This sysfs is only defined in DKMS drivers it exposes the internal AMDGPU version Signed-off-by: David M Nieto Signed-off-by: Peng Ju Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2659 +++- 1 file changed, 941 insertions(+), 1718 deletions(-)

[PATCH] drm/amdgpu: add done BO list

From: David M Nieto backport of "add a list in VM for BOs in the done state" Signed-off-by: David M Nieto Signed-off-by: Peng Ju Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1196 +++- 1 file changed, 561 insertions(+), 635 deletions(-) diff --git

[PATCH] DRM: amd: amdgpu: Fixed code style and removed unnecessary if statement

The file didn't follow the code style so it was changed. The "if" statement checked if the framebuffer was initialized was also changed since that condition is unlikely to happen. An unnecessary "if" was removed too since it didn't execute any code if the condition was met. Signed-off-by: Sergio

Re: [PATCH] drm/amdkfd: AIP mGPUs best prefetch location for xnack on

Am 2021-08-02 um 12:28 p.m. schrieb Philip Yang: > For xnack on, if range ACCESS or ACCESS_IN_PLACE (AIP) by single GPU, or > range is ACCESS_IN_PLACE by mGPUs and all mGPUs connection on xgmi same > hive, the best prefetch location is prefetch_loc GPU. Otherwise, the best > prefetch location is

Re: [PATCH] drm/amdkfd: support file backed SVM range

On 2021-08-03 1:01 p.m., Felix Kuehling wrote: Am 2021-08-02 um 10:56 a.m. schrieb Philip Yang: HMM migrate helper migrate_vma_pages do not migrate file backed pages to replace it with device pages because the pages are used by file cache. We

Re: [PATCH] drm/amdkfd: add parameter force in kfd_process_evict_queues

m 2021-08-03 um 2:57 p.m. schrieb Eric Huang: > It is to differenciate case scenario for proper behavior when > calling evict queues, such as GPU reset doesn't need to roll > back restoring partial evicted queues. > > Signed-off-by: Eric Huang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c |

[PATCH] drm/amdgpu: add DID for beige goby

From: Chengming Gui Add device ids. Signed-off-by: Chengming Gui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index

[PATCH] drm/amdkfd: add parameter force in kfd_process_evict_queues

It is to differenciate case scenario for proper behavior when calling evict queues, such as GPU reset doesn't need to roll back restoring partial evicted queues. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4

RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

Hi Thomas, Can you please hold off on applying the kmb patch, I am seeing some issues while testing. Modetest works, but video playback only plays once, and it fails the second time with this patch. Thanks, Anitha > -Original Message- > From: Sam Ravnborg > Sent: Tuesday, August 3,

Re: [Freedreno] [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

On 2021-08-03 02:06, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas

Re: [PATCH] drm/amdkfd: support file backed SVM range

Am 2021-08-02 um 10:56 a.m. schrieb Philip Yang: > HMM migrate helper migrate_vma_pages do not migrate file backed pages to > replace it with device pages because the pages are used by file cache. > We can not migrate the file backed range to VRAM, otherwise CPU access > range will not trigger

Re: [PATCH] drm/amdgpu: Fix vm free pts race when process exiting

Am 2021-08-02 um 6:33 p.m. schrieb Philip Yang: > Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid > link list corruption with crash backtrace: > > [ 2290.505111] list_del corruption. next->prev should be > 9b2514ec0018, but was 4e03280211010f04 > [ 2290.505154] kernel

Re: [PATCH v2] drm/amdgpu: fix fdinfo race with process exit

Am 2021-07-29 um 10:13 p.m. schrieb Philip Yang: > Get process vm root BO ref in case process is exiting and root BO is > freed, to avoid NULL pointer dereference backtrace: > > BUG: unable to handle kernel NULL pointer dereference at > > Call Trace: >

Re: [PATCH] drm/amdkfd: Restore all process on post reset

Am 2021-08-03 um 11:02 a.m. schrieb Eric Huang: > > > On 2021-07-30 5:26 p.m., Felix Kuehling wrote: >> Am 2021-07-28 um 1:31 p.m. schrieb Eric Huang: >>> It is to fix a bug of gpu_recovery on multiple GPUs, >>> When one gpu is reset, the application running on other >>> gpu hangs, because kfd

Issue with USB-C lanes or DSC / bandwidth on amdgpu

Hi everyone. I currently try to go all-in on Linux. Therefore I have one last issue that I still didn't manage to resolve: https://gitlab.freedesktop.org/drm/amd/-/issues/1616 I found that you guys implemented parts of the mentioned features here:

Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

Hi Thomas, On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote: > DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move > the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux > IRQ interfaces. > > DRM provides IRQ helpers for setting up, receiving and

Re: [PATCH] drm/amdkfd: Restore all process on post reset

On 2021-07-30 5:26 p.m., Felix Kuehling wrote: Am 2021-07-28 um 1:31 p.m. schrieb Eric Huang: It is to fix a bug of gpu_recovery on multiple GPUs, When one gpu is reset, the application running on other gpu hangs, because kfd post reset doesn't restore the running process. This will resume

Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

Hi Thomas, On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > DRM IRQ callbacks are now being called directly

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov wrote: > > On 03/08/2021 12:06, Thomas Zimmermann wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ

Re: [PATCH] drm/radeon: Update pitch for page flip

On Tue, Aug 3, 2021 at 4:34 AM Michel Dänzer wrote: > > On 2021-08-02 4:51 p.m., Alex Deucher wrote: > > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: > >> > >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: > >>> Am 02.08.21 um 09:43 schrieb Zhenneng Li: > When

Re: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[Public] Hello Guchun, In most of those cases you are right it is redundant, the reason i kept them separate for now is to resolve this bug while also keeping those interfaces modular, and not affecting the psp submit sequence yet. We are planning a bigger change to that source to remove alot

Re: [PATCH v2] drm/amdgpu: fix fdinfo race with process exit

ping? On 2021-07-29 10:13 p.m., Philip Yang wrote: Get process vm root BO ref in case process is exiting and root BO is freed, to avoid NULL pointer dereference backtrace: BUG: unable to handle kernel NULL pointer dereference at Call Trace:

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[Public] Before calling into psp_cmd_submit_buf, a mutex psp->cmd_buf_mutex is there, and after entering psp_cmd_submit_buf, there is another mutex psp->mutex, is it a bit redundant? Regards, Guchun From: Clements, John Sent: Tuesday, August 3, 2021 5:50 PM To: amd-gfx@lists.freedesktop.org

RE: [PATCH 0/9] DC Patches for August 2, 2021

[Public] Hi all,   This week this patchset was tested on the following systems:   HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)   AMD

[PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[AMD Official Use Only] Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions. 0001-drm-amdgpu-added-synchronization-for-psp-cmd-buf-acc.patch Description: 0001-drm-amdgpu-added-synchronization-for-psp-cmd-buf-acc.patch

Re: [PATCH] drm/amdgpu: update PSP BL cmd IDs

[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Clements, John Sent: Tuesday, August 3, 2021 4:20 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: update PSP BL cmd IDs [AMD Official Use Only] Submitting

Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

On 03/08/2021 12:06, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas

Re: [PATCH] drm/amdgpu/display: fix DMUB firmware version info

[AMD Official Use Only] Reviewed-by: Alex Deucher From: S, Shirish Sent: Tuesday, August 3, 2021 4:42 AM To: Wentland, Harry ; Kazlauskas, Nicholas ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org ; S, Shirish Subject: [PATCH] drm/amdgpu/display: fix

[PATCH AUTOSEL 5.10 9/9] drm/amdgpu/display: only enable aux backlight control for OLED panels

From: Alex Deucher [ Upstream commit f2ad3accefc63e72e9932e141c21875cc04beec8 ] We've gotten a number of reports about backlight control not working on panels which indicate that they use aux backlight control. A recent patch: commit 2d73eabe2984a435737498ab39bb1500a9ffe9a9 Author: Camille

[PATCH AUTOSEL 5.13 09/11] drm/amdgpu/display: only enable aux backlight control for OLED panels

From: Alex Deucher [ Upstream commit f2ad3accefc63e72e9932e141c21875cc04beec8 ] We've gotten a number of reports about backlight control not working on panels which indicate that they use aux backlight control. A recent patch: commit 2d73eabe2984a435737498ab39bb1500a9ffe9a9 Author: Camille

Re: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

Command buffer in psp context means different command buffers cannot be prepared in parallel. Any case of submitting commands for different TAs in parallel - ex: for RAS and some other TA? Thanks, Lijo On 8/3/2021 8:35 AM, Li, Candice wrote: [Public] Signed-off-by: Candice Li

New uAPI for color management proposal and feedback request v2

Greetings, Original proposal: https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg62387.html Abstract: Add "preferred color format", "active color format", "active bpc", and "active Broadcast RGB" drm properties, to control color information send to the monitor. It seems that the

[PATCH v2 13/14] drm: Remove unused devm_drm_irq_install()

DRM IRQ helpers will become legacy. The function devm_drm_irq_install() is unused and won't be required later. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_irq.c | 32 include/drm/drm_irq.h | 1 - 2 files changed, 33 deletions(-) diff --git

[PATCH v2 12/14] drm/vc4: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort

[PATCH v2 14/14] drm: IRQ midlayer is now legacy

Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use the prefix drm_legacy_, and move declarations to drm_legacy.h. In struct drm_device, move the fields irq and irq_enabled behind CONFIG_DRM_LEGACY. All callers have been updated. Signed-off-by: Thomas Zimmermann Acked-by: Sam

[PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort

[PATCH v2 06/14] drm/kmb: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/kmb/kmb_drv.c | 26

[PATCH v2 09/14] drm/radeon: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher ---

[PATCH v2 10/14] drm/tidss: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen ---

[PATCH v2 08/14] drm/mxsfb: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort

[PATCH v2 05/14] drm/gma500: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/power.c | 1

[PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 113

[PATCH v2 02/14] drm/arm/hdlcd: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Calls to platform_get_irq() can fail with a negative errno code. Abort

[PATCH v2 04/14] drm/fsl-dcu: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. Signed-off-by: Thomas Zimmermann ---

[PATCH v2 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. v2: * use managed release via devm_request_irq() (Sam) *

[PATCH v2 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ callbacks are now being called directly or inlined. The interrupt number returned by pci_msi_vector() is now stored in struct

[PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux IRQ interfaces. DRM provides IRQ helpers for setting up, receiving and removing IRQ handlers. It's an abstraction over plain Linux functions. The code is mid-layerish

[PATCH] drm/amdgpu/display: fix DMUB firmware version info

DMUB firmware info is printed before it gets initialized. Correct this order to ensure true value is conveyed. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/radeon: Update pitch for page flip

On 2021-08-02 4:51 p.m., Alex Deucher wrote: > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: >> >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: >>> Am 02.08.21 um 09:43 schrieb Zhenneng Li: When primary bo is updated, crtc's pitch may have not been updated,

RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] Yeah, you are right, Lijo. @Li, Candice @Clements, John please address this before submitting this patch. Regards, Guchun -Original Message- From: Lazar, Lijo Sent: Tuesday, August 3, 2021 4:16 PM To: Chen, Guchun ; Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements,

[PATCH] drm/amdgpu: update PSP BL cmd IDs

[AMD Official Use Only] Submitting patch to resolve issue with incorrect PSP BL cmd IDs 0001-drm-amdgpu-update-PSP-BL-cmd-IDs.patch Description: 0001-drm-amdgpu-update-PSP-BL-cmd-IDs.patch

Re: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

Not really. Below clearing and changing the buffer happens outside of the mutex, so it's not fine till the memcpy happens in psp_cmd_submit_buf. memset(cmd, 0, sizeof(struct psp_gfx_cmd_resp)); Thanks, Lijo On 8/3/2021 1:37 PM, Chen, Guchun wrote: [Public] In psp_cmd_submit_buf, it has

RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] In psp_cmd_submit_buf, it has psp->mutex to guard this, so it should be fine. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Lazar, Lijo Sent: Tuesday, August 3, 2021 2:30 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: Re:

RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] Exactly, I forgot to change it accordingly. Thanks @Chen, Guchun Thanks, Candice From: Chen, Guchun Sent: Tuesday, August 3, 2021 2:04 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: RE: [PATCH]

RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

[Public] +if (psp->asd_fw) { + release_firmware(psp->asd_fw); adev->psp.asd_fw = NULL; } Use "psp->asd_fw = NULL" should be more simple? Regards, Guchun From: amd-gfx On Behalf Of Li, Candice Sent: Tuesday, August