Re: [PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

Applied. Thanks! Alex On Wed, Aug 4, 2021 at 2:49 AM Christian König wrote: > > Am 04.08.21 um 03:51 schrieb Tuo Li: > > The varialbe gtt in the function amdgpu_ttm_tt_populate() and > > amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. > > Thus the null-pointer checks

Re: [PATCH v2] drm/radeon: Update pitch for page flip

On Tue, Aug 3, 2021 at 10:39 PM Zhenneng Li wrote: > > > When primary bo is updated, crtc's pitch may > have not been updated, this will lead to show > disorder content when user changes display mode, > we update crtc's pitch in page flip to avoid > this bug. > This refers to amdgpu's pageflip. >

[pull] amdgpu drm-fixes-5.14

Hi Dave, Daniel, Fixes for 5.14. The following changes since commit d28e2568ac26fff351c846bf74ba6ca5dded733e: Merge tag 'amd-drm-fixes-5.14-2021-07-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-07-29 17:20:29 +1000) are available in the Git repository at:

[PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.

When init failed in early init stage, amdgpu_object has not been initialized, so hasn't the ttm delayed queue functions. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 17:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > >

Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces

Hi Am 03.08.21 um 17:00 schrieb Sam Ravnborg: Hi Thomas, On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers don't benefit from using it. DRM IRQ

[PATCH] drm/amdkfd: Expose GFXIP engine version to sysfs

Add u32 gfx_version field to kfd_node_properties and kfd_device_info. Populate _device_info structs accordingly and expose to sysfs. This allows eliminating device-ID-based lookup tables in user mode for future ASICs. Signed-off-by: Graham Sider --- drivers/gpu/drm/amd/amdkfd/kfd_device.c |

[PATCH] drm/vc4: hdmi: Fix build break caused by merge issue

Commit 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod") was reverted partially by Commit 0600a948942d ("Merge tag 'v5.13' into amd-staging-drm-next") which caused build break when compiling 'make allmodconfig' Original Patch:

Re: [PATCH] drm/amdgpu: Fix vm free pts race when process exiting

Am 2021-08-04 um 5:01 a.m. schrieb Christian König: > Am 03.08.21 um 00:33 schrieb Philip Yang: >> Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid >> link list corruption with crash backtrace: >> >> [ 2290.505111] list_del corruption. next->prev should be >>  

Re: [PATCH] drm/radeon: Update pitch for page flip

On Tue, Aug 03, 2021 at 10:49:39AM -0400, Alex Deucher wrote: > On Tue, Aug 3, 2021 at 4:34 AM Michel Dänzer wrote: > > > > On 2021-08-02 4:51 p.m., Alex Deucher wrote: > > > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: > > >> > > >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian

Re: [PATCH] drm/amdgpu: Fix vm free pts race when process exiting

Am 04.08.21 um 17:11 schrieb philip yang: On 2021-08-04 5:01 a.m., Christian König wrote: Am 03.08.21 um 00:33 schrieb Philip Yang: Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid link list corruption with crash backtrace: [ 2290.505111] list_del corruption.

Re: [PATCH] drm/amdgpu: Fix vm free pts race when process exiting

On 2021-08-04 5:01 a.m., Christian König wrote: Am 03.08.21 um 00:33 schrieb Philip Yang: Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid link list corruption with crash backtrace:

Re: [PATCH v2] drm/amdgpu: fix fdinfo race with process exit

On 2021-08-04 5:04 a.m., Christian König wrote: Sorry I'm on vacation and can't reply immediately. This is the wrong approach. The fdinfo should have grabbed a reference to the fd it prints the info for. So we

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

[Public] +/* + * Helper function to query RAS EEPROM address + * + * @adev: amdgpu_device pointer + * + * Return true if vbios supports ras rom address reporting As you have documented the first argument of function amdgpu_atomfirmware_ras_rom_addr, the other one "uint8_t* i2c_address" should

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

[Public] The patch is Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Wednesday, August 4, 2021 17:14 To: Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only]

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

[AMD Official Use Only] Updated patch with reviewed changes From: amd-gfx On Behalf Of Clements, John Sent: Wednesday, August 4, 2021 4:48 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only]

Re: [PATCH] drm/amdgpu: Add driver version

Why did you then send it out? Thanks, Christian. Am 04.08.21 um 09:05 schrieb Zhou, Peng Ju: [AMD Official Use Only] Merge error, Too big to drop -Original Message- From: Peng Ju Zhou Sent: Wednesday, August 4, 2021 10:15 AM To: amd-gfx@lists.freedesktop.org Cc: Nieto, David M ;

Re: [PATCH v2] drm/amdgpu: fix fdinfo race with process exit

Sorry I'm on vacation and can't reply immediately. This is the wrong approach. The fdinfo should have grabbed a reference to the fd it prints the info for. So we should never race here. Can you double check how this happens? Thanks, Christian. Am 03.08.21 um 16:06 schrieb philip yang:

Re: [PATCH] drm/amdgpu: Fix vm free pts race when process exiting

Am 03.08.21 um 00:33 schrieb Philip Yang: Take vm->invalidated_lock spinlock to remove vm pd and pt bos, to avoid link list corruption with crash backtrace: [ 2290.505111] list_del corruption. next->prev should be 9b2514ec0018, but was 4e03280211010f04 [ 2290.505154] kernel BUG at

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

[AMD Official Use Only] Hi John, Can you please add error code check in the new atomfirmware interface so driver know exactly whether there is RAS EEPROM onboard, and accordingly, jump out and stop any further I2C request from here. Regards, Hawking From: Clements, John Sent: Wednesday,

[PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

[AMD Official Use Only] Submitting patch to get RAS EEPROM I2C address from VBIOS FW info table. Thank you, John Clements 0001-drm-amdgpu-set-RAS-EEPROM-address-from-VBIOS.patch Description: 0001-drm-amdgpu-set-RAS-EEPROM-address-from-VBIOS.patch

RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only] Add Alex. -Original Message- From: Jiawei Gu Sent: Wednesday, August 4, 2021 3:50 PM To: amd-gfx@lists.freedesktop.org Cc: Nieto, David M ; Deng, Emily ; Gu, JiaWei (Will) Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode Enable

[PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario. Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[Public] @Chen, Guchun, Based off your feedback I double checked the code, and I changed my opinion about it, I think it's better just to reuse the original mutex for now. I've submitted an updated patch for review From: Clements, John Sent: Tuesday, August 3, 2021

[PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

The varialbe gtt in the function amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4

[PATCH v2] drm/radeon: Update pitch for page flip

When primary bo is updated, crtc's pitch may have not been updated, this will lead to show disorder content when user changes display mode, we update crtc's pitch in page flip to avoid this bug. This refers to amdgpu's pageflip. v1->v2: Update all of the pitch in all of the page_flip functions

Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

Hi Am 03.08.21 um 20:36 schrieb Chrisanthus, Anitha: Hi Thomas, Can you please hold off on applying the kmb patch, I am seeing some issues while testing. Modetest works, but video playback only plays once, and it fails the second time with this patch. Sounds a bit like the testing issue at

RE: [PATCH] drm/amdgpu: add done BO list

[AMD Official Use Only] Merge error, Too big to drop > -Original Message- > From: Peng Ju Zhou > Sent: Wednesday, August 4, 2021 10:15 AM > To: amd-gfx@lists.freedesktop.org > Cc: Nieto, David M ; Zhou, Peng Ju > > Subject: [PATCH] drm/amdgpu: add done BO list > > From: David M Nieto

RE: [PATCH] drm/amdgpu: Add driver version

[AMD Official Use Only] Merge error, Too big to drop > -Original Message- > From: Peng Ju Zhou > Sent: Wednesday, August 4, 2021 10:15 AM > To: amd-gfx@lists.freedesktop.org > Cc: Nieto, David M ; Zhou, Peng Ju > > Subject: [PATCH] drm/amdgpu: Add driver version > > From: David M

Re: [PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

Am 04.08.21 um 03:51 schrieb Tuo Li: The varialbe gtt in the function amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped. Reported-by: TOTE Robot Signed-off-by: Tuo Li

RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access

[Public] Sorry for missing RB. This patch is: Reviewed-by: Guchun Chen Regards, Guchun From: amd-gfx On Behalf Of Chen, Guchun Sent: Wednesday, August 4, 2021 11:40 AM To: Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Li, Candice ; Lazar, Lijo Subject: RE: [PATCH]