Re: [PATCH v2 02/12] mm: remove extra ZONE_DEVICE struct page refcount

2021-09-14 Thread Ralph Campbell
On 9/13/21 9:15 AM, Alex Sierra wrote: From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration,

Re: 回复: [PATCH] drm/amdgpu: Put drm_dev_enter/exit outside hot codepath

2021-09-14 Thread Andrey Grodzovsky
I think you missed 'reply all' so bringing  back to public On 2021-09-14 11:40 p.m., Pan, Xinhui wrote: [AMD Official Use Only] perf says it is the lock addl $0x0,-0x4(%rsp) details is below. the contention is huge maybe. Yes - that makes sense to me too as long as the lock here is some

Re: [PATCH] drm/amdgpu: Put drm_dev_enter/exit outside hot codepath

2021-09-14 Thread Andrey Grodzovsky
On 2021-09-14 9:42 p.m., xinhui pan wrote: We hit soft hang while doing memory pressure test on one numa system. After a qucik look, this is because kfd invalid/valid userptr memory frequently with process_info lock hold. perf top says below, 75.81% [kernel] [k] __srcu_read_unlock

[PATCH] drm/amdgpu: Put drm_dev_enter/exit outside hot codepath

2021-09-14 Thread xinhui pan
We hit soft hang while doing memory pressure test on one numa system. After a qucik look, this is because kfd invalid/valid userptr memory frequently with process_info lock hold. perf top says below, 75.81% [kernel] [k] __srcu_read_unlock 6.19% [amdgpu] [k] amdgpu_gmc_set_pte_pde

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Michael Ellerman
Borislav Petkov writes: > On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: >> Introduce a powerpc version of the cc_platform_has() function. This will >> be used to replace the powerpc mem_encrypt_active() implementation, so >> the implementation will initially only support the

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Wed, Sep 08, 2021 at 05:58:36PM -0500, Tom Lendacky wrote: > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index 18fe19916bc3..4b54a2377821 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -144,7 +144,7 @@ void __init sme_unmap_bootdata(char

[PATCH 3/3] drm/amd/display: Add modifiers capable of DCC image stores for gfx10_3

2021-09-14 Thread Joshua Ashton
Some games, ie. Doom Eternal, present from compute following compute post-fx and would benefit from having DCC image stores available. DCN on gfx10_3 doesn't need INDEPENDENT_128B_BLOCKS = 0 so we can expose these modifiers capable of DCC image stores. Signed-off-by: Joshua Ashton Reviewed-by:

[PATCH 1/3] drm/amd/display: Use dcc_ind_blk value to set register directly

2021-09-14 Thread Joshua Ashton
We don't need to do this workaround if we start setting this value when we fill the plane attributes. Signed-off-by: Joshua Ashton Reviewed-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-

[PATCH 2/3] drm/amd/display: Handle GFX10_RBPLUS modifiers for dcc_ind_blk

2021-09-14 Thread Joshua Ashton
Adds the missing logic to set the correct value of dcc_ind_blk for this tiling version. Signed-off-by: Joshua Ashton Reviewed-by: Bas Nieuwenhuizen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +++ 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/2] drm/sched: fix the bug of time out calculation(v4)

2021-09-14 Thread Grodzovsky, Andrey
AFAIK this one is independent. Christian, can you confirm ? Andrey From: amd-gfx on behalf of Alex Deucher Sent: 14 September 2021 15:33 To: Christian König Cc: Liu, Monk ; amd-gfx list ; Maling list - DRI developers Subject: Re: [PATCH 1/2] drm/sched: fix

Re: [PATCH] drm/amd/display: Reduce stack size for dml21_ModeSupportAndSystemConfigurationFull

2021-09-14 Thread Arnd Bergmann
On Tue, Sep 14, 2021 at 11:05 PM Harry Wentland wrote: > > [Why & How] > With Werror enabled in the kernel we were failing the clang build since > dml21_ModeSupportAndSystemConfigurationFull's stack frame is 1064 when > building with clang, and exceeding the default 1024 stack frame limit. > >

[PATCH] drm/amd/display: Reduce stack size for dml21_ModeSupportAndSystemConfigurationFull

2021-09-14 Thread Harry Wentland
[Why & How] With Werror enabled in the kernel we were failing the clang build since dml21_ModeSupportAndSystemConfigurationFull's stack frame is 1064 when building with clang, and exceeding the default 1024 stack frame limit. The culprit seems to be the Pipe struct, so pull the relevant block out

Re: [PATCH 1/2] drm/sched: fix the bug of time out calculation(v4)

2021-09-14 Thread Alex Deucher
Was this fix independent of the other discussions? Should this be applied to drm-misc? Alex On Wed, Sep 1, 2021 at 4:42 PM Alex Deucher wrote: > > On Wed, Sep 1, 2021 at 2:50 AM Christian König > wrote: > > > > Am 01.09.21 um 02:46 schrieb Monk Liu: > > > issue: > > > in cleanup_job the

Re: [BUG] VAAPI encoder cause kernel panic if encoded video in 4K

2021-09-14 Thread Mikhail Gavrilov
On Wed, 14 Apr 2021 at 11:48, Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > > That is expected behavior, the application is just buggy and causing a > page fault on the GPU. > > The kernel should just not crash with a backtrace. > > Regards, > Christian. > If after it GPU hangs

Re: amdgpu: atomic API and cursor/overlay planes

2021-09-14 Thread Harry Wentland
On 2021-09-07 10:03, Simon Ser wrote: > Hi all, > > Recently I've been discussing with various people [1] [2] about amdgpu's > handling of KMS planes. AMD hardware is a bit special when it comes to > the cursor plane, and it's not always 100% clear how that maps with the > KMS API. > > Up until

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Jason Gunthorpe
On Tue, Sep 14, 2021 at 04:18:31PM +0200, Daniel Vetter wrote: > On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > > Hi, > > Re-sending this patch-set following the release of our user-space TPC > > compiler and runtime library. > > > > I would appreciate a review on this. > > I

Re: drm/amd/display: move FPU associated DSC code to DML folder

2021-09-14 Thread Anson Jacob
Tested on nixeus 4k144hz DSC capable display on RX5700XT (NAVI10 0x1002:0x731F 0x1DA2:0xE410 0xC1) on ubuntu 20.04. Display lightsup at 4k144hz with DSC engine on. Tested-by: Anson Jacob On 2021-09-07 10:32 a.m., Qingqing Zhuo wrote: As part of the FPU isolation work documented in

Re: [PATCH 1/2] drm/amdgpu/display: fix warning about indentation

2021-09-14 Thread Harry Wentland
On 2021-09-14 10:59, Alex Deucher wrote: > Looks like this code block was missing parens. > > Fixes: c0ffd1945147 ("drm/amd/display: Add DPCD writes at key points") > Cc: Leo (Hanghong) Ma > Cc: Mikita Lipski > Cc: Aric Cyr > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry >

Re: [PATCH 2/2] drm/amdgpu/display: add a proper license to dc_link_dp.c

2021-09-14 Thread Harry Wentland
On 2021-09-14 10:59, Alex Deucher wrote: > Was missing. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 24 ++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm

2021-09-14 Thread Harry Wentland
On 2021-09-13 15:11, Nicholas Kazlauskas wrote: > [Why] > The "base_addr_is_mc_addr" field was added for dcn3.1 support but > pa_config was never updated to set it to false. > > Uninitialized memory causes it to be set to true which results in > address mistranslation and white screen. > > [How]

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Tue, Sep 14, 2021 at 04:47:41PM +0200, Christophe Leroy wrote: > Yes, see > https://lore.kernel.org/linuxppc-dev/20210914123919.58203...@canb.auug.org.au/T/#t Aha, more compiler magic stuff ;-\ Oh well, I guess that fix will land upstream soon. Thx. -- Regards/Gruss, Boris.

[PATCH 1/2] drm/amdgpu/display: fix warning about indentation

2021-09-14 Thread Alex Deucher
Looks like this code block was missing parens. Fixes: c0ffd1945147 ("drm/amd/display: Add DPCD writes at key points") Cc: Leo (Hanghong) Ma Cc: Mikita Lipski Cc: Aric Cyr Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 5 ++--- 1 file changed, 2

[PATCH 2/2] drm/amdgpu/display: add a proper license to dc_link_dp.c

2021-09-14 Thread Alex Deucher
Was missing. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 24 ++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Oded Gabbay
On Tue, Sep 14, 2021 at 5:18 PM Daniel Vetter wrote: > > On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > > Hi, > > Re-sending this patch-set following the release of our user-space TPC > > compiler and runtime library. > > > > I would appreciate a review on this. > > I think the

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Christophe Leroy
Le 14/09/2021 à 13:58, Borislav Petkov a écrit : On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: Introduce a powerpc version of the cc_platform_has() function. This will be used to replace the powerpc mem_encrypt_active() implementation, so the implementation will initially

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-14 Thread Daniel Vetter
On Sun, Sep 12, 2021 at 07:53:07PM +0300, Oded Gabbay wrote: > Hi, > Re-sending this patch-set following the release of our user-space TPC > compiler and runtime library. > > I would appreciate a review on this. I think the big open we have is the entire revoke discussions. Having the option to

Re: [resend PATCH] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-14 Thread Daniel Vetter
On Thu, Sep 09, 2021 at 09:10:39AM +0200, Christian König wrote: > Am 08.09.21 um 20:27 schrieb Daniel Vetter: > > On Tue, Sep 07, 2021 at 11:28:23AM +0200, Christian König wrote: > > > Am 07.09.21 um 11:05 schrieb Daniel Vetter: > > > > On Tue, Sep 07, 2021 at 08:22:20AM +0200, Christian König

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Borislav Petkov
On Wed, Sep 08, 2021 at 05:58:35PM -0500, Tom Lendacky wrote: > Introduce a powerpc version of the cc_platform_has() function. This will > be used to replace the powerpc mem_encrypt_active() implementation, so > the implementation will initially only support the CC_ATTR_MEM_ENCRYPT > attribute. >

Re: [PATCH] drm/amdgpu: Update PSP TA unload function

2021-09-14 Thread Clements, John
[AMD Official Use Only] Reviewed-by: John Clements From: Li, Candice Sent: Monday, September 13, 2021 3:55 PM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amdgpu: Update PSP TA unload function Update PSP TA unload

Re: [PATCH] drm/amdgpu: Conform ASD header/loading to generic TA systems

2021-09-14 Thread Clements, John
[AMD Official Use Only] Reviewed-by: John Clements From: Li, Candice Sent: Monday, September 13, 2021 3:54 PM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amdgpu: Conform ASD header/loading to generic TA systems