Re: [PATCH] drm/amdkfd: fix svm_migrate_fini warning

2021-09-20 Thread Felix Kuehling
Am 2021-09-20 um 5:55 p.m. schrieb Philip Yang: > Don't use devm_request_free_mem_region to alloc VRAM region for pgmap, devm_... refers to a device manager that automatically releases device-specific resources when a driver disconnects from a device. So maybe that just means, our

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-20 Thread Harry Wentland
On 2021-09-15 10:36, Pekka Paalanen wrote: > On Mon, 16 Aug 2021 15:37:23 +0200 > sebast...@sebastianwick.net wrote: > >> On 2021-08-16 14:40, Harry Wentland wrote: >>> On 2021-08-16 7:10 a.m., Brian Starkey wrote: On Fri, Aug 13, 2021 at 10:42:12AM +0530, Sharma, Shashank wrote:

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-20 Thread Harry Wentland
On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 -0400 > Harry Wentland wrote: > >> Use the new DRM RFC doc section to capture the RFC previously only >> described in the cover letter at >> https://patchwork.freedesktop.org/series/89506/ >> >> v3: >> * Add sections on

[PATCH] drm/amdkfd: fix svm_migrate_fini warning

2021-09-20 Thread Philip Yang
Don't use devm_request_free_mem_region to alloc VRAM region for pgmap, because driver__detach releases all device resource region, then calls amdgpu_device_fini_sw, which calls devm_memunmap_pages generating below warning trace: WARNING: CPU: 1 PID: 3646 at drivers/base/devres.c:795

Re: [PATCH 03/15] dmr/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-20 Thread Fernando Ramos
On 21/09/20 09:54AM, kernel test robot wrote: > > [auto build test ERROR on drm-exynos/exynos-drm-next] > [also build test ERROR on tegra-drm/drm/tegra/for-next linus/master v5.15-rc2 > next-20210917] I forgot to #include for those platforms and didn't notice because I only tried to build for

Re: [PATCH v2 09/12] lib: test_hmm add module param for zone device type

2021-09-20 Thread Sierra Guiza, Alejandro (Alex)
On 9/20/2021 3:53 AM, Alistair Popple wrote: On Tuesday, 14 September 2021 2:16:01 AM AEST Alex Sierra wrote: In order to configure device public in test_hmm, two module parameters should be passed, which correspond to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If

Re: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: > > Replace drm_mm with drm buddy manager for > VRAM memory management Would be good to document why we are doing this and what advantages it brings over the old drm_mm code. Alex > > Signed-off-by: Arunpravin > --- >

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-20 Thread Kirill A. Shutemov
On Wed, Sep 08, 2021 at 05:58:36PM -0500, Tom Lendacky wrote: > diff --git a/arch/x86/mm/mem_encrypt_identity.c > b/arch/x86/mm/mem_encrypt_identity.c > index 470b20208430..eff4d19f9cb4 100644 > --- a/arch/x86/mm/mem_encrypt_identity.c > +++ b/arch/x86/mm/mem_encrypt_identity.c > @@ -30,6 +30,7

Re: [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: Please prefix the patch subject with drm. E.g., drm: Enable buddy memory manager support Same for the second patch, but make it drm/amdgpu instead. Alex > > Port Intel buddy system manager to drm root folder > Add CPU mappable/non-mappable

[PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Arunpravin
Replace drm_mm with drm buddy manager for VRAM memory management Signed-off-by: Arunpravin --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 78 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 216 ++ 3 files

[PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Arunpravin
Port Intel buddy system manager to drm root folder Add CPU mappable/non-mappable region support to the drm buddy manager Signed-off-by: Arunpravin --- drivers/gpu/drm/Makefile| 2 +- drivers/gpu/drm/drm_buddy.c | 465 include/drm/drm_buddy.h | 154

Re: [PATCH 2/2] drm/amdgpu: Fix resume failures when device is gone

2021-09-20 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Fri, Sep 17, 2021 at 7:31 AM Andrey Grodzovsky wrote: > > Problem: > When device goes into suspend and unplugged during it > then all HW programming during resume fails leading > to a bad SW during pci remove handling which follows. > Because device is

Re: [PATCH] drm/radeon: fix uninitialized bool variable

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:44 AM Christian König wrote: > > > > Am 18.09.21 um 11:41 schrieb Zhiwei Yang: > > The bool variable detected_hpd_without_ddc in struct radeon_connector > > is uninitialized when first used, that may cause unnecessary ddc ops. > > Make it as false when a new connector is

Re: [PATCH] drm/amd/display: fix empty debug macros

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 8:16 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Using an empty macro expansion as a conditional expression > produces a W=1 warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function > 'dce_aux_transfer_with_retries': >

Re: [PATCH v2 09/12] lib: test_hmm add module param for zone device type

2021-09-20 Thread Alistair Popple
On Tuesday, 14 September 2021 2:16:01 AM AEST Alex Sierra wrote: > In order to configure device public in test_hmm, two module parameters > should be passed, which correspond to the SP start address of each > device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, > private device

[PATCH] drm/amd/display: fix empty debug macros

2021-09-20 Thread Arnd Bergmann
From: Arnd Bergmann Using an empty macro expansion as a conditional expression produces a W=1 warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function 'dce_aux_transfer_with_retries': drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:775:156: error: suggest braces

Re: [PATCH] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-20 Thread Michel Dänzer
On 2021-09-20 12:31, Simon Ser wrote: > On GFX9+, format modifiers are always enabled and ensure the > frame-buffers can be scanned out at ADDFB2 time. > > On GFX8-, format modifiers are not supported and no other check > is performed. This means ADDFB2 IOCTLs will succeed even if the > tiling

[PATCH] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-20 Thread Simon Ser
On GFX9+, format modifiers are always enabled and ensure the frame-buffers can be scanned out at ADDFB2 time. On GFX8-, format modifiers are not supported and no other check is performed. This means ADDFB2 IOCTLs will succeed even if the tiling isn't supported for scan-out, and will result in

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-20 Thread Thomas Zimmermann
Hi Am 20.09.21 um 10:41 schrieb Thomas Zimmermann: (cc'ing dri-devel) Hi Am 13.09.21 um 16:36 schrieb Alex Deucher: On Thu, Sep 9, 2021 at 11:25 PM Evan Quan wrote: With the shadow buffer support from generic framebuffer emulation, it's possible now to have runpm kicked when no update for

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-20 Thread Thomas Zimmermann
(cc'ing dri-devel) Hi Am 13.09.21 um 16:36 schrieb Alex Deucher: On Thu, Sep 9, 2021 at 11:25 PM Evan Quan wrote: With the shadow buffer support from generic framebuffer emulation, it's possible now to have runpm kicked when no update for console. Change-Id:

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-20 Thread Thomas Zimmermann
Hi Am 13.09.21 um 16:36 schrieb Alex Deucher: On Thu, Sep 9, 2021 at 11:25 PM Evan Quan wrote: With the shadow buffer support from generic framebuffer emulation, it's possible now to have runpm kicked when no update for console. Change-Id: I285472c9100ee6f649d3f3f3548f402b9cd34eaf

Re: [PATCH] drm/radeon: fix uninitialized bool variable

2021-09-20 Thread Christian König
Am 18.09.21 um 11:41 schrieb Zhiwei Yang: The bool variable detected_hpd_without_ddc in struct radeon_connector is uninitialized when first used, that may cause unnecessary ddc ops. Make it as false when a new connector is alloced. Signed-off-by: Zhiwei Yang ---

Re: [PATCH] drm/amd/display: move FPU associated DSC code to DML folder

2021-09-20 Thread Christian König
Feel free to add an Acked-by: Christian König Am 07.09.21 um 16:32 schrieb Qingqing Zhuo: As part of the FPU isolation work documented in https://patchwork.freedesktop.org/series/93042/, isolate code that uses FPU in DSC to DML, where all FPU code should locate. This change does not refactor

Have you attended XDC 2021? Give us your feedback!

2021-09-20 Thread Samuel Iglesias Gonsálvez
Hi, First of all, thanks organizers for such a great conference. It was smooth and, although there were some issues as it is usual in any conference, they were fixed promptly :-) I would like also to thank all of you for attending and participating either via submitting talks, watching them or

[PATCH] drm/radeon: fix uninitialized bool variable

2021-09-20 Thread yangzhiwei
>From 23dc76b1a4c7eb516b2830e1d2bb588316e18e93 Mon Sep 17 00:00:00 2001 From: Zhiwei Yang Date: Sat, 18 Sep 2021 16:17:06 +0800 Subject: [PATCH] drm/radeon: fix uninitialized bool variable The bool variable detected_hpd_without_ddc in struct radeon_connector is uninitialized when first

[PATCH] drm/radeon: fix uninitialized bool variable

2021-09-20 Thread Zhiwei Yang
The bool variable detected_hpd_without_ddc in struct radeon_connector is uninitialized when first used, that may cause unnecessary ddc ops. Make it as false when a new connector is alloced. Signed-off-by: Zhiwei Yang --- drivers/gpu/drm/radeon/radeon_connectors.c | 4 1 file changed, 4

Re: [PATCH 2/2] MAINTAINERS: add Andrey as the DRM GPU scheduler maintainer

2021-09-20 Thread Christian König
Am 17.09.21 um 18:15 schrieb Alex Deucher: Now that the scheduler is being used by more and more drivers, we need someone to maintain it. Andrey has stepped up to maintain the scheduler. Cc: Andrey Grodzovsky Cc: airl...@gmail.com Cc: daniel.vet...@ffwll.ch Signed-off-by: Alex Deucher