[PATCH AUTOSEL 5.14 15/40] drm/amdkfd: fix svm_migrate_fini warning

2021-09-27 Thread Sasha Levin
From: Philip Yang [ Upstream commit 197ae17722e989942b36e33e044787877f158574 ] Device manager releases device-specific resources when a driver disconnects from a device, devm_memunmap_pages and devm_release_mem_region calls in svm_migrate_fini are redundant. It causes below warning trace after

[PATCH AUTOSEL 5.14 14/40] drm/amdkfd: handle svm migrate init error

2021-09-27 Thread Sasha Levin
From: Philip Yang [ Upstream commit 7d6687200a939176847090bbde5cb79a82792a2f ] If svm migration init failed to create pgmap for device memory, set pgmap type to 0 to disable device SVM support capability. Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher

Re: [PATCH] amd/amdkfd: add ras page retirement handling for sq/sdma (v2)

2021-09-27 Thread Zhou1, Tao
[AMD Official Use Only] Ping... From: Zhou1, Tao Sent: Friday, September 24, 2021 4:37 PM To: amd-gfx@lists.freedesktop.org ; Zhang, Hawking ; Kuehling, Felix ; Joshi, Mukul ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH] amd/amdkfd: add ras page retirement

[PATCH] drm/amd/pm: Fix that RPM cannot be obtained for specific GPU

2021-09-27 Thread huangyizhi
The current mechanism for obtaining RPM is to read tach_period from the register, and then calculate the RPM together with the frequency. But we found that on specific GPUs, such as RX 550 and RX 560D, tach_period always reads as 0 and smu7_fan_ctrl_get_fan_speed_rpm will returns -EINVAL. To

Re: [PATCH 02/02 v2] drm/amd/display: add cyan_skillfish display support

2021-09-27 Thread Alex Deucher
On Mon, Sep 27, 2021 at 5:16 PM Liu, Zhan wrote: > > [Public] > > [Why] > add display related cyan_skillfish files in. > > makefile controlled by CONFIG_DRM_AMD_DC_DCN201 flag. > > Signed-off-by: Charlene Liu > Signed-off-by: Zhan Liu > Reviewed-by: Charlene Liu > Acked-by: Jun Lei > --- > >

[pull] amdgpu, amdkfd, radeon drm-next-5.16

2021-09-27 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.16. The following changes since commit 8f0284f190e6a0aa09015090568c03f18288231a: Merge tag 'amd-drm-next-5.15-2021-08-27' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-08-30 09:06:03 +1000) are available in the Git repository at:

RE: [PATCH 02/02] drm/amd/display: add cyan_skillfish display support

2021-09-27 Thread Liu, Zhan
[Public] > -Original Message- > From: Alex Deucher > Sent: 2021/September/27, Monday 4:50 PM > To: Liu, Zhan > Cc: amd-gfx@lists.freedesktop.org; Liu, Charlene ; > Wentland, Harry ; Deucher, Alexander > ; Lei, Jun ; Pillai, > Aurabindo > Subject: Re: [PATCH 02/02] drm/amd/display: add

Re: [PATCH 02/02] drm/amd/display: add cyan_skillfish display support

2021-09-27 Thread Alex Deucher
On Mon, Sep 27, 2021 at 4:43 PM Liu, Zhan wrote: > > [Public] > > [Why] > add display related cyan_skillfish files in. > > makefile controlled by CONFIG_DRM_AMD_DC_DCN201 flag. > > Signed-off-by: Charlene Liu > Signed-off-by: Zhan Liu > Reviewed-by: Charlene Liu > Acked-by: Jun Lei > --- >

[PATCH 00/02] cyan skillfish display support

2021-09-27 Thread Liu, Zhan
[Public] This patch set brings cyan skillfish display support Charlene Liu / Zhan Liu (2): drm/amdgpu: add cyan_skillfish asic header files drm/amd/display: add cyan_skillfish display support drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +

Re: [PATCH] drm/amd/amdgpu: Validate ip discovery blob

2021-09-27 Thread Alex Deucher
Applied with minor updates to the error messages. Thanks! Alex On Sun, Sep 26, 2021 at 5:27 PM Ernst Sjöstrand wrote: > > We use the number_instance index that we get from the fw discovery blob > to index into an array for example. > > Signed-off-by: Ernst Sjöstrand > --- >

Re: [PATCH] gpu: amd: replace open-coded offsetof() with builtin

2021-09-27 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 27, 2021 at 8:21 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The two AMD drivers have their own custom offsetof() implementation > that now triggers a warning with recent versions of clang: > > drivers/gpu/drm/radeon/radeon_atombios.c:133:14: error:

Re: [PATCH] drm/amdkfd: fix resource_size.cocci warnings

2021-09-27 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Sep 26, 2021 at 3:10 PM Amos Jianjun Kong wrote: > > On Sun, Sep 26, 2021 at 3:17 PM Yang Li wrote: >> >> Use resource_size function on resource object >> instead of explicit computation. >> >> Clean up coccicheck warning: >>

[PATCH v3] drm/dp: Add Additional DP2 Headers

2021-09-27 Thread Fangzhi Zuo
Include FEC, DSC, Link Training related headers. Change since v2 - Align with the spec for DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT Signed-off-by: Fangzhi Zuo --- This patch is based on top of the other DP2.0 work in "drm/dp: add LTTPR DP 2.0 DPCD addresses" --- include/drm/drm_dp_helper.h | 20

Re: [PATCH] drm/amdgpu: fix warning for overflow check

2021-09-27 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 27, 2021 at 9:07 AM Christian König wrote: > > Am 27.09.21 um 14:58 schrieb Arnd Bergmann: > > From: Arnd Bergmann > > > > The overflow check in amdgpu_bo_list_create() causes a warning with > > clang-14 on 64-bit architectures, since the limit can never be > >

Re: [PATCH v2] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-27 Thread Alex Deucher
On Mon, Sep 27, 2021 at 11:09 AM Simon Ser wrote: > > On GFX9+, format modifiers are always enabled and ensure the > frame-buffers can be scanned out at ADDFB2 time. > > On GFX8-, format modifiers are not supported and no other check > is performed. This means ADDFB2 IOCTLs will succeed even if

[PATCH] drm/amdgpu/display: remove unused variable

2021-09-27 Thread Alex Deucher
No longer used, drop it. Fixes: 1e07005161fc ("drm/amd/display: add function to convert hw to dpcd lane settings") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS

2021-09-27 Thread Yazen Ghannam
On Sat, Sep 25, 2021 at 01:20:57PM +0200, Borislav Petkov wrote: > On Fri, Sep 24, 2021 at 07:46:10PM +, Yazen Ghannam wrote: > > I agree with you in general. But this device isn't really a GPU. And > > users of this device seem to want to count *every* error, at least for > > now. > > Aha,

[PATCH v2] drm/dp: Add Additional DP2 Headers

2021-09-27 Thread Fangzhi Zuo
Include FEC, DSC, Link Training related headers. Signed-off-by: Fangzhi Zuo --- This patch is based on top of the other DP2.0 work in "drm/dp: add LTTPR DP 2.0 DPCD addresses" --- include/drm/drm_dp_helper.h | 20 1 file changed, 20 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: force exit gfxoff on sdma resume for rmb s0ix

2021-09-27 Thread Alex Deucher
On Sun, Sep 26, 2021 at 9:14 AM Prike Liang wrote: > > In the s2idle stress test sdma resume fail occasionally,in the > failed case GPU is in the gfxoff state.This issue may introduce > by FSDL miss handle doorbell S/R and now temporary fix the issue > by forcing exit gfxoff for sdma resume. > >

Re: [PATCH] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-27 Thread Simon Ser
On Monday, September 27th, 2021 at 16:57, Alex Deucher wrote: > No objections from me with the WARN_ONCE change suggested by Michel. Cool, just sent v2 with Michel's comment fixed.

[PATCH v2] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-27 Thread Simon Ser
On GFX9+, format modifiers are always enabled and ensure the frame-buffers can be scanned out at ADDFB2 time. On GFX8-, format modifiers are not supported and no other check is performed. This means ADDFB2 IOCTLs will succeed even if the tiling isn't supported for scan-out, and will result in

Re: [PATCH] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-27 Thread Alex Deucher
On Mon, Sep 27, 2021 at 9:09 AM Simon Ser wrote: > > Alex, Harry, Nicholas: any thoughts on this patch? No objections from me with the WARN_ONCE change suggested by Michel. Alex

RE: [PATCH 00/24] DC Patches Sep 24, 2021

2021-09-27 Thread Wheeler, Daniel
[Public] Hi all,   This week this patchset was tested on the following systems:   HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)   AMD

Re: [PATCH] amdgpu: check tiling flags when creating FB on GFX8-

2021-09-27 Thread Simon Ser
Alex, Harry, Nicholas: any thoughts on this patch?

Re: [PATCH] drm/amdgpu: fix warning for overflow check

2021-09-27 Thread Christian König
Am 27.09.21 um 14:58 schrieb Arnd Bergmann: From: Arnd Bergmann The overflow check in amdgpu_bo_list_create() causes a warning with clang-14 on 64-bit architectures, since the limit can never be exceeded. drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c:74:18: error: result of comparison of

[PATCH] drm/amd/amdgpu: Add missing mp_11_0_8_sh_mask.h header

2021-09-27 Thread Tom St Denis
The commit 9b716ef1501b2e62181073493dc1c7a17140bd21 added the offset header but didn't add the masks. This adds the masks based on what was selected for the offsets. Signed-off-by: Tom St Denis --- .../include/asic_reg/mp/mp_11_0_8_sh_mask.h | 355 ++ 1 file changed, 355

[PATCH] drm/amdgpu: fix warning for overflow check

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann The overflow check in amdgpu_bo_list_create() causes a warning with clang-14 on 64-bit architectures, since the limit can never be exceeded. drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c:74:18: error: result of comparison of constant 256204778801521549 with expression of type

Re: [PATCH] drm/amdgpu: fix clang out-of-range warning

2021-09-27 Thread Christian König
In general that change looks good. But what configuration is that? Background is that it doesn't make much sense to compile the amdgpu driver on systems where resource_size_t is only 32bit. Christian. Am 27.09.21 um 14:19 schrieb Arnd Bergmann: From: Arnd Bergmann clang-14 points out that

[PATCH] gpu: amd: replace open-coded offsetof() with builtin

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann The two AMD drivers have their own custom offsetof() implementation that now triggers a warning with recent versions of clang: drivers/gpu/drm/radeon/radeon_atombios.c:133:14: error: performing pointer subtraction with a null pointer has undefined behavior

[PATCH] drm/amdgpu: fix clang out-of-range warning

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann clang-14 points out that comparing an 'unsigned int' against a large 64-bit constantn is pointless: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1206:18: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is

[PATCH] [RESEND] drm/amdgpu: fix enum odm_combine_mode mismatch

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann A conversion from 'bool' to 'enum odm_combine_mode' was incomplete, and gcc warns about this with many instances of display/dc/dml/dcn20/display_mode_vba_20.c:3899:44: warning: implicit conversion from 'enum ' to 'enum odm_combine_mode' [-Wenum-conversion] 3899 |

Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS

2021-09-27 Thread Borislav Petkov
On Fri, Sep 24, 2021 at 07:46:10PM +, Yazen Ghannam wrote: > I agree with you in general. But this device isn't really a GPU. And > users of this device seem to want to count *every* error, at least for > now. Aha, so something accelerator-y where they do general purpose computation. So

[PATCH] drm/amdkfd: fix resource_size.cocci warnings

2021-09-27 Thread Yang Li
Use resource_size function on resource object instead of explicit computation. Clean up coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:905:10-13: ERROR: Missing resource_size with res Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c

RE: [PATCH] drm/amdgpu: correct initial cp_hqd_quantum for gfx9

2021-09-27 Thread Ma, Le
[AMD Official Use Only] Reviewed-by: Le Ma -Original Message- From: Hawking Zhang Sent: Sunday, September 26, 2021 10:29 PM To: amd-gfx@lists.freedesktop.org; Ma, Le ; Deucher, Alexander ; Zhang, Morris Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: correct initial cp_hqd_quantum