Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

2021-10-29 Thread Lazar, Lijo
[Public] Instead of ASIC check better to do the check based on ppt_func->get_power_profile_mode. If function is NULL/not implemented, drop the attribute. Thanks, Lijo

Re: amdgpu "Fatal error during GPU init"; Ryzen 5600G integrated GPU + kernel 5.14.13

2021-10-29 Thread PGNet Dev
I got this comment from ASRockRack support re: the 'purple' screen: " Did you also get that background color in the BIOS menu? If not, it appears that this is the color may have something to do with video driver and it seems to be common with open source operating system. I came across these

RE: [PATCH v2] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Li, Roman
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, October 29, 2021 4:34 PM > To: Limonciello, Mario > Cc: amd-gfx list ; Li, Roman > > Subject: Re: [PATCH v2] drm/amd/display: Look at firmware version to > determine using dmub on dcn21 > > On Fri, Oct 29, 2021 at 4:33

Re: amdgpu "Fatal error during GPU init"; Ryzen 5600G integrated GPU + kernel 5.14.13

2021-10-29 Thread PGNet Dev
in case it's useful grep -i amd /var/log/Xorg.0.log | grep -v Modeline [ 324.709] (II) Applying OutputClass "AMDgpu" to /dev/dri/card0 [ 324.709]loading driver: amdgpu [ 324.818] (==) Matched amdgpu as autoconfigured driver 0

Re: amdgpu "Fatal error during GPU init"; Ryzen 5600G integrated GPU + kernel 5.14.13

2021-10-29 Thread PGNet Dev
I would start with an sbios update is possible. I swapped out the ASRockRack X470D4U mobo for a new, next-gen X570D4U. Keeping the same 2X16GB UDIMMs, and trying 2 different Ryzen 5600G CPUs, I now see the following ... With an NVIDIA PCIe card as primary adapter, it posts & functions, as

[PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

2021-10-29 Thread Mario Limonciello
This command corresponding to this attribute was deprecated in the PMFW for YC so don't show a non-functional attribute. Since future APUs may be brought up using IP version checking also disable it for future APU's. If any do support the command then they can be treated as exceptions.

Re: [PATCH v2] drm/amdgpu/pm: drop pp_power_profile_mode support for yellow carp

2021-10-29 Thread Limonciello, Mario
On 10/29/2021 15:57, Alex Deucher wrote: On Fri, Oct 29, 2021 at 11:34 AM Mario Limonciello wrote: This was added by commit bd8dcea93a7d ("drm/amd/pm: add callbacks to read/write sysfs file pp_power_profile_mode") but the feature was deprecated from PMFW. Remove it from the driver.

Re: [PATCH v2] drm/amdgpu/pm: drop pp_power_profile_mode support for yellow carp

2021-10-29 Thread Alex Deucher
On Fri, Oct 29, 2021 at 11:34 AM Mario Limonciello wrote: > > This was added by commit bd8dcea93a7d ("drm/amd/pm: add callbacks to > read/write sysfs file pp_power_profile_mode") but the feature was > deprecated from PMFW. Remove it from the driver. > > Signed-off-by: Mario Limonciello

Re: [PATCH v2] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Alex Deucher
On Fri, Oct 29, 2021 at 4:33 PM Mario Limonciello wrote: > > commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 > asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this > implied a new dependency on newer firmware which might not be met on older > kernel

[PATCH v2] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Mario Limonciello
commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this implied a new dependency on newer firmware which might not be met on older kernel versions. Since sw_init runs before hw_init, there is an

RE: [PATCH] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, October 29, 2021 15:24 > To: Limonciello, Mario > Cc: amd-gfx list ; Li, Roman > > Subject: Re: [PATCH] drm/amd/display: Look at firmware version to determine > using dmub on dcn21 > > On Fri, Oct 29, 2021 at 4:19 PM

Re: [PATCH] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Alex Deucher
On Fri, Oct 29, 2021 at 4:19 PM Alex Deucher wrote: > > On Fri, Oct 29, 2021 at 4:12 PM Mario Limonciello > wrote: > > > > commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 > > asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this > > implied a new

Re: [PATCH] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Alex Deucher
On Fri, Oct 29, 2021 at 4:12 PM Mario Limonciello wrote: > > commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 > asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this > implied a new dependency on newer firmware which might not be met on older > kernel

[PATCH] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Mario Limonciello
commit b1c61212d8dc ("drm/amd/display: Fully switch to dmub for all dcn21 asics") switched over to using dmub on Renoir to fix Gitlab 1735, but this implied a new dependency on newer firmware which might not be met on older kernel versions. Since sw_init runs before hw_init, there is an

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit 31fa8cbce4664946a1688898410fee41ad05364d: drm: Add R10 and R12 FourCC (2021-10-28 17:20:45 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.16-2021-10-29

Re: [PATCH v2 2/2] drm/amdkfd: fix resume error when iommu disabled in Picasso

2021-10-29 Thread youling 257
will it merge into linux 5.15 release? 2021-10-13 14:16 GMT+08:00, Yifan Zhang : > When IOMMU disabled in sbios and kfd in iommuv2 path, > IOMMU resume failure blocks system resume. Don't allow kfd to > use iommu v2 when iommu is disabled. > > Reported-by: youling > Tested-by: youling >

[PATCH v2] drm/amdgpu/pm: drop pp_power_profile_mode support for yellow carp

2021-10-29 Thread Mario Limonciello
This was added by commit bd8dcea93a7d ("drm/amd/pm: add callbacks to read/write sysfs file pp_power_profile_mode") but the feature was deprecated from PMFW. Remove it from the driver. Signed-off-by: Mario Limonciello --- Changes from v1->v2: * Drop changes to RN and VGH as the deprecation is

[PATCH 10/14] drm/amd/display: Add MPC meory shutdown support

2021-10-29 Thread Aurabindo Pillai
From: Jake Wang [Why & How] The MPC memory clocks should be powered down when not in use. Acked-by: Aurabindo Pillai Signed-off-by: Jake Wang Reviewed-by: Eric Yang --- .../gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c | 7 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 69

[PATCH 14/14] drm/amd/display: 3.2.160

2021-10-29 Thread Aurabindo Pillai
From: Aric Cyr Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index e9bac161fd25..3aac3f4a2852 100644 ---

[PATCH 13/14] drm/amd/display: [FW Promotion] Release 0.0.91

2021-10-29 Thread Aurabindo Pillai
From: Anthony Koo Acked-by: Aurabindo Pillai Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 12/14] drm/amd/display: add condition check for dmub notification

2021-10-29 Thread Aurabindo Pillai
[Why & How] In order to have dc_enable_dmub_notifications() more precise, add one more condition to check if dc->debug.dpia_debug.bits.disable_dpia is false. Signed-off-by: Meenakshikumar Somasundaram Signed-off-by: Wayne Lin Signed-off-by: Aurabindo Pillai Reviewed-by: Nicholas Kazlauskas

[PATCH 09/14] drm/amd/display: Added HPO HW control shutdown support

2021-10-29 Thread Aurabindo Pillai
From: Jake Wang [Why] HPO is only used for DP2.0. HPO HW control should be disable when not being used to save power. [How] Shutdown HPO HW control during init hw. Shutdown HPO HW control during stream disable. Enable HPO HW control during stream enable if DP2.0. Acked-by: Aurabindo Pillai

[PATCH 11/14] drm/amd/display: Added new DMUB boot option for power optimization

2021-10-29 Thread Aurabindo Pillai
From: Jake Wang [Why] During Z10, root clock gating and memory low power registers needs to to be restored if optimization is enabled in driver. [How] Added new DMUB boot option for root clock gating and memory low power. Acked-by: Aurabindo Pillai Signed-off-by: Jake Wang Reviewed-by:

[PATCH 07/14] drm/amd/display: Clear encoder assignments when state cleared.

2021-10-29 Thread Aurabindo Pillai
From: Jimmy Kizito [Why] State can be cleared without removing individual streams (by calling dc_remove_stream_from_ctx()). This can leave the encoder assignment module in an incoherent state and cause future assignments to be incorrect. [How] Clear encoder assignments when committing 0 streams

[PATCH 08/14] drm/amd/display: fix register write sequence for LINK_SQUARE_PATTERN

2021-10-29 Thread Aurabindo Pillai
From: Wenjing Liu [why] write LINK_SQUARE_PATTERN_num + 1 for square pulse pattern. Specs requirement to write this register prior to write LINK_QUAL_LANEX_SET. Acked-by: Aurabindo Pillai Signed-off-by: Wenjing Liu Reviewed-by: George Shen ---

[PATCH 06/14] drm/amd/display: Force disable planes on any pipe split change

2021-10-29 Thread Aurabindo Pillai
From: Roman Li [Why] In scenario when 1 display connected with pipe split (2 pipes in use) and 3 new displays simultaneously hotplugged via MST hub (4 pipes in use), mpcc may get reprogram to other vtg, remaining busy. In this case waiting for mpcc idle timeouts with error like this: [drm]

[PATCH 04/14] drm/amd/display: avoid link loss short pulse stuck the system

2021-10-29 Thread Aurabindo Pillai
From: Yu-ting Shen [Why] MST monitor sends link loss short pulse continuous but sink is occupy by HDMI input to lead link training fail. [How] disable link once retraining fail. Acked-by: Aurabindo Pillai Signed-off-by: Yu-ting Shen Reviewed-by: Wenjing Liu ---

[PATCH 05/14] drm/amd/display: Fix bpc calculation for specific encodings

2021-10-29 Thread Aurabindo Pillai
From: Bing Guo [Why] 1. YCbCr 4:2:2 8bpc/10bpc modes are blocked for HDMI by policy 2. A YCbCr 4:2:0 calculation error blocked some 4:2:0 timing modes [How] YCbCr 4:2:2 8bpc/10bpc modes are allowed for HDMI Fix YCbCr 4:2:0 calculation error Acked-by: Aurabindo Pillai Signed-off-by: Bing Guo

[PATCH 03/14] drm/amd/display: Fix dummy p-state hang on monitors with extreme timing

2021-10-29 Thread Aurabindo Pillai
From: Felipe Clark [WHY] It was found that the system would hang on a dummy pstate when playing 4k60 videos on a 1080p 390Hz monitor. [HOW] Properly select the dummy_pstate_latency_ms when firmware assisted memory clock switching is enabled instead of assuming that the highest latency would

[PATCH 02/14] drm/amd/display: Fix dcn10_log_hubp_states printf format string

2021-10-29 Thread Aurabindo Pillai
From: Anson Jacob Fix spacing issue for the format string. Addresses-Coverity-ID: 1446765: ("Invalid printf format string") Acked-by: Aurabindo Pillai Signed-off-by: Anson Jacob Reviewed-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- 1 file

[PATCH 01/14] drm/amd/display: dsc engine not disabled after unplug dsc mst hub

2021-10-29 Thread Aurabindo Pillai
From: Hersen Wu [WHY] If timing and bpp of displays on mst hub are not changed, pbn, slot_num for displays should not be changed. Linux user mode may initiate atomic_check with different display configuration after set mode finished. This will call to amdgpu_dm to re-compute payload, slot_num of

[PATCH 00/14] DC patches for Nov 1, 2021

2021-10-29 Thread Aurabindo Pillai
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC release version 3.2.160 * DMUB fw version 0.0.91 and bug fixes * DSC related fixes * Minor power optimization improvements * Bug fixes and improvements in display pipeline ---

Re: [PATCH 1/1] drm/amdgpu: remove unnecessary checks

2021-10-29 Thread Das, Nirmoy
ping! On 10/22/2021 1:03 PM, Nirmoy Das wrote: amdgpu_ttm_backend_bind() only needed for TTM_PL_TT and AMDGPU_PL_PREEMPT. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 1/1] drm/amdgpu: return early on error while setting bar0 memtype

2021-10-29 Thread Nirmoy Das
We set WC memtype for aper_base but don't check return value of arch_io_reserve_memtype_wc(). Be more defensive and return early on error. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] mm/migrate.c: Remove MIGRATE_PFN_LOCKED

2021-10-29 Thread Alistair Popple
On Friday, 29 October 2021 2:33:31 AM AEDT Felix Kuehling wrote: > Am 2021-10-27 um 9:42 p.m. schrieb Alistair Popple: > > On Wednesday, 27 October 2021 3:09:57 AM AEDT Felix Kuehling wrote: > >> Am 2021-10-25 um 12:16 a.m. schrieb Alistair Popple: > >>> MIGRATE_PFN_LOCKED is used to indicate to

RE: [PATCH] drm/amdgpu: use correct register mask to extract field

2021-10-29 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Friday, October 29, 2021 15:17 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Min, Frank ; Lazar, Lijo ; Oak Zeng ; Zhang, Hawking Subject: [PATCH]

[PATCH] drm/amdgpu: use correct register mask to extract field

2021-10-29 Thread Yang Wang
From: Oak Zeng Aldebaran has different register mask definitions for regiter MC_VM_XGMI_LFB_CNTL. Use the correct masks to interpret fields of this register. Signed-off-by: Oak Zeng Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c | 18 +- 1 file

Re: Lockdep spalt on killing a processes

2021-10-29 Thread Christian König
Am 28.10.21 um 19:26 schrieb Andrey Grodzovsky: On 2021-10-27 3:58 p.m., Andrey Grodzovsky wrote: On 2021-10-27 10:50 a.m., Christian König wrote: Am 27.10.21 um 16:47 schrieb Andrey Grodzovsky: On 2021-10-27 10:34 a.m., Christian König wrote: Am 27.10.21 um 16:27 schrieb Andrey