[PATCH] drm/amd/display: Fix Compile Error for DCE

Follow-up fix for: drm/amd/display: Add Debugfs Entry to Force in SST Sequence Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2] drm/amdkfd: fix svm_bo release invalid wait context warning

On 2021-12-09 4:18 p.m., Philip Yang wrote: Add svm_range_bo_unref_async to schedule work to wait for svm_bo eviction work done and then free svm_bo. __do_munmap put_page is atomic context, call svm_range_bo_unref_async to avoid warning invalid wait context. Other non atomic context call

Re: [PATCH] drm/amdgpu: disable default navi2x co-op kernel support

On 2021-12-09 10:20 p.m., Jonathan Kim wrote: This patch reverts the following: 'commit fc547b2b1816 ("drm/amdkfd: add Navi2x to GWS init conditions")' Disable GWS usage in default settings for now due to FW bugs. Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling ---

Re: [Patch v2] drm/amdgpu: Don't inherit GEM object VMAs in child process

On 2021-12-10 4:48 p.m., Rajneesh Bhardwaj wrote: When an application having open file access to a node forks, its shared mappings also get reflected in the address space of child process even though it cannot access them with the object permissions applied. With the existing permission checks

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On 2021-12-10 10:13 a.m., Christian König wrote: Am 10.12.21 um 15:25 schrieb Guilherme G. Piccoli: On 10/12/2021 11:16, Alex Deucher wrote:> [...] Why not just reload the driver after kexec? Alex Because the original issue is the kdump case, and we want a very very tiny kernel - also, the

[PATCH] amdgpu: fix some kernel-doc markup

Those are not today pulled by the sphinx doc, but better be ready. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-

[PATCH 5/7] drm/msm: Alter comment to use kmap_local_page()

From: Ira Weiny kmap() is being deprecated. So this comment could be misleading in the future. Change this comment to point to using kmap_local_page(). While here remove 'we' from the comment. Signed-off-by: Ira Weiny --- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 1 file changed, 2

[PATCH 3/7] drm/gma: Remove calls to kmap()

From: Ira Weiny kmap() is being deprecated and these instances are easy to convert to kmap_local_page(). Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper instead of an open coded use of kmap_local_page(). Signed-off-by: Ira Weiny ---

[PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual

[PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

From: Ira Weiny This series starts by converting the last easy kmap() uses to kmap_local_page(). There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, ttm_bo_kmap_ttm() is called in a number of different ways including some which are not thread local. I have a patch to

[PATCH 7/7] drm/radeon: Ensure kunmap is called on error

From: Ira Weiny The default case leaves the buffer object mapped in error. Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual

[PATCH 2/7] drm/amd: Replace kmap() with kmap_local_page()

From: Ira Weiny kmap() is being deprecated. These maps are thread local and can be replaced with kmap_local_page(). Replace kmap() with kmap_local_page() Signed-off-by: Ira Weiny --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 4/7] drm/radeon: Replace kmap() with kmap_local_page()

From: Ira Weiny kmap() is being deprecated and this usage is local to the thread. Use kmap_local_page() instead. Signed-off-by: Ira Weiny --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c

[PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

From: Ira Weiny kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used. Replace kmap() calls with kmap_local_page(). Signed-off-by: Ira Weiny --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++--

Re: [PATCH 3/3] drm/amdkfd: reset queue which consumes RAS poison

On 2021-12-10 6:15 a.m., Tao Zhou wrote: CP supports unmap queue with reset mode which only destroys specific queue without affecting others. Replacing whole gpu reset with reset queue mode for RAS poison consumption saves much time, and we can also fallback to gpu reset solution if reset

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On 10/12/2021 11:16, Alex Deucher wrote:> [...] > Why not just reload the driver after kexec? > > Alex Because the original issue is the kdump case, and we want a very very tiny kernel - also, the crash originally could have been caused by amdgpu itself, so if it's a GPU issue, we don't want to

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On 10/12/2021 12:13, Christian König wrote: > [...] > How about issuing a PCIe reset and re-initializing the ASIC with just > the VBIOS? > > That should be pretty straightforward I think. > > Christian. Thanks Christian, that'd be perfect! Is it feasible? Per Alex comment, we'd need to run

Re: [PATCH v2 10/10] drm/amdgpu: re-format file header comments

Applied. Thanks! Alex On Thu, Dec 9, 2021 at 12:02 PM Isabella Basso wrote: > > Fix the warning below: > > warning: Cannot understand * \file amdgpu_ioc32.c > on line 2 - I thought it was a doc line > > Changes since v1: > - As suggested by Alexander Deucher: > 1. Reduce diff to minimum

Re: [PATCH v2 09/10] drm/amdgpu: remove unnecessary variables

Applied. Thanks! Alex On Thu, Dec 9, 2021 at 12:03 PM Felix Kuehling wrote: > > Am 2021-12-09 um 10:47 a.m. schrieb Isabella Basso: > > This fixes the warnings below, and also drops the display_count > > variable, as it's unused. > > > > In function 'svm_range_map_to_gpu': > > warning:

[PATCH 10/10] drm/amd/display: 3.2.166

From: Aric Cyr Acked-by: Pavle Kotarac Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 963b58803ae5..18e59d635ca2 100644 ---

[PATCH 07/10] drm/amd/display: Reset DMCUB before HW init

From: Nicholas Kazlauskas [Why] If the firmware wasn't reset by PSP or HW and is currently running then the firmware will hang or perform underfined behavior when we modify its firmware state underneath it. [How] Reset DMCUB before setting up cache windows and performing HW init. Reviewed-by:

[PATCH 09/10] drm/amd/display: implement dc_mode_memclk

From: Martin Leung why: Need interface to lower clocks when in dc (power save) mode. Must be able to work with p_state unsupported cases Can cause flicker when OS notifies us of dc state change how: added dal3 interface for KMD added pathway to query smu for this softmax added blank before

[PATCH 08/10] drm/amd/display: ODM + MPO window on only one half of ODM

From: Eric Bernstein [Why] For ODM + MPO window on one half of ODM, only 3 pipes should be allocated and scaling parameters adjusted to handle this case [How] Fix pipe allocation when MPO viewport is only on one side of ODM split, and modify scaling paramters. Added diags test cases for ODM +

[PATCH 06/10] drm/amd/display: [FW Promotion] Release 0.0.97

From: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Pavle Kotarac Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 05/10] drm/amd/display: Force det buf size to 192KB with 3+ streams and upscaling

From: Michael Strauss [WHY] This workaround resolves underflow caused by incorrect DST_Y_PREFETCH. Overriding to 192KB DET buf size until the DST_Y_PREFETCH calc is fixed. Reviewed-by: Eric Yang Acked-by: Pavle Kotarac Signed-off-by: Michael Strauss ---

[PATCH 04/10] drm/amd/display: parse and check PSR SU caps

From: Mikita Lipski [why] Adding a function to read PSR capabilities and ALPM capabilities. Also adding a helper function to validate if the sink and the driver support PSR SU. [how] - isolated all PSR and ALPM reading calls to a separate funciton - set all required PSR caps - added a helper

[PATCH 02/10] drm/amd/display: Add debugfs entry for ILR

From: Wayne Lin [Why & How] In order to know the intermediate link rates supported by the eDP panel and test to select the optimized link rate to save power, create a new debugfs entry "ilr_setting" for setting ILR. Reviewed-by: Aurabindo Jayamohanan Pillai Acked-by: Pavle Kotarac

[PATCH 03/10] drm/amd/display: Add src/ext ID info for dummy service

From: Solomon Chiu [Why] Current error log of dummy irq service doesn't have src/ext ID info in the log. [How] Add src/ext ID in ack/set of dummy irq service. Reviewed-by: Wayne Lin Acked-by: Pavle Kotarac Signed-off-by: Solomon Chiu ---

[PATCH 01/10] drm/amd/display: Set exit_optimized_pwr_state for DCN31

From: Nicholas Kazlauskas [Why] SMU now respects the PHY refclk disable request from driver. This causes a hang during hotplug when PHY refclk was disabled because it's not being re-enabled and the transmitter control starts on dc_link_detect. [How] We normally would re-enable the clk with

DC Patches January 10, 2020

This new DC version brings improvements in the following areas: - FW promotion to 0.0.97 - DSC fixes for supported Docks - Fixes eDP display issue - Vendor LTTR workarounds - Fixes Tiled display audio issue Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.97 Aric Cyr (1):

Re: [PATCH v2 03/10] drm/amdgpu: fix amdgpu_ras_mca_query_error_status scope

Applied. Thanks! Alex On Thu, Dec 9, 2021 at 12:01 PM Isabella Basso wrote: > > This commit fixes the compile-time warning below: > > warning: no previous prototype for ‘amdgpu_ras_mca_query_error_status’ > [-Wmissing-prototypes] > > Changes since v1: > - As suggested by Alexander Deucher: >

[pull] amdgpu, amdkfd drm-next-5.17

Hi Dave, Daniel, More stuff for 5.17. The following changes since commit 70897848730470cc477d5d89e6222c0f6a9ac173: drm/amdgpu/display: Only set vblank_disable_immediate when PSR is not enabled (2021-12-01 16:00:58 -0500) are available in the Git repository at:

Re: [PATCH v4 0/6] Expand display core documentation

On 2021-12-09 4:04 p.m., Yann Dirson wrote: Thanks for this. It's really good to see this. Reviewed-by: Harry Wentland Hearfully seconded, let's get this rolling :) Reviewed-by: Yann Dirson Series applied to amd-staging-drm-next Thanks a lot! Harry On 2021-12-09 09:20, Rodrigo

[Patch v2] drm/amdgpu: Don't inherit GEM object VMAs in child process

When an application having open file access to a node forks, its shared mappings also get reflected in the address space of child process even though it cannot access them with the object permissions applied. With the existing permission checks on the gem objects, it might be reasonable to also

Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

On 2021-12-10 11:19 a.m., Quan, Evan wrote: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Friday, December 10, 2021 8:25 PM To: Gong, Curry;amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Zhu, James ; Liu, Leo; Quan, Evan Subject: Re: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

On 2021-12-10 6:41 a.m., chen gong wrote: Play a video on the raven (or PCO, raven2) platform, and then do the S3 test. When resume, the following error will be reported: amdgpu :02:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vcn_dec test failed (-110)

Re: Looking for clarifications around gfx/kcq/kiq

> > amdgpu_ring_alloc() itself is unconditionally setting count_dw, > > which looked > > suspicious to me -- so I added the check shown below, and it does > > look like > > ring_alloc() gets called again too soon. Am I right in thinking > > this could be > > the cause of amdgpu_ring_test_helper()

Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

On Fri, Dec 10, 2021 at 11:06 AM Quan, Evan wrote: > > [AMD Official Use Only] > > Hi Curry, > > Some nitpicks below. With them fixed, the patch is reviewed-by: Evan Quan > > > @Deucher, Alexander this should be able address the issue reported by >

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On Fri, Dec 10, 2021 at 10:24 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 12:13, Christian König wrote: > > [...] > > How about issuing a PCIe reset and re-initializing the ASIC with just > > the VBIOS? > > > > That should be pretty straightforward I think. > > > > Christian. > > > Thanks

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On Fri, Dec 10, 2021 at 9:25 AM Guilherme G. Piccoli wrote: > > On 10/12/2021 11:16, Alex Deucher wrote:> [...] > > Why not just reload the driver after kexec? > > > > Alex > > Because the original issue is the kdump case, and we want a very very > tiny kernel - also, the crash originally could

[PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 ++ Documentation/gpu/amdgpu/index.rst| 342 +-

[PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 81 1 file changed, 81 insertions(+) diff --git

[PATCH v2 3/3] Documentation/gpu: include description of some of the GC microcontrollers

This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 35 1 file changed, 35

[PATCH v2 0/3] Enrich amdgpu docs from recent threads

This series starts by splitting the amdgpu/index file to make some room for additional contents. The rest is basically bringing Alex' descriptions of the hardware and driver internals into the doc. Changes in v2: * fix typos (Harry Wentland) * get rid of double headings Yann Dirson (3):

Re: [PATCH] drm/amdkfd: explicitly create/destroy queue attributes under /sys

On 12/10/2021 10:49 AM, Felix Kuehling wrote: On 2021-12-10 2:22 a.m., Christian König wrote: Am 09.12.21 um 23:27 schrieb Felix Kuehling: Am 2021-12-09 um 5:14 p.m. schrieb Chen, Xiaogang: On 12/9/2021 12:40 PM, Felix Kuehling wrote: Am 2021-12-09 um 2:49 a.m. schrieb Xiaogang.Chen:

Re: [PATCH] drm/amdkfd: explicitly create/destroy queue attributes under /sys

On 2021-12-10 2:22 a.m., Christian König wrote: Am 09.12.21 um 23:27 schrieb Felix Kuehling: Am 2021-12-09 um 5:14 p.m. schrieb Chen, Xiaogang: On 12/9/2021 12:40 PM, Felix Kuehling wrote: Am 2021-12-09 um 2:49 a.m. schrieb Xiaogang.Chen: From: Xiaogang Chen When application is about

RE: [PATCH V4 02/17] drm/amd/pm: do not expose power implementation details to amdgpu_pm.c

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Friday, December 10, 2021 1:53 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V4 02/17] drm/amd/pm: do not expose power >

Re: [PATCH v2 03/11] mm/gup: migrate PIN_LONGTERM dev coherent pages to system

On 2021-12-09 8:31 p.m., Alistair Popple wrote: On Friday, 10 December 2021 3:54:31 AM AEDT Sierra Guiza, Alejandro (Alex) wrote: On 12/9/2021 10:29 AM, Felix Kuehling wrote: Am 2021-12-09 um 5:53 a.m. schrieb Alistair Popple: On Thursday, 9 December 2021 5:55:26 AM AEDT Sierra Guiza,

Re: [PATCH 2/2] drm/amd: move variable to local scope

With Christian's comments addressed both patches are Reviewed-by: Harry Wentland Harry On 2021-12-10 10:54, Mario Limonciello wrote: > `edp_stream` is only used when backend is enabled on eDP, don't > declare the variable outside that scope. > > Signed-off-by: Mario Limonciello > --- >

RE: [PATCH 2/2] drm/amd: move variable to local scope

[AMD Official Use Only] > -Original Message- > From: Koenig, Christian > Sent: Friday, December 10, 2021 10:19 > To: Limonciello, Mario ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope > > Am 10.12.21 um 17:12

RE: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Friday, December 10, 2021 8:25 PM > To: Gong, Curry ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhu, James > ; Liu, Leo ; Quan, Evan > > Subject: Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is

Re: [PATCH 2/2] drm/amd: move variable to local scope

Am 10.12.21 um 17:12 schrieb Limonciello, Mario: [AMD Official Use Only] -Original Message- From: Koenig, Christian Sent: Friday, December 10, 2021 10:07 To: Limonciello, Mario ; amd- g...@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope Am

RE: [PATCH 2/2] drm/amd: move variable to local scope

[AMD Official Use Only] > -Original Message- > From: Koenig, Christian > Sent: Friday, December 10, 2021 10:07 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope > > > > Am 10.12.21 um 16:54 schrieb Mario

Re: [PATCH 2/2] drm/amd: move variable to local scope

Am 10.12.21 um 16:54 schrieb Mario Limonciello: `edp_stream` is only used when backend is enabled on eDP, don't declare the variable outside that scope. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 +-- 1 file changed, 1

RE: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

[AMD Official Use Only] Hi Curry, Some nitpicks below. With them fixed, the patch is reviewed-by: Evan Quan @Deucher, Alexander this should be able address the issue reported by https://gitlab.freedesktop.org/drm/amd/-/issues/1828. Can you help to confirm this? BR Evan > -Original

[PATCH 1/2] drm/amd: add some extra checks that is_dig_enabled is defined

There are a few places that this isn't checked that could potentially be a NULL pointer access. Signed-off-by: Mario Limonciello --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 3 ++- .../display/dc/dce110/dce110_hw_sequencer.c | 21 +-- 2 files changed, 12 insertions(+),

[PATCH 2/2] drm/amd: move variable to local scope

`edp_stream` is only used when backend is enabled on eDP, don't declare the variable outside that scope. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH 1/2] drm/amdgpu: introduce a kind of halt state for amdgpu device

On 2021-12-09 10:47 p.m., Lang Yu wrote: On 12/09/ , Christian KKKnig wrote: Am 09.12.21 um 16:38 schrieb Andrey Grodzovsky: On 2021-12-09 4:00 a.m., Christian König wrote: Am 09.12.21 um 09:49 schrieb Lang Yu: It is useful to maintain error context when debugging SW/FW issues. We

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

Am 10.12.21 um 16:24 schrieb Guilherme G. Piccoli: On 10/12/2021 12:13, Christian König wrote: [...] How about issuing a PCIe reset and re-initializing the ASIC with just the VBIOS? That should be pretty straightforward I think. Christian. Thanks Christian, that'd be perfect! Is it

Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

[AMD Official Use Only] Please ignore this one. There was some issue, and all changes are not included in the patch. I have sent an update in a new mail (same subject). Sorry for inconvenience. BR, Marina From: Marina Nikolic Sent: Friday, December 10, 2021 1:00

Re: [PATCH 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-09 18:47, Yann Dirson wrote: > This is Alex' description from the "gpu block diagram" thread, edited to > fit as ReST. > > Originally-by: Alex Deucher > Signed-off-by: Yann Dirson > --- > Documentation/gpu/amdgpu/driver-core.rst | 81 > 1 file changed, 81

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

Am 10.12.21 um 15:25 schrieb Guilherme G. Piccoli: On 10/12/2021 11:16, Alex Deucher wrote:> [...] Why not just reload the driver after kexec? Alex Because the original issue is the kdump case, and we want a very very tiny kernel - also, the crash originally could have been caused by

Re: [PATCH 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-09 18:47, Yann Dirson wrote: > This is Alex' description from the "gpu block diagram" thread, edited to > fit as ReST. > > Originally-by: Alex Deucher > Signed-off-by: Yann Dirson > --- > Documentation/gpu/amdgpu/driver-core.rst | 81 > 1 file changed, 81

Re: [PATCH 3/3] Documentation/gpu: include description of some of the GC microcontrollers

On 2021-12-09 18:47, Yann Dirson wrote: > This is Alex' description from the "Looking for clarifications around > gfx/kcq/kiq" > thread, edited to fit as ReST. > > Originally-by: Alex Deucher > Signed-off-by: Yann Dirson > --- > Documentation/gpu/amdgpu/driver-core.rst | 35

[PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

== Description == Due to security reasons setting through sysfs should only be allowed in passthrough mode. Options that are not mapped as SMU messages do not have any mechanizm to distinguish between passthorugh, onevf and mutivf usecase. A unified approach is needed. == Changes == This patch

[PATCH] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

This value does not get cached into adev->pm.fw_version during startup for smu13 like it does for other SMU like smu10. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

Thanks a lot Alex / Gerd and Thomas, very informative stuff! I'm glad there are projects to collect/save the data and reuse after a kdump, this is very useful. I'll continue my study on the atombios thing of AMD and QXL, maybe at least we can make it work in qemu, that'd be great (like a small

Re: [bisected][regression] Applications that need amdgpu doesn't run after waking up from suspend

Hi, I just reverted the commit in tags/v5.15, and there are no issues after reverting the bad commit. But in 5.16-rc4, "startx" hangs with or without reverting the commit, it could be another bug.Regards,Tareque On Friday, December 10, 2021, 02:15:49 AM GMT+6, w...@kernel.org wrote:

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

On Fri, Dec 10, 2021 at 9:09 AM Guilherme G. Piccoli wrote: > > Thanks a lot Alex / Gerd and Thomas, very informative stuff! I'm glad > there are projects to collect/save the data and reuse after a kdump, > this is very useful. > > I'll continue my study on the atombios thing of AMD and QXL,

Re: [PATCH] drm/amdgpu: fix dropped backing store handling in amdgpu_dma_buf_move_notify

[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, December 10, 2021 3:39 AM To: amd-gfx@lists.freedesktop.org ; alexdeuc...@gmail.com Subject: [PATCH] drm/amdgpu: fix dropped backing store handling in

Re: [PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

On 12/10/2021 5:11 PM, chen gong wrote: Play a video on the raven (or PCO, raven2) platform, and then do the S3 test. When resume, the following error will be reported: amdgpu :02:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vcn_dec test failed (-110)

[PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

== Description == Due to security reasons setting through sysfs should only be allowed in passthrough mode. Options that are not mapped as SMU messages do not have any mechanizm to distinguish between passthorugh, onevf and mutivf usecase. A unified approach is needed. == Changes == This patch

[PATCH] drm/amdgpu: When the VCN(1.0) block is suspended, powergating is explicitly enabled

Play a video on the raven (or PCO, raven2) platform, and then do the S3 test. When resume, the following error will be reported: amdgpu :02:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vcn_dec test failed (-110) [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP

[PATCH 3/3] drm/amdkfd: reset queue which consumes RAS poison

CP supports unmap queue with reset mode which only destroys specific queue without affecting others. Replacing whole gpu reset with reset queue mode for RAS poison consumption saves much time, and we can also fallback to gpu reset solution if reset queue fails. Signed-off-by: Tao Zhou ---

[PATCH 1/3] drm/amdgpu: add gpu reset control for umc page retirement

Add a reset parameter for umc page retirement, let user decide whether call gpu reset in umc page retirement. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 15 --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h | 5 +++-- 2 files changed, 15 insertions(+), 5

[PATCH 2/3] drm/amdkfd: add reset parameter for unmap queues

So we can set reset mode for unmap operation, no functional change. Signed-off-by: Tao Zhou --- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

Re: [PATCH v5] drm/amdgpu: add support for SMU debug option

On 12/10/2021 3:08 PM, Lang Yu wrote: SMU firmware expects the driver maintains error context and doesn't interact with SMU any more when SMU errors occurred. That will aid in debugging SMU firmware issues. Add SMU debug option support for this request, it can be enabled or disabled via

Re: [PATCH v2] drm/amdgpu: introduce a kind of halt state for amdgpu device

Am 10.12.21 um 10:35 schrieb Lang Yu: It is useful to maintain error context when debugging SW/FW issues. Introduce amdgpu_device_halt() for this purpose. It will bring hardware to a kind of halt state, so that no one can touch it any more. Compare to a simple hang, the system will keep stable

RE: [PATCH V4 14/17] drm/amd/pm: relocate the power related headers

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, December 9, 2021 8:41 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V4 14/17] drm/amd/pm: relocate the power

RE: [PATCH V4 11/17] drm/amd/pm: correct the usage for amdgpu_dpm_dispatch_task()

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, December 9, 2021 8:37 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V4 11/17] drm/amd/pm: correct the usage for

[PATCH v5] drm/amdgpu: add support for SMU debug option

SMU firmware expects the driver maintains error context and doesn't interact with SMU any more when SMU errors occurred. That will aid in debugging SMU firmware issues. Add SMU debug option support for this request, it can be enabled or disabled via amdgpu_smu_debug debugfs file. Use a 32-bit

[PATCH v2] drm/amdgpu: introduce a kind of halt state for amdgpu device

It is useful to maintain error context when debugging SW/FW issues. Introduce amdgpu_device_halt() for this purpose. It will bring hardware to a kind of halt state, so that no one can touch it any more. Compare to a simple hang, the system will keep stable at least for SSH access. Then it should

RE: [PATCH V4 09/17] drm/amd/pm: optimize the amdgpu_pm_compute_clocks() implementations

[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, December 9, 2021 8:32 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Feng, Kenneth > Subject: Re: [PATCH V4 09/17] drm/amd/pm: optimize the >

[PATCH] drm/amdgpu: fix dropped backing store handling in amdgpu_dma_buf_move_notify

bo->tbo.resource can now be NULL. Signed-off-by: Christian König Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1811 --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c

Re: Reuse framebuffer after a kexec (amdgpu / efifb)

Hi Am 09.12.21 um 19:17 schrieb Guilherme G. Piccoli: Thanks again Alex! Some comments inlined below: On 09/12/2021 15:06, Alex Deucher wrote: Not really in a generic way. It's asic and platform specific. In addition most modern displays require link training to bring up the display, so you