Re: [PATCH V2 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread Christian König
Nice cleanup, feel free to add an Acked-by: Christian König as well. Christian. Am 14.01.22 um 07:44 schrieb Zhou1, Tao: [AMD Official Use Only] The series is: Reviewed-by: Tao Zhou -Original Message- From: Chai, Thomas Sent: Friday, January 14, 2022 1:34 PM To:

RE: [PATCH v4] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Chen, Horace
[AMD Official Use Only] Reviewed-by: Horace Chen -Original Message- From: Chen, JingWen Sent: Friday, January 14, 2022 2:54 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Chen, Horace ; Skvortsov, Victor ; Chen, JingWen Subject: [PATCH v4] drm/amd/amdgpu: fixing read wrong

[PATCH v4] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Jingwen Chen
[Why] This fixes 35709bd76d229a51b0c571a768b741650ec47828. we should read pf2vf data based at mman.fw_vram_usage_va after gmc sw_init. patch 35709bd76 breaks this logic. [How] calling amdgpu_virt_exchange_data in amdgpu_virt_init_data_exchange to set the right base in the right sequence. v2:

RE: [PATCH V2 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread Zhou1, Tao
[AMD Official Use Only] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Friday, January 14, 2022 1:34 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Clements, > John ; Chai, Thomas > Subject: [PATCH

RE: [PATCH v3] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Skvortsov, Victor
[AMD Official Use Only] +Shaoyun -Original Message- From: Chen, JingWen Sent: Thursday, January 13, 2022 11:09 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Chen, Horace ; Skvortsov, Victor ; Chen, JingWen Subject: [PATCH v3] drm/amd/amdgpu: fixing read wrong pf2vf data in

[PATCH 2/2] drm/amdgpu: apply vcn harvest quirk

2022-01-13 Thread Guchun Chen
This is a following patch to apply the workaround only on those boards with a bad harvest table in ip discovery. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 32 --- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: drop redundant check of ip discovery_bin

2022-01-13 Thread Guchun Chen
Early check in amdgpu_discovery_reg_base_init promises this. Signed-off-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH V2 5/5] drm/amdgpu: Fix the code style warnings in hdp xgmi mca and umc

2022-01-13 Thread yipechai
drm/amdgpu: Fix the code style warnings in hdp xgmi mca and umc: 1. WARNING: missing space after struct definition. 2. WARNING: please, no space before tabs. 3. WARNING: line length of xxx exceeds 100 columns. 4. ERROR: "foo* bar" should be "foo *bar". 5. ERROR: space required before the open

[PATCH V2 4/5] drm/amdgpu: Fix the code style warnings in sdma

2022-01-13 Thread yipechai
Fix the code style warnings in sdma: 1. WARNING: Missing a blank line after declarations. 2. ERROR: that open brace { should be on the previous line. 3. WARNING: unnecessary whitespace before a quoted newline. 4. ERROR: space required after that ',' (ctx:VxV). Signed-off-by: yipechai ---

[PATCH V2 3/5] drm/amdgpu: Fix the code style warnings in gmc

2022-01-13 Thread yipechai
Fix the code style warnings in gmc: ERROR: space required after that ',' (ctx:VxV). Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V2 2/5] drm/amdgpu: Fix the code style warnings in gfx

2022-01-13 Thread yipechai
Fix the code style warnings in gfx: 1. WARNING: suspect code indent for conditional statements. 2. ERROR: spaces required around that '=' (ctx:WxV). Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 2 +- 2 files changed, 3

[PATCH V2 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread yipechai
Fix the code style warnings in amdgpu_ras: 1. ERROR: space required before the open parenthesis '('. 2. WARNING: line length of xxx exceeds 100 columns. 3. ERROR: "foo* bar" should be "foo *bar". 4. WARNING: unnecessary whitespace before a quoted newline. 5. WARNING: space prohibited before

[PATCH v3] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Jingwen Chen
[Why] This fixes 35709bd76d229a51b0c571a768b741650ec47828. we should read pf2vf data based at mman.fw_vram_usage_va after gmc sw_init. patch 35709bd76 breaks this logic. [How] calling amdgpu_virt_exchange_data in amdgpu_virt_init_data_exchange to set the right base in the right sequence. v2:

RE: [PATCH 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread Chai, Thomas
OK, I will update the patches to add the fixed warning types. -Original Message- From: Zhou1, Tao Sent: Friday, January 14, 2022 11:45 AM To: Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Clements, John Subject: RE: [PATCH 1/5] drm/amdgpu: Fix the code style

RE: [PATCH 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Chai, Thomas > Sent: Friday, January 14, 2022 11:36 AM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Clements, > John ; Chai, Thomas > Subject: [PATCH 1/5] drm/amdgpu: Fix the code style

[PATCH] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Jingwen Chen
[Why] This fixes 35709bd76d229a51b0c571a768b741650ec47828. we should read pf2vf data based at mman.fw_vram_usage_va after gmc sw_init. patch 35709bd76 breaks this logic. [How] calling amdgpu_virt_exchange_data in amdgpu_virt_init_data_exchange to set the right base in the right sequence. v2:

[PATCH 4/5] drm/amdgpu: Fix the code style warnings in sdma

2022-01-13 Thread yipechai
Fix the code style warnings in sdma. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/sdma_v4_4.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

[PATCH 5/5] drm/amdgpu: Fix the code style warnings in hdp xgmi mca and umc

2022-01-13 Thread yipechai
drm/amdgpu: Fix the code style warnings in hdp xgmi mca and umc. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- drivers/gpu/drm/amd/amdgpu/mca_v3_0.c| 7 --- drivers/gpu/drm/amd/amdgpu/umc_v6_1.c| 3

[PATCH 3/5] drm/amdgpu: Fix the code style warnings in gmc

2022-01-13 Thread yipechai
Fix the code style warnings in gmc. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c

[PATCH 2/5] drm/amdgpu: Fix the code style warnings in gfx

2022-01-13 Thread yipechai
Fix the code style warnings in gfx. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

[PATCH 1/5] drm/amdgpu: Fix the code style warnings in amdgpu_ras

2022-01-13 Thread yipechai
Fix the code style warnings in amdgpu_ras. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 41 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 10 +++--- 2 files changed, 30 insertions(+), 21 deletions(-) diff --git

RE: [PATCH v2] drm/amdgpu: fix null ptr access

2022-01-13 Thread Quan, Evan
[AMD Official Use Only] For the patch with power code change, we usually have the patch title prefixed with "drm/amd/pm". With that fixed, the patch is reviewed-by: Evan Quan > -Original Message- > From: Cui, Flora > Sent: Friday, January 14, 2022 10:54 AM > To: Quan, Evan ;

[PATCH v2] drm/amdgpu: fix null ptr access

2022-01-13 Thread Flora Cui
check null ptr first before access its element v2: check adev->pm.dpm_enabled early in amdgpu_debugfs_pm_init() Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 2 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [RFC PATCH v2 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers

2022-01-13 Thread Esaki Tomohito
Hi, Thank you for your comment. On 2022/01/14 2:56, Bas Nieuwenhuizen wrote: I think we'll also want to do a conditional disable for DC (drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c) since it only enables modifiers on newer HW. Something like "if (modifiers == NULL)

Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-13 Thread Esaki Tomohito
Hi Daniel-san, Thank you for your comments. On 2022/01/13 22:44, Daniel Stone wrote: Hi Esaki-san, On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the

[PATCH 13/13] drm/amd/display: 3.2.169

2022-01-13 Thread Wayne Lin
From: Aric Cyr This version brings along following fixes: - Organize FPU associated code to DML - Modify SMU_TIMEOUT macro - Organize dcn201 code - Address DS stays disabled problem under specific scenario - Fix black screen issue - Update DML to rev.99 - Address problem of eDP hot-plug feature

[PATCH 12/13] drm/amd/display: [FW Promotion] Release 0.0.100.0

2022-01-13 Thread Wayne Lin
From: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Wayne Lin Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 11/13] drm/amd/display: Add signal type check when verify stream backends same

2022-01-13 Thread Wayne Lin
From: Dale Zhao [Why] For allow eDP hot-plug feature, the stream signal may change to VIRTUAL when plug-out and back to eDP when plug-in. OS will still setPathMode with same timing for each plugging, but eDP gets no stream update as we don't check signal type changing back as keeping it VIRTUAL.

[PATCH 10/13] drm/amd/display: update dml to rev.99 and smu clk_table w/a

2022-01-13 Thread Wayne Lin
From: Charlene Liu [why] 1. update dml to rev.99 2. add smu clk table w/a: smu gives 1 dtm level with mismatch voltage table which causes multiple issues. Reviewed-by: Nicholas Kazlauskas Acked-by: Wayne Lin Signed-off-by: Charlene Liu --- .../dc/dml/dcn31/display_mode_vba_31.c|

[PATCH 09/13] drm/amd/display: Fix black screen issue on memory clock switch en

2022-01-13 Thread Wayne Lin
From: Felipe Clark [WHY] With some monitors when multi plane overlay is enabled the memory clock switching mechanism has to change and, due to an error in the initialization sequence, it may cause a black screen. [HOW] Change the firmware assisted memory clock switch initialization and

[PATCH 08/13] drm/amd/display: DCEFCLK DS on CLK init

2022-01-13 Thread Wayne Lin
From: Chris Park [Why] On HG APU + dGPU scenario with no display to dGPU, DS stays disabled due to no display present. This problem can be worked around by DAL calling DCEFCLK DS message to SMU on clk init. [How] Call DCEFCLK DS message to SMU on clk init. Reviewed-by: Jun Lei Acked-by: Wayne

[PATCH 07/13] drm/amd/display: modify SMU_TIMEOUT macro.

2022-01-13 Thread Wayne Lin
From: Ian Chen [WHY] If some SMU features are not enabled, SMU will return fail to that message. [HOW] SMU_TIMEOUT macro will treat "return fail" as timeout also. Correct the macro to only report timeout case. Reviewed-by: Jun Lei Acked-by: Wayne Lin Signed-off-by: Ian Chen ---

[PATCH 06/13] drm/amd/display: move FPU associated DCN302 code to DML folder

2022-01-13 Thread Wayne Lin
From: "Dhillon, Jasdeep" [Why & How] As part of the FPU isolation work documented in https://patchwork.freedesktop.org/series/93042/, isolate code that uses FPU in DCN302 to DML, where all FPU code should locate. Co-authored-by: Jasdeep Dhillon Reviewed-by: Rodrigo Siqueira Acked-by: Wayne

[PATCH 05/13] drm/amd/display: 3.2.168

2022-01-13 Thread Wayne Lin
From: Aric Cyr This version brings improvements in the following: - Fix problem observed while assigning link encoder - Constrain seamless boot on eDP only - Improve Z9 interface Acked-by: Rodrigo Siqueira Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file

[PATCH 04/13] drm/amd/display: support new PMFW interface to disable Z9 only

2022-01-13 Thread Wayne Lin
From: Eric Yang [Why] Need to disable Z9 on configurations that only support Z10 [How] Support new PMFW interface to disable Z9 Reviewed-by: Nicholas Kazlauskas Acked-by: Rodrigo Siqueira Signed-off-by: Eric Yang --- .../amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 6 +++---

[PATCH 03/13] drm/amd/display: adjust bit comparison to be more type safe

2022-01-13 Thread Wayne Lin
From: Eric Yang Might potentially have truncation problem with the implicit casting Reviewed-by: Nicholas Kazlauskas Acked-by: Rodrigo Siqueira Signed-off-by: Eric Yang --- drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/13] drm/amd/display: Disabled seamless boots on DP and renamed power_down_display_on_boot

2022-01-13 Thread Wayne Lin
From: Jarif Aftab [WHY] - We only ever want seamless boots on eDPs - The naming and logic did not match the context [HOW] - Removed unnecessary if statements - Renamed power_down_display_on_boot to seamless_boot_edp_requested and swapped the logic Reviewed-by: Martin Leung Acked-by: Rodrigo

[PATCH 01/13] drm/amd/display: Reset link encoder assignments in atomic check

2022-01-13 Thread Wayne Lin
From: Stylon Wang [Why] The link encoder assignments must be "invalid" before commencing on the reassignment operation in DC. A failing atomic check from interruption of a signal could often leave the assignment change in place and trigger the assertion. [How] As a work-around the link encoder

[PATCH 00/13] DC Patches January 14, 2022

2022-01-13 Thread Wayne Lin
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fix problem observed while assigning link encoder * Constrain seamless boot on eDP only * Improve Z9 interface * Organize FPU associated code to DML * Modify SMU_TIMEOUT macro * Organize dcn201 code * Address DS

RE: [PATCH] drm/amdgpu: fix null ptr access

2022-01-13 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: Cui, Flora > Sent: Thursday, January 13, 2022 2:58 PM > To: amd-gfx@lists.freedesktop.org; Quan, Evan > Cc: Cui, Flora > Subject: [PATCH] drm/amdgpu: fix null ptr access > > check null ptr first before access its element > >

Re: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon

2022-01-13 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jan 13, 2022 at 8:38 AM Chen, Guchun wrote: > > Series is: > Reviewed-by: Guchun Chen > > Regards, > Guchun > > -Original Message- > From: Yang Li > Sent: Thursday, January 13, 2022 3:12 PM > To: airl...@linux.ie; Chen, Guchun > Cc: dan...@ffwll.ch;

Re: [PATCH V2 2/2] drm/amdgpu: No longer insert ras blocks into ras_list if it already exists in ras_list

2022-01-13 Thread Luben Tuikov
NAK. This patch should be reverted. We need to figure out why the block is being added and fix this there. Regards, Luben On 2022-01-12 05:38, yipechai wrote: > No longer insert ras blocks into ras_list if it already exists in ras_list. > > Signed-off-by: yipechai > --- >

Re: [RFC PATCH v2 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers

2022-01-13 Thread Bas Nieuwenhuizen
I think we'll also want to do a conditional disable for DC (drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c) since it only enables modifiers on newer HW. Something like "if (modifiers == NULL) fb_modifiers_not_supported = true;" in amdgpu_dm_plane_init. On Thu, Jan 13, 2022 at 10:44 AM

Re: [PATCH 2/2] drm/amdgpu: No longer insert ras blocks into ras_list if it already exists in ras_list

2022-01-13 Thread Alex Deucher
On Wed, Jan 12, 2022 at 3:36 AM Zhou1, Tao wrote: > > [AMD Official Use Only] > > > > > -Original Message- > > From: Chai, Thomas > > Sent: Wednesday, January 12, 2022 3:48 PM > > To: amd-gfx@lists.freedesktop.org > > Cc: Chai, Thomas ; Zhang, Hawking > > ; Zhou1, Tao ; Clements, > >

Re: [PATCH 2/2] drm/amdgpu: add vram check function for GMC

2022-01-13 Thread Felix Kuehling
Am 2022-01-13 um 2:45 a.m. schrieb Xiaojian Du: > This will add vram check function for GMC, it will cover gmc v8/9/10 > > Signed-off-by: Xiaojian Du > Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 42 + >

[PATCH] drm/amdkfd: use proper interrupt handling for gfx10

2022-01-13 Thread Jonathan Kim
GFX has the following changes when handling interrupts in the KFD: - no pasid workaround required - SQ interrupt auto has different events - SQ interrupt word is continguous and only has 23-bit data. Also SH is labelled as SA and workgroup id replaces CU id. - SQ interrupt word is continguos and

Re: [Patch v2] drm/amdgpu: add vram check function for GMC

2022-01-13 Thread Alex Deucher
On Thu, Jan 13, 2022 at 5:00 AM Xiaojian Du wrote: > > This will add vram check function for GMC, it will cover gmc v6/7/8/9/10 > Please provide a better description. Also, we should either protect the calls to this function with: if (amdgpu_emu_mode == 1) or return early in the function if

Re: [PATCH] drm/amdgpu: don't do resets on APUs which don't support it

2022-01-13 Thread Alex Deucher
On Thu, Jan 13, 2022 at 1:56 AM Lazar, Lijo wrote: > > Hi Alex, > > What about something like this? > > bool amdgpu_device_reset_on_suspend(struct amdgpu_device *adev) > { > if (adev->in_s0ix || adev->gmc.xgmi.num_physical_nodes > 1) > return false; > > switch

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-13 Thread Limonciello, Mario
On 1/13/2022 03:16, Bert Karwatzki wrote: Am Mittwoch, dem 12.01.2022 um 02:08 + schrieb Limonciello, Mario: [AMD Official Use Only] -Original Message- From: Bert Karwatzki Sent: Tuesday, January 11, 2022 19:12 To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario ;

RE: [PATCH Review 1/1] drm/amdgpu: handle denied inject error into critical regions v2

2022-01-13 Thread Chen, Guchun
[Public] I guess you still need to add a commit description in v2. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Stanley.Yang Sent: Thursday, January 13, 2022 9:28 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Stanley ; Zhou1, Tao ; Clements, John ; Zhang, Hawking

Re: [PATCH] drm/amdgpu: don't do resets on APUs which don't support it

2022-01-13 Thread Limonciello, Mario
On 1/13/2022 00:56, Lazar, Lijo wrote: Hi Alex, What about something like this? bool amdgpu_device_reset_on_suspend(struct amdgpu_device *adev) {     if (adev->in_s0ix || adev->gmc.xgmi.num_physical_nodes > 1)     return false;     switch

RE: [PATCH] tests/amdgpu: Add VCN test support for Biege Goby

2022-01-13 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only] Reviewed-By: Veerabadhran Gopalakrishnan -Original Message- From: Alex Deucher Sent: Thursday, January 13, 2022 7:47 PM To: Chen, Guchun Cc: amd-gfx list ; Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Liu, Leo Subject: Re: [PATCH]

Re: [PATCH] tests/amdgpu: Add VCN test support for Biege Goby

2022-01-13 Thread Alex Deucher
Acked-by: Alex Deucher On Thu, Jan 13, 2022 at 8:55 AM Guchun Chen wrote: > > Added Beige Goby chip id in vcn test, will open a MR to > merge this on gitlab after review. > > Signed-off-by: Guchun Chen > --- > tests/amdgpu/vcn_tests.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] tests/amdgpu: Add VCN test support for Biege Goby

2022-01-13 Thread Guchun Chen
Added Beige Goby chip id in vcn test, will open a MR to merge this on gitlab after review. Signed-off-by: Guchun Chen --- tests/amdgpu/vcn_tests.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c index 628b4910..15d573d3

Re: [RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-13 Thread Daniel Stone
Hi Esaki-san, On Thu, 13 Jan 2022 at 09:44, Tomohito Esaki wrote: > Some drivers whose planes only support linear layout fb do not support format > modifiers. > These drivers should support modifiers, however the DRM core should handle > this > rather than open-coding in every driver. > > In

RE: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon

2022-01-13 Thread Chen, Guchun
Series is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Yang Li Sent: Thursday, January 13, 2022 3:12 PM To: airl...@linux.ie; Chen, Guchun Cc: dan...@ffwll.ch; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; amd-gfx@lists.freedesktop.org;

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-13 Thread Bert Karwatzki
Am Mittwoch, dem 12.01.2022 um 02:08 + schrieb Limonciello, Mario: > [AMD Official Use Only] > > > -Original Message- > > From: Bert Karwatzki > > Sent: Tuesday, January 11, 2022 19:12 > > To: amd-gfx@lists.freedesktop.org > > Cc: Limonciello, Mario ; Kazlauskas, > > Nicholas > > ;

Re: [PATCH] drm/amdgpu: Indent some if statements

2022-01-13 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 1/13/2022 7:17 AM, Dan Carpenter wrote: These if statements need to be indented. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/1] drm/amdgpu: move bo_va ref counting to internal funcs

2022-01-13 Thread Das, Nirmoy
On 1/13/2022 1:12 PM, Christian König wrote: Am 13.01.22 um 13:06 schrieb Nirmoy Das: GEM code should not deal with struct amdgpu_bo_va's ref_count. Move ref counting to amdgpu_vm.c. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 +++  

Re: [PATCH 1/1] drm/amdgpu: move bo_va ref counting to internal funcs

2022-01-13 Thread Christian König
Am 13.01.22 um 13:06 schrieb Nirmoy Das: GEM code should not deal with struct amdgpu_bo_va's ref_count. Move ref counting to amdgpu_vm.c. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 38

[PATCH 1/1] drm/amdgpu: move bo_va ref counting to internal funcs

2022-01-13 Thread Nirmoy Das
GEM code should not deal with struct amdgpu_bo_va's ref_count. Move ref counting to amdgpu_vm.c. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 38 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h |

[PATCH] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Jingwen Chen
[Why] This fixes 35709bd76d229a51b0c571a768b741650ec47828. we should read pf2vf data based at mman.fw_vram_usage_va after gmc sw_init. patch 35709bd76 breaks this logic. [How] calling amdgpu_virt_exchange_data in amdgpu_virt_init_data_exchange to set the right base in the right sequence.

RE: [PATCH V2 2/2] drm/amdgpu: To eliminate the warning of no previous prototype for 'amdgpu_ras_block_match_default'

2022-01-13 Thread Zhou1, Tao
[AMD Official Use Only] The subject can be simplified as "fix compile warning for ras_block_match_default", with that fixed the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Thursday, January 13, 2022 6:32 PM > To: amd-gfx@lists.freedesktop.org >

[PATCH V2 2/2] drm/amdgpu: To eliminate the warning of no previous prototype for 'amdgpu_ras_block_match_default'

2022-01-13 Thread yipechai
To eliminate the warning of no previous prototype for 'amdgpu_ras_block_match_default'. Fix compile warnings. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[PATCH V2 1/2] drm/amdgpu: Use ARRAY_SIZE to get array length

2022-01-13 Thread yipechai
Use ARRAY_SIZE to get array length. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 23f4290b2fde..394a18e3c6af

[Patch v2] drm/amdgpu: add vram check function for GMC

2022-01-13 Thread Xiaojian Du
This will add vram check function for GMC, it will cover gmc v6/7/8/9/10 Signed-off-by: Xiaojian Du --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 46 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 4 +++

[RFC PATCH v2 3/3] drm: replace allow_fb_modifiers with fb_modifiers_not_supported

2022-01-13 Thread Tomohito Esaki
Since almost drivers support fb modifiers, allow_fb_modifiers is replaced with fb_modifiers_not_supported and removed. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/drm_framebuffer.c| 6 +++--- drivers/gpu/drm/drm_ioctl.c | 2 +-

[RFC PATCH v2 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers

2022-01-13 Thread Tomohito Esaki
Set fb_modifiers_not_supported flag in legacy drivers whose planes support non-linear layouts but does not support modifiers, and replace allow_fb_modifiers with fb_modifiers_not_supported. Signed-off-by: Tomohito Esaki --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +++---

[RFC PATCH v2 1/3] drm: add support modifiers for drivers whose planes only support linear layout

2022-01-13 Thread Tomohito Esaki
The LINEAR modifier is advertised as default if a driver doesn't specify modifiers. However, there are legacy drivers such as radeon that do not support modifiers but infer the actual layout of the underlying buffer. Therefore, a new flag not_support_fb_modifires is introduced for these legacy

[RFC PATCH v2 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-13 Thread Tomohito Esaki
Some drivers whose planes only support linear layout fb do not support format modifiers. These drivers should support modifiers, however the DRM core should handle this rather than open-coding in every driver. In this patch series, these drivers expose format modifiers based on the following

[PATCH -next 2/2 v2] drm/amdgpu: clean up some inconsistent indenting

2022-01-13 Thread Yang Li
Eliminate the follow smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3504 amdgpu_device_init() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1716 amdgpu_ras_error_status_query() warn: if statement not indented drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1058

[PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon

2022-01-13 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2725:16-17: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] drm/amdgpu: add vram check function for GMC

2022-01-13 Thread Huang Rui
On Thu, Jan 13, 2022 at 03:45:26PM +0800, Du, Xiaojian wrote: > This will add vram check function for GMC, it will cover gmc v8/9/10 > > Signed-off-by: Xiaojian Du > Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 42 + >