RE: [PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Sierra Guiza, Alejandro (Alex) Sent: Saturday, February 12, 2022 12:18 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Chen, Guchun Subject: [PATCH] drm/amdkfd: replace err by dbg print at svm vram

Re: [PATCH v3 07/12] PCI: Set ports for discrete USB4 controllers appropriately

2022-02-11 Thread Bjorn Helgaas
Make the subject specific, not just "appropriately." I think you're marking something *removable*, so include that. On Fri, Feb 11, 2022 at 01:32:45PM -0600, Mario Limonciello wrote: > Discrete USB4 controllers won't have ACPI nodes specifying which > PCIe or XHCI port they are linked with. > >

[pull] amdgpu, amdkfd, radeon drm-next-5.18

2022-02-11 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 5.18. The following changes since commit 4efdddbce7c1329f00c458e85dcaf105aebdc0ed: Merge tag 'amd-drm-next-5.17-2022-01-12' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-01-14 15:42:28 +0100) are available in the Git repository at: https

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-11 Thread Limonciello, Mario
On 2/11/2022 15:35, Bjorn Helgaas wrote: On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt controller to indicate that D3 is possible. As this is used solely for older Apple systems, move it into a quirk tha

Re: [PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable

2022-02-11 Thread Bjorn Helgaas
On Fri, Feb 11, 2022 at 01:32:44PM -0600, Mario Limonciello wrote: > USB4 class devices are also removable like Intel Thunderbolt devices. Spec reference, please. > Drivers of downstream devices use this information to declare functional > differences in how the drivers perform by knowing that th

[PATCH 11/11] drm/amd/display: extend dcn201 support

2022-02-11 Thread Jasdeep Dhillon
From: Oliver Logush Signed-off-by: Oliver Logush --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- drivers/gpu/drm/amd/display/include/dal_asic_id.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/

[PATCH 10/11] drm/amd/display: Add dsc pre-validation in atomic check

2022-02-11 Thread Jasdeep Dhillon
From: Roman Li [Why] The previous change: "Add affected crtcs to atomic state for dsc mst unplug" forces modeset on all added crctc regardless whether timing changed or not. Per our implementation of dsc we need modeset only if timing changed. Otherwise dsc can be programmed incorrectly leading t

[PATCH 08/11] drm/amd/display: 3.2.173

2022-02-11 Thread Jasdeep Dhillon
From: Aric Cyr This version brings along the following fixes: -Fixes bugs for dsc mst hub -Enables 29 denial itnerface by default -Fixes dmub outbox notificatoin Acked-by: Jasdeep Dhillon Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 09/11] drm/amd/display: add dsc mst stream pbn log for debug

2022-02-11 Thread Jasdeep Dhillon
From: Hersen Wu [why] payload and slot number of display on dsc mst hub will be adjusted when there is change on any display on dsc hub. to monitor dsc enable/disable, pbn change, we need add log. [How] add mst_pbn to dc_dsc_config of dc_crtc_timing. add dsc, pbn, display name within dc_core_ena

[PATCH 07/11] drm/amd/display: [FW Promotion] Release 0.0.104.0

2022-02-11 Thread Jasdeep Dhillon
From: Anthony Koo Acked-by: Jasdeep Dhillon Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 06/11] drm/amd/display: Add affected crtcs to atomic state for dsc mst unplug

2022-02-11 Thread Jasdeep Dhillon
From: Roman Li [Why] When display topology changed on DSC hub we add all crtcs with dsc support to atomic state. Refer to patch:"drm/amd/display: Trigger modesets on MST DSC connectors" However the original implementation may skip crtc if the topology change caused by unplug. That potentially cou

[PATCH 05/11] drm/amd/display: enable z9 denial interface by default

2022-02-11 Thread Jasdeep Dhillon
From: Eric Yang Reviewed-by: Nicholas Kazlauskas Acked-by: Jasdeep Dhillon Signed-off-by: Eric Yang --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gp

[PATCH 04/11] drm/amd/display: make sure pipe power gating reach requested hw state

2022-02-11 Thread Jasdeep Dhillon
From: Charlene Liu [why] display mapping change will involved pipe power gating on and off. when doing this too fase, sometimes usbc will have no display. check HW status, it is still in pipe power gating. [how] insert polling HW status to make sure the required state reached. also add dal regis

[PATCH 02/11] drm/amd/display: Fix for dmub outbox notification enable

2022-02-11 Thread Jasdeep Dhillon
From: Meenakshikumar Somasundaram [Why] Currently driver enables dmub outbox notification before oubox ISR is registered. During boot scenario, sometimes dmub issues hpd outbox message before driver registers ISR and those messages are missed. [How] Enable dmub outbox notification after outbox I

[PATCH 03/11] drm/amd/display: dsc mst re-compute pbn for changes on hub

2022-02-11 Thread Jasdeep Dhillon
From: Hersen Wu [why] when unplug 1 dp from dsc mst hub, atomic_check new request dc_state only include info for the unplug dp. this will not trigger re-compute pbn for displays still connected to hub. [how] all displays connected to dsc hub are available in dc->current_state, by comparing dc->c

[PATCH 01/11] drm/amd/display: reset lane settings after each PHY repeater LT

2022-02-11 Thread Jasdeep Dhillon
From: Sung Joon Kim [why] In LTTPR non-transparent mode, we need to reset the cached lane settings before performing link training on the next PHY repeater. Otherwise, the cached lane settings will be used for the next clock recovery e.g. VS = MAX (3) which should not be the case according to the

[PATCH 00/11] DC Patches Feburary 14, 2022

2022-02-11 Thread Jasdeep Dhillon
This DC patchset brings improvements in multiple areas. In summary, we highlight: -Fixes bugs for dsc mst hub -Enables Z9 denial interface by default -Fixes dmub outbox notification Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.104.0 Aric Cyr (1): drm/amd/display: 3.2.173 Ch

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-11 Thread Bjorn Helgaas
On Fri, Feb 11, 2022 at 01:32:43PM -0600, Mario Limonciello wrote: > The root port used for PCIe tunneling should be marked as removable to > ensure that the entire chain is marked removable. > > This can be done by looking for the device property specified in > the ACPI tables `usb4-host-interfac

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-11 Thread Bjorn Helgaas
On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: > `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt > controller to indicate that D3 is possible. As this is used solely > for older Apple systems, move it into a quirk that enumerates across > all Intel TBT co

Re: [PATCH v3 02/12] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk

2022-02-11 Thread Bjorn Helgaas
Update subject to something like: PCI: pciehp: Quirk broken Command Completed support on Intel Thunderbolt controllers On Fri, Feb 11, 2022 at 01:32:40PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` check is currently used to indicate the lack of > command completed support for a num

Re: [PATCH v2 1/1] drm/amdgpu: Show IP discovery in sysfs

2022-02-11 Thread Alex Deucher
On Fri, Feb 11, 2022 at 3:53 PM Luben Tuikov wrote: > > Add IP discovery data in sysfs. The format is: > /sys/class/drm/cardX/device/ip_discovery/die/D/B/I/ > where, > X is the card ID, an integer, > D is the die ID, an integer, > B is the IP HW ID, an integer, aka block type, > I is the IP HW ID

Re: [PATCH v3 01/12] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-11 Thread Bjorn Helgaas
On Fri, Feb 11, 2022 at 01:32:39PM -0600, Mario Limonciello wrote: > This PCI class definition of the USB4 device is currently located only in > the thunderbolt driver. > > It will be needed by a few other drivers for upcoming changes. Move it into > the common include file. > > Acked-by: Alex De

Re: [PATCH] drm/amdgpu: Fix htmldoc warning

2022-02-11 Thread Alex Deucher
On Fri, Feb 11, 2022 at 3:55 PM Andrey Grodzovsky wrote: > > Update function name. > > Signed-off-by: Andrey Grodzovsky > Reported-by: kernel test robot Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH] drm/amdgpu: Fix htmldoc warning

2022-02-11 Thread Andrey Grodzovsky
Update function name. Signed-off-by: Andrey Grodzovsky Reported-by: kernel test robot --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

[PATCH v2 1/1] drm/amdgpu: Show IP discovery in sysfs

2022-02-11 Thread Luben Tuikov
Add IP discovery data in sysfs. The format is: /sys/class/drm/cardX/device/ip_discovery/die/D/B/I/ where, X is the card ID, an integer, D is the die ID, an integer, B is the IP HW ID, an integer, aka block type, I is the IP HW ID instance, an integer. are the attributes of the block instance. At t

[PATCH v2 0/1] drm/amdgpu: Show IP discovery in sysfs

2022-02-11 Thread Luben Tuikov
Version 2, this version, integrates community feedback. Version 1, adds sysfs tear-down on rmmod. Show IP discovery in sysfs. See the commit message for the layout format. For instance, on a Sienna Cichlid, the layout looks like this: $tree /sys/class/drm/card0/device/ip_discovery/ /sys/class/dr

Re: [PATCH 0/4] General cleanup and SPDX update

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 13:59 schrieb Rajneesh Bhardwaj: There are a bunch of warnings from checkpatch and kerneldoc style issues that this cleanup series tries to address and also update the SPDX License header for all the KFD files within amdgpu driver. The series is Reviewed-by: Felix Kuehling

Re: [PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 14:45 schrieb Alex Sierra: Avoid spam the kernel log on application memory allocation failures. __func__ argument was also removed from dev_fmt macro due to parameter conflicts with dynamic_dev_dbg. Signed-off-by: Alex Sierra Reviewed-by: Philip Yang --- drivers/gpu/drm/am

[PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread Alex Sierra
Avoid spam the kernel log on application memory allocation failures. __func__ argument was also removed from dev_fmt macro due to parameter conflicts with dynamic_dev_dbg. Signed-off-by: Alex Sierra Reviewed-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 17 + 1

RE: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-11 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mika Westerberg > Sent: Friday, February 11, 2022 04:24 > To: Limonciello, Mario > Cc: Bjorn Helgaas ; Andreas Noever > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.org>; open list:RADEON and AMDGPU

RE: [PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-11 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mika Westerberg > Sent: Friday, February 11, 2022 04:35 > To: Limonciello, Mario > Cc: Bjorn Helgaas ; Andreas Noever > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.org>; open list:RADEON and AMDG

[PATCH v3 11/12] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Acked-by: Hans de Goede Signed-off-by: Mario Limonciello --- drivers/platform/x86/apple-gmux.c | 2 +- 1 f

[PATCH v3 12/12] PCI: drop `pci_is_thunderbolt_attached`

2022-02-11 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. As all drivers now look at the removable attribute, drop this function. Signed-off-by: Mario Limonciello --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff --git

[PATCH v3 09/12] drm/nouveau: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++-- 1 file changed, 2 inse

[PATCH v3 10/12] drm/radeon: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/radeon_device.c | 4 ++-- drivers/gpu/drm/radeo

[PATCH v3 08/12] drm/amd: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Mario Limonciello
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Reviewed-by: Macpaul Lin Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2

[PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-11 Thread Mario Limonciello
The root port used for PCIe tunneling should be marked as removable to ensure that the entire chain is marked removable. This can be done by looking for the device property specified in the ACPI tables `usb4-host-interface`. Suggested-by: Mika Westerberg Link: https://docs.microsoft.com/en-us/w

[PATCH v3 06/12] PCI: Explicitly mark USB4 NHI devices as removable

2022-02-11 Thread Mario Limonciello
USB4 class devices are also removable like Intel Thunderbolt devices. Drivers of downstream devices use this information to declare functional differences in how the drivers perform by knowing that they are connected to an upstream TBT/USB4 port. Reviewed-by: Macpaul Lin Signed-off-by: Mario Lim

[PATCH v3 01/12] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-11 Thread Mario Limonciello
This PCI class definition of the USB4 device is currently located only in the thunderbolt driver. It will be needed by a few other drivers for upcoming changes. Move it into the common include file. Acked-by: Alex Deucher Acked-by: Mika Westerberg Signed-off-by: Mario Limonciello --- drivers/

[PATCH v3 07/12] PCI: Set ports for discrete USB4 controllers appropriately

2022-02-11 Thread Mario Limonciello
Discrete USB4 controllers won't have ACPI nodes specifying which PCIe or XHCI port they are linked with. In order to set the removable attribute appropriately, use the USB4 DVSEC extended capabability set on these root ports to determine if they are located on a discrete USB4 controller. Suggeste

[PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-11 Thread Mario Limonciello
`pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt controller to indicate that D3 is possible. As this is used solely for older Apple systems, move it into a quirk that enumerates across all Intel TBT controllers. Suggested-by: Mika Westerberg Signed-off-by: Mario Limonciello

[PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-11 Thread Mario Limonciello
The `is_thunderbolt` attribute is currently a dumping ground for a variety of things. Instead use the driver core removable attribute to indicate the detail a device is attached to a thunderbolt or USB4 chain. Signed-off-by: Mario Limonciello --- drivers/pci/probe.c | 20 +++--

[PATCH v3 02/12] PCI: Move `is_thunderbolt` check for lack of command completed to a quirk

2022-02-11 Thread Mario Limonciello
The `is_thunderbolt` check is currently used to indicate the lack of command completed support for a number of older Thunderbolt devices. This however is heavy handed and should have been done via a quirk. Move the affected devices outlined in commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ fo

[PATCH v3 00/12] Overhaul `is_thunderbolt`

2022-02-11 Thread Mario Limonciello
Various drivers in the kernel use `is_thunderbolt` or `pci_is_thunderbolt_attached` to designate behaving differently from a device that is internally in the machine. This relies upon checks for a specific capability only set on Intel controllers. Non-Intel USB4 designs should also match this desi

Re: [PATCH 2/2] drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 12:15 schrieb Jonathan Kim: SDMA 5.2.x queues are required to be mapped and unmapped from the extended engines. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH 2/4] drm/amdkfd: updade SPDX license header

2022-02-11 Thread Rajneesh Bhardwaj
Update the SPDX License header for all the KFD files. Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 ++- drivers/gpu/drm/amd/amdkfd/kfd_crat.h | 3 ++- driv

[PATCH 3/4] drm/amdkfd: Fix leftover errors and warnings

2022-02-11 Thread Rajneesh Bhardwaj
A bunch of errors and warnings are leftover KFD over the years, attempt to fix the errors and most warnings reported by checkpatch tool. Still a few warnings remain which may be false positives so ignore them for now. Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

[PATCH 4/4] drm/amdgpu: Fix a kerneldoc warning

2022-02-11 Thread Rajneesh Bhardwaj
Add missing parameters to fix a kerneldoc warning Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c inde

[PATCH 1/4] drm/amdgpu: Fix some kerneldoc warnings

2022-02-11 Thread Rajneesh Bhardwaj
Fix few kerneldoc warnings and one typo. Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amd

[PATCH 0/4] General cleanup and SPDX update

2022-02-11 Thread Rajneesh Bhardwaj
There are a bunch of warnings from checkpatch and kerneldoc style issues that this cleanup series tries to address and also update the SPDX License header for all the KFD files within amdgpu driver. Rajneesh Bhardwaj (4): drm/amdgpu: Fix some kerneldoc warnings drm/amdkfd: updade SPDX license

Re: [PATCH 1/2] drm/amdkfd: remove unneeded unmap single queue option

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 12:15 schrieb Jonathan Kim: The KFD only unmaps all queues, all dynamics queues or all process queues since RUN_LIST is mapped with all KFD queues. There's no need to provide a single type unmap so remove this option. You should also remove KFD_UNMAP_QUEUES_FILTER_SINGLE_QUE

Re: [PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 11:17 schrieb Alex Sierra: Avoid spam the kernel log on application memory allocation failures. __func__ argument was also removed from dev_fmt macro due to parameter conflicts with dynamic_dev_dbg. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 9

Re: [PATCH] drm/amdgpu: remove ctx->lock

2022-02-11 Thread Andrey Grodzovsky
On 2022-02-11 03:24, Ken Xue wrote: KMD reports a warning on holding a lock from drm_syncobj_find_fence, when running amdgpu_test case “syncobj timeline test”. ctx->lock was designed to prevent concurrent "amdgpu_ctx_wait_prev_fence" calls and avoid dead reservation lock from GPU reset. Ju

Re: [PATCH] drm/amdkfd: Fix prototype warning for get_process_num_bos

2022-02-11 Thread Felix Kuehling
Am 2022-02-10 um 23:30 schrieb Rajneesh Bhardwaj: Fix the warning: no previous prototype for 'get_process_num_bos' [-Wmissing-prototypes] Reported-by: kernel test robot Signed-off-by: Rajneesh Bhardwaj The series is Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_charde

Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-02-11 Thread Wolfram Sang
On Fri, Feb 04, 2022 at 07:22:44PM +, Tareque Md.Hanif wrote: > The issue still exists. It takes very long time to suspend (10-12s). > `DRI_PRIME=1 glxgears` is a black window. > > journalctl attached > Looking forward to any testing. Any new ideas which Tareque could test? signature.asc

[PATCH 2/2] drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues

2022-02-11 Thread Jonathan Kim
SDMA 5.2.x queues are required to be mapped and unmapped from the extended engines. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b

[PATCH 1/2] drm/amdkfd: remove unneeded unmap single queue option

2022-02-11 Thread Jonathan Kim
The KFD only unmaps all queues, all dynamics queues or all process queues since RUN_LIST is mapped with all KFD queues. There's no need to provide a single type unmap so remove this option. Signed-off-by: Jonathan Kim --- .../drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +- .../gpu/drm/amd/am

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 11:39 schrieb David Hildenbrand: On 11.02.22 17:15, David Hildenbrand wrote: On 01.02.22 16:48, Alex Sierra wrote: Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page o

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread Jason Gunthorpe
On Fri, Feb 11, 2022 at 05:49:08PM +0100, David Hildenbrand wrote: > On 11.02.22 17:45, Jason Gunthorpe wrote: > > On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote: > > > >> ... I'm pretty sure we cannot FOLL_PIN DEVICE_PRIVATE pages > > > > Currently the only way to get a DEVICE

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread David Hildenbrand
On 11.02.22 17:15, David Hildenbrand wrote: > On 01.02.22 16:48, Alex Sierra wrote: >> Device memory that is cache coherent from device and CPU point of view. >> This is used on platforms that have an advanced system bus (like CAPI >> or CXL). Any page of a process can be migrated to such memory. H

Re: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread srinivas pandruvada
On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_xxx() directly instead of jiffies judgment > for understanding. > > Signed-off-by: Wang Qing Acked-by: Srinivas Pandruvada > --- >  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- >  1 file changed,

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread Jason Gunthorpe
On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote: > ... I'm pretty sure we cannot FOLL_PIN DEVICE_PRIVATE pages Currently the only way to get a DEVICE_PRIVATE page out of the page tables is via hmm_range_fault() and that doesn't manipulate any ref counts. Jason

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread David Hildenbrand
On 11.02.22 17:45, Jason Gunthorpe wrote: > On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote: > >> ... I'm pretty sure we cannot FOLL_PIN DEVICE_PRIVATE pages > > Currently the only way to get a DEVICE_PRIVATE page out of the page > tables is via hmm_range_fault() and that doesn'

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread David Hildenbrand
On 01.02.22 16:48, Alex Sierra wrote: > Device memory that is cache coherent from device and CPU point of view. > This is used on platforms that have an advanced system bus (like CAPI > or CXL). Any page of a process can be migrated to such memory. However, > no one should be allowed to pin such me

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread Felix Kuehling
Am 2022-02-11 um 11:15 schrieb David Hildenbrand: On 01.02.22 16:48, Alex Sierra wrote: Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. H

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-11 Thread Sierra Guiza, Alejandro (Alex)
On 2/11/2022 10:39 AM, David Hildenbrand wrote: On 11.02.22 17:15, David Hildenbrand wrote: On 01.02.22 16:48, Alex Sierra wrote: Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a

Re: [PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread philip yang
On 2022-02-11 11:17 a.m., Alex Sierra wrote: Avoid spam the kernel log on application memory allocation failures. __func__ argument was also removed from dev_fmt macro due to parameter conflicts with dynamic_dev_dbg. Looks good to me. Reviewed-by: P

[PATCH] drm/amdkfd: replace err by dbg print at svm vram migration

2022-02-11 Thread Alex Sierra
Avoid spam the kernel log on application memory allocation failures. __func__ argument was also removed from dev_fmt macro due to parameter conflicts with dynamic_dev_dbg. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 9 + 1 file changed, 5 insertions(+), 4 de

RE: [PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

2022-02-11 Thread Russell, Kent
I can add a guard to be safe. When I checked previously it just returned zeroes, but that might have just been good luck. And I'll remove the mutex too. Thanks! Kent > -Original Message- > From: Quan, Evan > Sent: Thursday, February 10, 2022 11:46 PM > To: Russell, Kent ; amd-gfx@list

RE: [PATCH] drm/amdgpu: no rlcg legacy read in SRIOV case

2022-02-11 Thread Skvortsov, Victor
[AMD Official Use Only] Reviewed-by: Victor Skvortsov Thanks, Victor -Original Message- From: Zhang, Hawking Sent: Friday, February 11, 2022 1:42 AM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander ; Skvortsov, Victor Subject

Re: [RFC] Upstreaming Linux for Nintendo Wii U

2022-02-11 Thread Christophe Leroy
Hi Ash, Le 11/02/2022 à 12:29, Michael Ellerman a écrit : > Ash Logan writes: >> - Like the Wii before it, the Wii U has a small amount of RAM at address >> zero, a gap, then a large amount of RAM at a higher address. Instead of >> the "map everything and reserve the gap" approach of the Wii, we

Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Hans de Goede
Hi, On 2/11/22 10:00, Yehezkel Bernat wrote: > On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello > wrote: >> >> Currently `pci_is_thunderbolt_attached` is used to indicate a device >> is connected externally. >> >> The PCI core now marks such devices as removable and downstream drivers >> can us

Re: [PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:24PM -0600, Mario Limonciello wrote: > USB4 class devices are also removable like Intel Thunderbolt devices. > > Drivers of downstream devices use this information to declare functional > differences in how the drivers perform by knowing that they are conne

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-11 Thread Mika Westerberg
Hi Mario, On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` attribute is currently a dumping ground for a > variety of things. > > Instead use the driver core removable attribute to indicate the > detail a device is attached to a thunderbolt or USB4 chain.

Re: [RFC] Upstreaming Linux for Nintendo Wii U

2022-02-11 Thread Michael Ellerman
Ash Logan writes: > Hello, Hi Ash, I can't really answer all your questions, but I can chime in on one or two things ... > - Right now I've made a new platform (like ps3) rather than joining the > GameCube and Wii in embedded6xx, since that is marked as BROKEN_ON_SMP. > The Wii U is a 3-core sy

Re: [PATCH v2 1/9] thunderbolt: move definition of PCI_CLASS_SERIAL_USB_USB4

2022-02-11 Thread Mika Westerberg
On Thu, Feb 10, 2022 at 04:43:21PM -0600, Mario Limonciello wrote: > This PCI class definition of the USB4 device is currently located only in > the thunderbolt driver. > > It will be needed by a few other drivers for upcoming changes. Move it into > the common include file. > > Acked-by: Alex De

Re: [PATCH 05/12] drm/amd/pm: move the check for dpm enablement to amdgpu_dpm.c

2022-02-11 Thread Lazar, Lijo
On 2/11/2022 1:22 PM, Evan Quan wrote: Instead of checking this in every instance(framework), moving that check to amdgpu_dpm.c is more proper. And that can make code clean and tidy. Signed-off-by: Evan Quan Change-Id: I2f83a3b860e8aa12cc86f119011f520fbe21a301 --- drivers/gpu/drm/amd/amdgp

Re: [PATCH 12/12] drm/amd/pm: revise the implementations for asic reset

2022-02-11 Thread Lazar, Lijo
On 2/11/2022 1:22 PM, Evan Quan wrote: Instead of having an interface for every reset method, we replace them with a new interface which can support all reset methods. Signed-off-by: Evan Quan Change-Id: I4c8a7121dd65c2671085673dd7c13cf7e4286f3d --- drivers/gpu/drm/amd/amdgpu/aldebaran.c

Re: [PATCH v2 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-11 Thread Christian König
Am 11.02.22 um 14:15 schrieb Somalapuram, Amaranath: On 2/11/2022 5:22 PM, Christian König wrote: Am 11.02.22 um 12:47 schrieb Somalapuram Amaranath: List of register to be populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amd

Re: [PATCH v2 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-11 Thread Somalapuram, Amaranath
On 2/11/2022 5:22 PM, Christian König wrote: Am 11.02.22 um 12:47 schrieb Somalapuram Amaranath: List of register to be populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  5 ++   drivers/gpu/drm/amd/am

Re: [PATCH v2 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-11 Thread Christian König
Am 11.02.22 um 12:47 schrieb Somalapuram Amaranath: List of register to be populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 61 +

[PATCH v2 2/2] drm/amdgpu: add reset register trace function on GPU reset

2022-02-11 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 19 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff -

[PATCH v2 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-11 Thread Somalapuram Amaranath
List of register to be populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 61 + 2 files changed, 66 insertions(+) diff --git a/drivers

RE: [PATCH Review 1/1] drm/amdgpu: adjust register address calculation

2022-02-11 Thread Zhou1, Tao
[AMD Official Use Only] With the typo fixed, the patch is: Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Friday, February 11, 2022 6:15 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Clements, John ; > Zhou1, Tao > Cc: Yang, Stanley > Subject: [P

[PATCH Review 1/1] drm/amdgpu: adjust register address calculation

2022-02-11 Thread Stanley . Yang
the UMC_STATUS register is not liner, adjust offset calculation formula to get correct address Change-Id: Ic8926078301848330babf289c4238dc8cbcf313d Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd

Re: [PATCH v11 1/5] drm: improve drm_buddy_alloc function

2022-02-11 Thread Arunpravin
On 10/02/22 9:40 pm, Matthew Auld wrote: > On 27/01/2022 14:11, Arunpravin wrote: >> - Make drm_buddy_alloc a single function to handle >>range allocation and non-range allocation demands >> >> - Implemented a new function alloc_range() which allocates >>the requested power-of-two block

[PATCH V2 11/13] media: tda8083: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/tda8083.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/tda8083.c b/drivers/media/d

[PATCH V2 1/13] block: xen: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/block/xen-blkback/blkback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/

[PATCH V2 10/13] media: stv0299: use time_is_before_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/stv0299.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0299.c b/drivers/med

[PATCH V2 10/13] md: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/md/dm-writecache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index

[PATCH V2 13/13] media: vivid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/test-drivers/vivid/vivid-kthread-cap.c | 3 ++- drivers/media/test-drivers/vivid/vivid-kthread-out.c | 3 ++- drivers/media/test-drivers/vivid/v

[PATCH V2 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/clk/mvebu/armada-37xx-periph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mv

Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Yehezkel Bernat
On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello wrote: > > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello >

[PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-i

[PATCH V2 3/13] gpu: drm: i915: use time_is_after_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/

[PATCH V2 12/13] media: wl128x: use time_is_before_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/radio/wl128x/fmdrv_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drive

Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached`

2022-02-11 Thread Hans de Goede
Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello Thanks, this

Re: [PATCH v2 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

2022-02-11 Thread Alistair Popple
On Thursday, 10 February 2022 10:47:35 PM AEDT David Hildenbrand wrote: > On 10.02.22 12:39, Alistair Popple wrote: > > On Thursday, 10 February 2022 9:53:38 PM AEDT David Hildenbrand wrote: > >> On 07.02.22 05:26, Alistair Popple wrote: > >>> Currently any attempts to pin a device coherent page wi

[PATCH V2 9/13] media: si21xx: use time_is_before_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/media/dvb-frontends/si21xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb

[PATCH V2 6/13] input: serio: use time_is_before_jiffies() instead of jiffies judgment

2022-02-11 Thread Qing Wang
From: Wang Qing It is better to use time_xxx() directly instead of jiffies judgment for understanding. Signed-off-by: Wang Qing --- drivers/input/serio/ps2-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gp

  1   2   >