On 2/16/2022 8:26 PM, Christian König wrote:
Am 16.02.22 um 14:11 schrieb Somalapuram, Amaranath:
On 2/16/2022 3:41 PM, Christian König wrote:
Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by:
Am 17.02.22 um 03:46 schrieb Gu, JiaWei (Will):
[AMD Official Use Only]
Hi Christian,
My same concern is that an additional parameter may affects other drivers which
want to use public drm_sched_init(), and I want to reduce the scope of
affection.
Will it avoid potential compatibility issues
On 2/17/2022 11:15 AM, Mario Limonciello wrote:
The `program_aspm` callback is already guarded for aspm, but the
`enable_aspm` callback doesn't follow the module parameter.
Update it to use the helper `amdgpu_device_should_use_aspm`.
Signed-off-by: Mario Limonciello
Series is
Evaluating `pcie_aspm_enabled` as part of driver probe has the implication
that if one PCIe bridge with an AMD GPU connected doesn't support ASPM
then none of them do. This is an invalid assumption as the PCIe core will
configure ASPM for individual PCIe bridges.
Create a new helper function
The `program_aspm` callback is already guarded for aspm, but the
`enable_aspm` callback doesn't follow the module parameter.
Update it to use the helper `amdgpu_device_should_use_aspm`.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++-
1 file changed, 2
On 2/17/2022 10:28 AM, Limonciello, Mario wrote:
[AMD Official Use Only]
commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled
ASPM
by default but a variety of hardware configurations it turns out that this
caused a regression.
* PPC64LE hardware does not support ASPM at a
On 2/17/2022 8:18 AM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Monday, February 14, 2022 12:04 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ;
rui.hu...@amd.com
Subject: Re: [PATCH 07/12] drm/amd/pm: correct
[AMD Official Use Only]
> > commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled
> ASPM
> > by default but a variety of hardware configurations it turns out that this
> > caused a regression.
> >
> > * PPC64LE hardware does not support ASPM at a hardware level.
> >
On 2/17/2022 8:05 AM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Friday, February 11, 2022 9:40 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ;
rui.hu...@amd.com
Subject: Re: [PATCH 05/12] drm/amd/pm: move the
On 2/17/2022 9:16 AM, Mario Limonciello wrote:
commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled ASPM
by default but a variety of hardware configurations it turns out that this
caused a regression.
* PPC64LE hardware does not support ASPM at a hardware level.
On Wed, Feb 16, 2022 at 10:46 PM Mario Limonciello
wrote:
>
> commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled ASPM
> by default but a variety of hardware configurations it turns out that this
> caused a regression.
>
> * PPC64LE hardware does not support ASPM at a hardware
Hi Dave, Daniel,
Fixes for 5.17.
The following changes since commit 754e0b0e35608ed5206d6a67a791563c631cec07:
Linux 5.17-rc4 (2022-02-13 12:13:30 -0800)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-fixes-5.17-2022-02-16
for you to
if CONFIG_DRM_USE_DYNAMIC_DEBUG=y, use new macro to create the sysfs
bitmap to control drm.debug callsites.
DEFINE_DYNAMIC_DEBUG_CLASSBITS( debug, __drm_debug, "p",
"drm.debug - control summary",
/* inline vector of _ddebug.class_id's to be controlled, max 14 vals */
In order to use dynamic-debug's jump-label optimization in drm-debug,
its clarifying to refine drm_debug_enabled into 3 uses:
1. drm_debug_enabled - legacy, public
2. __drm_debug_enabled - optimized for dyndbg jump-label enablement.
3. _drm_debug_enabled - pr_debug instrumented, observable
1.
drm_print.c calls pr_debug() just once, from __drm_printfn_debug(),
which is a generic/service fn. The callsite is compile-time enabled
by DEBUG in both DYNAMIC_DEBUG=y/n builds.
For dyndbg builds, reverting this callsite back to bare printk is
correcting a few anti-features:
1- callsite is
Add a struct _ddebug ptr to drm_dbg() and drm_dev_dbg() protos.
And upgrade the current use of _dynamic_func_call_no_desc(); ie drop
the '_no_desc', since the factory macro's callees (these 2 functions)
are now expecting the arg.
This lets those functions act more like pr_debug(). It also means
drm_dev_dbg() & drm_dbg() sit below the categorized layer of the DRM
debug API, and implement most of it. These are good places to insert
dynamic-debug jump-label mechanics, allowing DRM to avoid the runtime
cost of drm_debug_enabled().
Set up for this by changing the func names by adding '__'
For CONFIG_DRM_USE_DYNAMIC_DEBUG=y, wrap drm_dbg() & drm_dev_dbg() in
one of dyndbg's Factory macros: _dynamic_func_call_no_desc().
This makes the (~4000) callsites controllable, typically by class:
# 0 is DRM_UT_CORE
#> echo module drm class 0 +p > /proc/dynamic_debug/control
=N: keeps
move site.flag update after the v4pr_info("change") message, and
improve the message to print both old and new flag values.
Heres new form:
dyndbg: changed net/ipv4/tcp.c:2424 [tcp]tcp_recvmsg_locked pT -> _
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 11 ++-
1 file changed,
Hide flags test in a macro.
no functional changes.
Signed-off-by: Jim Cromie
---
include/linux/dynamic_debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 664bb83778d2..106065244f73 100644
---
enum drm_debug_category has 10 "classes", explicitly initialized with
0x-bitmasks which could be simplified as BIT(X)s. But lets go
further: use natural enumeration (int, starting at 0), and do the
BIT(cat) in drm_debug_enabled(cat) at runtime.
While this slightly pessimizes the bit-test, the
This exported fn is effectively obsoleted by Commit:HEAD~2, so remove it.
The export was added here:
commit a2d375eda771 ("dyndbg: refine export, rename to
dynamic_debug_exec_queries()")
commit 4c0d77828d4f ("dyndbg: export ddebug_exec_queries")
Its intent was to allow drm.debug to use the
DEFINE_DYNAMIC_DEBUG_CLASSBITS(fsname, var, bitmap_desc, classes..)
allows users to create a drm.debug style (bitmap) sysfs interface, to
control sets of pr_debug's according to their .class_id's
This wraps existing "class" keyword and behavior:
echo "module drm -p ; module drm class 0 +p ;
DRM defines/uses 10 enum drm_debug_category's to create exclusive
classes of debug messages. To support this directly in dynamic-debug,
add the following:
- struct _ddebug.class_id:4 - 4 bits is enough
- define _DPRINTK_SITE_UNCLASSED 15 - see below
and the query support:
- struct
In https://lore.kernel.org/lkml/20211209150910.ga23...@axis.com/
Vincent's patch commented on, and worked around, a bug toggling
static_branch's, when a 2nd PRINTK-ish flag was added. The bug
results in a premature static_branch_disable when the 1st of 2 flags
was disabled.
The cited commit
drm.debug api provides ~23 macros to issue 10 categories of debug
messages, each enabled by a bit in /sys/module/drm/parameters/debug.
drm_debug_enabled(category) tests these bits at runtime; while cheap
individually, the costs accumulate.
For CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this patchset
commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled ASPM
by default but a variety of hardware configurations it turns out that this
caused a regression.
* PPC64LE hardware does not support ASPM at a hardware level.
CONFIG_PCIEASPM is often disabled on these architectures.
* Some
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Friday, February 11, 2022 9:22 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ;
> rui.hu...@amd.com
> Subject: Re: [PATCH 12/12] drm/amd/pm: revise the implementations for
> asic
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Monday, February 14, 2022 12:04 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ;
> rui.hu...@amd.com
> Subject: Re: [PATCH 07/12] drm/amd/pm: correct the checks for granting gpu
>
[AMD Official Use Only]
Hi Christian,
My same concern is that an additional parameter may affects other drivers which
want to use public drm_sched_init(), and I want to reduce the scope of
affection.
Will it avoid potential compatibility issues if we keep the interface unchanged
and let
Jason Gunthorpe writes:
> On Wed, Feb 16, 2022 at 09:31:03AM +0100, David Hildenbrand wrote:
>> On 16.02.22 03:36, Alistair Popple wrote:
>> > On Wednesday, 16 February 2022 1:03:57 PM AEDT Jason Gunthorpe wrote:
>> >> On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote:
>> >>
>> >>>
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Friday, February 11, 2022 9:40 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ;
> rui.hu...@amd.com
> Subject: Re: [PATCH 05/12] drm/amd/pm: move the check for dpm
> enablement to
[Public]
> -Original Message-
> From: Chen, Guchun
> Sent: Friday, February 11, 2022 4:07 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Lazar, Lijo
> ; Quan, Evan ; Huang, Ray
>
> Subject: RE: [PATCH 05/12] drm/amd/pm: move the check for dpm
>
[Public]
Acked-by: Alex Deucher
From: Tuikov, Luben
Sent: Wednesday, February 16, 2022 5:08 PM
To: amd-gfx@lists.freedesktop.org
Cc: Tuikov, Luben ; Deucher, Alexander
; kbuild-...@lists.01.org ;
linux-ker...@vger.kernel.org ; kernel test robot
Subject:
Fix this ARM warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:664:35: warning: format '%ld'
expects argument of type 'long int', but argument 4 has type 'size_t' {aka
'unsigned int'} [-Wformat=]
Cc: Alex Deucher
Cc: kbuild-...@lists.01.org
Cc: linux-ker...@vger.kernel.org
Reported-by:
From: Yifan Zhang
this patch adds gc 10.3.6 support.
Signed-off-by: Yifan Zhang
Reviewed-by: Alex Deucher
Reviewed-by: Huang Rui
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 ++
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 87 ++-
From: Yifan Zhang
this patch adds support for gmc10.
Signed-off-by: Yifan Zhang
Reviewed-by: Alex Deucher
Reviewed-by: Huang Rui
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c| 3 +++
From: Yifan Zhang
Add below supports:
GFX Coarse Grain Clock Gating(CGCG)
GFX Coarse grain light sleep/deep sleep(CGLS)
GFX Medium Grain Clock Gating(MGCG)
GFX Medium Grain light sleep/deep sleep(MGLS)
GFX Fine Grain Clock Gating(FGCG)
RLC MGLS
CP MGLS
MMHUB Clock Gating
SDMA Clock Gating
HDP
From: Yifan Zhang
This patch adds add nv common init for gc 10.3.6.
Signed-off-by: Yifan Zhang
Reviewed-by: Alex Deucher
Reviewed-by: Huang Rui
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
drivers/gpu/drm/amd/amdgpu/nv.c | 5 +
2
On 2022-02-15 16:44, Alex Deucher wrote:
> From: Leo Li
>
> Initialize DMUB for DCN316. Use same funcs as DCN31 for
> DCN316.
>
> Acked-by: Prike Liang
> Signed-off-by: Leo Li
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
>
On Wed, Feb 16, 2022 at 11:56:51AM -0500, Felix Kuehling wrote:
> In the case of DEVICE_COHERENT memory, the pfns correspond to real physical
> memory addresses. I don't think they have those PFN_DEV|PFN_MAP bits set.
So do DAX pages. The PTE flag does several things. As this would be
the first
Am 2022-02-15 um 20:42 schrieb Harish Kasiviswanathan:
Print alloc node, peer node and memory domain when peer map fails. This
is more useful
Signed-off-by: Harish Kasiviswanathan
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff
Am 2022-02-15 um 21:01 schrieb Jason Gunthorpe:
On Tue, Feb 15, 2022 at 05:49:07PM -0500, Felix Kuehling wrote:
Userspace does
1) mmap(MAP_PRIVATE) to allocate anon memory
2) something to trigger migration to install a ZONE_DEVICE page
3) munmap()
Who decrements the refcout on the
On 2/16/2022 08:44, Alex Deucher wrote:
On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg
wrote:
Hi all,
On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote:
On 2/15/2022 01:29, Lukas Wunner wrote:
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
On Tue, Feb 15, 2022 at 9:35 PM James D. Turner
wrote:
>
> Hi Alex,
>
> > I guess just querying the ATIF method does something that negatively
> > influences the windows driver in the guest. Perhaps the platform
> > thinks the driver has been loaded since the method has been called so
> > it
On 2022-02-15 16:44, Alex Deucher wrote:
From: Prike Liang
Add 3.1.6 DCE IP and assign relevant sw DM function for the new DCE.
Signed-off-by: Prike Liang
Reviewed-by: Alex Deucher
Reviewed-by: Leo Li
Thanks!
Signed-off-by: Alex Deucher
---
On 2022-02-15 16:44, Alex Deucher wrote:
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/Makefile
b/drivers/gpu/drm/amd/display/dc/gpio/Makefile
index c5ddade8b187..a1bf2128feba 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/gpio/Makefile
@@
On 2022-02-16 05:46, Somalapuram, Amaranath wrote:
On 2/15/2022 10:09 PM, Andrey Grodzovsky wrote:
On 2022-02-15 05:12, Somalapuram Amaranath wrote:
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
On 2022-02-15 16:44, Alex Deucher wrote:
From: Prike Liang
- set DC version
- add construct/destroy dc clock management function
- register dcn interrupt handler
Signed-off-by: Prike Liang
Acked-by: Leo Li
Reviewed-by: Leo Li
Thanks.
Signed-off-by: Alex Deucher
---
On Wed, Feb 16, 2022 at 10:10 AM Mario Limonciello
wrote:
>
> The message `Voltage value looks like a Leakage ID but it's not patched`
> shows up as an error on Dell Precision 3540. This doesn't cause functional
> problems and should be downgraded to info.
>
> Link:
The message `Voltage value looks like a Leakage ID but it's not patched`
shows up as an error on Dell Precision 3540. This doesn't cause functional
problems and should be downgraded to info.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1162
Signed-off-by: Mario Limonciello
---
Am 16.02.22 um 14:11 schrieb Somalapuram, Amaranath:
On 2/16/2022 3:41 PM, Christian König wrote:
Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
Am 16.02.22 um 14:55 schrieb Somalapuram, Amaranath:
On 2/16/2022 6:47 PM, Lazar, Lijo wrote:
On 2/16/2022 4:39 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 4:13 PM, Lazar, Lijo wrote:
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On
Hi all,
On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote:
> On 2/15/2022 01:29, Lukas Wunner wrote:
> > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
> > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> > > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2
On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg
wrote:
>
> Hi all,
>
> On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote:
> > On 2/15/2022 01:29, Lukas Wunner wrote:
> > > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote:
> > > >
On Tue, Feb 15, 2022 at 6:47 PM Tom St Denis wrote:
>
> Needed by umr to detect if ip discovered ASIC is an APU or not.
>
> (v2): Remove asic type from packet it's not strictly needed
>
> Signed-off-by: Tom St Denis
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 -
> 1 file
On 2/16/2022 6:47 PM, Lazar, Lijo wrote:
On 2/16/2022 4:39 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 4:13 PM, Lazar, Lijo wrote:
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
On Wed, Feb 16, 2022 at 09:31:03AM +0100, David Hildenbrand wrote:
> On 16.02.22 03:36, Alistair Popple wrote:
> > On Wednesday, 16 February 2022 1:03:57 PM AEDT Jason Gunthorpe wrote:
> >> On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote:
> >>
> >>> Device private and device
On 16.02.22 03:36, Alistair Popple wrote:
> On Wednesday, 16 February 2022 1:03:57 PM AEDT Jason Gunthorpe wrote:
>> On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote:
>>
>>> Device private and device coherent pages are not marked with pte_devmap and
>>> they
>>> are backed by a
On 2/16/2022 4:39 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 4:13 PM, Lazar, Lijo wrote:
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection
On 2/16/2022 3:41 PM, Christian König wrote:
Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
On Tue, 15 Feb 2022 at 16:37, Simon Ser wrote:
>
> On Tuesday, February 15th, 2022 at 15:38, Emil Velikov
> wrote:
>
> > On Tue, 15 Feb 2022 at 13:55, Simon Ser wrote:
> > >
> > > On Tuesday, February 15th, 2022 at 13:04, Emil Velikov
> > > wrote:
> > >
> > > > Greetings everyone,
> > > >
>
Am 16.02.22 um 08:22 schrieb Jiawei Gu:
Now scheduler contains device ptr. Add it so scheduler printing can be
more reader-friendly under multiple GPU scenario.
Signed-off-by: Jiawei Gu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 2/16/2022 4:13 PM, Lazar, Lijo wrote:
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram
Am 16.02.22 um 11:43 schrieb Lazar, Lijo:
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram
On 2/15/2022 10:09 PM, Andrey Grodzovsky wrote:
On 2022-02-15 05:12, Somalapuram Amaranath wrote:
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 -
On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote:
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
On 2/16/2022 3:45 PM, Lazar, Lijo wrote:
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 +
2
Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath:
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 +
2
Am 16.02.22 um 01:38 schrieb Felix Kuehling:
Reference:
https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
CC: Changcheng Deng
Signed-off-by: Felix Kuehling
Reviewed-by: Christian König
---
include/uapi/linux/kfd_ioctl.h | 2 +-
1 file
Dump the list of register values to trace event on GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16
2 files changed, 34 insertions(+), 1 deletion(-)
diff
List of register populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 +
2 files changed, 100 insertions(+)
diff --git
[AMD Official Use Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Zhou1, Tao
Sent: Wednesday, February 16, 2022 15:25
To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ;
Yang, Stanley ; Chai, Thomas
Cc: Zhou1, Tao
Subject: [PATCH] drm/amdkfd: add return
[AMD Official Use Only]
With my concern in comment fixed, the series is:
Reviewed-by: Tao Zhou
> -Original Message-
> From: amd-gfx On Behalf Of yipechai
> Sent: Wednesday, February 16, 2022 4:08 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhou1, Tao ; Zhang, Hawking
> ; Clements,
On Tue, Feb 15, 2022 at 05:49:07PM -0500, Felix Kuehling wrote:
> > Userspace does
> > 1) mmap(MAP_PRIVATE) to allocate anon memory
> > 2) something to trigger migration to install a ZONE_DEVICE page
> > 3) munmap()
> >
> > Who decrements the refcout on the munmap?
> >
> > When a
On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote:
> Device private and device coherent pages are not marked with pte_devmap and
> they
> are backed by a struct page. The only way of inserting them is via
> migrate_vma.
> The refcount is decremented in zap_pte_range() on munmap()
Hi Wang,
On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote:
> From: Wang Qing
>
> Use the helper function time_is_{before,after}_jiffies() to improve
> code readability.
I applied changes by Danilo Krummrich converting the driver to use
ktime_t (see
Jason Gunthorpe writes:
> On Tue, Feb 15, 2022 at 04:35:56PM -0500, Felix Kuehling wrote:
>>
>> On 2022-02-15 14:41, Jason Gunthorpe wrote:
>> > On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote:
>> > > On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote:
>> > > > >
Hi Alex,
> I guess just querying the ATIF method does something that negatively
> influences the windows driver in the guest. Perhaps the platform
> thinks the driver has been loaded since the method has been called so
> it enables certain behaviors that require ATIF interaction that never
>
On Wednesday, 16 February 2022 1:03:57 PM AEDT Jason Gunthorpe wrote:
> On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote:
>
> > Device private and device coherent pages are not marked with pte_devmap and
> > they
> > are backed by a struct page. The only way of inserting them is
1. Move calling ras block instance members from module internal
function to the top calling xxx_ras_late_init.
2. Module internal function calls can only use parameter variables
of xxx_ras_late_init instead of ras block instance members.
Signed-off-by: yipechai
---
1. Define amdgpu_ras_block_late_init_default in amdgpu_ras.c as
.ras_late_init common function, which is called when
.ras_late_init of ras block isn't initialized.
2. Remove the code of using amdgpu_ras_block_late_init to
initialize .ras_late_init in ras blocks.
Signed-off-by: yipechai
Define amdgpu_ras_late_init to call all ras blocks' .ras_late_init.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c| 44 --
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c| 25
Remove redundant calls of ras_late_init in mca ras block.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_mca.h | 3 ---
drivers/gpu/drm/amd/amdgpu/mca_v3_0.c | 21
Remove redundant calls of ras_late_init in hdp ras block.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 5 -
drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c | 2 +-
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git
Remove redundant calls of ras_late_init in mmhub ras block.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.h | 1 -
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
4
Modify .ras_late_init function pointer parameter so that
it can remove redundant intermediate calls in some ras blocks.
Signed-off-by: yipechai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 2
88 matches
Mail list logo
