Only GFX ring, SDMA ring and VCN decode ring support secure submission
at the moment.
Suggested-by: Christian König
Signed-off-by: Lang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 +
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
drive
From: "Tianci.Yin"
[why]
On Renoir, vcn ring test failed on the second time insmod in the reload
test. After invetigation, it proves that vcn only can disable dpg under
dpg unpause mode (dpg unpause mode is default for dec only, dpg pause
mode is for dec/enc).
[how]
unpause dpg in dpg stopping p
On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:
> drm: Add drm_mode_init()
> drm/bridge: Use drm_mode_copy()
> drm/imx: Use drm_mode_duplicate()
> drm/panel: Use drm_mode_duplicate()
> drm/vc4: Use drm_mode_copy()
These have been pushed to drm-misc-next.
> drm/amdgpu: Re
On 3/11/22 20:06, jim.cro...@gmail.com wrote:
> On Fri, Mar 11, 2022 at 12:06 PM Jason Baron wrote:
>>
>>
>>
>> On 3/10/22 23:47, Jim Cromie wrote:
>>> DRM defines/uses 10 enum drm_debug_category's to create exclusive
>>> classes of debug messages. To support this directly in dynamic-debug,
>>
On Mon, Mar 14, 2022 at 5:10 PM Yongqiang Sun wrote:
>
> MI25 SRIOV guest driver loading failed due to allocate
> memory overlaps with private memory area.
maybe instead of "private memory area", say something like "firmware
reserved area".
> Add below change to fix the issue:
> 1. Allocate stol
MI25 SRIOV guest driver loading failed due to allocate
memory overlaps with private memory area.
Add below change to fix the issue:
1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid
the memory overlap.
2. Move allocate reserve allocation to vbios allocation since both the
two
On Mon, Mar 14, 2022 at 3:35 PM Christian König
wrote:
>
> Am 14.03.22 um 19:54 schrieb Yongqiang Sun:
> > [Why]
> > Memory access violation will happen in case of allocate stolen vga
> > memory with size isn't 0.
> >
> > [How]
> > when allocating stolen vga memory, use fw vram offset as the start
On Mon, Mar 14, 2022 at 3:41 PM Christian König
wrote:
>
> Am 14.03.22 um 19:54 schrieb Yongqiang Sun:
> > [Why]
> > MI25 SRIOV guest driver loading failed due to allocate
> > memory overlaps with private memory area.
> >
> > [How]
> > 1. Allocate stolen reserved memory for MI25 SRIOV specifically
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski :
On Mon, 14 Mar 2022 12:53:24 +0100 you wrote:
> Various spelling mistakes in comments.
> Detected with the help of Coccinelle.
>
> ---
>
> drivers/base/devres.c |4 ++--
> drive
Am 2022-03-14 um 10:50 schrieb Philip Yang:
Migrate vram to ram may fail to find the vma if process is exiting
and vma is removed, evict svm bo worker sets prange->svm_bo to NULL
and warn svm_bo ref count != 1 only if migrating vram to ram
successfully.
Signed-off-by: Philip Yang
---
drivers/
Am 2022-03-14 um 10:50 schrieb Philip Yang:
Migrate vram to ram may fail to find the vma if process is exiting
and vma is removed, evict svm bo worker sets prange->svm_bo to NULL
and warn svm_bo ref count != 1 only if migrating vram to ram
successfully.
Signed-off-by: Philip Yang
---
drivers/
Am 14.03.22 um 19:54 schrieb Yongqiang Sun:
[Why]
MI25 SRIOV guest driver loading failed due to allocate
memory overlaps with private memory area.
[How]
1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid
the memory overlap.
2. Move allocate reserve allocation to vbios alloca
handle a situation in the condition order-- == min_order,
when order = 0, leading to order = -1, it now won't exit
the loop. To avoid this problem, added a order check in
the same condition, (i.e) when order is 0, we return
-ENOSPC
Signed-off-by: Arunpravin
---
drivers/gpu/drm/drm_buddy.c | 2 +-
Am 14.03.22 um 19:54 schrieb Yongqiang Sun:
[Why]
Memory access violation will happen in case of allocate stolen vga
memory with size isn't 0.
[How]
when allocating stolen vga memory, use fw vram offset as the start point
instead of hard code value 0.
Please stop separating commit message into
handle instances when size is not aligned with the min_page_size.
Unigine Heaven has allocation requests for example required pages
are 161 and alignment request is 128. To allocate the left over
33 pages, continues the iteration to find the order value which
is 5 and 0 and when it compares with mi
On 10/03/22 8:59 pm, Matthew Auld wrote:
> On 10/03/2022 14:47, Arunpravin wrote:
>>
>>
>> On 08/03/22 10:31 pm, Matthew Auld wrote:
>>> On 08/03/2022 13:59, Arunpravin wrote:
On 07/03/22 10:11 pm, Matthew Auld wrote:
> On 07/03/2022 14:37, Arunpravin wrote:
>> place BUG_O
[Why]
MI25 SRIOV guest driver loading failed due to allocate
memory overlaps with private memory area.
[How]
1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid
the memory overlap.
2. Move allocate reserve allocation to vbios allocation since both the
two functions are doing si
[Why]
Memory access violation will happen in case of allocate stolen vga
memory with size isn't 0.
[How]
when allocating stolen vga memory, use fw vram offset as the start point
instead of hard code value 0.
Signed-off-by: Yongqiang Sun
Change-Id: I7c555a6c1fb4b3fa8685753b4bdcbe215f89ea1e
---
d
I'm not sure I understand this change. It looks like you will check the
RAS poison status on every UTCL2 VM fault? Is that because there is no
dedicated interrupt source or client ID to distinguish UTCL2 poison
consumption from VM faults?
Why is kfd_signal_poison_consumed_event not done for UT
Am 2022-03-14 um 03:03 schrieb Tao Zhou:
Other parameters can be gotten from ih_ring_entry, so only inputting
ih_ring_entry is enough.
I'm not sure what's the reason for this change. You remove one
parameter, but end up duplicating the SOC15_..._FROM_IH_RING_ENTRY
translations. It doesn't loo
Thanks!
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2022-03-14 10:04, Dan Carpenter wrote:
> Smatch complains that the dev_err_ratelimited() is indented one tab more
> than the surrounding lines.
>
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> __smu_cmn_reg_print_error()
On Mon, 14 Mar 2022 10:23:27 -0400
Alex Deucher wrote:
> On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> >
> > On Thu, 10 Mar 2022 11:56:41 -0800
> > Rob Clark wrote:
> >
> > > For something like just notifying a compositor that a gpu crash
> > > happened, perhaps drm_event is more su
Migrate vram to ram may fail to find the vma if process is exiting
and vma is removed, evict svm bo worker sets prange->svm_bo to NULL
and warn svm_bo ref count != 1 only if migrating vram to ram
successfully.
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 27 +
On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
>
> On Thu, 10 Mar 2022 11:56:41 -0800
> Rob Clark wrote:
>
> > For something like just notifying a compositor that a gpu crash
> > happened, perhaps drm_event is more suitable. See
> > virtio_gpu_fence_event_create() for an example of adding
On Thu, Mar 10, 2022 at 9:32 PM Lang Yu wrote:
>
> On 03/10/ , Christian König wrote:
> > Ok, thanks.
> >
> > Lang is that case your patch should work fine.
> >
> > Just add another patch with a check for the encode case to reject any CS
> > with TMZ buffers in it.
>
> Only VCN decode ring is care
Smatch complains that the dev_err_ratelimited() is indented one tab more
than the surrounding lines.
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
__smu_cmn_reg_print_error() warn: inconsistent indenting
It looks like it's not a bug, just that the indenting needs to be clea
[Public]
Hi all,
This week this patchset was tested on the following systems:
HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p
60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI),
1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)
Leno
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
b/dr
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index c
Hi all,
I've confirmed that changing the `amdgpu_atif_pci_probe_handle` function
to do nothing does make the GPU work properly in the VM. I started with
f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)")
and changed the function implementation to:
static bool amdgpu_atif_pci_
Hi All,
On 3/9/22 18:53, Rajat Jain wrote:
> On Wed, Mar 9, 2022 at 7:06 AM Sean Paul wrote:
>>
>> From: Sean Paul
>>
>> This patch adds the necessary hooks to make amdgpu aware of privacy
>> screens. On devices with privacy screen drivers (such as thinkpad-acpi),
>> the amdgpu driver will defer
On 3/10/22 23:47, Jim Cromie wrote:
> DRM defines/uses 10 enum drm_debug_category's to create exclusive
> classes of debug messages. To support this directly in dynamic-debug,
> add the following:
>
> - struct _ddebug.class_id:4 - 4 bits is enough
> - define _DPRINTK_SITE_UNCLASSED 15 - see be
On 10.03.22 18:26, Alex Sierra wrote:
> DEVICE_COHERENT pages introduce a subtle distinction in the way
> "normal" pages can be used by various callers throughout the kernel.
> They behave like normal pages for purposes of mapping in CPU page
> tables, and for COW. But they do not support LRU lists
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
---
drivers/base/devres.c |4 ++--
drivers/clk/qcom/gcc-sm6125.c |2 +-
drivers/clk/ti/clkctrl.c|2 +-
drivers/gpu/drm/amd/amdg
Various spelling mistakes in comments.
Detected with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amd
On 3/10/22 23:47, Jim Cromie wrote:
> In
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211209150910.ga23...@axis.com/__;!!GjvTz_vk!HGKKoni4RVdEBgv_V0zPSNSX428bpf02zkCy2WbeQkBdVtp1QJqGX-lJYlRDGg$
>
>
> Vincent's patch commented on, and worked around, a bug toggling
> static_bra
Never mind Tao. I guess you just want to leverage client_id to differentiate
sdma int source from the default, right? Then might consider to explicitly call
out the UTCL2_FAULT source.
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Zhang,
Hawking
Sent: Monday, March 14
[AMD Official Use Only]
Copy Felix
@@ -119,10 +121,14 @@ static void event_interrupt_poison_consumption(struct
kfd_dev *dev,
break;
case SOC15_INTSRC_SDMA_ECC:
default:
+ if (client_id == SOC15_IH_CLIENTID_UTCL2)
+ ret = kfd_dqm
On 3/14/2022 12:33 PM, Tao Zhou wrote:
Do RAS page retirement and use gpu reset as fallback in utcl2
fault handler.
Signed-off-by: Tao Zhou
---
.../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/gp
On 3/14/2022 12:33 PM, Tao Zhou wrote:
Add help functions to check and clear RAS utcl2 poison status.
Signed-off-by: Tao Zhou
---
.../drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 28 ++-
.../gpu/drm/amd/include/kgd_kfd_interface.h | 3 ++
2 files changed, 30 insertions(
Am 14.03.22 um 03:46 schrieb Lang Yu:
Only ring GFX, SDMA and VCN_DEC support secure submission at the moment.
Signed-off-by: Lang Yu
it would be nicer if we have that as flag in ring->funcs, but that way
works for now as well.
Reviewed-by: Christian König
Thanks,
Christian.
---
driv
Am 14.03.22 um 03:45 schrieb Lang Yu:
It is a hardware issue that VCN can't handle a GTT
backing stored TMZ buffer on CHIP_RAVEN series ASIC.
Move such a TMZ buffer to VRAM domain before command
submission as a wrokaround.
v2:
- Use patch_cs_in_place callback.
v3:
- Bail out early if unsec
Add help functions to check and clear RAS utcl2 poison status.
Signed-off-by: Tao Zhou
---
.../drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 28 ++-
.../gpu/drm/amd/include/kgd_kfd_interface.h | 3 ++
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
Do RAS page retirement and use gpu reset as fallback in utcl2
fault handler.
Signed-off-by: Tao Zhou
---
.../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c
b/drive
Other parameters can be gotten from ih_ring_entry, so only inputting
ih_ring_entry is enough.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v
45 matches
Mail list logo