[PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

2022-03-21 Thread Tao Zhou
Print the status out when it passes, and also tell user gpu reset is triggered when we fall back to legacy way. v2: make the message more explicit. v3: change succeeds to succeeded. replace pr_warn with dev_warn. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c |

Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

2022-03-21 Thread Paul Menzel
Dear Tao, Am 22.03.22 um 04:51 schrieb Zhou1, Tao: -Original Message- From: Paul Menzel Sent: Tuesday, March 22, 2022 11:42 AM […] Am 22.03.22 um 04:29 schrieb Tao Zhou: Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

2022-03-21 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Paul Menzel > Sent: Tuesday, March 22, 2022 11:42 AM > To: Zhou1, Tao > Cc: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Kuehling, Felix ; Yang, > Stanley ; Chai, Thomas ; > Lazar, Lijo > Subject: Re: [PATCH] drm/amdkfd: print

Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

2022-03-21 Thread Paul Menzel
Dear Tao, Thank you for rerolling the pacth. Am 22.03.22 um 04:29 schrieb Tao Zhou: Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy way. The verb *fall back* is written with a space. v2: make the message more explicitly. explicit

[PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v3)

2022-03-21 Thread Tao Zhou
Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy way. v2: make the message more explicitly. v3: change succeeds to succeeded. replace pr_warn with dev_info. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 21, 2022 7:21 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Kuehling, Felix > ; Yang, Stanley ; Chai, > Thomas > Subject: Re: [PATCH] drm/amdkfd: print unmap queue status

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Zhou1, Tao
[AMD Official Use Only] > -Original Message- > From: Paul Menzel > Sent: Monday, March 21, 2022 6:47 PM > To: Zhou1, Tao > Cc: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Kuehling, Felix ; Yang, > Stanley ; Chai, Thomas > Subject: Re: [PATCH] drm/amdkfd: print unmap queue

Re: [PATCH 00/22] drm: Review of mode copies

2022-03-21 Thread Ville Syrjälä
On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > wrote: > > > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > > drm: Add drm_mode_init() > > > drm/bridge: Use drm_mode_copy() > > > drm/imx: Use

Re: Bug#1005005: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Diederik de Haas
On maandag 21 maart 2022 19:49:56 CET Dominique Dumont wrote: > On Monday, 21 March 2022 09:57:59 CET Thorsten Leemhuis wrote: > > Dominique/Salvatore/Eric, what's the status of this regression? > > According to the debian bug tracker the problem is solved with 5.16 and > > 5.17, but was 5.15 ever

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Thorsten Leemhuis
On 21.03.22 19:49, Dominique Dumont wrote: > On Monday, 21 March 2022 09:57:59 CET Thorsten Leemhuis wrote: >> Dominique/Salvatore/Eric, what's the status of this regression? >> According to the debian bug tracker the problem is solved with 5.16 and >> 5.17, but was 5.15 ever fixed? > > I don't

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Dominique Dumont
Hi On Monday, 21 March 2022 09:57:59 CET Thorsten Leemhuis wrote: > Dominique/Salvatore/Eric, what's the status of this regression? > According to the debian bug tracker the problem is solved with 5.16 and > 5.17, but was 5.15 ever fixed? I don't think so. On kernel side, the commit fixing this

[RFC] Add KFD available memory ioctl

2022-03-21 Thread Daniel Phillips
Hi all, This patch adds a new KFD ioctl to return the largest possible memory size that can be allocated as a buffer object by the existing kfd_ioctl_alloc_memory_of_gpu. It attempts to use exactly the same accept/reject criteria as kfd_ioctl_alloc_memory_of_gpu, so that allocating a new buffer

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-21 Thread Rob Clark
On Mon, Mar 21, 2022 at 2:30 AM Christian König wrote: > > Am 18.03.22 um 16:12 schrieb Rob Clark: > > On Fri, Mar 18, 2022 at 12:42 AM Christian König > > wrote: > >> Am 17.03.22 um 18:31 schrieb Rob Clark: > >>> On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote: > [SNIP] > > (At

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Thorsten Leemhuis
On 21.03.22 13:07, Éric Valette wrote: > My problem has never been fixed. > > The proposed patch has been applied to 5.15. I do not remerber which version > 28 maybe. > > I still have à RIP in pm_suspend. Did not test the Last two 15 versions. > > I can leave with 5.10 est using own compiled

Re: [PATCH] drm/amd/display: Fix p-state allow debug index on dcn31

2022-03-21 Thread Harry Wentland
On 2022-03-18 15:00, Nicholas Kazlauskas wrote: > [Why] > It changed since dcn30 but the hubbub31 constructor hasn't been > modified to reflect this. > > [How] > Update the value in the constructor to 0x6 so we're checking the right > bits for p-state allow. > > It worked before by accident, but

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-21 Thread Daniel Vetter
On Fri, Mar 18, 2022 at 08:12:54AM -0700, Rob Clark wrote: > On Fri, Mar 18, 2022 at 12:42 AM Christian König > wrote: > > > > Am 17.03.22 um 18:31 schrieb Rob Clark: > > > On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote: > > >> [SNIP] > > >>> (At some point, I'd like to use scheduler for

[PATCH 18/23] drm/amdgpu: remove dma_resv workaround

2022-03-21 Thread Christian König
We can now add multiple writers to the dma_resv object. Also enable the check for not adding containers in dma_resv.c again. Signed-off-by: Christian König Cc: amd-gfx@lists.freedesktop.org --- drivers/dma-buf/dma-resv.c | 6 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h |

[PATCH 15/23] drm/amdgpu: use dma_resv_get_singleton in amdgpu_pasid_free_cb

2022-03-21 Thread Christian König
Makes the code a bit more simpler. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git

[PATCH 09/23] drm/amdgpu: use dma_resv_for_each_fence for CS workaround

2022-03-21 Thread Christian König
Get the write fence using dma_resv_for_each_fence instead of accessing it manually. Signed-off-by: Christian König Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 08/23] drm/radeon: stop using dma_resv_excl_fence

2022-03-21 Thread Christian König
Instead use the new dma_resv_get_singleton function. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_display.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 4/7] drm/amdgpu: rework TLB flushing

2022-03-21 Thread philip yang
On 2022-03-21 5:33 a.m., Christian König wrote: Am 18.03.22 um 16:45 schrieb philip yang: On 2022-03-17 9:50 a.m., Christian König wrote: [SNIP] @@ -890,9 +929,20 @@ int

Re: [PATCH 7/7] drm/amdgpu: remove table_freed param from the VM code

2022-03-21 Thread philip yang
On 2022-03-17 9:50 a.m., Christian König wrote: Better to leave the decision when to flush the VM changes in the TLB to the VM code. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-

Re: [PATCH] drm/amdgpu/vcn: Correct the register setting for vcn1

2022-03-21 Thread Paul Menzel
Dear Emily, Am 21.03.22 um 09:26 schrieb Emily Deng: Correct the code error for setting register UVD_GFX10_ADDR_CONFIG. Need to use inst_idx, or it only will set VCN0. Please add a Fixes tag. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 4 ++-- 1 file changed,

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Éric Valette
My problem has never been fixed. The proposed patch has been applied to 5.15. I do not remerber which version 28 maybe. I still have à RIP in pm_suspend. Did not test the Last two 15 versions. I can leave with 5.10 est using own compiled kernels. Thanks for asking. 21 mars 2022 09:58:01

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-03-21 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. Dominique/Salvatore/Eric, what's the status of this regression? According to the debian bug tracker the problem is solved with 5.16 and 5.17, but was 5.15 ever fixed? Ciao,

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-21 Thread James Turner
>>> Right, interference from host drivers and pre-boot environments is >>> always a concern with GPU assignment in particular. AMD GPUs have a >>> long history of poor behavior relative to things like PCI secondary >>> bus resets which we use to try to get devices to clean, reusable >>> states for

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-21 Thread Hans de Goede
Hi, On 3/20/22 21:11, Rajat Jain wrote: > () Hello Hans, Sean, > > > > On Fri, Mar 11, 2022 at 4:12 AM Hans de Goede wrote: >> >> Hi All, >> >> On 3/9/22 18:53, Rajat Jain wrote: >>> On Wed, Mar 9, 2022 at 7:06 AM Sean Paul wrote: From: Sean Paul This patch adds the

Re: [PATCH] drm/amdgpu/vcn: Correct the register setting for vcn1

2022-03-21 Thread James Zhu
ThispatchisReviewed-by:JamesZhu On 2022-03-21 4:26 a.m., Emily Deng wrote: Correct the code error for setting register UVD_GFX10_ADDR_CONFIG. Need to use inst_idx, or it only will set VCN0. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 4 ++-- 1 file changed, 2

RE: [PATCH] amd/display: set backlight only if required

2022-03-21 Thread S, Shirish
[AMD Official Use Only] Ping! Regards, Shirish S -Original Message- From: S, Shirish Sent: Monday, March 14, 2022 12:24 PM To: Wentland, Harry ; S, Shirish ; Wentland, Harry ; Kazlauskas, Nicholas ; Lakha, Bhawanpreet Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Lazar, Lijo
On 3/21/2022 3:08 PM, Tao Zhou wrote: Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy way. v2: make the message more explicitly. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 11 +++ 1 file

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, March 21, 2022 17:38 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd:

Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Paul Menzel
Dear Tao, Thank you for the patch. Am 21.03.22 um 10:38 schrieb Tao Zhou: Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy way. v2: make the message more explicitly. Signed-off-by: Tao Zhou ---

[PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Tao Zhou
Print the status out when it passes, and also tell user gpu reset is triggered when we fallback to legacy way. v2: make the message more explicitly. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)

Re: [PATCH 4/7] drm/amdgpu: rework TLB flushing

2022-03-21 Thread Christian König
Am 18.03.22 um 16:45 schrieb philip yang: On 2022-03-17 9:50 a.m., Christian König wrote: [SNIP] @@ -890,9 +929,20 @@ int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev, r = vm->update_funcs->commit(, fence); + if (!unlocked && (!(flags & AMDGPU_PTE_VALID) ||

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-21 Thread Christian König
Am 18.03.22 um 16:12 schrieb Rob Clark: On Fri, Mar 18, 2022 at 12:42 AM Christian König wrote: Am 17.03.22 um 18:31 schrieb Rob Clark: On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote: [SNIP] (At some point, I'd like to use scheduler for the replay, and actually use

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption

2022-03-21 Thread Zhang, Hawking
[AMD Official Use Only] Let's explicitly call out RAS poison consumption, unmap queue flow succeed: client id %d\n And RAS poison consumption, fallback to gpu reset flow: client id %d\n Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, March 21, 2022 16:21 To:

[PATCH] drm/amdgpu/vcn: Correct the register setting for vcn1

2022-03-21 Thread Emily Deng
Correct the code error for setting register UVD_GFX10_ADDR_CONFIG. Need to use inst_idx, or it only will set VCN0. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c

[PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption

2022-03-21 Thread Tao Zhou
Print the status out when it passes, gpu reset message can be observed when unmap queue fails. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] drm: add a check to verify the size alignment

2022-03-21 Thread Paul Menzel
Dear Arunpravin, Am 21.03.22 um 06:59 schrieb Arunpravin Paneer Selvam: add a simple check to reject any size not aligned to the min_page_size. Nit: I’d start sentences with a capital letter. Could you please add a summary of the discussion to the commit message, so the question “Why?” is

Re: [PATCH Review 1/1] drm/amdgpu/pm: add asic smu support check

2022-03-21 Thread Paul Menzel
Dear Stanley, Thank you for your patch. Am 21.03.22 um 06:45 schrieb Stanley.Yang: Some nits: Could you please remove the dot from the name: $ git config --global user.name "Stanley Yang" $ git commit --amend -s --author="Stanley Yang " The prefix drm/amd/pm seems to be more

Re: [PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-21 Thread Arunpravin Paneer Selvam
On 16/03/22 6:02 pm, Christian König wrote: > Am 16.03.22 um 12:31 schrieb Matthew Auld: >> On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote: >>> handle a situation in the condition order-- == min_order, >>> when order = 0 and min_order = 0, leading to order = -1, >>> it now won't exit the

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-21 Thread Arunpravin Paneer Selvam
On 16/03/22 12:28 pm, Paul Menzel wrote: > Dear Arunprivin, > > > Am 16.03.22 um 07:49 schrieb Arunpravin Paneer Selvam: > >> On 15/03/22 9:14 pm, Paul Menzel wrote: > >>> Am 15.03.22 um 16:42 schrieb Arunpravin: >>> On 15/03/22 2:35 pm, Paul Menzel wrote: >>> > Am 15.03.22 um

RE: [PATCH Review 1/1] drm/amdgpu/pm: add asic smu support check

2022-03-21 Thread Quan, Evan
[AMD Official Use Only] Reviewed-by: Evan Quan > -Original Message- > From: Stanley.Yang > Sent: Monday, March 21, 2022 1:46 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao ; Li, > Candice ; Quan, Evan > Cc: Yang, Stanley > Subject: [PATCH Review 1/1]

[PATCH] drm: add a check to verify the size alignment

2022-03-21 Thread Arunpravin Paneer Selvam
add a simple check to reject any size not aligned to the min_page_size. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/drm_buddy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index 72f52f293249..b503c88786b0