Re: [PATCH] drm/amdkfd: shrink bitmap size in struct svm_validate_context

2022-04-11 Thread Felix Kuehling
Am 2022-04-11 um 23:06 schrieb Lang Yu: A MAX_GPU_INSTANCE bits bitmap will suffice. Signed-off-by: Lang Yu Thanks for catching that. The patch is Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] amdgpu/pm: Clarify documentation of error handling in send_smc_mesg

2022-04-11 Thread Lazar, Lijo
On 4/12/2022 9:38 AM, Darren Powell wrote: Contrary to the smu_cmn_send_smc_msg_with_param documentation, two cases exist where messages are silently dropped with no error returned to the caller. These cases occur in unusual situations where either: 1. the message target is a virtual GPU,

[PATCH 1/1] amdgpu/pm: Clarify documentation of error handling in send_smc_mesg

2022-04-11 Thread Darren Powell
Contrary to the smu_cmn_send_smc_msg_with_param documentation, two cases exist where messages are silently dropped with no error returned to the caller. These cases occur in unusual situations where either: 1. the message target is a virtual GPU, or 2. a PCI recovery is underway and the HW is

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Modem, Bhanuprakash
On Tue-12-04-2022 08:37 am, Murthy, Arun R wrote: +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() As we are using DEFINE_SHOW_ATTRIBUTE() to define file_operations, this function name must be _show().

[PATCH v2 5/5] drm/radeon: Use TTM builtin resource manager debugfs code

2022-04-11 Thread Zack Rusin
From: Zack Rusin Switch to using the TTM resource manager debugfs helpers. The functionality is largely the same. The TTM resource managers need to stay valid for as long as the drm debugfs_root is valid. Signed-off-by: Zack Rusin Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc:

[PATCH v2 3/5] drm/amdgpu: Use TTM builtin resource manager debugfs code

2022-04-11 Thread Zack Rusin
From: Zack Rusin Switch to using the TTM resource manager debugfs helpers. It's exactly the same functionality but the debugfs code is shared with other drivers. The TTM resource managers need to stay valid for as long as the drm debugfs_root is valid. Signed-off-by: Zack Rusin Cc: Alex

RE: [Intel-gfx] [V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com;

RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() Thanks and Regards, Arun R Murthy

[PATCH] drm/amdkfd: shrink bitmap size in struct svm_validate_context

2022-04-11 Thread Lang Yu
A MAX_GPU_INSTANCE bits bitmap will suffice. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c index 8b6adc142e25..459fa07a3bcc 100644

RE: [PATCH 1/3] drm/amdgpu: add poison consumption flag for RAS IH

2022-04-11 Thread Zhou1, Tao
[AMD Official Use Only] Hi Stanley, The flag is set by RAS block poison irq handler, such as vcn/jpeg poison irq handler. It's not configured in RAS init. Regards, Tao > -Original Message- > From: Yang, Stanley > Sent: Monday, April 11, 2022 10:12 PM > To: Zhou1, Tao ;

Re: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Lazar, Lijo
Thanks Jesse. Please also add below before you commit. Fixes: 1ef60191b259 ("drm/amdgpu: Use flexible array member") Reviewed-by: Lijo Lazar Thanks, Lijo On 4/12/2022 7:22 AM, Zhang, Jesse(Jie) wrote: [AMD Official Use Only] Thanks Paul Menzel Attach the patch file .

Re: [PATCHv2] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-11 um 22:15 schrieb Mukul Joshi: Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2.

[PATCHv2] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Mukul Joshi
Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2. Ensure that node numbering in sysfs and nodes

RE: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only] Thanks Paul Menzel Attach the patch file . -Original Message- From: Paul Menzel Sent: Monday, 11 April 2022 11:21 pm To: Zhang, Jesse(Jie) Cc: amd-gfx@lists.freedesktop.org; Zhang, Yifan ; Huang, Ray Subject: Re: [PATCH ] drm/amdgpu: fix discovery ip failed

Re: [PATCH] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-11 um 21:14 schrieb Joshi, Mukul: [AMD Official Use Only] -Original Message- From: Kuehling, Felix Sent: Monday, April 11, 2022 8:16 PM To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org Cc: Shuotao Xu Subject: Re: [PATCH] drm/amdkfd: Cleanup IO links during KFD device

RE: [PATCH] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Joshi, Mukul
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Monday, April 11, 2022 8:16 PM > To: Joshi, Mukul ; amd-gfx@lists.freedesktop.org > Cc: Shuotao Xu > Subject: Re: [PATCH] drm/amdkfd: Cleanup IO links during KFD device > removal > > Am 2022-04-07 um 12:15

[PATCH AUTOSEL 4.9 1/7] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 4.14 02/11] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 4.14 01/11] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.19 10/12] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch

[PATCH AUTOSEL 4.19 02/12] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 4.19 01/12] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.4 16/21] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch

[PATCH AUTOSEL 5.4 05/21] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 5.4 04/21] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling

[PATCH AUTOSEL 5.4 03/21] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung

[PATCH AUTOSEL 5.4 02/21] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel

[PATCH AUTOSEL 5.4 01/21] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.10 24/30] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch

[PATCH AUTOSEL 5.10 23/30] drm/amd/display: Revert FEC check in validation

2022-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit b2075fce104b88b789c15ef1ed2b91dc94198e26 ] why and how: causes failure on install on certain machines Reviewed-by: George Shen Acked-by: Alex Hung Signed-off-by: Martin Leung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha

[PATCH AUTOSEL 5.10 09/30] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 5.10 08/30] drm/amdgpu/vcn: improve vcn dpg stop procedure

2022-04-11 Thread Sasha Levin
From: Tianci Yin [ Upstream commit 6ea239adc2a712eb318f04f5c29b018ba65ea38a ] Prior to disabling dpg, VCN need unpausing dpg mode, or VCN will hang in S3 resuming. Reviewed-by: James Zhu Signed-off-by: Tianci Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.10 07/30] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling

[PATCH AUTOSEL 5.10 06/30] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung

[PATCH AUTOSEL 5.10 05/30] drm/amd/display: FEC check in timing validation

2022-04-11 Thread Sasha Levin
From: Chiawen Huang [ Upstream commit 7d56a154e22ffb3613fdebf83ec34d5225a22993 ] [Why] disable/enable leads FEC mismatch between hw/sw FEC state. [How] check FEC status to fastboot on/off. Reviewed-by: Anthony Koo Acked-by: Alex Hung Signed-off-by: Chiawen Huang Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.10 04/30] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel

[PATCH AUTOSEL 5.10 01/30] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.15 31/41] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch

[PATCH AUTOSEL 5.15 30/41] drm/amd/display: Revert FEC check in validation

2022-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit b2075fce104b88b789c15ef1ed2b91dc94198e26 ] why and how: causes failure on install on certain machines Reviewed-by: George Shen Acked-by: Alex Hung Signed-off-by: Martin Leung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha

[PATCH AUTOSEL 5.15 29/41] drm/amd/display: Enable power gating before init_pipes

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit 58e16c752e9540b28a873c44c3bee83e022007c1 ] [Why] In init_hw() we call init_pipes() before enabling power gating. init_pipes() tries to power gate dsc but it may fail because required force-ons are not released yet. As a result with dsc config the following

[PATCH AUTOSEL 5.15 11/41] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 5.15 10/41] drm/amdgpu/vcn: improve vcn dpg stop procedure

2022-04-11 Thread Sasha Levin
From: Tianci Yin [ Upstream commit 6ea239adc2a712eb318f04f5c29b018ba65ea38a ] Prior to disabling dpg, VCN need unpausing dpg mode, or VCN will hang in S3 resuming. Reviewed-by: James Zhu Signed-off-by: Tianci Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.15 09/41] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling

[PATCH AUTOSEL 5.15 08/41] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung

[PATCH AUTOSEL 5.15 07/41] drm/amd/display: FEC check in timing validation

2022-04-11 Thread Sasha Levin
From: Chiawen Huang [ Upstream commit 7d56a154e22ffb3613fdebf83ec34d5225a22993 ] [Why] disable/enable leads FEC mismatch between hw/sw FEC state. [How] check FEC status to fastboot on/off. Reviewed-by: Anthony Koo Acked-by: Alex Hung Signed-off-by: Chiawen Huang Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.15 06/41] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel

[PATCH AUTOSEL 5.15 05/41] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough

2022-04-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b818a5d374542ccec73dcfe578a081574029820e ] If the GPU is passed through to a guest VM, use the PCI BAR for CPU FB access rather than the physical address of carve out. The physical address is not valid in a guest. v2: Fix HDP handing as suggested by Michel

[PATCH AUTOSEL 5.15 04/41] drm/amdgpu: conduct a proper cleanup of PDB bo

2022-04-11 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 2d505453f38e18d42ba7d5428aaa17aaa7752c65 ] Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a proper cleanup of PDB bo. v2: update subject to be more accurate Signed-off-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex

[PATCH AUTOSEL 5.15 01/41] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.17 38/49] drm/amd/display: Fix allocate_mst_payload assert on resume

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit f4346fb3edf7720db3f7f5e1cab1f667cd024280 ] [Why] On resume we do link detection for all non-MST connectors. MST is handled separately. However the condition for telling if connector is on mst branch is not enough for mst hub case. Link detection for mst branch

[PATCH AUTOSEL 5.17 37/49] drm/amd/display: Revert FEC check in validation

2022-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit b2075fce104b88b789c15ef1ed2b91dc94198e26 ] why and how: causes failure on install on certain machines Reviewed-by: George Shen Acked-by: Alex Hung Signed-off-by: Martin Leung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha

[PATCH AUTOSEL 5.17 36/49] drm/amd/display: Enable power gating before init_pipes

2022-04-11 Thread Sasha Levin
From: Roman Li [ Upstream commit 58e16c752e9540b28a873c44c3bee83e022007c1 ] [Why] In init_hw() we call init_pipes() before enabling power gating. init_pipes() tries to power gate dsc but it may fail because required force-ons are not released yet. As a result with dsc config the following

[PATCH AUTOSEL 5.17 35/49] drm/amd/display: Correct Slice reset calculation

2022-04-11 Thread Sasha Levin
From: Chris Park [ Upstream commit 862a876c3a6372f2fa9d0c6510f1976ac94fc857 ] [Why] Once DSC slice cannot fit pixel clock, we incorrectly reset min slices to 0 and allow max slice to operate, even when max slice itself cannot fit the pixel clock properly. [How] Change the sequence such that we

[PATCH AUTOSEL 5.17 12/49] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-04-11 Thread Sasha Levin
From: QintaoShen [ Upstream commit ebbb7bb9e80305820dc2328a371c1b35679f2667 ] As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.

[PATCH AUTOSEL 5.17 11/49] drm/amdgpu/vcn: improve vcn dpg stop procedure

2022-04-11 Thread Sasha Levin
From: Tianci Yin [ Upstream commit 6ea239adc2a712eb318f04f5c29b018ba65ea38a ] Prior to disabling dpg, VCN need unpausing dpg mode, or VCN will hang in S3 resuming. Reviewed-by: James Zhu Signed-off-by: Tianci Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.17 10/49] drm/amdkfd: Fix Incorrect VMIDs passed to HWS

2022-04-11 Thread Sasha Levin
From: Tushar Patel [ Upstream commit b7dfbd2e601f3fee545bc158feceba4f340fe7cf ] Compute-only GPUs have more than 8 VMIDs allocated to KFD. Fix this by passing correct number of VMIDs to HWS v2: squash in warning fix (Alex) Signed-off-by: Tushar Patel Reviewed-by: Felix Kuehling

[PATCH AUTOSEL 5.17 09/49] drm/amd/display: Update VTEM Infopacket definition

2022-04-11 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit c9fbf6435162ed5fb7201d1d4adf6585c6a8c327 ] [Why & How] The latest HDMI SPEC has updated the VTEM packet structure, so change the VTEM Infopacket defined in the driver side to align with the SPEC. Reviewed-by: Chris Park Acked-by: Alex Hung

[PATCH AUTOSEL 5.17 08/49] drm/amd/display: FEC check in timing validation

2022-04-11 Thread Sasha Levin
From: Chiawen Huang [ Upstream commit 7d56a154e22ffb3613fdebf83ec34d5225a22993 ] [Why] disable/enable leads FEC mismatch between hw/sw FEC state. [How] check FEC status to fastboot on/off. Reviewed-by: Anthony Koo Acked-by: Alex Hung Signed-off-by: Chiawen Huang Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.17 07/49] drm/amd/display: fix audio format not updated after edid updated

2022-04-11 Thread Sasha Levin
From: Charlene Liu [ Upstream commit 5e8a71cf13bc9184fee915b2220be71b4c6cac74 ] [why] for the case edid change only changed audio format. driver still need to update stream. Reviewed-by: Alvin Lee Reviewed-by: Aric Cyr Acked-by: Alex Hung Signed-off-by: Charlene Liu Tested-by: Daniel

[PATCH AUTOSEL 5.17 06/49] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough

2022-04-11 Thread Sasha Levin
From: Alex Deucher [ Upstream commit b818a5d374542ccec73dcfe578a081574029820e ] If the GPU is passed through to a guest VM, use the PCI BAR for CPU FB access rather than the physical address of carve out. The physical address is not valid in a guest. v2: Fix HDP handing as suggested by Michel

[PATCH AUTOSEL 5.17 05/49] drm/amdgpu: conduct a proper cleanup of PDB bo

2022-04-11 Thread Sasha Levin
From: Guchun Chen [ Upstream commit 2d505453f38e18d42ba7d5428aaa17aaa7752c65 ] Use amdgpu_bo_free_kernel instead of amdgpu_bo_unref to perform a proper cleanup of PDB bo. v2: update subject to be more accurate Signed-off-by: Guchun Chen Reviewed-by: Christian König Signed-off-by: Alex

[PATCH AUTOSEL 5.17 02/49] drm/amd: Add USBC connector ID

2022-04-11 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit c5c948aa894a831f96fccd025e47186b1ee41615 ] [Why] Add a dedicated AMDGPU specific ID for use with newer ASICs that support USB-C output Signed-off-by: Aurabindo Pillai Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

Re: [PATCH] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-07 um 12:15 schrieb Mukul Joshi: Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2.

Re: [PATCH 1/2] drm/amdkfd: Cleanup IO links during KFD device removal

2022-04-11 Thread Felix Kuehling
Am 2022-04-08 um 04:45 schrieb Shuotao Xu: Currently, the IO-links to the device being removed from topology, are not cleared. As a result, there would be dangling links left in the KFD topology. This patch aims to fix the following: 1. Cleanup all IO links to the device being removed. 2. Ensure

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread kernel test robot
Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v5.18-rc2 next-20220411] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: AMDGPU: RX 6500 XT: System reset when loading module [SOLVED]

2022-04-11 Thread Cal Peake
Hi all, I wanted to put a capper on this just in case anyone was interested, or in case any future people find this thread, because I did find a resolution. Turns out the way to stop the system from crashing was to disable Global C-State Control in the BIOS. Christian, Alex, you guys seem to

gcc inserts __builtin_popcount, causes 'modpost: "__popcountdi2" ... amdgpu.ko] undefined'

2022-04-11 Thread Sergei Trofimovich
Current linux-5.17.1 on fresh gcc-12 fails to build with errors like: ERROR: modpost: "__popcountdi2" [drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko] undefined! ERROR: modpost: "__popcountdi2" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! It is occasionally seen by others on

Re: gcc inserts __builtin_popcount, causes 'modpost: "__popcountdi2" ... amdgpu.ko] undefined'

2022-04-11 Thread Jakub Jelinek
On Mon, Apr 11, 2022 at 10:08:15PM +0100, Sergei Trofimovich wrote: > Current linux-5.17.1 on fresh gcc-12 fails to build with errors like: > > ERROR: modpost: "__popcountdi2" > [drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko] undefined! > ERROR: modpost: "__popcountdi2"

Vega 56 failing to process EDID from VR Headset

2022-04-11 Thread James Dutton
Hi, I have an Oculus Rift S, that I am trying to get working in Linux. I have an AMD Vega 56 graphics card. The VR headset plugs into a display port of the Vega56. The amdgpu driver sees the connection, and tries to process it. The problem is it cannot process the EDID, so fails to recognise

[igt-dev] [PATCH i-g-t v2] tests/drm_buddy: Add drm buddy test cases

2022-04-11 Thread Arunpravin Paneer Selvam
Add a set of drm buddy test cases to validate the drm/drm_buddy.c memory allocator. v2: sorted in alphabetical order Signed-off-by: Arunpravin Paneer Selvam Reviewed-by: Matthew Auld --- tests/drm_buddy.c | 14 ++ tests/meson.build | 1 + 2 files changed, 15 insertions(+) create

Re: AMDGPU: regression on 5.17.1

2022-04-11 Thread Alex Deucher
On Sat, Apr 9, 2022 at 12:28 PM Michele Ballabio wrote: > > On Tue, 5 Apr 2022 10:23:16 -0400 > Alex Deucher wrote: > > > On Mon, Apr 4, 2022 at 3:39 PM Michele Ballabio > > wrote: > > > > > > On Mon, 4 Apr 2022 13:03:41 -0400 > > > Alex Deucher wrote: > > > > > > > On Sun, Apr 3, 2022 at

[linux-next:master] BUILD REGRESSION d12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14

2022-04-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d12d7e1cfe38e0c36d28c7a9fbbc436ad0d17c14 Add linux-next specific files for 20220411 Error/Warning reports: https://lore.kernel.org/linux-mm/202203160358.yulpl6b4-...@intel.com https

Re: [PATCH] drm/radeon: remove r600_blit_shaders.[c|h]

2022-04-11 Thread Alex Deucher
On Sat, Apr 9, 2022 at 1:11 PM Tom Rix wrote: > > The only use of the global variables in r600_blit_shaders.c > were in the old drivers/gpu/drm/radeon/r600_blit.c > This file was removed in > commit 8333f607a631 ("drm/radeon: remove UMS support") > > So remove the r600_blit_shaders.[c|h] files >

Patch "drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions()" has been added to the 5.4-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The

Patch "drm/amdkfd: add missing void argument to function kgd2kfd_init" has been added to the 5.4-stable tree

2022-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amdkfd: add missing void argument to function kgd2kfd_init to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Greg Kroah-Hartman
On Mon, Apr 11, 2022 at 09:43:06AM -0700, Nathan Chancellor wrote: > Hi everyone, > > These two patches resolve two instances of -Wstrict-prototypes with > newer versions of clang that are present in 5.4. The main Makefile makes > this a hard error. > > The first patch is upstream commit

RE: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Deucher, Alexander
[Public] > -Original Message- > From: Nathan Chancellor > Sent: Monday, April 11, 2022 12:43 PM > To: Greg Kroah-Hartman ; Sasha Levin > > Cc: Kuehling, Felix ; Deucher, Alexander > ; Nick Desaulniers > ; amd-gfx@lists.freedesktop.org; > l...@lists.linux.dev; sta...@vger.kernel.org;

[PATCH 5.4 2/2] drm/amdkfd: Fix -Wstrict-prototypes from amdgpu_amdkfd_gfx_10_0_get_functions()

2022-04-11 Thread Nathan Chancellor
This patch is for linux-5.4.y only, it has no equivalent change upstream. When building x86_64 allmodconfig with tip of tree clang, there is an instance of -Wstrict-prototypes: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:168:59: error: a function declaration without a prototype is

[PATCH 5.4 1/2] drm/amdkfd: add missing void argument to function kgd2kfd_init

2022-04-11 Thread Nathan Chancellor
From: Colin Ian King commit 63617d8b125ed9f674133dd000b6df58d6b2965a upstream. Function kgd2kfd_init is missing a void argument, add it to clean up the non-ANSI function declaration. Acked-by: Randy Dunlap Signed-off-by: Colin Ian King Signed-off-by: Alex Deucher Signed-off-by: Nathan

[PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd

2022-04-11 Thread Nathan Chancellor
Hi everyone, These two patches resolve two instances of -Wstrict-prototypes with newer versions of clang that are present in 5.4. The main Makefile makes this a hard error. The first patch is upstream commit 63617d8b125e ("drm/amdkfd: add missing void argument to function kgd2kfd_init"), which

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 11:28 AM Paul Menzel wrote: > > Dear Yongqiang, > > > Thank you for your patch. > > Am 11.04.22 um 15:59 schrieb Yongqiang Sun: > > MS_HYPERV with vega10 doesn't have the interface to process > > request init data msg. > > Should some Hyper-V folks be added to the

Re: [EXTERNAL] [PATCH 2/2] drm/amdkfd: Add PCIe Hotplug Support for AMDKFD

2022-04-11 Thread Andrey Grodzovsky
On 2022-04-08 21:28, Shuotao Xu wrote: On Apr 8, 2022, at 11:28 PM, Andrey Grodzovsky wrote: [Some people who received this message don't often get email from andrey.grodzov...@amd.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] On 2022-04-08 04:45,

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Paul Menzel
Dear Yongqiang, Thank you for your patch. Am 11.04.22 um 15:59 schrieb Yongqiang Sun: MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Should some Hyper-V folks be added to the reviewers list too? Check hypervisor type to not send the request for

Re: [PATCH v2 ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 11:25 AM Zhang, Jesse(Jie) wrote: > > [AMD Official Use Only] > > > > + Deucher, Alexander > > > > From: Zhang, Jesse(Jie) > Sent: Monday, 11 April 2022 11:15 pm > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Ray ; Zhang, Yifan > Subject: [PATCH ] drm/amdgpu: fix

RE: [PATCH v2 ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only] + Deucher, Alexander From: Zhang, Jesse(Jie) Sent: Monday, 11 April 2022 11:15 pm To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Zhang, Yifan Subject: [PATCH ] drm/amdgpu: fix discovery ip failed [AMD Official Use Only] Fix discovery ip failed, and the log:

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Alex Deucher
On Mon, Apr 11, 2022 at 9:52 AM Yongqiang Sun wrote: > > MS_HYPERV with vega10 doesn't have the interface to process > request init data msg. > Check hypervisor type to not send the request for MS_HYPERV. > > Signed-off-by: Yongqiang Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12

Re: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Paul Menzel
Dear Jie, Thank you for your patch. Am 11.04.22 um 17:15 schrieb Zhang, Jesse(Jie): You might want to add a space before the (. [AMD Official Use Only] Please send a patch with `git format-patch` or similar. Fix discovery ip failed, and the log: On what system? 56.129549]

Re: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Paul Menzel
Dear Elena, Am 11.04.22 um 15:32 schrieb Elena Sakhnovitch: On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such

[PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Zhang, Jesse(Jie)
[AMD Official Use Only] Fix discovery ip failed, and the log: 56.129549] [drm:amdgpu_discovery_validate_ip [amdgpu]] *ERROR* Unexpected number_instance (64) from ip discovery blob [ 56.130129] [drm:amdgpu_discovery_validate_ip [amdgpu]] *ERROR* Unexpected hw_id (45056) from ip discovery

回复: [PATCH 1/3] drm/amdgpu: add poison consumption flag for RAS IH

2022-04-11 Thread Yang, Stanley
[AMD Official Use Only] Hi Tao, According to the series patches, I have one question, is the ras_ih_flag set according to poison mode configuration, if yes, driver will handle poison once get ecc_irq interrupt, but at this moment there may no app to consumes it, this seems conflict the poison

Re: [PATCH] drm/amdkfd: Asynchronously free events

2022-04-11 Thread Felix Kuehling
Am 2022-04-11 um 08:52 schrieb philip yang: On 2022-04-07 22:39, Felix Kuehling wrote: The synchronize_rcu call in destroy_events can take several ms, which noticeably slows down applications destroying many events. Use kfree_rcu to free the event structure asynchronously and eliminate the

[PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Yongqiang Sun
MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Check hypervisor type to not send the request for MS_HYPERV. Signed-off-by: Yongqiang Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Lazar, Lijo
On 4/11/2022 7:02 PM, Elena Sakhnovitch wrote: On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platforms

[PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Yongqiang Sun
MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Check hypervisor type to not send the request for MS_HYPERV. Signed-off-by: Yongqiang Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam: On 11/04/22 7:02 pm, Matthew Auld wrote: On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Arunpravin Paneer Selvam
On 11/04/22 7:02 pm, Matthew Auld wrote: > On 11/04/2022 13:42, Christian König wrote: >> >> Am 11.04.22 um 11:47 schrieb Matthew Auld: >>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size

[PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Elena Sakhnovitch
On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such platforms through driver. v2: FEATURE_FAN_CONTROL_MASK is replaced

Re: [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Matthew Auld
On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their

RE: DC Patches Apri 6, 2022

2022-04-11 Thread Wheeler, Daniel
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to

Re: [PATCH] drm/amdgpu: Release memory when psp sw_init is failed

2022-04-11 Thread Wang, Yang(Kevin)
[AMD Official Use Only] From: amd-gfx on behalf of Ma Jun Sent: Monday, April 11, 2022 8:42 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Release memory when psp sw_init is

  1   2   >