回复: [PATCH Review 1/1] drm/amdgpu/pm: adjust EccInfo_t struct

2022-06-15 Thread Yang, Stanley
[AMD Official Use Only - General] Thanks hawking, in the previous patch it has checked pmfw version and the EccInfo_t struct is consistent on driver side and pmfw side with pmfw debug version 68.54.136 during develop this feature, but it's changed in the official release version 68.55.0, so

RE: [PATCH Review 1/1] drm/amdgpu/pm: adjust EccInfo_t struct

2022-06-15 Thread Zhang, Hawking
[AMD Official Use Only - General] For the structure itself, the change is okay to me. But you'll have to apply pmfw version check in the implementation to make data matches with fw structure The patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From:

RE: [PATCH] drm/amd: Don't show warning on reading vbios values for SMU13 3.1

2022-06-15 Thread Quan, Evan
[AMD Official Use Only - General] Thanks for the fix. Yes, the support for APUs was missing from the relevant code. I think you can just drop the piece of code below. / else { dev_warn(smu->adev->dev, "Unexpected and unhandled version: %d.%d\n",

[PATCH Review 1/1] drm/amdgpu/pm: adjust EccInfo_t struct

2022-06-15 Thread Stanley . Yang
The EccInfo_t struct in driver_if.h is as below in official release verion 68.55.0 typedef struct { uint64_t mca_umc_status; uint64_t mca_umc_addr; uint16_t ce_count_lo_chip; uint16_t ce_count_hi_chip; uint32_t eccPadding; uint64_t mca_ceumc_addr; } EccInfo_t; It's different

Re: [PATCH] drm/amd: Don't show warning on reading vbios values for SMU13 3.1

2022-06-15 Thread Alex Deucher
On Tue, Jun 14, 2022 at 10:22 AM Mario Limonciello wrote: > > Some APUs with SMU13 are showing the following message: > `amdgpu :63:00.0: amdgpu: Unexpected and unhandled version: 3.1` > > This warning isn't relevant for smu info 3.1, as no bootup information > is present in the table. > >

RE: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-15 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider > -Original Message- > From: Yang, Philip > Sent: Wednesday, June 15, 2022 5:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Sider, Graham ; Yang, Philip > > Subject: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active > > We remove the

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
Pushed to drm-misc-next. Alex On Wed, Jun 15, 2022 at 7:26 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor > wrote: > > > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor >

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Stephen Rothwell
Hi all, On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor wrote: > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor > > wrote: > > > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > > On Wed,

[PATCH] amd/display/dc: Fix COLOR_ENCODING and COLOR_RANGE doing nothing for DCN20+

2022-06-15 Thread Joshua Ashton
For DCN20 and above, the code that actually hooks up the provided input_color_space got lost at some point. Fixes COLOR_ENCODING and COLOR_RANGE doing nothing on DCN20+. Tested using Steam Remote Play Together + gamescope. Signed-off-by: Joshua Ashton ---

答复: [PATCH v2 2/2] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-06-15 Thread Feng, Kenneth
[AMD Official Use Only - General] [AMD Official Use Only - General] Reviewed-by: Kenneth Feng mailto:kenneth.f...@amd.com>> Best wishes Kenneth Feng 发件人: Powell, Darren 日期: 星期四, 2022年6月16日 05:00 收件人: amd-gfx@lists.freedesktop.org 抄送: Lazar, Lijo , Wang, Yang(Kevin) , Feng, Kenneth , Quan,

Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-15 Thread philip yang
On 2022-06-15 10:06, Christian König wrote: Am 15.06.22 um 15:17 schrieb Sider, Graham: [AMD Official Use Only - General] -Original Message- From: Koenig, Christian

[PATCH] drm/amd: Revert "drm/amd/display: keep eDP Vdd on when eDP stream is already enabled"

2022-06-15 Thread Mario Limonciello
A variety of Lenovo machines with Rembrandt APUs and OLED panels have stopped showing the display at login. This behavior clears up after leaving it idle and moving the mouse or touching keyboard. It was bisected to be caused by commit 559e2655220d ("drm/amd/display: keep eDP Vdd on when eDP

[PATCH 2/2] drm/amdkfd: Free queue after unmap queue success

2022-06-15 Thread Philip Yang
After queue unmap or remove from MES successfully, free queue sysfs entries, doorbell and remove from queue list. Otherwise, application may destroy queue again, cause below kernel warning or crash backtrace. For outstanding queues, either application forget to destroy or failed to destroy,

[PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-15 Thread Philip Yang
We remove the user queue from MES scheduler to update queue properties. If the queue becomes active after updating, add the user queue to MES scheduler, to be able to handle command packet submission. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 6

Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DEBUG_FS is not set

2022-06-15 Thread Harry Wentland
On 2022-06-15 17:00, Alex Deucher wrote: > amdgpu_dm_crtc_late_register is only used when CONFIG_DEBUG_FS > so make it dependent on that. > > Fixes: 4cd79f614b50 ("drm/amd/display: Move connector debugfs to drm") > Cc: Bhanuprakash Modem > Cc: Harry Wentland > Cc: Arun R Murthy > Cc: Jani

[PATCH] drm/amdgpu/display: fix build when CONFIG_DEBUG_FS is not set

2022-06-15 Thread Alex Deucher
amdgpu_dm_crtc_late_register is only used when CONFIG_DEBUG_FS so make it dependent on that. Fixes: 4cd79f614b50 ("drm/amd/display: Move connector debugfs to drm") Cc: Bhanuprakash Modem Cc: Harry Wentland Cc: Arun R Murthy Cc: Jani Nikula Reported-by: Randy Dunlap Reported-by: Nathan

Re: [PATCH v2 2/2] amdgpu/pm: Fix possible array out-of-bounds if SCLK levels != 2

2022-06-15 Thread Powell, Darren
[AMD Official Use Only - General] Ping  From: Powell, Darren Sent: Wednesday, May 11, 2022 1:44 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Wang, Yang(Kevin) ; Feng, Kenneth ; Quan, Evan ; Ma, Le ; Powell, Darren Subject: [PATCH v2 2/2]

[pull] amdgpu drm-fixes-5.19

2022-06-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.19. The following changes since commit 1f192b9e8d8a5c619b33a868fb1af063af65ce5d: Merge tag 'drm-misc-fixes-2022-06-09' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2022-06-10 13:29:22 +1000) are available in the Git repository at:

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor wrote: > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap > > > wrote: > > > > > > > > > > > > > > > > On

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor wrote: > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > > > > > > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > Changes since

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
Hi-- On 6/15/22 13:13, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:44 PM Randy Dunlap wrote: >> >> >> >> On 6/15/22 12:28, Alex Deucher wrote: >>> On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: On 6/14/22 23:01, Stephen Rothwell wrote: > Hi all, > >

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20220614: > > > > > > > on i386: > > # CONFIG_DEBUG_FS is not set > > > > > >

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 3:44 PM Randy Dunlap wrote: > > > > On 6/15/22 12:28, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > >> > >> > >> > >> On 6/14/22 23:01, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20220614: > >>> > >> > >> on i386: > >>

[linux-next:master] BUILD SUCCESS 6012273897fefb12566580efedee10bb06e5e6ed

2022-06-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6012273897fefb12566580efedee10bb06e5e6ed Add linux-next specific files for 20220615 Warning reports: https://lore.kernel.org/llvm/202206151803.an0djvge-...@intel.com https://lore.kernel.org

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
On 6/15/22 12:28, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: >> >> >> >> On 6/14/22 23:01, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20220614: >>> >> >> on i386: >> # CONFIG_DEBUG_FS is not set >> >> >>

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20220614: > > > > on i386: > # CONFIG_DEBUG_FS is not set > > > ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function >

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Randy Dunlap
On 6/14/22 23:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20220614: > on i386: # CONFIG_DEBUG_FS is not set ../drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_crtc_late_register’:

Re: [PATCH] drm/radeon: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 8:33 AM hongao wrote: > > Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi for more > efficiency > > Tested on "Oland [Radeon HD 8570 / R7 240/340 OEM]" & "Caicos [R5 230]" Can you verify that drm_display_info.is_hdmi has been populated when all of these

Re: [PATCH] drm/radeon: fix incorrrect SPDX-License-Identifiers

2022-06-15 Thread Christian König
Am 15.06.22 um 18:11 schrieb Alex Deucher: radeon is MIT. This were incorrectly changed in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") and commit d198b34f3855 (".gitignore: add SPDX License Identifier") and: commit ec8f24b7faaf

[PATCH] drm/radeon: fix incorrrect SPDX-License-Identifiers

2022-06-15 Thread Alex Deucher
radeon is MIT. This were incorrectly changed in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") and commit d198b34f3855 (".gitignore: add SPDX License Identifier") and: commit ec8f24b7faaf ("treewide: Add SPDX license identifier -

Re: [RFC 1/3] drm/amd/display: Introduce KUnit to DML

2022-06-15 Thread Maíra Canal
Hi Daniel Thank you for your feedback! We are working on the comments you pointed out. On 6/7/22 23:36, Daniel Latypov wrote: > On Tue, Jun 7, 2022 at 6:09 PM Maíra Canal wrote: >> diff --git >> a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/display_mode_lib_test.c >>

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-15 Thread Yann Dirson
Nice! > diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv > b/Documentation/gpu/amdgpu/apu-asic-info-table.csv ... > +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, > RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0 ... > +Ryzen 3000 series / AMD Ryzen Embedded

Re: [PATCH 03/13] mm: shmem: provide oom badness for shmem files

2022-06-15 Thread Christian König
Am 15.06.22 um 15:15 schrieb Michal Hocko: On Wed 15-06-22 14:35:22, Christian König wrote: [...] Even the classic mm_struct based accounting includes MM_SHMEMPAGES into the badness. So accounting shared resources as badness to make a decision is nothing new here. Yeah, it is nothing really

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-15 Thread Alex Deucher
On Wed, Jun 15, 2022 at 3:47 AM Simon Ser wrote: > > On Tuesday, June 14th, 2022 at 20:30, Alex Deucher > wrote: > > > On Tue, Jun 14, 2022 at 2:16 PM Simon Ser cont...@emersion.fr wrote: > > > > > On Monday, June 13th, 2022 at 22:01, Rodrigo Siqueira > > > rodrigo.sique...@amd.com wrote: > >

Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-15 Thread Christian König
Am 15.06.22 um 15:17 schrieb Sider, Graham: [AMD Official Use Only - General] -Original Message- From: Koenig, Christian Sent: Wednesday, June 15, 2022 3:29 AM To: Sider, Graham ; amd- g...@lists.freedesktop.org Cc: Joshi, Mukul ; Kuehling, Felix ; Yang, Philip Subject: Re: [PATCH v3

Re: [PATCH 2/3] Documentation/gpu: Add an explanation about the DCN pipeline

2022-06-15 Thread Pekka Paalanen
On Mon, 13 Jun 2022 16:01:11 -0400 Rodrigo Siqueira wrote: > In the DCN code, we constantly talk about hardware pipeline, pipeline, > or even just pipes, which is a concept that is not obvious to everyone. > For this reason, this commit expands the DCN overview explanation by > adding a new

[PATCH] drm/radeon: Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2022-06-15 Thread hongao
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi for more efficiency Tested on "Oland [Radeon HD 8570 / R7 240/340 OEM]" & "Caicos [R5 230]" Signed-off-by: hongao --- drivers/gpu/drm/radeon/atombios_encoders.c | 6 +++--- drivers/gpu/drm/radeon/radeon_connectors.c | 12

RE: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-15 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: Koenig, Christian > Sent: Wednesday, June 15, 2022 3:29 AM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > ; Yang, Philip > Subject: Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11

Re: [PATCH 03/13] mm: shmem: provide oom badness for shmem files

2022-06-15 Thread Christian König
Am 13.06.22 um 16:11 schrieb Michal Hocko: [SNIP] Let me maybe get back to the initial question: We have resources which are not related to the virtual address space of a process, how should we tell the OOM killer about them? I would say memcg, but we have discussed this already... Well

Re: [PATCH] drm/radeon: Add build directory to include path

2022-06-15 Thread Michel Dänzer
On 2022-04-14 18:57, Michel Dänzer wrote: > On 2022-04-14 17:04, Masahiro Yamada wrote: >> On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer >> wrote: >>> On 2022-04-14 15:34, Alex Deucher wrote: On Thu, Apr 14, 2022 at 4:44 AM Christian König wrote: > Am 14.04.22 um 09:37 schrieb

Re: [PATCH] drm/amdgpu/vcn: adjust unified queue code format

2022-06-15 Thread Christian König
Am 15.06.22 um 04:56 schrieb Ruijing Dong: Fixed some errors and warnings found by checkpatch.pl. Signed-off-by: Ruijing Dong Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++-- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 8 2 files

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-15 Thread Simon Ser
On Tuesday, June 14th, 2022 at 20:30, Alex Deucher wrote: > On Tue, Jun 14, 2022 at 2:16 PM Simon Ser cont...@emersion.fr wrote: > > > On Monday, June 13th, 2022 at 22:01, Rodrigo Siqueira > > rodrigo.sique...@amd.com wrote: > > > > > Amdgpu driver is used in an extensive range of devices, and

Re: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-15 Thread Christian König
Am 13.06.22 um 17:20 schrieb Graham Sider: Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to GART for usermode queues in order to support oversubscription. In the case that work is submitted to an unmapped queue, MES must have a GART wptr address to determine whether

Re: [PATCH] drm/amdgpu: Adjust logic around GTT size (v3)

2022-06-15 Thread Christian König
Well the key point is it isn't better. It's just that different people will start complaining. I'm fine with trying to change it once more, just keep in mind that we decide between two evils and somebody could start complaining. Christian. Am 14.06.22 um 15:43 schrieb Alex Deucher: I don't

Re: [PATCH] drm/amdgpu/display: make FP handling in Makefiles consistent

2022-06-15 Thread Christian König
Well in this case Acked-by: Christian König Christian. Am 14.06.22 um 15:30 schrieb Alex Deucher: Anyone? This fixes the build on non-x86. Alex On Mon, Jun 13, 2022 at 9:52 AM Alex Deucher wrote: Ping? On Fri, Jun 10, 2022 at 11:43 AM Alex Deucher wrote: Use the same pattern as the