[PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-26 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in

[PATCH 2/2] drm/amd/pm: enable GFX ULV feature support for SMU13.0.0

2022-07-26 Thread Evan Quan
The feature is ready with latest firmwares. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: I4907ef8c96eb8933db01818d7431afb3778d1afd --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 1/2] drm/amd/pm: update driver if header for SMU 13.0.0

2022-07-26 Thread Evan Quan
And get the version bumped to 0x2C to match the latest PMFW. Signed-off-by: Evan Quan Reviewed-by: Hawking Zhang Change-Id: Ie4bc8fa0831ae6d1735c2dca27331ff6f6229e30 --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 2 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread Melissa Wen
On 07/26, Magali Lemes wrote: > On 7/25/22 20:38, Melissa Wen wrote: > > > On 07/25, Magali Lemes wrote: > > > On 7/25/22 16:42, André Almeida wrote: > > > > Hi Magali, > > > > > > > > Às 15:15 de 25/07/22, Magali Lemes escreveu: > > > > > As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >

Re: [PATCH] drm/amdgpu: Avoid direct cast to amdgpu_ttm_tt

2022-07-26 Thread Felix Kuehling
Am 2022-07-26 um 19:43 schrieb Rajneesh Bhardwaj: For typesafety, use container_of() instead of implicit cast from struct ttm_tt to struct amdgpu_ttm_tt. Cc: Christian König Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 44 ++--- 1 file

[PATCH] drm/amdgpu: Avoid direct cast to amdgpu_ttm_tt

2022-07-26 Thread Rajneesh Bhardwaj
For typesafety, use container_of() instead of implicit cast from struct ttm_tt to struct amdgpu_ttm_tt. Cc: Christian König Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 44 ++--- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git

Re: amdgpu: misc ugliness and inconsistency

2022-07-26 Thread André Almeida
Hi Dan, Às 12:52 de 26/07/22, Dan Carpenter escreveu: > Hi AMD devs, > > I guess there was a big merge in linux-next the other day? Anyway, it > generated a lot of Smatch warnings. I reported some of them but there > is just a lot so I'm mass reporting these. > > Inconsistent NULL checking

[PATCH 2/2] drm/amd/display: Fix indentation in commit_planes_for_stream()

2022-07-26 Thread Alex Deucher
No functional change. Just update whitespace. Signed-off-by: Alex Deucher Cc: Alvin Lee Cc: Martin Leung Cc: Harry Wentland Cc: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git

[PATCH 1/2] Revert "drm/amd/display: attempt to fix the logic in commit_planes_for_stream()"

2022-07-26 Thread Alex Deucher
This reverts commit a0d10c437c1c9859d24a16b90abf85120603b4ff. This caused a regression in the DC team testing. Signed-off-by: Alex Deucher Cc: Alvin Lee Cc: Martin Leung Cc: Harry Wentland Cc: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 45 +++- 1

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread André Almeida
Às 17:47 de 25/07/22, Magali Lemes escreveu: > > On 7/25/22 16:42, André Almeida wrote: >> Hi Magali, >> >> Às 15:15 de 25/07/22, Magali Lemes escreveu: >>> As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >>> _vcs_dpi_soc_bounding_box_st", change their types accordingly. >>> >> I can see

Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing

2022-07-26 Thread Andrew Morton
On Mon, 25 Jul 2022 21:22:06 -0500 "Sierra Guiza, Alejandro (Alex)" wrote: > >> a) add the || to the end of the previous line > >> b) indent such the we have a nice-to-read alignment > >> > >> if (!list_empty(_page_list) || isolation_error_count || > >> coherent_pages) > >> > > I missed

[PATCH v2 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

2022-07-26 Thread André Almeida
Add comments to document gfx_off related members of struct amdgpu_gfx. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h

[PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-07-26 Thread André Almeida
This series adds new logging features for GFXOFF available for vangogh and documentation for it. I've created a small userspace program to interact with this new debugfs interface and it can be found at: https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool Changelog: v2: - Make entrycount

[PATCH v2 3/4] Documentation/gpu: Document GFXOFF's count and residency

2022-07-26 Thread André Almeida
Add documentation explaining those two new files. While here, add a note about the value type. Signed-off-by: André Almeida --- Documentation/gpu/amdgpu/thermal.rst | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/thermal.rst

[PATCH v2 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh

2022-07-26 Thread André Almeida
Implement functions to get and set GFXOFF's entry count and residency for vangogh. Signed-off-by: André Almeida --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 5 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 92

[PATCH v2 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-26 Thread André Almeida
Add debugfs interface to log GFXOFF statistics: - Read amdgpu_gfxoff_count to get the total GFXOFF entry count at the time of query since system power-up - Write 1 to amdgpu_gfxoff_residency to start logging, and 0 to stop. Read it to get average GFXOFF residency % multiplied by 100 during

[pull] amdgpu, amdkfd drm-next-5.20

2022-07-26 Thread Alex Deucher
Hi Dave, Daniel, Bug fixes for 5.20 and a few new things. I know it's a bit late for new stuff, but this is mainly fixes for new IPs that were just added in 5.20 and more DC cleanup which is just code shuffling to group FP code into separate code objects and spliting up the DC DM code into more

Re: [bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes

2022-07-26 Thread Simon Ser
On Tuesday, July 26th, 2022 at 17:47, Dan Carpenter wrote: > On Tue, Jul 26, 2022 at 03:27:54PM +, Simon Ser wrote: > > > plane->state->fb is NULL iff afb is NULL. There is an early return to > > make sure the dereferences don't cause a segfault. > > > Are you talking about this: > > if

Re: Crash on resume from S3

2022-07-26 Thread Andrey Grodzovsky
The stack trace is expected part of reset procedure  so that ok. The issue you are having is a hang on one of GPU jobs during resume which triggers a GPU reset attempt. You can open a ticket with this issue here https://gitlab.freedesktop.org/drm/amd/-/issues, please attach full dmesg log.

Re: [PATCH 4/5] drm/amdgpu: revert context to stop engine before mode2 reset

2022-07-26 Thread Andrey Grodzovsky
Got it Acked-by: Andrey Grodzovsky Andrey On 2022-07-26 06:01, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Andrey, For slow tests I mean the slow hang tests by quark tool. An example here: hang_vm_gfx_dispatch_slow.lua - This script runs on a graphics engine using compute

Re: [PATCH 5/5] drm/amdgpu: reduce reset time

2022-07-26 Thread Andrey Grodzovsky
On 2022-07-26 05:40, Zhao, Victor wrote: [AMD Official Use Only - General] Hi Andrey, Reply inline. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:18 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng,

[PATCH] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-26 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in range [0x0010-0x0017] [

amdgpu: misc ugliness and inconsistency

2022-07-26 Thread Dan Carpenter
Hi AMD devs, I guess there was a big merge in linux-next the other day? Anyway, it generated a lot of Smatch warnings. I reported some of them but there is just a lot so I'm mass reporting these. Inconsistent NULL checking can be harmless. Part of the function assumes that the pointer can be

Re: [bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes

2022-07-26 Thread Dan Carpenter
On Tue, Jul 26, 2022 at 03:27:54PM +, Simon Ser wrote: > Hi, > > plane->state->fb is NULL iff afb is NULL. There is an early return to > make sure the dereferences don't cause a segfault. > Are you talking about this: if (!plane->state->fb && !old_plane_state->fb)

Re: [bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes

2022-07-26 Thread Simon Ser
Hi, plane->state->fb is NULL iff afb is NULL. There is an early return to make sure the dereferences don't cause a segfault. Simon

[bug report] drm/amd/display: DML changes for DCN32/321

2022-07-26 Thread Dan Carpenter
Hello Aurabindo Pillai, The patch dda4fb85e433: "drm/amd/display: DML changes for DCN32/321" from Feb 21, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1631 dml32_TruncToValidBPP() error: uninitialized

[PATCH] drm/amd/display: Fix apply_synaptics_fifo_reset_wa()

2022-07-26 Thread Dan Carpenter
There is a stray return which accidentally turns the last part of the function into dead code. Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround") Signed-off-by: Dan Carpenter --- >From static analysis. Untested.

[bug report] drm/amd/display: Synchronize displays with different timings

2022-07-26 Thread Dan Carpenter
Hello Vladimir Stempen, The patch 77a2b7265f20: "drm/amd/display: Synchronize displays with different timings" from Dec 29, 2020, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2199 dcn10_enable_vblanks_synchronization()

Re: [PATCH] drm/amd/display: fix signedness bug in execute_synaptics_rc_command()

2022-07-26 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jul 26, 2022 at 11:16 AM Dan Carpenter wrote: > > The "ret" variable needs to be signed for the error handling to work. > > Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround") > Signed-off-by: Dan Carpenter > --- >

[bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes

2022-07-26 Thread Dan Carpenter
Hello Simon Ser, The patch 03a663673063: "drm/amd/display: use FB pitch to fill dc_cursor_attributes" from Dec 2, 2020, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1271 handle_cursor_update() error: we

[bug report] drm/amd/display: Add dcn3.01 support to DC (v2)

2022-07-26 Thread Dan Carpenter
[ It's not clear to me why Smatch is complaining about 2 year old code but that seems like the buggy commit? ] Hello Roman Li, The patch 3a83e4e64bb1: "drm/amd/display: Add dcn3.01 support to DC (v2)" from Sep 29, 2020, leads to the following Smatch static checker warning:

[bug report] drm/amd/display: Initial DC support for Beige Goby

2022-07-26 Thread Dan Carpenter
Hello Aurabindo Pillai, The patch cd6d421e3d1a: "drm/amd/display: Initial DC support for Beige Goby" from Mar 15, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_resource.c:392 dcn303_stream_encoder_create() error:

[bug report] drm/amdgpu: create I2S platform devices for Jadeite platform

2022-07-26 Thread Dan Carpenter
Hello Vijendar Mukunda, The patch 4c33e5179ff1: "drm/amdgpu: create I2S platform devices for Jadeite platform" from Jun 30, 2022, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() error: buffer overflow 'i2s_pdata' 3 <= 3

[PATCH] drm/amd/display: fix signedness bug in execute_synaptics_rc_command()

2022-07-26 Thread Dan Carpenter
The "ret" variable needs to be signed for the error handling to work. Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 01/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Jul 26, 2022 at 3:26 AM Jiapeng Chong wrote: > > No functional modification involved. > > smatch warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:910 > dcn32_init_hw() warn: inconsistent indenting. > > Reported-by: Abaci Robot

Re: [PATCH v3 2/3] drm/amdkfd: Set svm range max pages

2022-07-26 Thread Felix Kuehling
Am 2022-07-25 um 17:17 schrieb Philip Yang: This will be used to split giant svm range into smaller ranges, to support VRAM overcommitment by giant range and improve GPU retry fault recover on giant range. Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling ---

Re: [PATCH] drm/amdkfd: fix kgd_mem memory leak when importing dmabuf

2022-07-26 Thread Felix Kuehling
Am 2022-07-26 um 07:15 schrieb Lang Yu: The kgd_mem memory allocated in amdgpu_amdkfd_gpuvm_import_dmabuf() is not freed properly. Explicitly free it in amdgpu_amdkfd_gpuvm_free_memory_of_gpu() under condition "mem->bo->kfd_bo != mem". Suggested-by: Felix Kuehling Signed-off-by: Lang Yu

Re: [PATCH v2] drm/amd/pm: Add get_gfx_off_status interface for yellow carp

2022-07-26 Thread André Almeida
Às 03:29 de 26/07/22, shikai@amd.com escreveu: > From: Shikai Guo > > add get_gfx_off_status interface to yellow_carp_ppt_funcs structure. > > Signed-off-by: Shikai Guo > --- Reviewed-by: André Almeida

RE: [PATCH v2] drm/amd/pm: Add get_gfx_off_status interface for yellow carp

2022-07-26 Thread Liang, Prike
[Public] Reviewed-by: Prike Liang > -Original Message- > From: amd-gfx On Behalf Of > shikai@amd.com > Sent: Tuesday, July 26, 2022 2:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Liang, Prike > ; Quan, Evan ; Liu, Aaron > > Subject: [PATCH v2] drm/amd/pm:

Re: [PATCH 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-26 Thread Alex Deucher
On Mon, Jul 25, 2022 at 11:03 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > > > > -Original Message- > > From: André Almeida > > Sent: Tuesday, July 26, 2022 12:15 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian > > ; Pan, Xinhui ; David > > Airlie ;

Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc

2022-07-26 Thread Michael Ellerman
Linus Torvalds writes: > On Mon, Jul 25, 2022 at 5:39 AM Michael Ellerman wrote: >> >> Further digging shows that the build failures only occur with compilers >> that default to 64-bit long double. > > Where the heck do we have 'long double' things anywhere in the kernel? There's one or two

[PATCH 20/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1372 dp_dsc_clock_en_read() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1478 dp_dsc_clock_en_write() warn:

[PATCH 14/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp_cm.c:450 dpp20_get_blndgam_current() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp_cm.c:543 dpp20_get_shaper_current() warn: inconsistent

[PATCH 11/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:186 optc3_set_dsc_config() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 7 ++-

[PATCH 08/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp_cm.c:67 dpp30_get_gamcor_current() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- .../drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 25

[PATCH 17/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:713 dml32_CalculateSwathWidth() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH 06/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:655 dcn315_clk_mgr_construct() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH 07/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:726 dcn31_clk_mgr_construct() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH 05/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:683 dcn316_clk_mgr_construct() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH 19/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
Clean up some inconsistent indenting, replace sizeof(x) / sizeof((x)[0])) with ARRAY_SIZE(x). smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/dcn30_fpu.c:185 optc3_fpu_set_vrr_m_const() warn: inconsistent indenting.

[PATCH 16/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_rq_dlg_calc_32.c:51 dml32_rq_dlg_get_rq_reg() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_rq_dlg_calc_32.c:68 dml32_rq_dlg_get_rq_reg()

[PATCH 03/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c:716 dcn314_clk_mgr_construct() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

[PATCH 15/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1728 dcn20_program_front_end_for_ctx() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- .../gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c |

Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc

2022-07-26 Thread Segher Boessenkool
Hi! On Mon, Jul 25, 2022 at 03:40:40PM -0700, Guenter Roeck wrote: > On 7/25/22 13:42, Segher Boessenkool wrote: > >>What I'm wondering is if the compiler is getting confused between > >>standard and long doubles when they are both the same bit length... > > > >The compiler emits the same code

Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc

2022-07-26 Thread Guenter Roeck
On 7/25/22 13:42, Segher Boessenkool wrote: On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote: Further digging shows that the build failures only occur with compilers that default to 64-bit long double. Where the heck do we have 'long double' things anywhere in the kernel? I

[PATCH 09/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp.c:724 dpp3_get_blndgam_current() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp.c:823 dpp3_get_shaper_current() warn: inconsistent indenting.

Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc

2022-07-26 Thread Michael Ellerman
Guenter Roeck writes: > On 7/25/22 13:42, Segher Boessenkool wrote: >> On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote: > Further digging shows that the build failures only occur with compilers > that default to 64-bit long double. Where the heck do we have 'long

[PATCH 01/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:910 dcn32_init_hw() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 8 1

[PATCH 10/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_mpc.c:116 mpc3_get_ogam_current() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_mpc.c:445 mpc3_get_shaper_current() warn: inconsistent indenting.

[PATCH 12/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb.c:104 dwb2_enable() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dwb.c | 4 ++-- 1 file

[PATCH 02/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:306 mpc32_get_shaper_current() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- .../gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 36

[PATCH 18/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn303/dcn303_fpu.c:205 dcn303_fpu_update_bw_bounding_box() warn: inconsistent indenting. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn303/dcn303_fpu.c:355 dcn303_fpu_init_soc_bounding_box()

[PATCH 13/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_mpc.c:305 mpc20_get_ogam_current() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- .../gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 36

[PATCH 04/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Jiapeng Chong
No functional modification involved. smatch warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn201/dcn201_clk_mgr.c:107 dcn201_update_clocks() warn: inconsistent indenting. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread Magali Lemes
On 7/25/22 20:38, Melissa Wen wrote: On 07/25, Magali Lemes wrote: On 7/25/22 16:42, André Almeida wrote: Hi Magali, Às 15:15 de 25/07/22, Magali Lemes escreveu: As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct _vcs_dpi_soc_bounding_box_st", change their types accordingly. I can see

[PATCH] drm/amdkfd: fix kgd_mem memory leak when importing dmabuf

2022-07-26 Thread Lang Yu
The kgd_mem memory allocated in amdgpu_amdkfd_gpuvm_import_dmabuf() is not freed properly. Explicitly free it in amdgpu_amdkfd_gpuvm_free_memory_of_gpu() under condition "mem->bo->kfd_bo != mem". Suggested-by: Felix Kuehling Signed-off-by: Lang Yu ---

Re: [PATCH v2 4/6] drm/i915: Implement intersect/compatible functions

2022-07-26 Thread Matthew Auld
On 25/07/2022 12:42, Arunpravin Paneer Selvam wrote: Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 43

RE: [PATCH 1/5] drm/amdgpu: add mode2 reset for sienna_cichlid

2022-07-26 Thread Zhao, Victor
[AMD Official Use Only - General] Will do. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:06 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng, Emily ; Koenig, Christian Subject: Re: [PATCH 1/5]

RE: [PATCH 4/5] drm/amdgpu: revert context to stop engine before mode2 reset

2022-07-26 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Andrey, For slow tests I mean the slow hang tests by quark tool. An example here: hang_vm_gfx_dispatch_slow.lua - This script runs on a graphics engine using compute engine and has a hacked CS program which is massive and duplicates standard CS program move

RE: [PATCH 5/5] drm/amdgpu: reduce reset time

2022-07-26 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Andrey, Reply inline. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:18 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng, Emily ; Koenig, Christian Subject: Re:

Crash on resume from S3

2022-07-26 Thread Tom Cook
I have a Ryzen 7 3700U in an HP laptop. lspci describes the GPU in this way: 04:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Picasso/Raven 2 [Radeon Vega Series / Radeon Vega Mobile Series] (rev c1) This laptop has never successfully resumed from suspend (I have tried

Re: [PATCH 1/3] Revert "drm/amdgpu: move internal vram_mgr function into the C file"

2022-07-26 Thread Tvrtko Ursulin
On 26/07/2022 08:46, Thomas Zimmermann wrote: Hi Am 25.07.22 um 19:14 schrieb Christian König: Am 25.07.22 um 17:27 schrieb Tvrtko Ursulin: On 24/07/2022 19:28, Thomas Zimmermann wrote: Hi Am 22.07.22 um 17:47 schrieb Christian König: Hi Tvrtko, scratching my head what exactly is going

Re: [PATCH 1/3] Revert "drm/amdgpu: move internal vram_mgr function into the C file"

2022-07-26 Thread Thomas Zimmermann
Hi Am 25.07.22 um 19:14 schrieb Christian König: Am 25.07.22 um 17:27 schrieb Tvrtko Ursulin: On 24/07/2022 19:28, Thomas Zimmermann wrote: Hi Am 22.07.22 um 17:47 schrieb Christian König: Hi Tvrtko, scratching my head what exactly is going on here. I've build tested drm-tip a couple of

RE: [PATCH v2] drm/amd/pm: Add get_gfx_off_status interface for yellow carp

2022-07-26 Thread Liu, Aaron
[AMD Official Use Only - General] Reviewed-by: Aaron Liu > -Original Message- > From: amd-gfx On Behalf Of > shikai@amd.com > Sent: Tuesday, July 26, 2022 2:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Liang, Prike > ; Quan, Evan ; Liu, Aaron > > Subject:

[PATCH v2] drm/amd/pm: Add get_gfx_off_status interface for yellow carp

2022-07-26 Thread shikai.guo
From: Shikai Guo add get_gfx_off_status interface to yellow_carp_ppt_funcs structure. Signed-off-by: Shikai Guo --- .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c