Hey, i have problems with my git-send today so i just attached V5 as a
patch here.
Andrey
On 2022-09-27 19:56, Luben Tuikov wrote:
Inlined:
On 2022-09-22 12:15, Andrey Grodzovsky wrote:
On 2022-09-22 11:03, Luben Tuikov wrote:
The title of this patch has "v3", but "v4" in the title prefix.
[AMD Official Use Only - General]
Hi Michel,
Please make sure umd is calling the libdrm function to create context with
different priories,
amdgpu_cs_ctx_create2(device_handle, AMDGPU_CTX_PRIORITY_HIGH, _handle).
Here is the behavior we could see:
1. After modprobe amdgpu, two software rings
Inlined:
On 2022-09-22 12:15, Andrey Grodzovsky wrote:
>
> On 2022-09-22 11:03, Luben Tuikov wrote:
>> The title of this patch has "v3", but "v4" in the title prefix.
>> If you're using "-v" to git-format-patch, please remove the "v3" from the
>> title.
>>
>> Inlined:
>>
>> On 2022-09-21 14:28,
Hi August,
I've sent a fix here: https://patchwork.freedesktop.org/patch/504993/
It's not the most ideal fix, but it should address the regression. Let
me know it works for you.
Thanks!
Leo
On 2022-09-27 10:22, August Wikerfors wrote:
Hi Leo,
On 2022-09-27 00:29, Leo Li wrote:
Hi
From: Leo Li
[Why]
Enabling Z10 optimizations allows DMUB to disable the OTG during PSR
link-off. This theoretically saves power by putting more of the display
hardware to sleep. However, we observe that with PSR SU, it causes
visual artifacts, higher power usage, and potential system hang.
On Tue, Sep 27, 2022 at 11:38 AM Sharma, Shashank
wrote:
>
>
>
> On 9/27/2022 5:23 PM, Felix Kuehling wrote:
> > Am 2022-09-27 um 10:58 schrieb Sharma, Shashank:
> >> Hello Felix,
> >>
> >> Thank for the review comments.
> >>
> >> On 9/27/2022 4:48 PM, Felix Kuehling wrote:
> >>> Am 2022-09-27 um
[AMD Official Use Only - General]
Reviewed-by: Aurabindo Pillai
--
Regards,
Jay
From: Mahfooz, Hamza
Sent: Tuesday, September 27, 2022 3:12 PM
To: linux-ker...@vger.kernel.org
Cc: Mahfooz, Hamza ; Wentland, Harry
; Li, Sun peng (Leo) ; Siqueira,
Rodrigo ;
Address the following error:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function
‘dc_stream_remove_writeback’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:527:55: error: array
subscript [0, 0] is outside array bounds of ‘struct dc_writeback_info[1]’
Am 2022-09-27 um 11:43 schrieb Philip Yang:
Unified memory usage with xnack off is tracked to avoid oversubscribe
system memory, with xnack on, we don't track unified memory usage to
allow memory oversubscribe. When switching xnack mode from off to on,
subsequent free ranges allocated with xnack
This work is solely for gfx9 (e.g. Vega) and older.
Navi has a completely separate high priority gfx queue we can use for this.
Thanks,
Christian.
Am 27.09.22 um 19:49 schrieb Michel Dänzer:
On 2022-09-27 08:06, Christian König wrote:
Hey Michel,
JIadong is working on exposing high/low
On 2022-09-27 08:06, Christian König wrote:
> Hey Michel,
>
> JIadong is working on exposing high/low priority gfx queues for gfx9 and
> older hw generations by using mid command buffer preemption.
Yeah, I've been keeping an eye on these patches. I'm looking forward to this
working.
> I know
On Tue, Sep 27, 2022 at 1:57 PM Mario Limonciello
wrote:
>
> We previously had in place some behavior that would cause APU or GPU
> to be reset during suspend entry. This caused various problems, and
> eventually was reverted. There are however users that preferred this
> behavior, so add an
We previously had in place some behavior that would cause APU or GPU
to be reset during suspend entry. This caused various problems, and
eventually was reverted. There are however users that preferred this
behavior, so add an option that they can use to force it.
Link:
On 2022-09-27 19:06, Sharma, Shashank wrote:
> On 9/27/2022 6:33 PM, Michel Dänzer wrote:
>> On 2022-09-27 13:47, Sharma, Shashank wrote:
>>> On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
> This patch and switches the GPU workload based profile
On 9/27/2022 7:13 PM, Michel Dänzer wrote:
On 2022-09-27 18:59, Sharma, Shashank wrote:
Hey Michel,
Thanks for the review coments.
On 9/27/2022 6:24 PM, Michel Dänzer wrote:
On 2022-09-26 23:40, Shashank Sharma wrote:
AMDGPU SOCs supports dynamic workload based power profiles, which can
On 2022-09-27 18:59, Sharma, Shashank wrote:
> Hey Michel,
> Thanks for the review coments.
>
> On 9/27/2022 6:24 PM, Michel Dänzer wrote:
>> On 2022-09-26 23:40, Shashank Sharma wrote:
>>> AMDGPU SOCs supports dynamic workload based power profiles, which can
>>> provide fine-tuned performance
On 9/27/2022 6:33 PM, Michel Dänzer wrote:
On 2022-09-27 13:47, Sharma, Shashank wrote:
On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the workload
From: Ville Syrjälä
Rename info->monitor_range to info->vrr_range to actually
reflect its usage.
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Leo Li
Cc: Rodrigo Siqueira
Cc: amd-gfx@lists.freedesktop.org
Reviewed-by: Manasi Navare
Acked-by: Jani Nikula
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Since we only use the parsed vrefresh range to determine
if VRR should be supported we should only accept continuous
frequency displays here.
Cc: Manasi Navare
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Leo Li
Cc: Rodrigo Siqueira
Cc: amd-gfx@lists.freedesktop.org
From: Ville Syrjälä
The current comment fails to clarify why we only accept
the "range limits only" variant of the range descriptor.
Reword it to make some actual sense.
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Leo Li
Cc: Rodrigo Siqueira
Cc: amd-gfx@lists.freedesktop.org
Reviewed-by:
Hey Michel,
Thanks for the review coments.
On 9/27/2022 6:24 PM, Michel Dänzer wrote:
On 2022-09-26 23:40, Shashank Sharma wrote:
AMDGPU SOCs supports dynamic workload based power profiles, which can
provide fine-tuned performance for a particular type of workload.
This patch series adds an
On 2022-09-27 13:47, Sharma, Shashank wrote:
> On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
>> On 9/27/2022 3:10 AM, Shashank Sharma wrote:
>>> This patch and switches the GPU workload based profile based
>>> on the workload hint information saved in the workload context.
>>> The workload profile is
On 2022-09-26 23:40, Shashank Sharma wrote:
> AMDGPU SOCs supports dynamic workload based power profiles, which can
> provide fine-tuned performance for a particular type of workload.
> This patch series adds an interface to set/reset these power profiles
> based on the workload type hints. A user
Unified memory usage with xnack off is tracked to avoid oversubscribe
system memory, with xnack on, we don't track unified memory usage to
allow memory oversubscribe. When switching xnack mode from off to on,
subsequent free ranges allocated with xnack off will not unreserve
memory. When switching
On 9/27/2022 5:23 PM, Felix Kuehling wrote:
Am 2022-09-27 um 10:58 schrieb Sharma, Shashank:
Hello Felix,
Thank for the review comments.
On 9/27/2022 4:48 PM, Felix Kuehling wrote:
Am 2022-09-27 um 02:12 schrieb Christian König:
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch
Am 2022-09-27 um 10:58 schrieb Sharma, Shashank:
Hello Felix,
Thank for the review comments.
On 9/27/2022 4:48 PM, Felix Kuehling wrote:
Am 2022-09-27 um 02:12 schrieb Christian König:
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch switches the GPU workload mode to/from
compute
Am 2022-09-26 um 17:40 schrieb Shashank Sharma:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload hint
flag.
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
Hello Felix,
Thank for the review comments.
On 9/27/2022 4:48 PM, Felix Kuehling wrote:
Am 2022-09-27 um 02:12 schrieb Christian König:
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch switches the GPU workload mode to/from
compute mode, while submitting compute workload.
On 9/27/2022 4:34 PM, Lazar, Lijo wrote:
On 9/27/2022 7:50 PM, Sharma, Shashank wrote:
On 9/27/2022 4:00 PM, Lazar, Lijo wrote:
On 9/27/2022 7:17 PM, Sharma, Shashank wrote:
On 9/27/2022 3:29 PM, Lazar, Lijo wrote:
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022
Am 2022-09-27 um 02:12 schrieb Christian König:
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch switches the GPU workload mode to/from
compute mode, while submitting compute workload.
Signed-off-by: Alex Deucher
Signed-off-by: Shashank Sharma
Feel free to add my acked-by, but
Hi Leo,
On 2022-09-27 00:29, Leo Li wrote:
Hi August, thanks for the log.
It seems the eDP panel does not fully satisfy the amdgpu requirements
for enabling PSR SU, but we're enabling it anyways.
I suspect it may be due to the "DP_FORCE_PSRSU_CAPABILITY" bit being set
in it's DPCD registers,
After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one
use struct i2c_id_config_access, so remove it.
Signed-off-by: Yuan Can
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 ---
1 file changed, 7 deletions(-)
diff --git
Hi Dmitry,
On 9/26/22 01:39, Dmitry Osipenko wrote:
> 25.08.2022 17:36, Hans de Goede пишет:
>> Before this commit when we want userspace to use the acpi_video backlight
>> device we register both the GPU's native backlight device and acpi_video's
>> firmware acpi_video# backlight device. This
On 9/27/2022 7:50 PM, Sharma, Shashank wrote:
On 9/27/2022 4:00 PM, Lazar, Lijo wrote:
On 9/27/2022 7:17 PM, Sharma, Shashank wrote:
On 9/27/2022 3:29 PM, Lazar, Lijo wrote:
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022
Am 2022-09-26 um 17:40 schrieb Shashank Sharma:
Allow the user to specify a workload hint to the kernel.
We can use these to tweak the dpm heuristics to better match
the workload for improved performance.
V3: Create only set() workload UAPI (Christian)
Signed-off-by: Alex Deucher
On 9/27/2022 4:00 PM, Lazar, Lijo wrote:
On 9/27/2022 7:17 PM, Sharma, Shashank wrote:
On 9/27/2022 3:29 PM, Lazar, Lijo wrote:
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022
On 9/27/2022 7:17 PM, Sharma, Shashank wrote:
On 9/27/2022 3:29 PM, Lazar, Lijo wrote:
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022
On 9/27/2022 3:29 PM, Lazar, Lijo wrote:
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022
On 9/27/2022 6:23 PM, Sharma, Shashank wrote:
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022
On 9/27/2022 2:39 PM, Lazar, Lijo wrote:
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds
On 9/27/2022 5:53 PM, Sharma, Shashank wrote:
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds new functions which will allow a user to
On 9/27/2022 2:20 PM, Lazar, Lijo wrote:
On 9/27/2022 5:17 PM, Sharma, Shashank wrote:
On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the
On 9/27/2022 2:10 PM, Lazar, Lijo wrote:
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload
On 9/27/2022 5:17 PM, Sharma, Shashank wrote:
On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the workload context.
The workload profile is reset
On 9/27/2022 5:11 PM, Sharma, Shashank wrote:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload hint
flag.
Cc: Alex Deucher
Signed-off-by:
On 9/27/2022 12:03 PM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the workload context.
The workload profile is reset to NONE when the job is done.
Signed-off-by:
On 9/27/2022 11:58 AM, Lazar, Lijo wrote:
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload hint
flag.
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
---
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the workload context.
The workload profile is reset to NONE when the job is done.
Signed-off-by: Alex Deucher
Signed-off-by: Shashank Sharma
On 9/27/2022 11:29 AM, Quan, Evan wrote:
[AMD Official Use Only - General]
-Original Message-
From: Sharma, Shashank
Sent: Tuesday, September 27, 2022 3:30 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Somalapuram,
Amaranath ; Koenig, Christian
On 9/27/2022 3:10 AM, Shashank Sharma wrote:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload hint
flag.
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
On 9/27/2022 1:05 PM, Tao Zhou wrote:
Inform host and let host handle consumption interrupt.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Gao, Likun
Sent: Tuesday, September 27, 2022 17:34
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Kuehling, Felix
Subject: [PATCH] drm/amdgpu: fix compiler warning for
[AMD Official Use Only - General]
From: Likun Gao
Change the type of parameter on amdgpu_gfx_cp_init_microcode to fix compiler
warning.
Signed-off-by: Likun Gao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +-
2 files changed, 2
[AMD Official Use Only - General]
> -Original Message-
> From: Sharma, Shashank
> Sent: Tuesday, September 27, 2022 3:30 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Somalapuram,
> Amaranath ; Koenig, Christian
>
> Subject: Re: [PATCH v3 2/5]
From: "Jiadong.Zhu"
Set ring functions with software ring callbacks on gfx9.
The software ring could be tested by debugfs_test_ib case.
v2: Set sw_ring 2 to enable software ring by default.
v3: Remove the parameter for software ring enablement.
v4: Use amdgpu_ring_init/fini for software rings.
From: "Jiadong.Zhu"
Trigger Mid-Command Buffer Preemption according to the priority of the software
rings and the hw fence signalling condition.
The muxer saves the locations of the indirect buffer frames from the software
ring together with the fence sequence number in its fifo queue, and pops
From: "Jiadong.Zhu"
1. Modify the unmap_queue package on gfx9. Add trailing fence to track the
preemption done.
2. Modify emit_ce_meta emit_de_meta functions for the resumed ibs.
v2: Restyle code not to use ternary operator.
v3: Modify code format.
v4: Enable Mid-Command Buffer Preemption
From: "Jiadong.Zhu"
The software ring is created to support priority context while there is only
one hardware queue for gfx.
Every software ring has its fence driver and could be used as an ordinary ring
for the GPU scheduler.
Multiple software rings are bound to a real ring with the ring
Felix Kuehling writes:
> On 2022-09-26 17:35, Lyude Paul wrote:
>> On Mon, 2022-09-26 at 16:03 +1000, Alistair Popple wrote:
>>> When the module is unloaded or a GPU is unbound from the module it is
>>> possible for device private pages to be left mapped in currently running
>>> processes.
On 9/26/22 14:35, Lyude Paul wrote:
>> +for (i = 0; i < npages; i++) {
>> +if (src_pfns[i] & MIGRATE_PFN_MIGRATE) {
>> +struct page *dpage;
>> +
>> +/*
>> + * _GFP_NOFAIL because the GPU is going away and there
>> +
As kzalloc and dm_helpers_allocate_gpu_mem can return NULL pointer,
it should be better to check the return value and return error.
Moreover, the return value of dcn32_clk_mgr_construct should be checked
by cascade.
Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
John Hubbard writes:
> On 9/26/22 14:35, Lyude Paul wrote:
>>> + for (i = 0; i < npages; i++) {
>>> + if (src_pfns[i] & MIGRATE_PFN_MIGRATE) {
>>> + struct page *dpage;
>>> +
>>> + /*
>>> +* _GFP_NOFAIL because the GPU is
Jason Gunthorpe writes:
> On Mon, Sep 26, 2022 at 04:03:06PM +1000, Alistair Popple wrote:
>> Since 27674ef6c73f ("mm: remove the extra ZONE_DEVICE struct page
>> refcount") device private pages have no longer had an extra reference
>> count when the page is in use. However before handing them
Inform host and let host handle consumption interrupt.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index
Hello Evan,
On 9/27/2022 4:14 AM, Quan, Evan wrote:
[AMD Official Use Only - General]
-Original Message-
From: amd-gfx On Behalf Of
Shashank Sharma
Sent: Tuesday, September 27, 2022 5:40 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Somalapuram,
Amaranath ; Koenig,
Am 27.09.22 um 05:37 schrieb Asher Song:
This patch is used to fix following compiling error that occurs in some
old kernels.
error: ‘for’ loop initial declarations are only allowed in C99 mode
for (int i = 0; i < dc->res_pool->res_cap->num_dsc; i++) {
Signed-off-by: Asher Song
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch switches the GPU workload mode to/from
compute mode, while submitting compute workload.
Signed-off-by: Alex Deucher
Signed-off-by: Shashank Sharma
Feel free to add my acked-by, but Felix should probably take a look as well.
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch and switches the GPU workload based profile based
on the workload hint information saved in the workload context.
The workload profile is reset to NONE when the job is done.
Signed-off-by: Alex Deucher
Signed-off-by: Shashank Sharma
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch adds new IOCTL flags in amdgpu_context_IOCTL to set
GPU workload profile. These calls will allow a user to switch
to a GPU power profile which might be better suitable to its
workload type. The currently supported workload types are:
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
This patch adds new functions which will allow a user to
change the GPU power profile based a GPU workload hint
flag.
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
Alex needs to take a closer look at this stuff, but feel free to add my
Am 26.09.22 um 23:40 schrieb Shashank Sharma:
Allow the user to specify a workload hint to the kernel.
We can use these to tweak the dpm heuristics to better match
the workload for improved performance.
V3: Create only set() workload UAPI (Christian)
Signed-off-by: Alex Deucher
Signed-off-by:
Hey Michel,
JIadong is working on exposing high/low priority gfx queues for gfx9 and
older hw generations by using mid command buffer preemption.
I know that you have been working on Gnome Mutter to make use from
userspace for this. Do you have time to run some tests with that?
Thanks,
72 matches
Mail list logo
