RE: [PATCH] drm/amdkfd: correct the cache info for gfx1036

2022-10-10 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - General] correct the cache information for gfx1036 Signed-off-by: Yifan Zhang yifan1.zh...@amd.com Signed-off-by: jie1zhan jesse.zh...@amd.com Change-Id:

RE: [PATCH] drm/amdgpu: remove unnecessary condition check

2022-10-10 Thread Gao, Likun
[AMD Official Use Only - General] Reviewed-by: Likun Gao . Regards, Likun -Original Message- From: amd-gfx On Behalf Of Hawking Zhang Sent: Tuesday, October 11, 2022 11:46 AM To: amd-gfx@lists.freedesktop.org; Gao, Likun ; Deucher, Alexander Cc: Zhang, Hawking Subject: [PATCH]

[PATCH] drm/amdgpu: remove unnecessary condition check

2022-10-10 Thread Hawking Zhang
version_minor>=0 is always true. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c index

RE: [PATCH 4/4] drm/amdgpu: fix coding style issue for mca notifier

2022-10-10 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, October 10, 2022 11:12 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas ; Li, Candice Cc: Zhou1, Tao Subject: [PATCH 4/4] drm/amdgpu: fix coding

Re: [PATCH v2] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-10 Thread Felix Kuehling
Am 2022-10-10 um 05:01 schrieb Slivka, Danijel: [AMD Official Use Only - General] Thank you for the input. Regarding function amdgpu_virt_mmio_blocked, this is not returning correct results as it is checking if read operation is successful, which for VF MMIO access protection is always

[PATCH] drm/amd/display: add a license to cursor_reg_cache.h

2022-10-10 Thread Alex Deucher
It's MIT. Fixes: b73353f7f3d434 ("drm/amd/display: Use the same cursor info across features") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/inc/hw/cursor_reg_cache.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/cursor_reg_cache.h

Re: [PATCH] drm/amd/display: fix transfer function passed to build_coefficients()

2022-10-10 Thread Alex Deucher
Ping? Alex On Mon, Sep 19, 2022 at 12:44 PM Alex Deucher wrote: > > The default argument should be enum TRANSFER_FUNCTION_SRGB rather than > the current boolean value which improperly maps to > TRANSFER_FUNCTION_BT709. > > Commit 9b3d76527f6e ("drm/amd/display: Revert adding degamma

Re: [PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback() [take 2]

2022-10-10 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Oct 10, 2022 at 2:05 AM Guenter Roeck wrote: > > Commit 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in > dc_stream_remove_writeback()") tried to fix an array bounds error seen > with gcc 12.0. Unfortunately, that results in another array bounds error, >

Re: [PATCH 2/2] drm/amd/pm: smu7_hwmgr: fix potential off-by-one overflow in 'performance_levels'

2022-10-10 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Oct 8, 2022 at 5:13 AM Quan, Evan wrote: > > Series is reviewed-by: Evan Quan > > > -Original Message- > > From: amd-gfx On Behalf Of > > Alexey Kodanev > > Sent: Tuesday, October 4, 2022 4:14 PM > > To: amd-gfx@lists.freedesktop.org > > Cc: Alexey

Re: [PATCH v6 10/21] RDMA/umem: Prepare to dynamic dma-buf locking specification

2022-10-10 Thread Jason Gunthorpe
On Sun, Oct 09, 2022 at 03:08:56AM +0300, Dmitry Osipenko wrote: > On 9/28/22 22:15, Dmitry Osipenko wrote: > > Prepare InfiniBand drivers to the common dynamic dma-buf locking > > convention by starting to use the unlocked versions of dma-buf API > > functions. > > > > Acked-by: Christian König

[linux-next:master] BUILD REGRESSION cd9fd78f5c11b5e165d9317ef11e613f4aef4dd1

2022-10-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: cd9fd78f5c11b5e165d9317ef11e613f4aef4dd1 Add linux-next specific files for 20221010 Error/Warning reports: https://lore.kernel.org/linux-doc/202209201326.sy9kholm-...@intel.com https

[PATCH] drm/amd/display: make virtual_disable_link_output static

2022-10-10 Thread Alex Deucher
It's not used outside of virtual_link_hwss.c. Fixes a -Wmissing-prototypes warning. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdkfd: Fix the warning of array-index-out-of-bounds

2022-10-10 Thread Ma, Jun
Hi Felix, Thanks for this suggestion, I'll make a new patch to fix this. Regards, Ma Jun On 10/9/2022 12:34 AM, Felix Kuehling wrote: > This breaks the CRAT table ABI, which will break APUs that use an actual > CRAT table from ACPI. > > I think to fix this, you'll need to populate >

Re: [PATCH v6 10/21] RDMA/umem: Prepare to dynamic dma-buf locking specification

2022-10-10 Thread Dmitry Osipenko
On 9/28/22 22:15, Dmitry Osipenko wrote: > Prepare InfiniBand drivers to the common dynamic dma-buf locking > convention by starting to use the unlocked versions of dma-buf API > functions. > > Acked-by: Christian König > Signed-off-by: Dmitry Osipenko > --- >

[PATCH -next] drm/amd/display: Simplify bool conversion

2022-10-10 Thread Yang Li
The result of 'pwr_status == 0' is Boolean, and the question mark expression is redundant. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback() [take 2]

2022-10-10 Thread Guenter Roeck
Commit 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()") tried to fix an array bounds error seen with gcc 12.0. Unfortunately, that results in another array bounds error, seen with older versions of gcc. Building csky:allmodconfig ... failed --

[PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-10 Thread Deming Wang
Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-10 Thread Deming Wang
Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Signed-off-by: Deming Wang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/amd/display: fix another array-bounds error in dc_stream_remove_writeback()

2022-10-10 Thread Palmer Dabbelt
From: Palmer Dabbelt Without this I get some warnings. I get the following with GCC 11: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function ‘dc_stream_remove_writeback’: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:527:83: warning: array subscript 1 is above

RE: [PATCH v2] drm/amdgpu: set vm_update_mode=0 as default for Sienna Cichlid in SRIOV case

2022-10-10 Thread Slivka, Danijel
[AMD Official Use Only - General] Thank you for the input. Regarding function amdgpu_virt_mmio_blocked, this is not returning correct results as it is checking if read operation is successful, which for VF MMIO access protection is always allowed. Regarding other suggestion to set this in some

RE: [PATCH 2/2] drm/amdgpu: Add poison mode query for umc v8_10_0

2022-10-10 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice > Li > Sent: Monday, October 10, 2022 2:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH 2/2] drm/amdgpu: Add poison mode query

[PATCH 2/2] drm/amdgpu: Add poison mode query for umc v8_10_0

2022-10-10 Thread Candice Li
Add poison mode query support on umc v8_10_0. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/umc_v8_10.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c b/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c index

[PATCH 1/2] drm/amdgpu: Update umc v8_10_0 headers

2022-10-10 Thread Candice Li
Add GeccCtrl offset and mask to umc v8_10_0 headers. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/include/asic_reg/umc/umc_8_10_0_offset.h | 2 ++ drivers/gpu/drm/amd/include/asic_reg/umc/umc_8_10_0_sh_mask.h | 3 +++ 2 files changed, 5 insertions(+) diff --git

[PATCH 2/4] drm/amdgpu: Add software ring callbacks for gfx9 (v8)

2022-10-10 Thread jiadong.zhu
From: "Jiadong.Zhu" Set ring functions with software ring callbacks on gfx9. The software ring could be tested by debugfs_test_ib case. v2: Set sw_ring 2 to enable software ring by default. v3: Remove the parameter for software ring enablement. v4: Use amdgpu_ring_init/fini for software rings.