[Public]
Hi Mario,
Comments inline. Thanks.
Best Regards,
Tim Huang
-Original Message-
From: Limonciello, Mario
Sent: Friday, October 14, 2022 5:35 AM
To: Huang, Tim ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Yifan
; Du, Xiaojian ; Gong, Richard
Subject: Re:
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Song, Asher
Sent: Friday, October 14, 2022 12:15 PM
To: Deucher, Alexander ; stalk...@gmail.com; Chen,
Guchun ; Quan, Evan ;
amd-gfx@lists.freedesktop.org
Cc: Song, Asher
Subject: [PATCH] drm/amdgpu: Revert
This reverts commit fe01cb24b81c0091d7e5668874d51ce913e44a97.
Unfortunately, that commit causes fan monitors can't be read and written
properly.
Signed-off-by: Asher Song
---
.../amd/pm/powerplay/hwmgr/vega10_thermal.c | 25 ++-
1 file changed, 13 insertions(+), 12
Update: Remove redundant comments as Christian suggests.
[Why]
If mes is not dequeued during fini, mes will be in an uncleaned state
during reload, then mes couldn't receive some commands which leads to
reload failure.
[How]
Perform MES dequeue via MMIO after all the unmap jobs are done by mes
On 10/13/2022 00:46, Tim Huang wrote:
The pmfw has changed the driver interface version, so keep same with the
fw.
Signed-off-by: Tim Huang
Cc: sta...@vger.kernel.org #6.0
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +-
1 file changed, 1
On 10/13/2022 00:46, Tim Huang wrote:
Update the SMU driver interface version to V7.
Signed-off-by: Tim Huang
---
.../swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git
The use of kmap() is being deprecated in favor of kmap_local_page().
There are two main problems with kmap(): (1) It comes with an overhead as
the mapping space is restricted and protected by a global lock for
synchronization and (2) it also requires global TLB invalidation when the
kmap’s pool
Building 32-bit images may fail with the following error.
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:
In function ‘dml32_UseMinimumDCFCLK’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:3142:1:
error: the frame
From: Mukul Joshi
Cleanup kfd_dev struct by removing ddev and pdev as both
drm_device and pci_dev can be fetched from amdgpu_device.
Signed-off-by: Mukul Joshi
Tested-by: Amber Lin
Reviewed-by: Felix Kuehling
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2
> > > So no tests that actually verify that the kernel properly rejects
> > > stuff stuff like modesets, gamma LUT updates, plane movement,
> > > etc.?
> >
> > Pondering this a bit more, it just occurred to me the current driver
> > level checks might easily lead to confusing behaviour. Eg. is
> >
On Wed, Oct 12, 2022 at 5:36 AM ZhenGuo Yin wrote:
>
> [Why]
> In SRIOV multi-vf, dpm is always disabled, and pm_attr_list won't
> be initialized. There will be a NULL pointer call trace after
> removing the dpm check condition in amdgpu_pm_sysfs_fini.
> BUG: kernel NULL pointer dereference,
Hi!
I bisected an issue of the 6.0 kernel which started happening after
6.0-rc7 on all my machines.
Backtrace of this issue looks like as:
[ 2807.339439] [ cut here ]
[ 2807.339445] WARNING: CPU: 11 PID: 2061 at
drivers/gpu/drm/drm_modeset_lock.c:276
[Public]
This patch is missing your signed-off-by.
Alex
From: amd-gfx on behalf of Victor Zhao
Sent: Thursday, October 13, 2022 4:27 AM
To: amd-gfx@lists.freedesktop.org
Cc: Grodzovsky, Andrey ; Lazar, Lijo
; Zhao, Victor
Subject: [PATCH 1/3] Revert
Am 13.10.22 um 12:39 schrieb YuBiao Wang:
Resend to fix coding style issue.
[Why]
If mes is not dequeued during fini, mes will be in an uncleaned state
during reload, then mes couldn't receive some commands which leads to
reload failure.
[How]
Perform MES dequeue via MMIO after all the unmap
Resend to fix coding style issue.
[Why]
If mes is not dequeued during fini, mes will be in an uncleaned state
during reload, then mes couldn't receive some commands which leads to
reload failure.
[How]
Perform MES dequeue via MMIO after all the unmap jobs are done by mes
and before kiq fini.
[Why]
If mes is not dequeued during fini, mes will be in an uncleaned state
during reload, then mes couldn't receive some commands which leads to
reload failure.
[How]
Perform MES dequeue via MMIO after all the unmap jobs are done by mes
and before kiq fini.
Signed-off-by: YuBiao Wang
---
On 10/13/2022 1:57 PM, Victor Zhao wrote:
This reverts commit 3ae992d5e1194a16e3d977076eb5722fa6e410d8.
This commit breaks the reset logic for aldebaran, revert it for now.
Will move the mask inside the reset handler.
Thanks for reverting. Please cc me also for refactored patches for SMU
On 10/13/2022 10:56 AM, Quan, Evan wrote:
[AMD Official Use Only - General]
-Original Message-
From: Lazar, Lijo
Sent: Thursday, October 13, 2022 12:14 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zhang, Hawking
Subject: Re: [PATCH V3 3/3]
This reverts commit 3efc702897c54c95c332632157ab042e942512c7.
This commit reverted the AMDGPU_SKIP_MODE2_RESET as it conflicts with
the original design of reset handler. Will redesign it.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +--
- refactor mode2 on v11.0.7 to align with aldebaran
- comment out using mode2 reset as default for now, will introduce
another controller to replace previous reset_level_mask
Signed-off-by: Victor Zhao
---
drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c | 23 ++---
1 file changed,
This reverts commit 3ae992d5e1194a16e3d977076eb5722fa6e410d8.
This commit breaks the reset logic for aldebaran, revert it for now.
Will move the mask inside the reset handler.
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 --
Inlined:
On 2022-10-10 02:07, jiadong@amd.com wrote:
> From: "Jiadong.Zhu"
>
> Set ring functions with software ring callbacks on gfx9.
>
> The software ring could be tested by debugfs_test_ib case.
>
> v2: Set sw_ring 2 to enable software ring by default.
> v3: Remove the parameter for
22 matches
Mail list logo
