[AMD Official Use Only - General]
I suggest you add comments here to remind people check whether
set_ta_context_funcs is called *before* using the following macros. They seems
general ta related interfaces but now *only* used by tools.
Going forward, we can a). introduce more TA type support,
If discovery is set to 2 in module parameters explicitly, the
intention is to use the discovery file in FW rather than the one in
BIOS, usually because the latter is incorrect. This patch to force
read discovery file if set discovery=2.
Signed-off-by: Yifan Zhang
---
Hello,
Can you write here your card name and firmware version? Without this patch,
my fan sensors are broken, and it's sensitive to my pc case with water
cooling.
My card is: Sapphire Pulse Radeon RX Vega 56 vd6546 SA
lspci name: [AMD/ATI] Vega 10 XL/XT [Radeon RX Vega 56/64] (rev c3)
Firmware:
1. Add a function pointer structure ta_funcs to psp context
2. Make the interfaces generic to all TAs
3. Leverage exisitng TA context and remove unused functions
4. Fix return code bugs
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c| 38 +---
1. Save TA unload psp response status
2. Add RAS TA loading status check for initialzaiton
3. Drop RAS context teardown to allow RAS TA to be reloaded
Signed-off-by: Candice Li
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
On Tue, Oct 25, 2022 at 10:25:33PM +0200, Hans de Goede wrote:
> Having the native driver come and then go and be replaced
> with the vendor driver would also be quite inconvenient
> for these planned changes.
I understand that it would be inconvenient, but you've broken existing
working
Hi (again),
On 10/25/22 22:25, Hans de Goede wrote:
> Hi Matthew,
>
> On 10/25/22 21:32, Matthew Garrett wrote:
>> On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
>>
>>> That is a valid point, but keep in mind that this is only used on ACPI
>>> platforms and then only on devices
Hi Matthew,
On 10/25/22 21:32, Matthew Garrett wrote:
> On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
>
>> That is a valid point, but keep in mind that this is only used on ACPI
>> platforms and then only on devices with a builtin LCD panel and then
>> only by GPU drivers which
On 10/25/2022 15:25, Hans de Goede wrote:
Hi Matthew,
On 10/25/22 21:32, Matthew Garrett wrote:
On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
That is a valid point, but keep in mind that this is only used on ACPI
platforms and then only on devices with a builtin LCD panel
On Tue, Oct 25, 2022 at 03:48:33PM -0400, Felix Kuehling wrote:
> Am 2022-10-25 um 05:12 schrieb Paulo Miguel Almeida:
> > kfd_pm4_headers_diq.h header is a leftover from the old H/W debugger
> > module support added on commit . That implementation
> > was removed after a while and the last file
On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
> That is a valid point, but keep in mind that this is only used on ACPI
> platforms and then only on devices with a builtin LCD panel and then
> only by GPU drivers which actually call acpi_video_get_backlight_type(),
> so e.g. not
Hi,
On 10/24/22 22:30, Matthew Garrett wrote:
> On Tue, Sep 27, 2022 at 01:04:52PM +0200, Hans de Goede wrote:
>
>> So to fix this we need to make acpi_video_get_backlight_type()
>> return native on the Acer Chromebook Spin 713.
>
> Isn't the issue broader than that? Unless the platform is
Am 2022-10-25 um 05:12 schrieb Paulo Miguel Almeida:
kfd_pm4_headers_diq.h header is a leftover from the old H/W debugger
module support added on commit . That implementation
was removed after a while and the last file that included that header
was removed on commit <5bdd3eb253544b1>.
This
Am 2022-10-25 um 02:09 schrieb Yang Li:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331
svm_migrate_copy_to_vram() warn: inconsistent indenting
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
Reported-by: Abaci Robot
Signed-off-by: Yang Li
This patch doesn't apply to our
Am 2022-10-25 um 03:28 schrieb Yang Li:
./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:985:58-62: ERROR: p is NULL but
dereferenced.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2549
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 ++-
Use mes.sched_version, mes.kiq_version for debugfs as
mes.ucode_fw_version does not contain correct versioning information.
Signed-off-by: Graham Sider
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
MES scheduler and kiq versions are stored in mes.sched_version and
mes.kiq_version, respectively, which are read from a register after
their queues are initialized. Remove mes.ucode_fw_version and
mes.data_fw_version which tried to read this versioning info from the
firmware headers (which don't
On Tue, 25 Oct 2022 09:21:07 +0100 Russell King (Oracle) wrote:
> Not me, Sean. My original implementation of phylink_validate_mask_caps()
> doesn't know anything about rate matching, so my version didn't have
> this issue.
>
> Sean's version of my patch (which is what was submitted) added the
>
On Tue, Oct 25, 2022 at 4:00 AM Alan Liu wrote:
>
> [Why]
> Before we call psp_securedisplay_invoke(), we call
> psp_prep_securedisplay_cmd_buf() to prepare and initialize the command
> buffer.
>
> However, we didn't use the mutex_lock to protect the status of command
> buffer. So when multiple
On Tue, Oct 25, 2022 at 03:15:49PM +0800, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the kset.kobj.name allocated by kobject_set_name()
> which must be called before a call to kset_register() may be
> leaked, since refcount of kobj was set
On Tue, 25 Oct 2022 at 16:51, Somalapuram Amaranath
wrote:
>
> Change ttm_resource structure from num_pages to size_t size in bytes.
> v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages
> v1 -> v2: change bo->resource->size to bo->base.size at some places
> v1 -> v2: remove the local
On 2022-10-25 03:15, Yang Yingliang wrote:
> Inject fault while loading module, kset_register() may fail.
> If it fails, the kset.kobj.name allocated by kobject_set_name()
> which must be called before a call to kset_register() may be
> leaked, since refcount of kobj was set in kset_init().
Am 25.10.22 um 17:50 schrieb Somalapuram Amaranath:
Change ttm_resource structure from num_pages to size_t size in bytes.
v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages
v1 -> v2: change bo->resource->size to bo->base.size at some places
v1 -> v2: remove the local variable
v1 -> v2:
Change ttm_resource structure from num_pages to size_t size in bytes.
v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages
v1 -> v2: change bo->resource->size to bo->base.size at some places
v1 -> v2: remove the local variable
v1 -> v2: cleanup cmp_size_smaller_first()
Signed-off-by:
On 10/21/22 00:31, Ao Zhong wrote:
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG form the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao
Hi Ao,
First of all, thanks a lot for this patch.
On 10/20/22 20:31, Ao Zhong wrote:
Move remaining FPU code to dml folder
in preparation for enabling aarch64 support.
I guess you found some of the issues here after you tried enabling the
arm64 compilation, right? If so, could you expand
@Daniel Vetter
, @Dave Airlie
Any objections taking this through the AMD tree or would you rather it
landed via drm-misc?
Thanks,
Alex
On Tue, Oct 25, 2022 at 10:21 AM Harry Wentland wrote:
>
> Series is
>
> Reviewed-by: Harry Wentland
>
> Harry
>
> On 2022-10-24 15:22, Hamza Mahfooz wrote:
On 2022-10-24 13:10, Alex Deucher wrote:
> build htmldocs produced this warning:
> drivers/gpu/drm/amd/display/dc/dc.h:1275: warning: cannot understand function
> prototype: 'struct dc_validation_set '
> The word "struct" was left out of the comment.
>
> Fixes: f4a59996c408 ("drm/amd/display:
Am 2022-10-25 um 07:37 schrieb Ma, Jun:
Hi Felix,
On 10/25/2022 5:06 AM, Felix Kuehling wrote:
On 2022-10-24 07:26, Ma Jun wrote:
For some GPUs with more CUs, the original sibling_map[32]
in struct crat_subtype_cache is not enough
to save the cache information when create the VCRAT table,
Series is
Reviewed-by: Harry Wentland
Harry
On 2022-10-24 15:22, Hamza Mahfooz wrote:
> This reverts commit 55eea8ef98641f6e1e1c202bd3a49a57c1dd4059.
>
> This quirk is now handled in the DRM core, so we can drop all of
> the internal code that was added to handle it.
>
> Signed-off-by: Hamza
The change of the commit ("Adjust removal control
flow for smu v13_0_2") brought a bug on SRIOV envrionment. It
caused unloading amdgpu failed on Guest VM. The reason is that
the VF FLR was requested while unloading amdgpu driver, but the
VF FLR of SRIOV sequence is wrong while removing
Hang on MES timeout if halt_if_hws_hang is set to 1.
Signed-off-by: Graham Sider
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 4
2 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
On Tue, Oct 25, 2022 at 4:29 AM Yifan Zha wrote:
>
> [Why]
> gfxhub_v3_0_3 system aperture registers are removed from RLCG register access
> range.
>
> [How]
> Skip access gfxhub_v3_0_3 system aperture registers under SRIOV VF.
> These registers will be programmed on host side.
>
>
On Tue, Oct 25, 2022 at 5:06 AM Yifan Zha wrote:
>
> [Why]
> GRBM_CNTL is a PF_only register on gfx_v11.
> RLCG interface will return "out of range" under SRIOV VF.
>
> [How]
> Skip access GRBM_CNTL under gfx_v11 SRIOV VF.
>
> Signed-off-by: Yifan Zha
Acked-by: Alex Deucher
> ---
>
kfd_pm4_headers_diq.h header is a leftover from the old H/W debugger
module support added on commit . That implementation
was removed after a while and the last file that included that header
was removed on commit <5bdd3eb253544b1>.
This patch removes the unused header file kfd_pm4_headers_diq.h
struct cdit_header was never used across any of the amd drivers nor
this is exposed to UAPI so it can be removed.
This patch removes struct cdit_header and refactor code accordingly
Signed-off-by: Paulo Miguel Almeida
---
At some point, removing this structure was suggested during a review for
./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:985:58-62: ERROR: p is NULL but
dereferenced.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2549
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 ++-
1 file changed, 2 insertions(+), 1
On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote:
> On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote:
> > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable
> > dereferenced before check 'state' (see line 583)
>
> Hi Russell, I think the warning is
Hi Felix,
On 10/25/2022 5:06 AM, Felix Kuehling wrote:
>
> On 2022-10-24 07:26, Ma Jun wrote:
>> For some GPUs with more CUs, the original sibling_map[32]
>> in struct crat_subtype_cache is not enough
>> to save the cache information when create the VCRAT table,
>> so fill the cache info into
Hi Felix,
Thanks for review. I will fix these problems in v2.
Regards,
Ma Jun
On 10/25/2022 5:03 AM, Felix Kuehling wrote:
> On 2022-10-24 07:26, Ma Jun wrote:
>> Init and save the base cu processor id for later use
>>
>> Signed-off-by: Ma Jun
>> ---
>> drivers/gpu/drm/amd/amdkfd/kfd_crat.c
Am 25.10.22 um 05:23 schrieb Luna Nova:
This patch doesn't apply nicely on 6.0, seems amd-staging-drm-next is missing
9b04369b060fd4885f728b7a4ab4851ffb1abb64 drm/scheduler: Don't kill jobs in
interrupt context
Yeah, so what? This is a rebase on top of amd-staging-drm-next. I've
just pushed
On 9/28/22 14:01, Alistair Popple wrote:
> This series aims to fix a number of page reference counting issues in
> drivers dealing with device private ZONE_DEVICE pages. These result in
> use-after-free type bugs, either from accessing a struct page which no
> longer exists because it has been
Am 24.10.22 um 22:21 schrieb Gavin Wan:
The change of the commit f5c7e7797060 ("Adjust removal control
flow for smu v13_0_2") brought a bug on SRIOV envrionment. It
caused unloading amdgpu failed on Guest VM. The reason is that
the VF FLR was requested while unloading amdgpu
[Why]
GRBM_CNTL is a PF_only register on gfx_v11.
RLCG interface will return "out of range" under SRIOV VF.
[How]
Skip access GRBM_CNTL under gfx_v11 SRIOV VF.
Signed-off-by: Yifan Zha
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
It's working 100% time correctly on my Vega 56 it was a reason why I did it
because without it returns mostly random data.
On Fri, Oct 14, 2022 at 1:15 PM Asher Song wrote:
> This reverts commit fe01cb24b81c0091d7e5668874d51ce913e44a97.
>
> Unfortunately, that commit causes fan monitors can't
[Why]
gfxhub_v3_0_3 system aperture registers are removed from RLCG register access
range.
[How]
Skip access gfxhub_v3_0_3 system aperture registers under SRIOV VF.
These registers will be programmed on host side.
Signed-off-by: Yifan Zha
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 3 +++
[Why]
Before we call psp_securedisplay_invoke(), we call
psp_prep_securedisplay_cmd_buf() to prepare and initialize the command
buffer.
However, we didn't use the mutex_lock to protect the status of command
buffer. So when multiple threads are using the command buffer, after
thread A return from
[Why]
gfxhub_v3_0_3 system aperture registers are removed from RLCG register access
range.
[How]
Skip access gfxhub_v3_0_3 system aperture registers under SRIOV VF.
These registers will be programmed on host side.
Signed-off-by: Yifan Zha
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 3 +++
[Why]
SDMA0_F32_CNTL is a PF_only regitser which will be blocked by L1.
RLCG will not program the register as well.
[How]
Skip to program SDMA0_F32_CNTL under SRIOV VF.
Signed-off-by: Yifan Zha
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Hi
Am 24.10.22 um 18:48 schrieb Alex Deucher:
On Mon, Oct 24, 2022 at 3:33 AM Thomas Zimmermann wrote:
Hi
Am 24.10.22 um 08:20 schrieb Quan, Evan:
[AMD Official Use Only - General]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex
Deucher
Sent:
On Tue, Sep 27, 2022 at 01:04:52PM +0200, Hans de Goede wrote:
> So to fix this we need to make acpi_video_get_backlight_type()
> return native on the Acer Chromebook Spin 713.
Isn't the issue broader than that? Unless the platform is Windows 8 or
later, we'll *always* (outside of some corner
This patch doesn't apply nicely on 6.0, seems amd-staging-drm-next is missing
9b04369b060fd4885f728b7a4ab4851ffb1abb64 drm/scheduler: Don't kill jobs in
interrupt context
On Fri, 14 Oct 2022, at 01:46, Christian König wrote:
> We leaked dependency fences when processes were beeing killed.
>
>
Inject fault while loading module, kset_register() may fail.
If it fails, the kset.kobj.name allocated by kobject_set_name()
which must be called before a call to kset_register() may be
leaked, since refcount of kobj was set in kset_init().
To mitigate this, we free the name in kset_register()
Hi,
On 2022/10/25 5:25, Luben Tuikov wrote:
On 2022-10-24 17:06, Luben Tuikov wrote:
On 2022-10-24 08:19, Yang Yingliang wrote:
Inject fault while loading module, kset_register() may fail.
If it fails, the name allocated by kobject_set_name() which
is called before kset_register() is leaked,
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331
svm_migrate_copy_to_vram() warn: inconsistent indenting
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +--
1 file changed, 1
55 matches
Mail list logo
