[PATCH] drm/amdgpu: remove the check of init status in psp_ras_initialize

The initialized status indicates RAS TA is loaded, but in some cases (such as RAS fatal error) RAS TA could be destroyed although it's not unloaded. Hence we load RAS TA unconditionally here. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +++- 1 file changed, 3

RE: [PATCH] drm/amdgpu: add vram reservation logic based on vram_usagebyfirmware_v2_2

[AMD Official Use Only - General] Hi @Tuikov, Luben, Which checkpatch.pl you used? I use the one in /linux/script/checkpatch.pl on branch amd-staging-drm-next. And I only got line length warning as: root@amd-SYS-7048GR-TR:~/gerrit/esther/linux# ./scripts/checkpatch.pl

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

On Wed, Nov 9, 2022 at 8:31 PM Paulo Miguel Almeida wrote: > > On Wed, Nov 09, 2022 at 06:45:57PM -0600, Gustavo A. R. Silva wrote: > > On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: > > > > Adding Alex, Christian and DRM lists to the thread. > > Thanks so much for your

RE: [PATCH] drm/amd/pm: skip disabling all smu features on smu_v13_0_10 in suspend

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Thursday, November 10, 2022 10:55 To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm: skip disabling all smu

[PATCH] drm/amd/pm: skip disabling all smu features on smu_v13_0_10 in suspend

skip disabling all smu features on smu_v13_0_10 in suspend Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c index

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

On Wed, Nov 09, 2022 at 06:45:57PM -0600, Gustavo A. R. Silva wrote: > On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: > > Adding Alex, Christian and DRM lists to the thread. Thanks so much for your reply Gustavo Yep, that's a good idea. > > > struct _ATOM_INIT_REG_BLOCK

RE: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.

[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Gavin Wan Sent: Thursday, November 10, 2022 2:24 AM To: amd-gfx@lists.freedesktop.org Cc: Wan, Gavin Subject: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: Adding Alex, Christian and DRM lists to the thread. > Hi KSPP community, > > I've been working on replacing 1-element arrays with flex array members > on the drm/amdgpu files. I came across one insteresting case which I > may

[pull] amdgpu, amdkfd drm-fixes-6.1

Hi Dave, Daniel, Fixes for 6.1. The following changes since commit 6295f1d8b4503ad8a18519b781dd2d1fe5e88c52: Merge tag 'drm-intel-fixes-2022-11-03' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2022-11-04 09:30:18 +1000) are available in the Git repository at:

RE: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.

[AMD Official Use Only - General] Rewed-by: shaoyun liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, November 9, 2022 2:07 PM To: Wan, Gavin Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment. On Wed,

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

On 11/9/22 13:20, Hamza Mahfooz wrote: Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are

Re: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.

On Wed, Nov 9, 2022 at 1:24 PM Gavin Wan wrote: > > For SRIOV, the guest driver should not do stop rlc. The host > handles programing RLC. > > On SRIOV, the stop rlc will be hang (RLC related registers are > blocked by policy) when the RLCG interface is not enabled. > > Signed-off-by: Gavin Wan

RE: [PATCH] drm/amdgpu: fix for suspend/resume sequence under sriov

[AMD Official Use Only - General] @Deucher, Alexander Following up on this to see if the patch reviewed and approved for up streaming? Thanks, SIRISH -Original Message- From: Zhao, Victor Sent: Thursday, November 3, 2022 12:08 AM To: Zhao,

[PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.

For SRIOV, the guest driver should not do stop rlc. The host handles programing RLC. On SRIOV, the stop rlc will be hang (RLC related registers are blocked by policy) when the RLCG interface is not enabled. Signed-off-by: Gavin Wan Change-Id: Iac31332e2c958aae9506759de1d3a311b5c84942 ---

[PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are only useful for debugging PSR (and confusing

[PATCH] drm/amd/display: only fill dirty rectangles when PSR is enabled

Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH] drm/amd/display: delete the duplicate .set_odm_bypass initialization in dcn314_tg_funcs

Fix below sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:244:18: warning: Initializer entry defined twice drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:257:18: also defined here Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions")

[PATCH] [next] drm/amdgpu: Replace one-element array with flex-array member

One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in structs _ATOM_CONNECTOR_DEVICE_TAG_RECORD, _ATOM_OBJECT_GPIO_CNTL_RECORD, _ATOM_BRACKET_LAYOUT_RECORD, _ATOM_BRACKET_LAYOUT_RECORD,

Re: [PATCH 1/2] drm/amdgpu: Move racy global PMU list into device

On Tue, Nov 08, 2022 at 11:50:04AM -0500, Felix Kuehling wrote: > While you're making the pmu list per-device, I'd suggest removing adev from > the pmu entry because it is now redundant. The device is implied by the list > that the entry is on. Instead, add an adev parameter to >

RE: [PATCH 2/2] drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code

[AMD Official Use Only - General] Hi Lyude, It LGTM. Feel free to add Reviewed-by: Wayne Lin > -Original Message- > From: Lyude Paul > Sent: Saturday, November 5, 2022 7:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: sta...@vger.kernel.org; David Airlie ; Daniel Vetter > ; Jani

RE: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

[Public] Thanks, Lyude! Comments inline. > -Original Message- > From: Lyude Paul > Sent: Saturday, November 5, 2022 7:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry ; sta...@vger.kernel.org; > Li, Sun peng (Leo) ; Siqueira, Rodrigo > ; Deucher, Alexander > ; Koenig,