Am 12.01.23 um 02:31 schrieb Felix Kuehling:
Rebased on latest amd-staging-drm-next. This is meant to be the final
review of this series, assuming no more issues are found.
This patch series enables KFD to interoperate more closely with DRM render
nodes. ROCm user mode already uses DRM render
[AMD Official Use Only - General]
Reviewed-by: Alan Liu
Thanks,
Alan
-Original Message-
From: Mahfooz, Hamza
Sent: Thursday, January 12, 2023 2:17 AM
To: amd-gfx@lists.freedesktop.org
Cc: Mahfooz, Hamza ; Wentland, Harry
; Li, Sun peng (Leo) ; Siqueira,
Rodrigo ; Deucher, Alexander
The assignment of the else and if branches is the same, so the if else
here is redundant, so we remove it.
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1951:2-4: WARNING: possible
condition with no effect (if == else).
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3719
Hi Dave, Daniel,
Fixes for 6.2.
The following changes since commit 93235bfd5a9c3329df31d1a4d7a93d138b3138c2:
Merge tag 'amd-drm-fixes-6.2-2023-01-04' of
https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2023-01-05 12:13:51
+0100)
are available in the Git repository at:
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it
warns:
clang-16: error: argument unused during compilation: '-mhard-float'
[-Werror,-Wunused-command-line-argument]
Similar to commit 84edc2eff827 ("selftest/fpu: avoid clang warning"),
just add this flag to GCC builds.
Hi all,
Clang can emit a few different warnings when it encounters a flag that it
recognizes but does not support internally. These warnings are elevated to
errors within {as,cc}-option via -Werror to catch unsupported flags that should
not be added to KBUILD_{A,C}FLAGS; see commit c3f0d0bc5b01
On Wed, Jan 11, 2023, 15:50 Alex Deucher wrote:
> On Wed, Jan 11, 2023 at 3:48 PM Alex Deucher
> wrote:
> >
> > On Wed, Jan 4, 2023 at 3:17 PM Marek Olšák wrote:
> > >
> > > Yes, it's meant to be like a spec sheet. We are not interested in the
> current bandwidth utilization.
> >
> > After
This is needed to correctly handle BOs imported into the GEM API, which
would otherwise get added twice to the same VM.
Signed-off-by: Felix Kuehling
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 28 +++
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git
When restoring after an eviction, use amdgpu_vm_handle_moved to update
BO VA mappings in KFD VMs that are not managed through the KFD API. This
should allow using the render node API to create more flexible memory
mappings in KFD VMs.
v2: Sync with pd fence after all page table updates
v3: Update
Instead of attaching the eviction fence when a KFD BO is first mapped,
attach it when it is allocated or imported. This in preparation to allow
KFD BOs to be mapped using the render node API.
Signed-off-by: Felix Kuehling
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 63
Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by
the caller. This will be useful for handling extra BO VA mappings in
KFD VMs that are managed through the render node API.
Signed-off-by: Felix Kuehling
Reviewed-by: Christian König
---
Exports a DMA buf fd of a given KFD buffer handle. This is intended for
being able to import KFD BOs into GEM contexts to leverage the
amdgpu_bo_va API for more flexible virtual address mappings. It will
also be used for the new upstreamable RDMA solution coming to UCX and
RCCL.
The corresponding
Rebased on latest amd-staging-drm-next. This is meant to be the final
review of this series, assuming no more issues are found.
This patch series enables KFD to interoperate more closely with DRM render
nodes. ROCm user mode already uses DRM render nodes to create its GPU VM
contexts and to
Use proper amdgpu_gem_prime_import function to handle all kinds of
imports. Remember the dmabuf reference to enable proper multi-GPU
attachment to multiple VMs without erroneously re-exporting the
underlying BO multiple times.
Signed-off-by: Felix Kuehling
---
On Mon, Dec 05, 2022 at 05:34:07PM -0700, Jim Cromie wrote:
> Hi everyone,
>
> DRM_USE_DYNAMIC_DEBUG=y has a regression on rc-*
>
> Regression is due to a chicken-egg problem loading modules; on
> `modprobe i915`, drm is loaded 1st, and drm.debug is set. When
> drm_debug_enabled() tested
On Mon, Dec 05, 2022 at 05:34:20PM -0700, Jim Cromie wrote:
> Cited commit uses stale macro name, fix this, and explain better.
>
> When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_*
> onto BITs in drm.debug. This still uses enum drm_debug_category, but
> it is somewhat
On DCN314 when resuming from s0i3 an ASSERT is shown indicating that
`VBIOSSMC_MSG_SetHardMinDcfclkByFreq` returned `VBIOSSMC_Result_Failed`.
This isn't a driver bug; it's a BIOS/configuration bug. To make this
easier to triage, add an explicit warning when this issue happens.
This matches the
On Wed, Jan 11, 2023 at 3:48 PM Alex Deucher wrote:
>
> On Wed, Jan 4, 2023 at 3:17 PM Marek Olšák wrote:
> >
> > Yes, it's meant to be like a spec sheet. We are not interested in the
> > current bandwidth utilization.
>
> After chatting with Marek on IRC and thinking about this more, I think
>
On Wed, Jan 4, 2023 at 3:17 PM Marek Olšák wrote:
>
> Yes, it's meant to be like a spec sheet. We are not interested in the current
> bandwidth utilization.
After chatting with Marek on IRC and thinking about this more, I think
this patch is fine. It's not really meant for bandwidth per se,
It is possible that adev->dm.dc->caps.max_links is greater than
AMDGPU_MAX_CRTCS. So, to not potentially access unallocated memory use
adev->mode_info.num_crtc to do the bounds check instead of
adev->dm.dc->caps.max_links.
Fixes: 278b2b5ba2f2 ("drm/amd/display: Implement multiple secure display")
Hi
Am 11.01.23 um 16:38 schrieb Thomas Zimmermann:
Set the framebuffer info for drivers that support VGA switcheroo. Only
affects the amdgpu driver, which uses VGA switcheroo and generic fbdev
emulation. For other drivers, this does nothing.
Amdgpu's lastclose helper called
On Wed, Jan 11, 2023 at 10:38 AM Thomas Zimmermann wrote:
>
> Set the framebuffer info for drivers that support VGA switcheroo. Only
> affects the amdgpu driver, which uses VGA switcheroo and generic fbdev
> emulation. For other drivers, this does nothing.
>
> Amdgpu's lastclose helper called
On Wed, Jan 11, 2023 at 04:38:13PM +0100, Thomas Zimmermann wrote:
> Set the framebuffer info for drivers that support VGA switcheroo. Only
> affects the amdgpu driver, which uses VGA switcheroo and generic fbdev
> emulation. For other drivers, this does nothing.
>
> Amdgpu's lastclose helper
On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote:
> Include in source files that need it. Some of DRM's
> source code gets OF header via drm_crtc_helper.h and ,
> which can leed to unnecessary recompilation.
>
> In drm_modes.c, add a comment on the reason for still including
> .
On Wed, Jan 11, 2023 at 02:02:02PM +0100, Thomas Zimmermann wrote:
> Define enum mode_set_atomic next to the only interface that uses
> the type. This will allow for removing several include statements
> for drm_fb_helper.h. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
On Wed, Jan 11, 2023 at 02:01:59PM +0100, Thomas Zimmermann wrote:
> Including in drm_crtc_helper.h is not required. Remove
> the include statement and avoid rebuilding DRM whenever the fbdev
> header changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
> include/drm/drm_crtc_helper.h | 2 --
>
Set the framebuffer info for drivers that support VGA switcheroo. Only
affects the amdgpu driver, which uses VGA switcheroo and generic fbdev
emulation. For other drivers, this does nothing.
Amdgpu's lastclose helper called vga_switcheroo_process_delayed_switch().
But as amdgpu uses generic fbdev
On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote:
>
>
> On 11/22/22 06:20, hongao wrote:
>> [Why]
>> Setting scaling does not correctly update CRTC state. As a result
>> dc stream state's src (composition area) && dest (addressable area)
>> was not calculated as expected. This causes set scaling
On Wed, Jan 11, 2023 at 8:23 AM Quan, Evan wrote:
>
> [AMD Official Use Only - General]
>
> Hi Matt,
>
> The problem with the approach(removal of interface functions from the
> ppt_funcs) is:
> 1. If to drop support for some sysfs interface, you need to know the internal
> implementation
On Tue, Jan 10, 2023 at 10:44 AM Rodrigo Siqueira
wrote:
>
> It was reported that on kernel v6.2-rc1, we have the following stack
> size issue:
>
> make[3]: *** [/kisskb/src/scripts/Makefile.build:504: drivers/media]
> Error 2
> [...]/display/dc/dml/dcn31/display_mode_vba_31.c: In function
>
Yes, the revert was reverted.
Alex
On Wed, Jan 11, 2023 at 3:35 AM Chen, Guchun wrote:
>
> Hi Yury,
>
>
>
> My understanding is though that’s a revert of your original patch, we did a
> revert again on top of the reverted patch later on. Can you please sync to
> below commit to check again?
On Wed, Jan 11, 2023 at 11:16:32AM +0800, Baolu Lu wrote:
> On 2023/1/10 21:25, Jason Gunthorpe wrote:
> > > + } else {
> > > + if (!pdev->bus->self ||
> > > + !pci_acs_path_enabled(pdev->bus->self, NULL,
> > > +
Hi
Am 11.01.23 um 14:21 schrieb Christian König:
Am 11.01.23 um 14:02 schrieb Thomas Zimmermann:
Including is not required, so remove the include
statements. No functional changes.
Reviewed-by: Christian König for this one and
the radeon patches #9 and #10 in this set.
Do you want to
[AMD Official Use Only - General]
Hi Matt,
The problem with the approach(removal of interface functions from the
ppt_funcs) is:
1. If to drop support for some sysfs interface, you need to know the internal
implementation details to mask out the corresponding function.
That's not
Am 11.01.23 um 14:02 schrieb Thomas Zimmermann:
Including is not required, so remove the include
statements. No functional changes.
Reviewed-by: Christian König for this one and
the radeon patches #9 and #10 in this set.
Do you want to push them to drm-misc-next because of some
On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote:
> Include in source files that need it. Some of DRM's
> source code gets OF header via drm_crtc_helper.h and ,
> which can leed to unnecessary recompilation.
>
> In drm_modes.c, add a comment on the reason for still including
> .
Including is not required, so remove the include
statements. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/radeon/atombios_crtc.c | 1 -
drivers/gpu/drm/radeon/radeon_connectors.c | 1 -
drivers/gpu/drm/radeon/radeon_drv.c | 1 -
Including is not required, so remove the include
statement. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 -
drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
2 files changed, 2 deletions(-)
diff --git
Define enum mode_set_atomic next to the only interface that uses
the type. This will allow for removing several include statements
for drm_fb_helper.h. No functional changes.
Signed-off-by: Thomas Zimmermann
---
include/drm/drm_fb_helper.h | 5 -
Remove unnecessary include statements for . I recently
changed this header and had to rebuild a good part of DRM. So avoid
this by removing the dependency.
Several files include via drm_fb_helper.h. So in v2 I
added additional patches that remove some of those include statements
as well.
Some
Remove unnecessary include statements for . No functional
changes. Include where the driver got the header file via
.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 1 -
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 -
Remove unnecessary include statements for . No functional
changes.
Signed-off-by: Thomas Zimmermann
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 1 -
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
b/drivers/gpu/drm/radeon/radeon_legacy_crtc.c
index
Including is not required, so remove the include
statements. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 -
Include in source files that need it. Some of DRM's
source code gets OF header via drm_crtc_helper.h and ,
which can leed to unnecessary recompilation.
In drm_modes.c, add a comment on the reason for still including
. The header file is required to get KHZ2PICOS(). The
macro is part of the UAPI
Include in source files that need it. Some of
DRM's source code gets the backlight header via drm_crtc_helper.h
and , which can leed to unnecessary recompilation. If
possible, do not include drm_crtc_helper.h any longer.
Signed-off-by: Thomas Zimmermann
Acked-by: Christian König # amd
---
Including in drm_crtc_helper.h is not required. Remove
the include statement and avoid rebuilding DRM whenever the fbdev
header changes.
Signed-off-by: Thomas Zimmermann
---
include/drm/drm_crtc_helper.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/drm/drm_crtc_helper.h
This needs to be squashed together with patch #3 and #4, otherwise you
would break the drivers in between.
What you can do is to separate the GDS/GWS/OA changes out of patch #3.
Christian.
Am 11.01.23 um 07:35 schrieb Somalapuram Amaranath:
Remove page shift operations as ttm_resource moved
This patch here needs to come first, otherwise changing the TTM/AMDGPU
internals to allow byte sized BOs for GDS would trigger this BUG_ON().
Christian.
Am 11.01.23 um 07:35 schrieb Somalapuram Amaranath:
ttm_resource allocate size in bytes to support less than page size
Signed-off-by:
Am 11.01.23 um 07:35 schrieb Somalapuram Amaranath:
Remove page shift operations as ttm_resource moved
from num_pages to size_t size in bytes.
This patch here is at least missing to remove the shifts in
amdgpu_job_set_resources():
if (gds) {
job->gds_base =
Hi Matt,
after reading a bit into the topic I think I know what's going on here.
The assumption that you need ACS to enable PASID handling is simply
incorrect.
Going to send a revert of the offending patch with an in deep
description of the problem.
Thanks,
Christian.
Am 10.01.23 um
Hi Yury,
My understanding is though that's a revert of your original patch, we did a
revert again on top of the reverted patch later on. Can you please sync to
below commit to check again? Or do I understand wrong?
On 2023/1/10 21:25, Jason Gunthorpe wrote:
+ } else {
+ if (!pdev->bus->self ||
+ !pci_acs_path_enabled(pdev->bus->self, NULL,
+ PCI_ACS_RR | PCI_ACS_UF))
+ return -EINVAL;
+ }
Why would
Hello,
Something went wrong, and we commited what we diced not commit.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.2-rc3=e5b781c56d46c44c52caa915f1b65064f2f7c1ba
and
54 matches
Mail list logo
