Re: [PATCH v2] drm/radeon: Do not use deprecated drm log API

2023-01-18 Thread Sam Ravnborg
Hi Nirmoy, On Tue, Jan 17, 2023 at 07:04:16PM +0100, Nirmoy Das wrote: > Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() > with proper APIs. Thanks for working on this! Also thanks for Christian to take care and apply the patches. Sam

RE: [PATCH] drm/amdgpu: retire unused get_umc_v6_7_channel_index

2023-01-18 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Thursday, January 19, 2023 14:26 To: Yang, Stanley ; Zhang, Hawking ; Chai, Thomas ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu:

[PATCH] drm/amdgpu: retire unused get_umc_v6_7_channel_index

2023-01-18 Thread Tao Zhou
Fix the following compile warning: drivers/gpu/drm/amd/amdgpu/umc_v6_7.c:53:24: warning: unused function 'get_umc_v6_7_channel_index' [-Wunused-function] static inline uint32_t get_umc_v6_7_channel_index(struct amdgpu_device *adev, ^ 1 warning generated. Signed-off-by:

RE: [PATCH 2/2] drm/amdgpu: Optimize sdma ras block initialization code for sdma v4_0

2023-01-18 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of YiPeng Chai Sent: Thursday, January 19, 2023 13:00 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Zhang, Hawking ; Chai, Thomas ; Li, Candice ;

[PATCH 2/2] drm/amdgpu: Optimize sdma ras block initialization code for sdma v4_0

2023-01-18 Thread YiPeng Chai
Optimize sdma ras block initialization code for sdma v4_0. Signed-off-by: YiPeng Chai Reviewed-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

[PATCH 1/2] drm/amdgpu: Add sdma ras function on sdma v6_0_3

2023-01-18 Thread YiPeng Chai
Add sdma ras function on sdma v6_0_3. Signed-off-by: YiPeng Chai Reviewed-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 35 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 24 3 files changed,

RE: [PATCH 2/2] drm/amd/display: disable S/G display on DCN 3.1.4

2023-01-18 Thread Zhang, Yifan
[Public] This series is: Reviewed-by: Yifan Zhang -Original Message- From: Deucher, Alexander Sent: Wednesday, January 18, 2023 10:26 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Li, Roman ; Zhang, Yifan Subject: [PATCH 2/2] drm/amd/display: disable S/G display on

Re: [PATCH] drm/amd/display: remove duplicate included header files

2023-01-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 18, 2023 at 2:49 AM wrote: > > From: ye xingchen > > resource.h is included more than once. > > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

[PATCH] drm/amd: Don't look for SRAT on systems without NUMA

2023-01-18 Thread Mario Limonciello
Laptops that have NUMA won't have an SRAT. Only look for SRAT when it should be there. Suggested-by: Felix Kuehling Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] drm/amd: Decrease warning about missing SRAT table to debug

2023-01-18 Thread Felix Kuehling
Am 2023-01-18 um 17:47 schrieb Mario Limonciello: As OEMs will control what ACPI tables are on their systems, SRAT might not be present. To avoid making an assumption that it is there but still be useful for debugging a missing table decrease warning about missing table to debug. Finding out

Re: [PATCH 0/3] Quiet down some warnings on laptops

2023-01-18 Thread Deucher, Alexander
[AMD Official Use Only - General] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Mario Limonciello Sent: Wednesday, January 18, 2023 5:47 PM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: [PATCH 0/3] Quiet down some

[PATCH 2/3] drm/amd: Decrease warning about missing SRAT table to debug

2023-01-18 Thread Mario Limonciello
As OEMs will control what ACPI tables are on their systems, SRAT might not be present. To avoid making an assumption that it is there but still be useful for debugging a missing table decrease warning about missing table to debug. Signed-off-by: Mario Limonciello ---

[PATCH 3/3] drm/amd: decrease message about missing PSP runtime database to debug

2023-01-18 Thread Mario Limonciello
Laptops with APUs from a variety of manufacturers and generations show a warning about a missing PSP runtime database. As it's not required for PSP to dump this database into framebuffer, decrease messages about it missing to debug. Signed-off-by: Mario Limonciello ---

[PATCH 1/3] drm/amd/display: Decrease messaging about DP alt mode state to debug

2023-01-18 Thread Mario Limonciello
Currently plugging in a USB-C device that issues an HPD will emit a warning level message `DP Alt mode state on HPD: %d`. This is needlessly noisy for most people, decrease it to debug so that it can be turned on by dynamic debug as needed. Signed-off-by: Mario Limonciello ---

[PATCH 0/3] Quiet down some warnings on laptops

2023-01-18 Thread Mario Limonciello
Looking at Cezanne laptops from a few manufacturers I've noticed a few harmless warnings are emitted to the logs. I looked through them and think they can all be decreased to debug. Mario Limonciello (3): drm/amd/display: Decrease messaging about DP alt mode state to debug drm/amd: Decrease

[PATCH] Documentation/gpu: update dGPU asic info table

2023-01-18 Thread Alex Deucher
Update to the latest launched dGPUs. Link: https://www.amd.com/en/graphics/radeon-rx-graphics Link: https://www.amd.com/en/graphics/amd-radeon-rx-laptops Signed-off-by: Alex Deucher --- Documentation/gpu/amdgpu/dgpu-asic-info-table.csv | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Intel-gfx] [PATCH v2 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-18 Thread Rodrigo Vivi
On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote: > Set the framebuffer info for drivers that support VGA switcheroo. Only > affects the amdgpu and nouveau drivers, which use VGA switcheroo and > generic fbdev emulation. For other drivers, this does nothing. > > This fixes a

Re: [PATCH 4/4] Documentation/gpu: Add Raphael to apu-asic-info-table

2023-01-18 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Wed, Jan 18, 2023 at 12:28 PM Mario Limonciello wrote: > > Raphael launched in 2022 but was missed to add to this table. > > Signed-off-by: Mario Limonciello > --- > Documentation/gpu/amdgpu/apu-asic-info-table.csv | 1 + > 1 file changed, 1

Re: [PATCH 0/4] Update AMD APU IP version docs

2023-01-18 Thread Guilherme G. Piccoli
On 18/01/2023 14:28, Mario Limonciello wrote: > Guilherme G. Piccoli submitted some patches recently to the mailing list > related to removing IP version detection code. As part of the discussion > it was mentioned that non-obviously some IP blocks are shared between > multiple APU parts. > >

[PATCH] drm/amdgpu: limit AV1 to the first instance on VCN4 encode

2023-01-18 Thread David (Ming Qiang) Wu
AV1 is only supported on the first instance. Added vcn_v4_0_enc_find_ib_param() to help search for an IB param. Signed-off-by: David (Ming Qiang) Wu Reviewed-by: Ruijing Dong --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 62 --- 1 file changed, 46 insertions(+), 16

[PATCH 2/4] Documentation/gpu: Update lines for GREEN_SARDINE and YELLOW_CARP

2023-01-18 Thread Mario Limonciello
These products have launched, so add matching codenames. Also AMD has announced that both of these products have new refresh variants that launch in 2023 using the new naming scheme, so add that information. Link:

[PATCH 4/4] Documentation/gpu: Add Raphael to apu-asic-info-table

2023-01-18 Thread Mario Limonciello
Raphael launched in 2022 but was missed to add to this table. Signed-off-by: Mario Limonciello --- Documentation/gpu/amdgpu/apu-asic-info-table.csv | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv

[PATCH 3/4] Documentation/gpu: Add Mendocino to apu-asic-info-table

2023-01-18 Thread Mario Limonciello
Mendocino launched in 2023 and uses the new naming scheme for APU processors. Link: https://community.amd.com/t5/corporate/announcing-new-model-numbers-for-2023-mobile-processors/ba-p/543985 Signed-off-by: Mario Limonciello --- Documentation/gpu/amdgpu/apu-asic-info-table.csv | 1 + 1 file

[PATCH 1/4] Documentation/gpu: Add MP0 version to apu-asic-info-table

2023-01-18 Thread Mario Limonciello
MP0 version is useful to know to figure out which firmware is intended for a platform. Add a column for all supported APUs. Signed-off-by: Mario Limonciello --- Documentation/gpu/amdgpu/apu-asic-info-table.csv | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 0/4] Update AMD APU IP version docs

2023-01-18 Thread Mario Limonciello
Guilherme G. Piccoli submitted some patches recently to the mailing list related to removing IP version detection code. As part of the discussion it was mentioned that non-obviously some IP blocks are shared between multiple APU parts. The example given was for launched products Rembrandt and

Re: [PATCH] drm/amd/display: fix hdmi_encoded_link_bw definition

2023-01-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 18, 2023 at 11:07 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Some of the data structures are hidden when CONFIG_DRM_AMD_DC_DCN is > disabled, which leads to a link failure: > >

Re: [PATCH] drm/amd/display: fix dp_retrieve_lttpr_cap() return value

2023-01-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 18, 2023 at 4:30 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc-13 notices a mismatch between the return type of dp_retrieve_lttpr_cap() > and the returned value: > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c: In > function

[PATCH] drm/amd/display: fix hdmi_encoded_link_bw definition

2023-01-18 Thread Arnd Bergmann
From: Arnd Bergmann Some of the data structures are hidden when CONFIG_DRM_AMD_DC_DCN is disabled, which leads to a link failure: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c:234:21: error: 'union hdmi_encoded_link_bw' declared inside parameter list will not be visible

Re: [PATCH 1/2] drm/amd/display: disable S/G display on DCN 3.1.5

2023-01-18 Thread Christian König
Am 18.01.23 um 15:26 schrieb Alex Deucher: Causes flickering or white screens in some configurations. Disable it for now until we can fix the issue. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2354 Cc: roman...@amd.com Cc: yifan1.zh...@amd.com Signed-off-by: Alex Deucher Acked-by:

Re: [PATCH] amd/dcn20: Fix high mem clock with multiple displays

2023-01-18 Thread Alex Deucher
On Wed, Jan 18, 2023 at 5:43 AM Nicu Borta wrote: > > On RX5000 series GPUs, using a high refresh rate monitor causes the VRAM to > always stay at the highest clock (according to AMD, this is done to prevent > flickering). > > However, when using 2 monitors (e.g. one at 165Hz and another at

RE: [PATCH 2/2] drm/amd/display: disable S/G display on DCN 3.1.4

2023-01-18 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: Deucher, Alexander > Sent: Wednesday, January 18, 2023 9:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Li, Roman > ; Zhang, Yifan > Subject: [PATCH 2/2] drm/amd/display: disable S/G display on DCN 3.1.4

[PATCH 2/2] drm/amd/display: disable S/G display on DCN 3.1.4

2023-01-18 Thread Alex Deucher
Causes flickering or white screens in some configurations. Disable it for now until we can fix the issue. Cc: roman...@amd.com Cc: yifan1.zh...@amd.com Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 1/2] drm/amd/display: disable S/G display on DCN 3.1.5

2023-01-18 Thread Alex Deucher
Causes flickering or white screens in some configurations. Disable it for now until we can fix the issue. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2354 Cc: roman...@amd.com Cc: yifan1.zh...@amd.com Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1

[PATCH] amd/dcn20: Fix high mem clock with multiple displays

2023-01-18 Thread Nicu Borta
On RX5000 series GPUs, using a high refresh rate monitor causes the VRAM to always stay at the highest clock (according to AMD, this is done to prevent flickering). However, when using 2 monitors (e.g. one at 165Hz and another at 60Hz), then disconnecting the high refresh monitor, before this

Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-18 Thread Das, Nirmoy
On 1/18/2023 7:27 AM, Christian König wrote: Am 17.01.23 um 19:12 schrieb Das, Nirmoy: Hi Alex, On 1/17/2023 7:06 PM, Alex Deucher wrote: On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das wrote: There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc:

[PATCH] drm/amd/display: remove duplicate included header files

2023-01-18 Thread ye.xingchen
From: ye xingchen resource.h is included more than once. Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH] drm/amd/display: fix dp_retrieve_lttpr_cap() return value

2023-01-18 Thread Arnd Bergmann
From: Arnd Bergmann gcc-13 notices a mismatch between the return type of dp_retrieve_lttpr_cap() and the returned value: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dp_capability.c: In function 'dp_retrieve_lttpr_cap':

Re: [PATCH 1/4] drm/amdgpu/nv: don't expose AV1 if VCN0 is harvested

2023-01-18 Thread Christian König
Acked-by: Christian König Regards, Christian. Am 18.01.23 um 02:09 schrieb Liu, Leo: [AMD Official Use Only - General] The series are: Reviewed-by: Leo Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: January 17, 2023 3:00 PM To: amd-gfx@lists.freedesktop.org