RE: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-02 Thread Xiao, Jack
[AMD Official Use Only - General] >> It's simply illegal to free up memory during suspend. Why? In my understanding, the limit was caused by DMA shutdown. Regards, Jack From: Koenig, Christian Sent: Thursday, February 2, 2023 7:43 PM To: Xiao, Jack ; amd-gfx@lists.freedesktop.org; Deucher,

[PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-02 Thread Joshua Ashton
Userspace has no way of controlling or knowing the pixel encoding currently, so there is no way for it to ever get the right values here. When we do add pixel_encoding control from userspace,we can pick the right value for the colorimetry packet based on the pixel_encoding + the colorspace.

[PATCH 2/3] drm/connector: Add enum documentation to drm_colorspace

2023-02-02 Thread Joshua Ashton
To match the other enums, and add more information about these values. Signed-off-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: dri-de...@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org ---

[PATCH 1/3] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-02-02 Thread Joshua Ashton
From: Harry Wentland This allows us to use strongly typed arguments. Signed-off-by: Harry Wentland Reviewed-by: Simon Ser Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: dri-de...@lists.freedesktop.org Cc:

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Bert Karwatzki
I hope I got it right this time: Here is the fix for Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 >From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject: [PATCH] Fix memory leak in

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Alex Deucher
On Thu, Feb 2, 2023 at 1:05 PM Bert Karwatzki wrote: > > amdgpu_sync_get_fence deletes the returned fence from the syncobj, so > the refcount of fence needs to lowered to avoid a memory leak: > https://gitlab.freedesktop.org/drm/amd/-/issues/2360 Bug:

Re: [PATCH v3] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-02 Thread Guilherme G. Piccoli
On 02/02/2023 13:12, Luben Tuikov wrote: > Hi Guilherme, > > Thanks for redoing to a v3. This patch is: > > Reviewed-by: Luben Tuikov > > Regards, > Luben > Thank you for the reviews Luben, much appreciated!

[PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Bert Karwatzki
amdgpu_sync_get_fence deletes the returned fence from the syncobj, so the refcount of fence needs to lowered to avoid a memory leak: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index

RE: [PATCH] drm/amd: Allow s0ix without BIOS support

2023-02-02 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Wednesday, February 1, 2023 21:49 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org; Rafael Ávila de Espíndola > > Subject: Re: [PATCH] drm/amd: Allow s0ix without BIOS support > > On Wed,

[PATCH] drm/amdgpu: Use the TGID for trace_amdgpu_vm_update_ptes

2023-02-02 Thread Friedrich Vock
The pid field corresponds to the result of gettid() in userspace. However, userspace cannot reliably attribute PTE events to processes with just the thread id. This patch allows userspace to easily attribute PTE update events to specific processes by comparing this field with the result of

Re: [PATCH v3] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-02 Thread Luben Tuikov
Hi Guilherme, Thanks for redoing to a v3. This patch is: Reviewed-by: Luben Tuikov Regards, Luben On 2023-02-02 08:48, Guilherme G. Piccoli wrote: > Currently amdgpu calls drm_sched_fini() from the fence driver sw fini > routine - such function is expected to be called only after the >

Re: [PATCH] drm/amd/amdgpu: enable athub cg on gc 11.0.3

2023-02-02 Thread Alex Deucher
On Thu, Feb 2, 2023 at 2:51 AM Kenneth Feng wrote: > > enable athub cg on gc 11.0.3 > > Signed-off-by: Kenneth Feng Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c

[linux-next:master] BUILD REGRESSION ea4dabbb4ad7eb52632a2ca0b8f89f0ea7c55dcf

2023-02-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: ea4dabbb4ad7eb52632a2ca0b8f89f0ea7c55dcf Add linux-next specific files for 20230202 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301301801.y5o08tqx-...@intel.com https

Re: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-02 Thread Guilherme G. Piccoli
On 02/02/2023 08:58, Christian König wrote: > [...] >> +if (!ring->no_scheduler && ring->sched.ops) >> drm_sched_fini(>sched); > > I think we should drop the check for no_scheduler here and just call > drm_sched_fini() when the scheduler instance was initialized

[PATCH v3] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-02 Thread Guilherme G. Piccoli
Currently amdgpu calls drm_sched_fini() from the fence driver sw fini routine - such function is expected to be called only after the respective init function - drm_sched_init() - was executed successfully. Happens that we faced a driver probe failure in the Steam Deck recently, and the function

Re: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-02 Thread Christian König
Am 01.02.23 um 17:48 schrieb Guilherme G. Piccoli: Currently amdgpu calls drm_sched_fini() from the fence driver sw fini routine - such function is expected to be called only after the respective init function - drm_sched_init() - was executed successfully. Happens that we faced a driver probe

AW: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-02 Thread Koenig, Christian
Big NAK to this! This warning is not related in any way to the hw state. It's simply illegal to free up memory during suspend. Regards, Christian. Von: Xiao, Jack Gesendet: Donnerstag, 2. Februar 2023 10:54 An: amd-gfx@lists.freedesktop.org ; Deucher,

[PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-02 Thread Jack Xiao
Reduce waringings, only warn when DMA is unavailable. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index

Re: [linux-next:master] BUILD REGRESSION 66eee64b235411d512bed4d672c2d00683239daf

2023-02-02 Thread Andrew Jeffery
On Thu, 2 Feb 2023, at 13:29, Neal Liu wrote: >> Hi Neal, >> >> On Thu, 2 Feb 2023, at 03:17, kernel test robot wrote: >> > tree/branch: >> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> > master >> > branch HEAD: 66eee64b235411d512bed4d672c2d00683239daf Add >>