[AMD Official Use Only - General]
> -Original Message-
> From: amd-gfx On Behalf Of
> Kenneth Feng
> Sent: Friday, February 10, 2023 1:14 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Feng, Kenneth
> Subject: [PATCH] drm/amd/amdgpu: implement mode2 reset on
> smu_v13_0_10
>
>
implement mode2 reset on smu_v13_0_10
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 7 +
drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.c | 303 ++
drivers/gpu/drm/amd/amdgpu/smu_v13_0_10.h
[AMD Official Use Only - General]
Hi Jack,
Are you trying to fix the call trace popped up on resuming below?
It seems mes created some bo for its self test and freed it up later at the
final stage of the resuming process.
All these happened before the in_suspend flag cleared. And that triggered
[AMD Official Use Only - General]
For some members, "0" is a valid value.
Thus "0x" is used instead to tell the output is invalid/unsupported.
BR
Evan
> -Original Message-
> From: amd-gfx On Behalf Of
> sfrcorne
> Sent: Wednesday, February 8, 2023 7:12 AM
> To: Alex Deucher
> Cc:
[Public]
This patch is :
Reviewed-by: Yifan Zhang
-Original Message-
From: Ji, Ruili
Sent: Thursday, February 9, 2023 2:18 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Deucher, Alexander
; Liu, Aaron ; Zhang, Yifan
; Ji, Ruili
Subject: [PATCH v2] drm/amdkfd: To fix
[Public]
This series is
Reviewed-by: Yifan Zhang
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, February 9, 2023 10:12 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 4/4] Revert "drm/amd/display: disable S/G display on DCN
On Thu, Feb 09, 2023 at 05:03:19PM +, Simon Ser wrote:
> On Thursday, February 9th, 2023 at 17:38, Joshua Ashton
> wrote:
>
> > > I mean, the strings are the uAPI, not the integers, right?
> >
> > Both are uAPI these days.
>
> Yes. The integers are uAPI, if you change them you'll break
Hi Dave, Daniel,
A few last minute display fixes.
The following changes since commit c6ac406cd8ff610a2d5da298b1d3071acfcde7f0:
drm/amdgpu/smu: skip pptable init under sriov (2023-02-08 22:33:37 -0500)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
Hi Mikhail, seems like your report flew past me, thanks for the ping.
This might be a simple issue of not backing off when deadlock was hit.
drm_atomic_normalize_zpos() can return an error code, and I ignored it
(oops!)
Can you give this patch a try?
On Thursday, February 9th, 2023 at 17:38, Joshua Ashton
wrote:
> > I mean, the strings are the uAPI, not the integers, right?
>
> Both are uAPI these days.
Yes. The integers are uAPI, if you change them you'll break libliftoff
users. There is an old thread discussing this somewhere. The tl;dr
On 2/8/23 09:30, Pekka Paalanen wrote:
On Fri, 3 Feb 2023 02:07:44 +
Joshua Ashton wrote:
Userspace has no way of controlling or knowing the pixel encoding
currently, so there is no way for it to ever get the right values here.
When we do add pixel_encoding control from userspace,we
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 20f513df926fac0594a3b65f79d856bd64251861 Add linux-next specific
files for 20230209
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202301302110.metnwkbd-...@intel.com
https
On 2/9/23 09:37, Christian König wrote:
> Am 09.02.23 um 15:11 schrieb Alex Deucher:
>> Some users have reported flickerng with S/G display. We've
>> tried extensively to reproduce and debug the issue on a wide
>> variety of platform configurations (DRAM bandwidth, etc.) and
>> a variety of
Am 09.02.23 um 15:11 schrieb Alex Deucher:
Some users have reported flickerng with S/G display. We've
tried extensively to reproduce and debug the issue on a wide
variety of platform configurations (DRAM bandwidth, etc.) and
a variety of monitors, but so far have not been able to. We
disabled
Applied. Thanks!
Alex
On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King wrote:
>
> The function name is being reported as dc_link_contruct when it is
> actually dc_link_construct_phy. Fix this by using %s and the __func__
> for the function name.
>
> Signed-off-by: Colin Ian King
> ---
>
Applied. Thanks!
Alex
On Thu, Feb 9, 2023 at 5:48 AM wrote:
>
> From: Ye Xingchen
>
> link_hwss.h is included more than once in link_dpms.c .
>
> Signed-off-by: Ye Xingchen
> ---
> v1 -> v2
> Fix the U+00A0 non-breaking space in the subject line.
>
Applied. Thanks!
Alex
On Thu, Feb 9, 2023 at 7:45 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member
> is not defined:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function
>
Applied. Thanks!
Alex
On Thu, Feb 9, 2023 at 8:41 AM Tom Rix wrote:
>
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6:
> warning: symbol 'should_disable_otg' was not declared. Should it be static?
>
> should_disable_otg() is only used in
On 01/31, Pekka Paalanen wrote:
> On Mon, 9 Jan 2023 14:38:09 -0100
> Melissa Wen wrote:
>
> > On 01/09, Melissa Wen wrote:
> > > Hi,
> > >
> > > After collecting comments in different places, here is a second version
> > > of the work on adding DRM CRTC 3D LUT support to the current DRM color
This reverts commit 3cc67fe1b3aa1ac4720e002f2aa2d08c9199a584.
Some users have reported flickerng with S/G display. We've
tried extensively to reproduce and debug the issue on a wide
variety of platform configurations (DRAM bandwidth, etc.) and
a variety of monitors, but so far have not been able
This reverts commit 2404f9b0ea0153c3fddb0c4d7a43869dc8608f6f.
Some users have reported flickerng with S/G display. We've
tried extensively to reproduce and debug the issue on a wide
variety of platform configurations (DRAM bandwidth, etc.) and
a variety of monitors, but so far have not been able
This reverts commit f081cd4ca2658752a8c0e2353d50aec80d07c65f.
Some users have reported flickerng with S/G display. We've
tried extensively to reproduce and debug the issue on a wide
variety of platform configurations (DRAM bandwidth, etc.) and
a variety of monitors, but so far have not been able
Some users have reported flickerng with S/G display. We've
tried extensively to reproduce and debug the issue on a wide
variety of platform configurations (DRAM bandwidth, etc.) and
a variety of monitors, but so far have not been able to. We
disabled S/G display on a number of platforms to
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
From: amd-gfx on behalf of Alex Deucher
Date: Thursday, February 9, 2023 at 21:43
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu/gmc11: fix system aperture set when AGP
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6:
warning: symbol 'should_disable_otg' was not declared. Should it be static?
should_disable_otg() is only used in dcn315_clk_mgr.c, so it should be static
Signed-off-by: Tom Rix
---
Need to cover both FB and AGP apertures.
v2: fix missed gfxhub_v3_0_3.c
Fixes: c6eafee038ed ("Revert "Revert "drm/amdgpu/gmc11: enable AGP aperture""")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 8
Use fb_start/end for consistency with gmc code for non-
XGMI systems, they are equivalent to vram_start/end.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The function name is being reported as dc_link_contruct when it is
actually dc_link_construct_phy. Fix this by using %s and the __func__
for the function name.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Ye Xingchen
link_hwss.h is included more than once in link_dpms.c .
Signed-off-by: Ye Xingchen
---
v1 -> v2
Fix the U+00A0 non-breaking space in the subject line.
drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Arnd Bergmann
When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member
is not defined:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function
'dp_active_dongle_validate_timing':
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c:126:66: error:
'const
From: Alex Deucher
[ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ]
There could be boards with DCN listed in IP discovery, but no
display hardware actually wired up. In this case the vbios
display table will not be populated. Detect this case and
skip loading DM when we detect it.
From: Alex Deucher
[ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ]
There could be boards with DCN listed in IP discovery, but no
display hardware actually wired up. In this case the vbios
display table will not be populated. Detect this case and
skip loading DM when we detect it.
From: Yiqing Yao
[ Upstream commit ac7170082c0e140663f0853d3de733a5341ce7b0 ]
These sysfs nodes are tested supported, so enable them.
Signed-off-by: Yiqing Yao
Reviewed-by: Hawking Zhang
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6
From: Evan Quan
[ Upstream commit bb25849c0fa550b26cecc9c476c519a927c66898 ]
Enable HDP clock gating control for gfx 11.0.3.
Signed-off-by: Evan Quan
Reviewed-by: Feifei Xu
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
drivers/gpu/drm/amd/amdgpu/soc21.c | 3 ++-
1 file
From: Nicholas Kazlauskas
[ Upstream commit 154711aa5759ef9b45903124fa813c4c29ee681c ]
[Why]
Otherwise we can be out of sync with what's in the hardware, leading
to us rerunning every command that's presently in the ringbuffer.
[How]
Reset software state for the mailboxes in hw_reset callback.
From: George Shen
[ Upstream commit 275d8a1db261a1272a818d40ebc61b3b865b60e5 ]
[Why]
The hwss function does_plane_fit_in_mall not applicable to dcn3.2 asics.
Using it with dcn3.2 can result in undefined behaviour.
[How]
Assign the function pointer to NULL.
Reviewed-by: Alvin Lee
Acked-by:
From: Daniel Miess
[ Upstream commit dd2db2dc4bd298f33dea50c80c3c11bee4e3b0a4 ]
[Why]
Lower max_downscale_ratio and ARGB888 downscale factor
to prevent cases where underflow may occur on dcn314
[How]
Set max_downscale_ratio to 400 and ARGB downscale factor
to 250 for dcn314
Reviewed-by:
From: Daniel Miess
[ Upstream commit ea062fd28f922cb118bfb33229f405b81aff7781 ]
[Why]
Brackets missing in the calculation for MIN_DST_Y_NEXT_START
[How]
Add missing brackets for this calculation
Reviewed-by: Nicholas Kazlauskas
Acked-by: Alex Hung
Signed-off-by: Daniel Miess
Tested-by:
On Thu, 09 Feb 2023, wrote:
> From: Ye Xingchen
>
> link_hwss.h is included more than once.
You've got U+00A0 non-breaking space in the subject line.
BR,
Jani.
>
> Signed-off-by: Ye Xingchen
> ---
> drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
On Wed, 8 Feb 2023 16:49:31 +0200
Ville Syrjälä wrote:
> On Wed, Feb 08, 2023 at 11:18:42AM +0200, Pekka Paalanen wrote:
> > On Fri, 3 Feb 2023 16:02:51 +0200
> > Ville Syrjälä wrote:
> >
> > > On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote:
> > > > On Fri, Feb 3, 2023 at
Harry, please don't ignore me.
This issue still happens in 6.1 and 6.2
Leo you are the author of the problematic commit please don't stand aside.
Really nobody is interested in clean logs without warnings and errors?
I am 100% sure that reverting commit
b261509952bc19d1012cf732f853659be6ebc61e
From: Ye Xingchen
link_hwss.h is included more than once.
Signed-off-by: Ye Xingchen
---
drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
index
Am 09.02.23 um 05:46 schrieb Alex Deucher:
Use fb_start/end for consistency with gmc code for non-
XGMI systems, they are equivalent to vram_start/end.
Signed-off-by: Alex Deucher
Acked-by: Christian König
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file
Am 09.02.23 um 05:46 schrieb Alex Deucher:
Need to cover both FB and AGP apertures.
Fixes: c6eafee038ed ("Revert "Revert "drm/amdgpu/gmc11: enable AGP aperture""")
Signed-off-by: Alex Deucher
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c | 4 ++--
44 matches
Mail list logo
