[PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-08 Thread Guchun Chen
In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Reported-by: Bert Karwatzki Suggested-by: Dmitry Baryshkov

[PATCH 1/2] drm/amdgpu: move poll enabled/disable into non DC path

2023-03-08 Thread Guchun Chen
Some amd asics having reliable hotplug support don't call drm_kms_helper_poll_init in driver init sequence. However, due to the unified suspend/resume path for all asics, because the output_poll_work->func is not set for these asics, a warning arrives when suspending. [ 90.656049] [

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-08 Thread Zack Rusin
On Wed, 2023-03-08 at 10:10 +0100, Christian König wrote: > > Am 08.03.23 um 06:14 schrieb Zack Rusin: > > On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: > > > VMWGFX is the only remaining user of this and should probably moved over > > > to drm_exec when it starts using GEM as well. >

[pull] amdgpu, amdkfd drm-fixes-6.3

2023-03-08 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. The following changes since commit 66305069eb6d17d9190cbcd196f3f7487df47ae8: Merge tag 'drm-misc-fixes-2023-02-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2023-03-07 05:42:34 +1000) are available in the Git repository at:

Re: [PATCH] drm/amdgpu: Remove useless else if

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 10:37 PM Jiapeng Chong wrote: > > The assignment of the else and if branches is the same, so the if else > here is redundant, so we remove it. > > ./drivers/gpu/drm/amd/amdgpu/nv.c:1048:2-4: WARNING: possible condition with > no effect (if == else). > > Reported-by: Abaci

[PATCH] drm/amdgpu/nv: fix codec array for SR_IOV

2023-03-08 Thread Alex Deucher
Copy paste error. Fixes: 384334120b66 ("drm/amdgpu/nv: don't expose AV1 if VCN0 is harvested") Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4454 Cc: Jiapeng Chong Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 ++-- 1 file changed, 2

[PATCH] drm/amdgpu: Remove useless else if

2023-03-08 Thread Jiapeng Chong
The assignment of the else and if branches is the same, so the if else here is redundant, so we remove it. ./drivers/gpu/drm/amd/amdgpu/nv.c:1048:2-4: WARNING: possible condition with no effect (if == else). Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4454

[PATCH] drm/amd/display: Use swap() instead of open coding it

2023-03-08 Thread Jiapeng Chong
Swap is a function interface that provides exchange function. To avoid code duplication, we can use swap function. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:359:57-58: WARNING opportunity for swap(). Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4448

RE: [PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage after resume

2023-03-08 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Deucher, Alexander > Sent: Wednesday, March 8, 2023 11:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Błażej Szczygieł > ; Quan, Evan > Subject: [PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage

[PATCH v2] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-08 Thread YuBiao Wang
v2: Add comments to clarify in the code. [Why] For engines not supporting soft reset, i.e. VCN, there will be a failed ib test before mode 1 reset during asic reset. The fences in this case are never signaled and next time when we try to free the sa_bo, kernel will hang. [How] During

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Sebastian Wick
On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland wrote: > > In order to IGT test colorspace we'll want to print > the currently enabled colorspace on a stream. We add > a new debugfs to do so, using the same scheme as > current bpc reporting. > > This might also come in handy when debugging display

Re: [PATCH v3 11/17] drm/amd/display: Send correct DP colorspace infopacket

2023-03-08 Thread Sebastian Wick
On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland wrote: > > Look at connector->colorimetry to determine output colorspace. > > We don't want to impact current SDR behavior, so > DRM_MODE_COLORIMETRY_DEFAULT preserves current behavior. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc:

RE: [PATCH 1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path

2023-03-08 Thread Chen, Guchun
Relying on dc_enabled will be more simple, thanks for your suggestion. I will send v2 to address this. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, March 9, 2023 12:29 AM To: Chen, Guchun Cc: amd-gfx@lists.freedesktop.org;

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Sebastian Wick
On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland wrote: > > We an use bitfields to track the support ones for HDMI > and DP. This allows us to print colorspaces in a consistent > manner without needing to know whether we're dealing with > DP or HDMI. > > Signed-off-by: Harry Wentland > Cc: Pekka

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Ville Syrjälä
On Thu, Mar 09, 2023 at 02:05:55AM +0100, Sebastian Wick wrote: > On Wed, Mar 8, 2023 at 10:09 AM Pekka Paalanen wrote: > > > > On Tue, 7 Mar 2023 10:10:53 -0500 > > Harry Wentland wrote: > > > > > From: Joshua Ashton > > > > > > Userspace has no way of controlling or knowing the pixel encoding

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Sebastian Wick
On Wed, Mar 8, 2023 at 10:09 AM Pekka Paalanen wrote: > > On Tue, 7 Mar 2023 10:10:53 -0500 > Harry Wentland wrote: > > > From: Joshua Ashton > > > > Userspace has no way of controlling or knowing the pixel encoding > > currently, so there is no way for it to ever get the right values here. > >

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-08 Thread Sebastian Wick
On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > On Tue, 7 Mar 2023 10:10:52 -0500 > Harry Wentland wrote: > > > From: Joshua Ashton > > > > To match the other enums, and add more information about these values. > > > > v2: > > - Specify where an enum entry comes from > > - Clarify

Re: [PATCH v2] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Felix Kuehling
On 2023-03-08 17:03, David Belanger wrote: Handle case when module is unloaded (kfd_exit) before a process space (mm_struct) is released. v2: Fixed potential race conditions by removing all kfd_process from the process table first, then working on releasing the resources. Signed-off-by: David

Re: [RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

2023-03-08 Thread Hans de Goede
Hi, On 3/8/23 22:58, Hans de Goede wrote: > Hi All, > > Here is version 2 of my patch series to pass the proper parent device > to backlight_device_register(). > > New in version 2 is delaying the registering of the backlight_dev till > after the drm_connector is registered by doing it from >

[PATCH v2] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread David Belanger
Handle case when module is unloaded (kfd_exit) before a process space (mm_struct) is released. v2: Fixed potential race conditions by removing all kfd_process from the process table first, then working on releasing the resources. Signed-off-by: David Belanger ---

[RFC v2 2/6] drm/amd/display/amdgpu_dm: Refactor register_backlight_device()

2023-03-08 Thread Hans de Goede
Refactor register_backlight_device(): 1) Turn the connector-type + signal check into an early exit condition to avoid the indentation level of the rest of the code 2) Add an array bounds check for the arrays indexed by dm->num_of_edps 3) register_backlight_device() always increases

[RFC v2 1/6] drm/amd/display/amdgpu_dm: Fix backlight_device_register() error handling

2023-03-08 Thread Hans de Goede
backlight_device_register() returns an ERR_PTR on error, but other code such as amdgpu_dm_connector_destroy() assumes dm->backlight_dev[i] is NULL if no backlight is registered. Clear dm->backlight_dev[i] on registration failure, to avoid other code trying to deref an ERR_PTR pointer.

[RFC v2 5/6] drm/amd/display/amdgpu_dm: Make amdgpu_dm_register_backlight_device() take an amdgpu_dm_connector

2023-03-08 Thread Hans de Goede
Make amdgpu_dm_register_backlight_device() take an amdgpu_dm_connector pointer to the connector for which it should register the backlight as its only argument. This is a preparation patch for moving the actual backlight class device registering to drm_connector_funcs.late_register.

[RFC v2 4/6] drm/amd/display/amdgpu_dm: Move most backlight setup into setup_backlight_device()

2023-03-08 Thread Hans de Goede
Rename register_backlight_device() to setup_backlight_device() and move all backlight setup related calls from amdgpu_dm_register_backlight_device() and from amdgpu_dm_initialize_drm_device() there. This leaves amdgpu_dm_register_backlight_device() dealing purely with registering the actual

[RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

2023-03-08 Thread Hans de Goede
Hi All, Here is version 2 of my patch series to pass the proper parent device to backlight_device_register(). New in version 2 is delaying the registering of the backlight_dev till after the drm_connector is registered by doing it from drm_connector_funcs.late_register. This involves first

[RFC v2 3/6] drm/amd/display/amdgpu_dm: Add a bl_idx to amdgpu_dm_connector

2023-03-08 Thread Hans de Goede
Currently functions like update_connector_ext_caps() and amdgpu_dm_connector_destroy() are iterating over dm->backlight_link[i] to find the index of the (optional) backlight_dev associated with the connector. Instead make register_backlight_device() store the dm->backlight_dev[] index used for

[RFC v2 6/6] drm/amd/display: Pass proper parent for DM backlight device registration v2

2023-03-08 Thread Hans de Goede
The parent for the backlight device should be the drm-connector object, not the PCI device. Userspace relies on this to be able to detect which backlight class device to use on hybrid gfx devices where there may be multiple native (raw) backlight devices registered. Specifically

[PATCH] drm/amdkfd: fix potential kgd_mem UAFs

2023-03-08 Thread Chia-I Wu
kgd_mem should be accessed with p->mutex locked, or it could have been freed by kfd_ioctl_free_memory_of_gpu. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 1/2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 10:20 AM Alex Deucher wrote: > > From: Błażej Szczygieł > > Always setup overdrive tables after resume. Preserve only some > user-defined settings in user_overdrive_table if they're set. > > Copy restored user_overdrive_table into od_table to get correct > values. > > On

Re: [PATCH] drm/amdkfd: Get prange->offset after svm_range_vram_node_new

2023-03-08 Thread Chen, Xiaogang
On 3/8/2023 11:11 AM, Felix Kuehling wrote: On 2023-03-08 02:45, Xiaogang.Chen wrote: From: Xiaogang Chen During miration to vram prange->offset is valid after vram buffer is located, either use old one or allocate a new one. Move svm_range_vram_node_new before migrate for each vma to

Re: [PATCH] amd/display/debugfs: add sysfs entry to read PSR residency from firmware

2023-03-08 Thread Hamza Mahfooz
On 3/8/23 02:10, Shirish S wrote: [Why] Currently there aren't any methods to determine PSR state residency. [How] create a sysfs entry for reading residency and internally hook it up to existing functionality of reading PSR residency from firmware. Signed-off-by: Shirish S ---

Re: [PATCH] drm/amdkfd: fix a potential double free in pqm_create_queue

2023-03-08 Thread Felix Kuehling
On 2023-03-07 19:19, Chia-I Wu wrote: Set *q to NULL on errors, otherwise pqm_create_queue would free it again. Signed-off-by: Chia-I Wu Thank you! I'm applying this patch to amd-staging-drm-next. Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c |

Re: [PATCH] drm/amdkfd: Get prange->offset after svm_range_vram_node_new

2023-03-08 Thread Felix Kuehling
On 2023-03-08 02:45, Xiaogang.Chen wrote: From: Xiaogang Chen During miration to vram prange->offset is valid after vram buffer is located, either use old one or allocate a new one. Move svm_range_vram_node_new before migrate for each vma to get valid prange->offset. Signed-off-by: Xiaogang

RE: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Zhuo, Qingqing (Lillian)
[AMD Official Use Only - General] On Wed, Mar 8, 2023 at 11:32 AM Maxime Ripard wrote: > > On Wed, Mar 08, 2023 at 04:27:01PM +, Zhuo, Qingqing (Lillian) wrote: > > [AMD Official Use Only - General] > > > > > Hi, > > > > On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: > > > +

Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Hamza Mahfooz
On 3/8/23 11:39, Alex Deucher wrote: On Wed, Mar 8, 2023 at 11:32 AM Maxime Ripard wrote: On Wed, Mar 08, 2023 at 04:27:01PM +, Zhuo, Qingqing (Lillian) wrote: [AMD Official Use Only - General] Hi, On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: + vc4 maintainers

Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Maxime Ripard
On Wed, Mar 08, 2023 at 04:27:01PM +, Zhuo, Qingqing (Lillian) wrote: > [AMD Official Use Only - General] > > > Hi, > > On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: > > + vc4 maintainers > > > > On 3/8/23 04:34, Qingqing Zhuo wrote: > > > [Why] > > >

Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 11:32 AM Maxime Ripard wrote: > > On Wed, Mar 08, 2023 at 04:27:01PM +, Zhuo, Qingqing (Lillian) wrote: > > [AMD Official Use Only - General] > > > > > Hi, > > > > On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: > > > + vc4 maintainers > > > > > > On

Re: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Felix Kuehling
On 2023-03-08 11:20, Christian König wrote: Am 08.03.23 um 17:17 schrieb Felix Kuehling: On 2023-03-08 04:07, Christian König wrote: Am 07.03.23 um 16:28 schrieb Belanger, David: [AMD Official Use Only - General] The test case is a python program that will load the driver, do some

Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Maxime Ripard
Hi, On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: > + vc4 maintainers > > On 3/8/23 04:34, Qingqing Zhuo wrote: > > [Why] > > drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’: > > drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label > > ‘err_disable_runtime_pm’ used

RE: [PATCH 2/2] drm/amd/amdkfd: Fix build error with unmatched argument type

2023-03-08 Thread Zhuo, Qingqing (Lillian)
[AMD Official Use Only - General] On 3/8/23 04:34, Qingqing Zhuo wrote: > [Why] > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c: In function > ‘svm_migrate_copy_to_vram’: > ./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:35:21: > error: format ‘%lx’ expects argument of type ‘long unsigned

Re: [PATCH 1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 7:17 AM Guchun Chen wrote: > > Some amd asics having reliable hotplug support don't call > drm_kms_helper_poll_init in driver init sequence. However, > due to the unified suspend/resume path for all asics, because > the output_poll_work->func is not set for these asics, a

RE: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Zhuo, Qingqing (Lillian)
[AMD Official Use Only - General] > Hi, On Wed, Mar 08, 2023 at 11:11:22AM -0500, Hamza Mahfooz wrote: > + vc4 maintainers > > On 3/8/23 04:34, Qingqing Zhuo wrote: > > [Why] > > drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’: > > drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error:

Re: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Christian König
Am 08.03.23 um 17:17 schrieb Felix Kuehling: On 2023-03-08 04:07, Christian König wrote: Am 07.03.23 um 16:28 schrieb Belanger, David: [AMD Official Use Only - General] The test case is a python program that will load the driver, do some operations, then unload the driver. What do you

Re: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Felix Kuehling
On 2023-03-08 04:07, Christian König wrote: Am 07.03.23 um 16:28 schrieb Belanger, David: [AMD Official Use Only - General] The test case is a python program that will load the driver, do some operations, then unload the driver. What do you mean with unloading the driver? Removing the

Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Hamza Mahfooz
+ vc4 maintainers On 3/8/23 04:34, Qingqing Zhuo wrote: [Why] drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’: drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined [How] update err_disable_runtime_pm to err_put_runtime_pm.

Re: [PATCH 2/2] drm/amd/amdkfd: Fix build error with unmatched argument type

2023-03-08 Thread Hamza Mahfooz
On 3/8/23 04:34, Qingqing Zhuo wrote: [Why] drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c: In function ‘svm_migrate_copy_to_vram’: ./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:35:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘uint64_t’

Re: [PATCH] drm/amd/display: remove unused variable available

2023-03-08 Thread Alex Deucher
Applied. Thanks! On Wed, Mar 8, 2023 at 9:11 AM Tom Rix wrote: > > With gcc and W=1, there is this error > drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:297:13: > error: > variable ‘available’ set but not used [-Werror=unused-but-set-variable] > 297 |

Re: [PATCH] drm/amd/display: remove unused variable res_pool

2023-03-08 Thread Alex Deucher
Applied. Thanks! On Wed, Mar 8, 2023 at 9:10 AM Tom Rix wrote: > > With gcc and W=1, there is this error > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1214:31: > error: variable ‘res_pool’ set but not used > [-Werror=unused-but-set-variable] > 1214 | struct

[linux-next:master] BUILD SUCCESS WITH WARNING fc31900c948610e7b5c2f15fb7795832c8325327

2023-03-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: fc31900c948610e7b5c2f15fb7795832c8325327 Add linux-next specific files for 20230308 Warning reports: https://lore.kernel.org/oe-kbuild-all/202302100744.d1zzxxfn-...@intel.com https

Re: [PATCH] drm/amd/pm: bump SMU 13.0.4 driver_if header version

2023-03-08 Thread Alex Deucher
Reviewed-by: Alex Deucher On Tue, Mar 7, 2023 at 10:44 PM Tim Huang wrote: > > Align the SMU driver interface version with PMFW to > suppress the version mismatch message on driver loading. > > Signed-off-by: Tim Huang > --- > .../drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h| 4

[PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage after resume

2023-03-08 Thread Alex Deucher
Always setup overdrive tables after resume. Preserve only some user-defined settings in user_overdrive_table if they're set. Copy restored user_overdrive_table into od_table to get correct values. On cold boot, BTC was triggered and GfxVfCurve was calibrated. We got VfCurve settings (a). On

[PATCH 1/2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-08 Thread Alex Deucher
From: Błażej Szczygieł Always setup overdrive tables after resume. Preserve only some user-defined settings in user_overdrive_table if they're set. Copy restored user_overdrive_table into od_table to get correct values. On cold boot, BTC was triggered and GfxVfCurve was calibrated. We got

Re: [PATCH] drm/amdgpu/soc21: Add video cap query support for VCN_4_0_4

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 9:58 AM wrote: > > From: Veerabadhran Gopalakrishnan > > Added the video capability query support for VCN version 4_0_4 > > Signed-off-by: Veerabadhran Gopalakrishnan > > Reviewed-by: Leo Liu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 1 +

RE: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Belanger, David
[AMD Official Use Only - General] > -Original Message- > From: Christian König > Sent: Wednesday, March 8, 2023 4:08 AM > To: Belanger, David ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module > exit. > >

Re: [PATCH v2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-08 Thread Alex Deucher
On Tue, Mar 7, 2023 at 9:34 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Thanks Alex. I probably get the root cause of the issue. It should be related > with the BTC feature. > - On cold boot, BTC was triggered and GfxVfCurve was calibrated. >We got VfCurve settings (a). >

[PATCH] drm/amdgpu/soc21: Add video cap query support for VCN_4_0_4

2023-03-08 Thread veerabadhran.gopalakrishnan
From: Veerabadhran Gopalakrishnan Added the video capability query support for VCN version 4_0_4 Signed-off-by: Veerabadhran Gopalakrishnan Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/soc21.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c

Re: [PATCH] drm/amdgpu: Drop redundant pci_enable_pcie_error_reporting()

2023-03-08 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 7, 2023 at 3:22 PM Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all

Re: [PATCH] drm/amd/display: add prefix to amdgpu_dm_crtc.h functions

2023-03-08 Thread Alex Deucher
Applied. Thanks! On Tue, Mar 7, 2023 at 2:34 PM David Tadokoro wrote: > > Some amdgpu_dm_crtc.h functions didn't have names that indicated where > they were declared. > > To better filter results in debug tools like ftrace, prefix these > functions with 'amdgpu_dm_crtc_'. > > Signed-off-by:

Re: [6.3][regression] commit a4e771729a51168bc36317effaa9962e336d4f5e lead to flood kernel logs with warning messages "at kernel/workqueue.c:3167 __flush_work+0x472/0x500"

2023-03-08 Thread Alex Deucher
On Wed, Mar 8, 2023 at 7:02 AM Mikhail Gavrilov wrote: > > Hi, > I didn't faced to issue drm_bridge_hpd_enable+0x94/0x9c [drm] but > fixing this issue leads to warning messages on my laptop ASUS ROG > Strix G15 Advantage Edition G513QY-HQ007 which has two AMD GPU. > Discrete Radeon 6800M and

[PATCH] drm/amd/display: remove unused variable available

2023-03-08 Thread Tom Rix
With gcc and W=1, there is this error drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:297:13: error: variable ‘available’ set but not used [-Werror=unused-but-set-variable] 297 | int available = 0; | ^ Since available is unused,

Re: [RFC] drm/amd/display: Pass proper parent for DM backlight device registration

2023-03-08 Thread Hans de Goede
Hi, On 2/15/23 12:38, Hans de Goede wrote: > The parent for the backlight device should be the drm-connector object, > not the PCI device. > > Userspace relies on this to be able to detect which backlight class device > to use on hybrid gfx devices where there may be multiple native (raw) >

[PATCH] drm/amd/display: remove unused variable res_pool

2023-03-08 Thread Tom Rix
With gcc and W=1, there is this error drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1214:31: error: variable ‘res_pool’ set but not used [-Werror=unused-but-set-variable] 1214 | struct resource_pool *res_pool; | ^~~~ Since

Re: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, Guchun Chen wrote: > In order to catch issues in other drivers to ensure proper call > sequence of polling function. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") How does an

[PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-08 Thread Guchun Chen
In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Reported-by: Bert Karwatzki Suggested-by: Dmitry Baryshkov

[PATCH 1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path

2023-03-08 Thread Guchun Chen
Some amd asics having reliable hotplug support don't call drm_kms_helper_poll_init in driver init sequence. However, due to the unified suspend/resume path for all asics, because the output_poll_work->func is not set for these asics, a warning arrives when suspending. [ 90.656049] [

[6.3][regression] commit a4e771729a51168bc36317effaa9962e336d4f5e lead to flood kernel logs with warning messages "at kernel/workqueue.c:3167 __flush_work+0x472/0x500"

2023-03-08 Thread Mikhail Gavrilov
Hi, I didn't faced to issue drm_bridge_hpd_enable+0x94/0x9c [drm] but fixing this issue leads to warning messages on my laptop ASUS ROG Strix G15 Advantage Edition G513QY-HQ007 which has two AMD GPU. Discrete Radeon 6800M and integrated in CPU Cezanne Vega 8. I found bad commit by bisecting: ❯

Re: [PATCH v3 00/17] Enable Colorspace connector property in amdgpu

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:50 -0500 Harry Wentland wrote: > This patchset is based on Joshua's previous patchset [1], as well > as my previous patchset [2]. > > It is > - enabling support for the colorspace property in amdgpu, as well as > - allowing drivers to specify the supported set of

Re: [PATCH v3 15/17] drm/amd/display: Add default case for output_color_space switch

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:11:05 -0500 Harry Wentland wrote: > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Reviewed-By: Joshua Ashton Hi,

[PATCH 2/2] drm/amd/amdkfd: Fix build error with unmatched argument type

2023-03-08 Thread Qingqing Zhuo
[Why] drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c: In function ‘svm_migrate_copy_to_vram’: ./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:35:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘uint64_t’ {aka ‘long long unsigned int’}

[PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Qingqing Zhuo
[Why] drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’: drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined [How] update err_disable_runtime_pm to err_put_runtime_pm. Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:11:04 -0500 Harry Wentland wrote: > In order to IGT test colorspace we'll want to print > the currently enabled colorspace on a stream. We add > a new debugfs to do so, using the same scheme as > current bpc reporting. > > This might also come in handy when debugging

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:59 -0500 Harry Wentland wrote: > We want compositors to be able to set the output > colorspace on DP and HDMI outputs, based on the > caps reported from the receiver via EDID. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc:

Re: [PATCH v3 06/17] drm/connector: Print connector colorspace in state debugfs

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:56 -0500 Harry Wentland wrote: > v3: Fix kerneldocs (kernel test robot) > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: Jani Nikula > Cc:

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:55 -0500 Harry Wentland wrote: > We an use bitfields to track the support ones for HDMI > and DP. This allows us to print colorspaces in a consistent > manner without needing to know whether we're dealing with > DP or HDMI. > > Signed-off-by: Harry Wentland > Cc: Pekka

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-08 Thread Christian König
Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it starts using GEM as well. Is this because vmwgfx piggybacks buffer-id relocations on top of ttm

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:53 -0500 Harry Wentland wrote: > From: Joshua Ashton > > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick

Re: [PATCH] drm/amdkfd: Fixed kfd_process cleanup on module exit.

2023-03-08 Thread Christian König
Am 07.03.23 um 16:28 schrieb Belanger, David: [AMD Official Use Only - General] The test case is a python program that will load the driver, do some operations, then unload the driver. What do you mean with unloading the driver? Removing the module? Or destroying the device? When the

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:52 -0500 Harry Wentland wrote: > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" > -

Re: [PATCH v4 01/17] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:29:34 -0500 Harry Wentland wrote: > This allows us to use strongly typed arguments. > > v2: > - Bring NO_DATA back > - Provide explicit enum values > > v4: Drop unnecessary '&' from kerneldoc (emersion) > > Signed-off-by: Harry Wentland > Reviewed-by: Simon Ser > >

[BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-08 Thread Steven Rostedt
In a report for a regression in my code, I tried to run v6.3-rc1 through my tests. It crashed at boot up on my first test (my start up tests do take a long time, hence the 206 seconds of boot!). [ 206.238782] [ cut here ] [ 206.277786] DEBUG_LOCKS_WARN_ON(lock->magic

Re: [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-08 Thread Steven Rostedt
On Tue, 7 Mar 2023 21:22:23 -0500 Steven Rostedt wrote: > Looks like there was a lock possibly used after free. But as commit > 9bff18d13473a9fdf81d5158248472a9d8ecf2bd ("drm/ttm: use per BO cleanup > workers") changed a lot of this code, I figured it may be the culprit. If I bothered to look

[PATCH] drm/amd/display: remove legacy fields of dc_plane_cap struct

2023-03-08 Thread David Tadokoro
The fields blends_with_above and blends_with_below of struct dc_plane_cap (defined in dc/dc.h) are boolean and set to true by default. All instances of a dc_plane_cap maintain the default values of both. Also, there is only one if statement that checks those fields and there would be the same