Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-14 Thread Huang Rui
On Wed, Mar 15, 2023 at 08:52:30AM +0800, Stefano Stabellini wrote: > On Mon, 13 Mar 2023, Jan Beulich wrote: > > On 12.03.2023 13:01, Huang Rui wrote: > > > Xen PVH is the paravirtualized mode and takes advantage of hardware > > > virtualization support when possible. It will using the hardware

RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland

2023-03-14 Thread Quan, Evan
[AMD Official Use Only - General] I'm OK with the drop of si_set_temperature_range() in late_init. Meanwhile, it's still not clear to me how this could lead reboot exception. Can you dig this a little bit further? For example, can you check whether the

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-14 Thread Stefano Stabellini
On Mon, 13 Mar 2023, Jan Beulich wrote: > On 12.03.2023 13:01, Huang Rui wrote: > > Xen PVH is the paravirtualized mode and takes advantage of hardware > > virtualization support when possible. It will using the hardware IOMMU > > support instead of xen-swiotlb, so disable swiotlb if current

Re: [PATCH] drm/amdgpu: Don't resume IOMMU after incomplete init

2023-03-14 Thread Alex Deucher
On Tue, Mar 14, 2023 at 1:54 PM Felix Kuehling wrote: > > Check kfd->init_complete in kgd2kfd_iommu_resume, consistent with other > kgd2kfd calls. This should fix IOMMU errors on resume from suspend when > KFD IOMMU initialization failed. > > Link:

[PATCH] drm/amdgpu: Don't resume IOMMU after incomplete init

2023-03-14 Thread Felix Kuehling
Check kfd->init_complete in kgd2kfd_iommu_resume, consistent with other kgd2kfd calls. This should fix IOMMU errors on resume from suspend when KFD IOMMU initialization failed. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217170 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2454 Cc:

Re: [PATCH] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-14 Thread Alex Deucher
On Tue, Mar 14, 2023 at 12:35 AM Kai-Heng Feng wrote: > > S2idle resume freeze can be observed on Intel ADL + AMD WX5500. This is > caused by commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default"). > > The root cause is still not clear for now. > > So extend and apply the ASPM quirk from

RE: NAB Show 2023 - Lead & Deal retrievals

2023-03-14 Thread Nancy Tyler
Hello, I sent you an email about attendees list ? Let me know your interest to Send Pricing Details.. Awaiting for your response! Cheers Nancy From: Nancy Tyler Sent: Thursday, March 9, 2023 5:13 PM To: amd-gfx@lists.freedesktop.org Subject: NAB Show 2023 - Lead & Deal retrievals

[PATCH] drm/radeon: remove unused variable rbo

2023-03-14 Thread Tom Rix
gcc with W=1 reports this error drivers/gpu/drm/radeon/radeon_ttm.c:201:27: error: variable ‘rbo’ set but not used [-Werror=unused-but-set-variable] 201 | struct radeon_bo *rbo; | ^~~ rbo use was removed with commit f87c1f0b7b79 ("drm/ttm: prevent

Re: [PATCH] drm/radeon: remove unused variable rbo

2023-03-14 Thread Christian König
Am 14.03.23 um 14:06 schrieb Tom Rix: gcc with W=1 reports this error drivers/gpu/drm/radeon/radeon_ttm.c:201:27: error: variable ‘rbo’ set but not used [-Werror=unused-but-set-variable] 201 | struct radeon_bo *rbo; | ^~~ rbo use was removed with

[PATCH AUTOSEL 4.19 6/7] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

[PATCH AUTOSEL 5.4 6/7] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

[PATCH AUTOSEL 5.10 6/8] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

[PATCH AUTOSEL 5.10 8/8] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-03-14 Thread Sasha Levin
From: Alex Hung [ Upstream commit 031f196d1b1b6d5dfcb0533b431e3ab1750e6189 ] [WHY] When PTEBufferSizeInRequests is zero, UBSAN reports the following warning because dml_log2 returns an unexpected negative value: shift exponent 4294966273 is too large for 32-bit type 'int' [HOW] In the case

[PATCH AUTOSEL 5.15 10/10] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-03-14 Thread Sasha Levin
From: Alex Hung [ Upstream commit 031f196d1b1b6d5dfcb0533b431e3ab1750e6189 ] [WHY] When PTEBufferSizeInRequests is zero, UBSAN reports the following warning because dml_log2 returns an unexpected negative value: shift exponent 4294966273 is too large for 32-bit type 'int' [HOW] In the case

[PATCH AUTOSEL 5.15 07/10] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

[PATCH AUTOSEL 6.1 13/13] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-03-14 Thread Sasha Levin
From: Alex Hung [ Upstream commit 031f196d1b1b6d5dfcb0533b431e3ab1750e6189 ] [WHY] When PTEBufferSizeInRequests is zero, UBSAN reports the following warning because dml_log2 returns an unexpected negative value: shift exponent 4294966273 is too large for 32-bit type 'int' [HOW] In the case

[PATCH AUTOSEL 6.1 12/13] drm/amdgpu: fix ttm_bo calltrace warning in psp_hw_fini

2023-03-14 Thread Sasha Levin
From: Horatio Zhang [ Upstream commit 23f4a2d29ba57bf88095f817de5809d427fcbe7e ] The call trace occurs when the amdgpu is removed after the mode1 reset. During mode1 reset, from suspend to resume, there is no need to reinitialize the ta firmware buffer which caused the bo pin_count increase

[PATCH AUTOSEL 6.1 08/13] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

[PATCH AUTOSEL 6.2 13/13] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-03-14 Thread Sasha Levin
From: Alex Hung [ Upstream commit 031f196d1b1b6d5dfcb0533b431e3ab1750e6189 ] [WHY] When PTEBufferSizeInRequests is zero, UBSAN reports the following warning because dml_log2 returns an unexpected negative value: shift exponent 4294966273 is too large for 32-bit type 'int' [HOW] In the case

[PATCH AUTOSEL 6.2 12/13] drm/amdgpu: fix ttm_bo calltrace warning in psp_hw_fini

2023-03-14 Thread Sasha Levin
From: Horatio Zhang [ Upstream commit 23f4a2d29ba57bf88095f817de5809d427fcbe7e ] The call trace occurs when the amdgpu is removed after the mode1 reset. During mode1 reset, from suspend to resume, there is no need to reinitialize the ta firmware buffer which caused the bo pin_count increase

[PATCH AUTOSEL 6.2 08/13] drm/amdkfd: Fix an illegal memory access

2023-03-14 Thread Sasha Levin
From: Qu Huang [ Upstream commit 4fc8fff378b2f2039f2a666d9f8c570f4e58352c ] In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the

RE: [PATCH] drm/amdgpu: skip ASIC reset for GC IP v11.0.4/11 when go to S4

2023-03-14 Thread Huang, Tim
[AMD Official Use Only - General] Please ignore this patch, will send out a new one to skip ASIC reset for all APUs. Thanks. -Original Message- From: Huang, Tim Sent: Monday, March 13, 2023 7:42 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Du, Xiaojian

RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland

2023-03-14 Thread Chen, Guchun
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, March 14, 2023 5:07 PM > To: Chen, Guchun ; Zhenneng Li > > Cc: David Airlie ; Pan, Xinhui ; > amd-gfx@lists.freedesktop.org; Daniel Vetter ; Deucher, > Alexander ; Koenig, Christian > >

RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland

2023-03-14 Thread Lazar, Lijo
[AMD Official Use Only - General] Hi Guchun, This patch doesn't look correct. Without dpm enabled, temperature range shouldn't be set at all. The patch posted by Zhenneng is good enough or better to skip late init altogether as it remains an empty function with that patch. Thanks, Lijo

[PATCH] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-14 Thread Kai-Heng Feng
S2idle resume freeze can be observed on Intel ADL + AMD WX5500. This is caused by commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default"). The root cause is still not clear for now. So extend and apply the ASPM quirk from commit e02fe3bc7aba ("drm/amdgpu: vi: disable ASPM on Intel Alder Lake

回复: RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland

2023-03-14 Thread 李真能
Attached patch will change the code logic, if adev->pm.dpm_enabled is false, si_set_temperature_range(...) will  be called, this is wrong obvious.   主 题:RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland 日 期:2023-03-14 09:04 发件人:Chen, Guchun 收件人:李真能; Will attached patch

RE: [PATCH] drm/amdgpu: Init MMVM_CONTEXTS_DISABLE in gmc11 golden setting under SRIOV

2023-03-14 Thread Chen, Horace
[AMD Official Use Only - General] Reviewed-by: Horace Chen -Original Message- From: Yifan Zha Sent: Monday, March 6, 2023 3:25 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking Cc: Chen, Horace ; Chang, HaiJun ; Zha, YiFan(Even) Subject: [PATCH] drm/amdgpu:

RE: [PATCH v2] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-14 Thread Wang, YuBiao
Hi Luben, I'd have to ping you because we've got a P1 ticket currently on this issue. Would you please give a vague time when would you confirm whether this patch is safe? Thank you a lot for helping double check this. Regards & Thanks, Yubiao -Original Message- From: Tuikov, Luben