From: Arnd Bergmann
Three functions in the amdgpu display driver cause -Wmissing-prototype
warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no
previous prototype for 'is_timing_changed' [-Werror=missing-prototypes]
is_timing_changed() is actually meant to
On Mon, Apr 17, 2023, at 23:12, Hamza Mahfooz wrote:
> On 4/17/23 17:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann
>>
>> The newly introduced global function is not declared in a header or
>> called from another file, causing a harmless warning with sparse
>> or W=1 builds:
>>
>>
On 4/17/23 17:05, Arnd Bergmann wrote:
From: Arnd Bergmann
Three functions in the amdgpu display driver cause -Wmissing-prototype
warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no
previous prototype for 'is_timing_changed' [-Werror=missing-prototypes]
On 4/17/23 17:05, Arnd Bergmann wrote:
From: Arnd Bergmann
The newly introduced global function is not declared in a header or
called from another file, causing a harmless warning with sparse
or W=1 builds:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no
From: Arnd Bergmann
Three functions in the amdgpu display driver cause -Wmissing-prototype
warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no
previous prototype for 'is_timing_changed' [-Werror=missing-prototypes]
From: Arnd Bergmann
The newly introduced global function is not declared in a header or
called from another file, causing a harmless warning with sparse
or W=1 builds:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no
previous prototype for 'dccg314_init'
From: Arnd Bergmann
Global functions in radeon_atpx_handler.c are not declared in a header
but instead in each file using them. This risks the types getting out
of sync and causes warnings:
drivers/gpu/drm/radeon/radeon_atpx_handler.c:64:6: error: no previous prototype
for 'radeon_has_atpx'
Currently, on a handful of ASICs. We allow the framebuffer for a given
plane to exist in either VRAM or GTT. However, if the plane's new
framebuffer is in a different memory domain than it's previous
framebuffer, flipping between them can cause the screen to flicker. So,
to fix this, don't perform
Thanks. Applied!
Alex
On Thu, Apr 13, 2023 at 11:12 AM Nikita Zhandarovich
wrote:
>
> Several calls to ci_dpm_fini() will attempt to free resources that
> either have been freed before or haven't been allocated yet. This
> may lead to undefined or dangerous behaviour.
>
> For instance, if
Applied. Thanks!
On Fri, Apr 14, 2023 at 11:08 AM Tom Rix wrote:
>
> cpp_check reports
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style:
> Variable
> 'oldest_index' is assigned a value that is never used. [unreadVariable]
>oldest_index = 0;
> ^
>
>
Applied. Thanks!
Alex
On Mon, Apr 17, 2023 at 1:42 PM Colin Ian King wrote:
>
> There is a spelling mistake in the smu_i2c_bus_access prototype. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 2 +-
> 1 file changed, 1 insertion(+), 1
There is a spelling mistake in the smu_i2c_bus_access prototype. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
On Mon, Apr 17, 2023 at 1:59 AM Christian König
wrote:
>
> Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
> > Currently, we allow the framebuffer for a given plane to move between
> > memory domains, however when that happens it causes the screen to
> > flicker, it is even possible for the
On 4/17/23 12:57, Srinivasan Shanmugam wrote:
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Added %s: to print the function name.
v3:
- Used the defined struct instead
On 4/17/23 13:08, Srinivasan Shanmugam wrote:
The previous 'commit 9360c01646d4e ("drm/amd/display: Add logging when
setting DP sink power state fails")', it is better to unconditionally
print "failed to power up sink", because we are returning
DC_ERROR_UNEXPECTED.
Cc: Aurabindo Pillai
Cc:
The previous 'commit 9360c01646d4e ("drm/amd/display: Add logging when
setting DP sink power state fails")', it is better to unconditionally
print "failed to power up sink", because we are returning
DC_ERROR_UNEXPECTED.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:CANCEL
BEGIN:VEVENT
DTSTART;VALUE=DATE:20231017
DTEND;VALUE=DATE:20231020
DTSTAMP:20230417T170848Z
ORGANIZER;CN=mario.kleiner...@gmail.com:mailto:mario.kleiner...@gmail.com
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VEVENT
DTSTART;VALUE=DATE:20231017
DTEND;VALUE=DATE:20231020
DTSTAMP:20230417T170311Z
ORGANIZER;CN=mario.kleiner...@gmail.com:mailto:mario.kleiner...@gmail.com
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Added %s: to print the function name.
v3:
- Used the defined struct instead of the bitwise logic here, like
Signed up will only attend virtually Online however just fyi
On Mon, Apr 17, 2023 at 1:41 PM Samuel Iglesias Gonsálvez
wrote:
>
> Hello!
>
> Registration & Call for Proposals are now open for XDC 2023, which will
> take place on October 17-19, 2023.
>
> https://xdc2023.x.org
>
> As usual, the
On 4/17/23 11:41, Wu, Hersen wrote:
[AMD Official Use Only - General]
Hi,
The change applies to all AMD GPU ASIC.
Please communicate with issue reporter to see if the issue could be reproduced
older ASIC, like Mendocino, CZN.
From the community reports, it can be reproduced on as far back
Am 17.04.23 um 17:25 schrieb Hamza Mahfooz:
On 4/17/23 11:03, Christian König wrote:
Am 17.04.23 um 16:51 schrieb Hamza Mahfooz:
On 4/17/23 01:59, Christian König wrote:
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
Currently, we allow the framebuffer for a given plane to move between
memory
Hi,
Please add:
Fixes: aa5fdb1ab5b6 ("drm/amd/display: Explicitly specify update type
per plane info change")
On 4/14/23 11:53, Qingqing Zhuo wrote:
From: Nicholas Kazlauskas
[Why]
The bit for flip addr is being set causing the determination for
FAST vs MEDIUM to always return MEDIUM when
[AMD Official Use Only - General]
Hi,
The change applies to all AMD GPU ASIC.
Please communicate with issue reporter to see if the issue could be reproduced
older ASIC, like Mendocino, CZN.
Thanks!
Hersen
-Original Message-
From: Mahfooz, Hamza
Sent: Monday, April 17, 2023 11:26 AM
On 4/17/23 11:03, Christian König wrote:
Am 17.04.23 um 16:51 schrieb Hamza Mahfooz:
On 4/17/23 01:59, Christian König wrote:
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
Currently, we allow the framebuffer for a given plane to move between
memory domains, however when that happens it
On 4/15/23 14:27, Srinivasan Shanmugam wrote:
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Added %s: to print the function name.
Am 17.04.23 um 16:51 schrieb Hamza Mahfooz:
On 4/17/23 01:59, Christian König wrote:
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
Currently, we allow the framebuffer for a given plane to move between
memory domains, however when that happens it causes the screen to
flicker, it is even possible
On 4/17/23 07:42, Christian König wrote:
>
>
> Am 17.04.23 um 16:34 schrieb Nikita Zhandarovich:
>> Currently, drm_prime_sg_to_page_addr_arrays() dereferences 'gtt->ttm'
>> without ensuring that 'gtt' (and therefore 'gtt->tmm') is not NULL.
>>
>> Fix this by testing 'gtt' for NULL value
On 4/15/23 11:17, Tom Rix wrote:
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: warning:
symbol
'dccg314_init' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix
Applied, thanks!
On 4/17/23 01:59, Christian König wrote:
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
Currently, we allow the framebuffer for a given plane to move between
memory domains, however when that happens it causes the screen to
flicker, it is even possible for the framebuffer to change memory
Currently, drm_prime_sg_to_page_addr_arrays() dereferences 'gtt->ttm'
without ensuring that 'gtt' (and therefore 'gtt->tmm') is not NULL.
Fix this by testing 'gtt' for NULL value before dereferencing.
Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.
Fixes:
Am 17.04.23 um 16:34 schrieb Nikita Zhandarovich:
Currently, drm_prime_sg_to_page_addr_arrays() dereferences 'gtt->ttm'
without ensuring that 'gtt' (and therefore 'gtt->tmm') is not NULL.
Fix this by testing 'gtt' for NULL value before dereferencing.
Found by Linux Verification Center
[Public]
Hi all,
This week this patchset was tested on the following systems:
Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U
Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U
Reference AMD RX6800
These systems were tested on the following display types:
eDP, (1080p 60hz [5650U])
On 4/17/23 13:41, Samuel Iglesias Gonsálvez wrote:
Hello!
Registration & Call for Proposals are now open for XDC 2023, which will
take place on October 17-19, 2023.
Forgot to mention, it will be in A Coruña, Spain :)
https://xdc2023.x.org
As usual, the conference is free of charge and
Hello!
Registration & Call for Proposals are now open for XDC 2023, which will
take place on October 17-19, 2023.
https://xdc2023.x.org
As usual, the conference is free of charge and open to the general
public. If you plan on attending, please make sure to register as early
as possible!
In
On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote:
> No invocation of get_user_pages() uses the vmas parameter, so remove
> it.
>
> The GUP API is confusing and caveated. Recent changes have done much to
> improve that, however there is more we can do. Exporting vmas is a prime
>
On 15.04.23 14:09, Lorenzo Stoakes wrote:
No invocation of get_user_pages() uses the vmas parameter, so remove
it.
The GUP API is confusing and caveated. Recent changes have done much to
improve that, however there is more we can do. Exporting vmas is a prime
target as the caller has to be
Hi Ricardo,
On Mon, Mar 13, 2023 at 04:22:54PM +0100, Ricardo Garcia wrote:
> This is a reminder that the deadline for new memberships and renewals
> finishes in a couple of weeks. Original email follows.
>
> Thanks for your attention.
I don't know if I'm the only one affected by this issue,
Reviewed-by: jingwen.ch...@amd.com
On 4/14/23 4:41 PM, Chong Li wrote:
> [WHY]
> Function "amdgpu_irq_update()" called by "amdgpu_device_ip_late_init()" is
> an atomic context.
> We shouldn't access registers through KIQ since "msleep()" may be called in
> "amdgpu_kiq_rreg()".
>
> [HOW]
>
No invocation of get_user_pages() uses the vmas parameter, so remove
it.
The GUP API is confusing and caveated. Recent changes have done much to
improve that, however there is more we can do. Exporting vmas is a prime
target as the caller has to be extremely careful to preclude their use
after
No invocation of get_user_pages() uses the vmas parameter, so remove
it.
The GUP API is confusing and caveated. Recent changes have done much to
improve that, however there is more we can do. Exporting vmas is a prime
target as the caller has to be extremely careful to preclude their use
after
No invocation of get_user_pages() uses the vmas parameter, so remove
it.
The GUP API is confusing and caveated. Recent changes have done much to
improve that, however there is more we can do. Exporting vmas is a prime
target as the caller has to be extremely careful to preclude their use
after
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: warning:
symbol
'dccg314_init' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix
---
On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote:
> No invocation of get_user_pages() uses the vmas parameter, so remove
> it.
>
> The GUP API is confusing and caveated. Recent changes have done much to
> improve that, however there is more we can do. Exporting vmas is a prime
>
Am 14.04.23 um 18:22 schrieb Alan Liu:
[Why]
After gpu-reset, sometimes the driver would fail to enable vblank irq,
causing flip_done timed out and the desktop freezed.
During gpu-reset, we will disable and enable vblank irq in dm_suspend()
and dm_resume(). Later on in
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz:
Currently, we allow the framebuffer for a given plane to move between
memory domains, however when that happens it causes the screen to
flicker, it is even possible for the framebuffer to change memory
domains on every plane update (causing a
46 matches
Mail list logo
