[PATCH] drm/amdgpu: disable virtual display support on APP device

2023-06-05 Thread Yang Wang
virtual display is not support on APP device. Signed-off-by: Yang Wang Signed-off-by: Gavin Wan Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-05 Thread Sui Jingfeng
Hi, On 2023/6/6 06:16, Andi Shyti wrote: Hi Sui, On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng To keep consistent with vga_iostate_to_str() function, the third argument of vga_str_to_iostate() function should be 'unsigned int *'. I think the real reason

RE: [PATCH 1/2] drm/amdgpu: make sure BOs are locked in amdgpu_vm_get_memory

2023-06-05 Thread Chen, Guchun
[Public] Acked-by: Guchun Chen for this series. A simple question is we don't need to hold the lock if bo locations are not changed? Regards, Guchun > -Original Message- > From: Christian König > Sent: Monday, June 5, 2023 5:11 PM > To: amd-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-05 Thread Andi Shyti
Hi Sui, On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > To keep consistent with vga_iostate_to_str() function, the third argument > of vga_str_to_iostate() function should be 'unsigned int *'. I think the real reason is not to keep consistent with

RE: [PATCH] drm/amd: Check that a system is a NUMA system before looking for SRAT

2023-06-05 Thread Limonciello, Mario
[Public] > On 2023-06-02 08:18, Mario Limonciello wrote: > > It's pointless on laptops to look for the SRAT table as these are not > > NUMA. Check the number of possible nodes is > 1 to decide whether to > > look for SRAT. > > > > Suggested-by: Felix Kuehling > > Signed-off-by: Mario

Re: [PATCH] drm/amd: Check that a system is a NUMA system before looking for SRAT

2023-06-05 Thread Felix Kuehling
On 2023-06-02 08:18, Mario Limonciello wrote: It's pointless on laptops to look for the SRAT table as these are not NUMA. Check the number of possible nodes is > 1 to decide whether to look for SRAT. Suggested-by: Felix Kuehling Signed-off-by: Mario Limonciello I think we discussed this a

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Felix Richter
I will apply this patch and see if fixes the issue for me. Will let you now when I am done. Felix On 05.06.23 16:11, Alex Deucher wrote: On Sat, Jun 3, 2023 at 10:52 AM Felix Richter wrote: Hi Guys, sorry for the silence from my side. I had a lot of things to take care of after returning

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Felix Richter
Hi, I can confirm that setting amdgpu.sg_display=0 does not fix the issue for me. I have 64GB of Kinsten Memory running with XMP at 5200MHz. I attached the result of `dmidecode --type=memory` to this email. Kind regards Felix Richter On 05.06.23 17:27, Hamza Mahfooz wrote: On 6/3/23

[PATCH 2/2] drm/amd/display: mark dml314's UseMinimumDCFCLK() as noinline_for_stack

2023-06-05 Thread Hamza Mahfooz
clang reports: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:3892:6: error: stack frame size (2632) exceeds limit (2048) in 'dml314_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than] 3892 | void dml314_ModeSupportAndSystemConfigurationFull(struct

[PATCH 1/2] drm/amd/display: mark dml31's UseMinimumDCFCLK() as noinline_for_stack

2023-06-05 Thread Hamza Mahfooz
clang reports: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.c:3797:6: error: stack frame size (2632) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than] 3797 | void dml31_ModeSupportAndSystemConfigurationFull(struct

Re: drm/amd: Drop messages in init for radeon, amdgpu

2023-06-05 Thread Limonciello, Mario
On 6/5/2023 9:28 AM, Alex Deucher wrote: Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the user's configuration. Drop the message in the module init function as this can be confusing to users. Link:

Re: [PATCH] drm/amdkfd: mark som eclear_address_watch() callback static

2023-06-05 Thread Alex Deucher
On Mon, Jun 5, 2023 at 6:58 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Some of the newly introduced clear_address_watch callback handlers have > no prototype because they are only used in one file, which causes a W=1 > warning: > >

Re: [PATCH] drm/amdgpu: Report ras_num_recs in debugfs

2023-06-05 Thread Alex Deucher
On Sat, Jun 3, 2023 at 1:11 AM Luben Tuikov wrote: > > Report the number of records stored in the RAS EEPROM table in debugfs. > > This can be used by user-space to calculate the capacity of the RAS EEPROM > table since "bad_page_cnt_threshold" is also reported in the same place in > debugfs. > >

RE: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 ttm_bo_release+0x27e/0x2d0 [ttm]

2023-06-05 Thread Deucher, Alexander
[Public] + Christian > -Original Message- > From: Borislav Petkov > Sent: Saturday, June 3, 2023 1:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; dri- > de...@lists.freedesktop.org; lkml > Subject: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 >

Re: [PATCH] drm/amdgpu: fix xclk freq on CHIP_STONEY

2023-06-05 Thread Alex Deucher
Applied. Thanks! On Fri, Jun 2, 2023 at 11:13 PM Chia-I Wu wrote: > > On Fri, Jun 2, 2023 at 11:50 AM Alex Deucher wrote: > > > > Nevermind, missing your Signed-off-by. Please add and I'll apply. > Sorry that I keep forgetting... This patch is > > Signed-off-by: Chia-I Wu > > I can send

Re: [PATCH 2/4] drm/amdkfd: Signal page table fence after KFD flush tlb

2023-06-05 Thread Christian König
Am 05.06.23 um 17:40 schrieb Shashank Sharma: On 05/06/2023 17:18, Christian König wrote: Am 05.06.23 um 17:13 schrieb Shashank Sharma: On 02/06/2023 16:54, Felix Kuehling wrote: Am 2023-06-02 um 07:57 schrieb Christian König: Am 01.06.23 um 21:31 schrieb Philip Yang: To free page table

Re: [PATCH 2/4] drm/amdkfd: Signal page table fence after KFD flush tlb

2023-06-05 Thread Shashank Sharma
On 05/06/2023 17:18, Christian König wrote: Am 05.06.23 um 17:13 schrieb Shashank Sharma: On 02/06/2023 16:54, Felix Kuehling wrote: Am 2023-06-02 um 07:57 schrieb Christian König: Am 01.06.23 um 21:31 schrieb Philip Yang: To free page table BOs which are freed when updating page table,

[PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Paul Menzel
Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the model and user's configuration. amdgpu binds to all display class devices with VID 0x1002 and then determines whether or not to bind to a device based on whether the

RE: [PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Deucher, Alexander
[AMD Official Use Only - General] > -Original Message- > From: Paul Menzel > Sent: Monday, June 5, 2023 11:23 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter > Cc: Paul Menzel ; amd-gfx@lists.freedesktop.org; >

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Hamza Mahfooz
On 6/3/23 10:52, Felix Richter wrote: Hi Guys, sorry for the silence from my side. I had a lot of things to take care of after returning from vacation. Also I had to wait on the zfs modules to be updated to support kernel 6.3 for further testing. The bad news is that I am still

Re: [PATCH v2] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-05 Thread Alex Deucher
Applied. Thanks! On Mon, Jun 5, 2023 at 4:13 AM Christian König wrote: > > Am 03.06.23 um 09:43 schrieb Min Li: > > Userspace can race to free the gobj(robj converted from), robj should not > > be accessed again after drm_gem_object_put, otherwith it will result in > > use-after-free. > > > >

Re: [PATCH 2/4] drm/amdkfd: Signal page table fence after KFD flush tlb

2023-06-05 Thread Christian König
Am 05.06.23 um 17:13 schrieb Shashank Sharma: On 02/06/2023 16:54, Felix Kuehling wrote: Am 2023-06-02 um 07:57 schrieb Christian König: Am 01.06.23 um 21:31 schrieb Philip Yang: To free page table BOs which are freed when updating page table, for example PTE BOs when PDE0 used as PTE.

Re: [PATCH 2/2] drm/amdgpu: make sure that BOs have a backing store

2023-06-05 Thread Alex Deucher
On Mon, Jun 5, 2023 at 5:11 AM Christian König wrote: > > It's perfectly possible that the BO is about to be destroyed and doesn't > have a backing store associated with it. > > Signed-off-by: Christian König Series is: Reviewed-by: Alex Deucher > --- >

Re: [PATCH 2/4] drm/amdkfd: Signal page table fence after KFD flush tlb

2023-06-05 Thread Shashank Sharma
On 02/06/2023 16:54, Felix Kuehling wrote: Am 2023-06-02 um 07:57 schrieb Christian König: Am 01.06.23 um 21:31 schrieb Philip Yang: To free page table BOs which are freed when updating page table, for example PTE BOs when PDE0 used as PTE. Signed-off-by: Philip Yang ---  

[PATCH] drm/amd: Drop messages in init for radeon, amdgpu

2023-06-05 Thread Alex Deucher
Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the user's configuration. Drop the message in the module init function as this can be confusing to users. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2608

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Felix Richter
Hi Guys, sorry for the silence from my side. I had a lot of things to take care of after returning from vacation. Also I had to wait on the zfs modules to be updated to support kernel 6.3 for further testing. The bad news is that I am still experiencing issues. I have been able to get a

[PATCH v2] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-05 Thread Min Li
Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free. Signed-off-by: Min Li --- Changes in v2: - Remove unused robj, avoid compile complain drivers/gpu/drm/radeon/radeon_gem.c | 4 +---

WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 ttm_bo_release+0x27e/0x2d0 [ttm]

2023-06-05 Thread Borislav Petkov
Hi, this below triggers with the latest Linus tree: 51f269a6ecc7 ("Merge tag 'probes-fixes-6.4-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace") ... [ 16.173593] [drm] radeon kernel modesetting enabled. [ 16.173743] radeon :29:00.0: vgaarb: deactivate vga

Re: Build regressions/improvements in v6.4-rc5

2023-06-05 Thread Geert Uytterhoeven
On Mon, 5 Jun 2023, Geert Uytterhoeven wrote: JFYI, when comparing v6.4-rc5[1] to v6.4-rc4[3], the summaries are: - build errors: +2/-4 arm64-gcc5/arm64-allmodconfig (seen before) [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9561de3a55bed6bdd44a12820ba81ec416e705a7/ (151 out

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Alex Deucher
On Sat, Jun 3, 2023 at 10:52 AM Felix Richter wrote: > > Hi Guys, > > sorry for the silence from my side. I had a lot of things to take care > of after returning from vacation. Also I had to wait on the zfs modules > to be updated to support kernel 6.3 for further testing. > > The bad news is

RE: [PATCH 00/14] DC Patches June 2, 2023

2023-06-05 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: *

[PATCH Review V2 3/3] drm/amdgpu: convert vcn/jpeg logical mask to physical mask

2023-06-05 Thread Stanley . Yang
Changed from V1: Remove amdgpu_ras_logical_mask_to_physical_mask due to GET_MASK provides same feature. Support convert VCN/JPEG logical mask to physical mask. Signed-off-by: Stanley.Yang Reviewed-by: Tao Zhou Reviewed-by: Hawking Zhang ---

[PATCH Review V2 1/3] drm/amdgpu: pass xcc mask to ras ta

2023-06-05 Thread Stanley . Yang
pass xcc mask to ras ta, ras ta will compare the mask with the one from chiplet topology. Changed from V1: Remove IP version checking. Set ras_cmd->ras_init_message.init_flags.xcc_mask directly due to xcc_mask is common structres to all the devices. Signed-off-by:

[PATCH Review V2 2/3] drm/amdgpu: support check vcn jpeg block mask

2023-06-05 Thread Stanley . Yang
Support VCN/JPEG instance mask checking, pass logical mask directly except GFX/SDMA/VCN/JPEG blocks. Changed from V1: correct a typo Signed-off-by: Stanley.Yang Reviewed-by: Tao Zhou Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 +- 1 file changed, 5

[PATCH] drm/amdkfd: mark som eclear_address_watch() callback static

2023-06-05 Thread Arnd Bergmann
From: Arnd Bergmann Some of the newly introduced clear_address_watch callback handlers have no prototype because they are only used in one file, which causes a W=1 warning: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c:164:10: error: no previous prototype for

[PATCH 1/2] drm/amdgpu: make sure BOs are locked in amdgpu_vm_get_memory

2023-06-05 Thread Christian König
We need to grab the lock of the BO or otherwise can run into a crash when we try to inspect the current location. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 69 +++--- 1 file changed, 39 insertions(+), 30 deletions(-) diff --git

[PATCH 2/2] drm/amdgpu: make sure that BOs have a backing store

2023-06-05 Thread Christian König
It's perfectly possible that the BO is about to be destroyed and doesn't have a backing store associated with it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] Revert "drm/amdgpu: change the reference clock for raven/raven2"

2023-06-05 Thread Michel Dänzer
On 6/2/23 20:43, Alex Deucher wrote: > This reverts commit fbc24293ca16b3b9ef891fe32ccd04735a6f8dc1. > > This results in inconsistent timing reported via asynchronous > GPU queries. > > Link: https://lists.freedesktop.org/archives/amd-gfx/2023-May/093731.html > Cc: jesse.zh...@amd.com > Cc:

Re: [PATCH v2] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-05 Thread Christian König
Am 03.06.23 um 09:43 schrieb Min Li: Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free. Signed-off-by: Min Li Reviewed-by: Christian König --- Changes in v2: - Remove unused