RE: [PATCH] drm/amdgpu: Move calculation of xcp per memory node

2023-06-13 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, June 14, 2023 12:28 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Yang, Philip ; Kamal, Asad ; Ma, Le Subject: [PATCH]

[PATCH] drm/amdgpu: Move calculation of xcp per memory node

2023-06-13 Thread Lijo Lazar
Its value is required for finding the memory id of xcp. Fixes: 2130f4ca70b7f ("drm/amdgpu: Add xcp manager num_xcp_per_mem_partition") Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

RE: [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface

2023-06-13 Thread Ma, Le
[AMD Official Use Only - General] Series is Reviewed-by: Le Ma > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, June 13, 2023 6:54 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Kamal, Asad ; Ma, > Le > Subject: [PATCH 3/3] drm/amdgpu:

[PATCH] drm/amd/display: Convert to kdoc formats in dc/core/dc.c

2023-06-13 Thread Srinivasan Shanmugam
Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3483: warning: Cannot understand * *** drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4204: warning: Cannot understand *

Re: [PATCH v5] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-13 Thread Lyude Paul
Alright, managed to figure out my MST woes! Just tested with nouveau and I see no regressions :) Reviewed-by: Lyude Paul On Fri, 2023-06-09 at 18:49 +0800, Wayne Lin wrote: > [Why] > The sequence for collecting down_reply from source perspective should > be: > > Request_n->repeat (get partial

[PATCH v2] drm/amd/pm: Align eccinfo table structure with smu v13_0_0 interface

2023-06-13 Thread Candice Li
Update eccinfo table structure according to smu v13_0_0 interface. v2: Calculate array size instead of using macro definition. Signed-off-by: Candice Li Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 2/2] drm/amdgpu: Add channel_dis_num to ras init flags

2023-06-13 Thread Candice Li
Add disabled channel number to ras init flags. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/ta_ras_if.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH 1/2] drm/amdgpu: Update total channel number for umc v8_10

2023-06-13 Thread Candice Li
Update total channel number for umc v8_10. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 ++ drivers/gpu/drm/amd/amdgpu/umc_v8_10.h| 3 ++- 3 files changed, 5

Re: [PATCH] drm/amdkfd: decrement queue count on mes queue destroy

2023-06-13 Thread Felix Kuehling
On 2023-06-13 17:48, Jonathan Kim wrote: Queue count should decrement on queue destruction regardless of HWS support type. Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/amdkfd: decrement queue count on mes queue destroy

2023-06-13 Thread Jonathan Kim
Queue count should decrement on queue destruction regardless of HWS support type. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

[linux-next:master] BUILD REGRESSION 1f6ce8392d6ff486af5ca96df9ded5882c4b6977

2023-06-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 1f6ce8392d6ff486af5ca96df9ded5882c4b6977 Add linux-next specific files for 20230613 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306082341.uqtcm8po-...@intel.com https

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-06-13 Thread Jacopo Mondi
Hello I'm completing the support for 3D LUT on R-Car DU peripheral and I have used this series as a base. I'm wondering, since quite some time has passed without any update if this series is still a thing and it makes any sense for me to try to bring it forward. I'm asking as I've noticed:

[PATCH 2/2] drm/amdgpu/pm: make mclk consistent for smu 13.0.7

2023-06-13 Thread Alex Deucher
Use current uclk to be consistent with other dGPUs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

[PATCH 1/2] drm/amdgpu/pm: make gfxclock consistent for sienna cichlid

2023-06-13 Thread Alex Deucher
Use average gfxclock for consistency with other dGPUs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-13 Thread Michel Dänzer
On 6/12/23 20:14, Pillai, Aurabindo wrote: > > I want to double check if we're identifying the correct monitor for applying > the workaround. Could you please try the attached patch and let me know the > panel id ? amdgpu: ### Not applying any edid quirk for panel 4c2d71ac I'm attaching the

[PATCHv3] drm/amdgpu: Update invalid PTE flag setting

2023-06-13 Thread Mukul Joshi
Update the invalid PTE flag setting with TF enabled. This is to ensure, in addition to transitioning the retry fault to a no-retry fault, it also causes the wavefront to enter the trap handler. With the current setting, the fault only transitions to a no-retry fault. Additionally, have 2 sets of

[PATCH 2/3] drm/amdgpu: cache gpuvm fault information for gmc7+

2023-06-13 Thread Alex Deucher
Cache the current fault info in the vm struct. This can be queried by userspace later to help debug UMDs. Cc: samuel.pitoi...@gmail.com Acked-by: Guchun Chen Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 +++

[PATCH 3/3] drm/amdgpu: add new INFO ioctl query for the last GPU page fault

2023-06-13 Thread Alex Deucher
Add a interface to query the last GPU page fault for the process. Useful for debugging context lost errors. v2: split vmhub representation between kernel and userspace Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238 libdrm MR:

[PATCH 1/3] drm/amdgpu: add cached GPU fault structure to vm struct

2023-06-13 Thread Alex Deucher
When we get a GPU page fault, cache the fault for later analysis. Cc: samuel.pitoi...@gmail.com Acked-by: Guchun Chen Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 31 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 18 +++ 2 files

[PATCH v2 0/3] Add GPU page fault query interface

2023-06-13 Thread Alex Deucher
This patch set adds support for an application to query GPU page faults. It's useful for debugging and there are vulkan extensions that could make use of this. Preliminary user space code which uses this can be found here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Tue, Jun 13, 2023 at 3:59 PM Christian König wrote: > > Am 13.06.23 um 15:05 schrieb Karol Herbst: > > On Mon, Dec 5, 2022 at 2:40 PM Christian König > > wrote: > >> Am 29.11.22 um 22:14 schrieb Felix Kuehling: > >>> On 2022-11-25 05:21, Christian König wrote: > Instead of a single

Re: [PATCH] drm/amdgpu/sdma4: set align mask to 255

2023-06-13 Thread Christian König
Reviewed-by: Christian König Am 13.06.23 um 03:14 schrieb Liu, Aaron: [AMD Official Use Only - General] Reviewed-by: Aaron Liu -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, June 13, 2023 5:48 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Christian König
Am 13.06.23 um 15:05 schrieb Karol Herbst: On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: Am 29.11.22 um 22:14 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote: Instead of a single worker going over the list of delete BOs in regular intervals use a per BO worker

Re: [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface

2023-06-13 Thread Deucher, Alexander
[Public] Sorry, replied to the wrong rev of the patch. my AB applies to v2 as well. Alex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, June 13, 2023 9:25 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Ma, Le ; Kamal, Asad ; Zhang,

Re: [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface

2023-06-13 Thread Deucher, Alexander
[Public] Series is: Acked-by: Alex Deucher From: Lazar, Lijo Sent: Tuesday, June 13, 2023 6:53 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le Subject: [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface

Re: [PATCH] drm/amdgpu: update external rev_id for gc_11_0_1 and gc_11_0_4

2023-06-13 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Aaron Liu Sent: Monday, June 12, 2023 11:09 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Liu, Aaron Subject: [PATCH] drm/amdgpu: update external rev_id for gc_11_0_1

Re: [PATCH] drm/amdkfd: Remove DUMMY_VRAM_SIZE

2023-06-13 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Mukul Joshi Sent: Monday, June 12, 2023 7:06 PM To: amd-gfx@lists.freedesktop.org Cc: Joshi, Mukul ; Kuehling, Felix Subject: [PATCH] drm/amdkfd: Remove DUMMY_VRAM_SIZE Remove DUMMY_VRAM_SIZE as it

Re: [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: > > Am 29.11.22 um 22:14 schrieb Felix Kuehling: > > On 2022-11-25 05:21, Christian König wrote: > >> Instead of a single worker going over the list of delete BOs in regular > >> intervals use a per BO worker which blocks for the resv object

RE: [PATCH v2 2/3] drm/amdgpu: Use PSP FW API for partition switch

2023-06-13 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards Hawking -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, June 13, 2023 19:03 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Kamal, Asad ; Zhang, Hawking

RE: [PATCH] drm/amdgpu: Release SDMAv4.4.2 ecc irq properly

2023-06-13 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Tuesday, June 13, 2023 18:46 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le Subject: [PATCH] drm/amdgpu: Release

[PATCH v2 2/3] drm/amdgpu: Use PSP FW API for partition switch

2023-06-13 Thread Lijo Lazar
Use PSP firmware interface for switching compute partitions. Signed-off-by: Lijo Lazar --- v2: Changed the return value to int .../drm/amd/amdgpu/aqua_vanjaram_reg_init.c| 3 --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c| 18 ++ 2 files changed, 6

[PATCH v2 3/3] drm/amdgpu: Remove unused NBIO interface

2023-06-13 Thread Lijo Lazar
Set compute partition mode interface in NBIO is no longer used. Remove the only implementation from NBIO v7.9 Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 2 -- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 14 -- 2 files changed, 16 deletions(-) diff

[PATCH v2 1/3] drm/amdgpu: Change nbio v7.9 xcp status definition

2023-06-13 Thread Lijo Lazar
PARTITION_MODE field in PARTITION_COMPUTE_STATUS register is defined as below by firmware. SPX = 0, DPX = 1, TPX = 2, QPX = 3, CPX = 4 Change driver definition accordingly. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 8 +++- 1 file changed, 3

[PATCH 2/3] drm/amdgpu: Use PSP FW API for partition switch

2023-06-13 Thread Lijo Lazar
Use PSP firmware interface for switching compute partitions. Signed-off-by: Lijo Lazar --- .../drm/amd/amdgpu/aqua_vanjaram_reg_init.c| 3 --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c| 18 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git

[PATCH 3/3] drm/amdgpu: Remove unused NBIO interface

2023-06-13 Thread Lijo Lazar
Set compute partition mode interface in NBIO is no longer used. Remove the only implementation from NBIO v7.9 Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 2 -- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 14 -- 2 files changed, 16 deletions(-) diff

[PATCH 1/3] drm/amdgpu: Change nbio v7.9 xcp status definition

2023-06-13 Thread Lijo Lazar
PARTITION_MODE field in PARTITION_COMPUTE_STATUS register is defined as below by firmware. SPX = 0, DPX = 1, TPX = 2, QPX = 3, CPX = 4 Change driver definition accordingly. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 8 +++- 1 file changed, 3

[PATCH] drm/amdgpu: Release SDMAv4.4.2 ecc irq properly

2023-06-13 Thread Lijo Lazar
Release ECC irq only if irq is enabled - only when RAS feature is enabled ECC irq gets enabled. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c

RE: [PATCH v5] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-13 Thread Lin, Wayne
[AMD Official Use Only - General] Noted. Thanks, Lyude! Regards, Wayne Lin > -Original Message- > From: Lyude Paul > Sent: Tuesday, June 13, 2023 6:34 AM > To: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com;

RE: [PATCH] drm/amdgpu: add wait_for helper for spirom update

2023-06-13 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Gao, Likun Sent: Tuesday, June 13, 2023 15:37 To: amd-gfx list Subject: [PATCH] drm/amdgpu: add wait_for helper for spirom update [AMD Official Use Only -

[PATCH] drm/amdgpu: add wait_for helper for spirom update

2023-06-13 Thread Gao, Likun
[AMD Official Use Only - General] From: Likun Gao Sent: Tuesday, June 13, 2023 3:29 PM To: brahma_sw_dev Cc: Zhang, Hawking ; Gao, Likun Subject: [PATCH] drm/amdgpu: add wait_for helper for spirom update From: Likun Gao Spirom update typically requires extremely long duration for command

RE: [PATCH Review 1/2] drm/amdgpu: Optimze checking ras supported

2023-06-13 Thread Yang, Stanley
[AMD Official Use Only - General] > -Original Message- > From: Zhou1, Tao > Sent: Tuesday, June 13, 2023 3:08 PM > To: Yang, Stanley ; amd-gfx@lists.freedesktop.org; > Zhang, Hawking > Cc: Yang, Stanley > Subject: RE: [PATCH Review 1/2] drm/amdgpu: Optimze checking ras > supported > >

RE: [PATCH Review 2/2] drm/amdgpu: Add checking mc_vram_size

2023-06-13 Thread Zhou1, Tao
[AMD Official Use Only - General] With my concerns fixed, the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Tuesday, June 13, 2023 11:53 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH

RE: [PATCH Review 1/2] drm/amdgpu: Optimze checking ras supported

2023-06-13 Thread Zhou1, Tao
[AMD Official Use Only - General] [Tao] typo in title: Optimze -> Optimize > -Original Message- > From: Stanley.Yang > Sent: Tuesday, June 13, 2023 11:53 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH Review 1/2] drm/amdgpu: