[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, June 27, 2023 12:39
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma, Le ;
Kasiviswanathan, Harish ; Kamal, Asad
; Zhang,
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Lazar, Lijo
Sent: Tuesday, June 27, 2023 13:19
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
; Gadre, Mangesh
Subject: [PATCH] drm/amdgpu: Keep non-psp
When PSP block is not present, use direct programming.
Signed-off-by: Lijo Lazar
Acked-by: Mangesh Gadre
Tested-by: Mangesh Gadre
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 28 +++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git
[AMD Official Use Only - General]
Reviewed-by: Yang Wang
Best Regards,
Kevin
-Original Message-
From: amd-gfx On Behalf Of Lazar, Lijo
Sent: Tuesday, June 27, 2023 12:39 PM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma, Le ;
Kasiviswanathan, Harish ;
On 6/27/2023 9:02 AM, Quan, Evan wrote:
[AMD Official Use Only - General]
-Original Message-
From: Lazar, Lijo
Sent: Monday, June 26, 2023 7:54 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: Re: [PATCH 2/2] drm/amd/pm: avoid unintentional
This function is more general and easy to use by more clients.
Signed-off-by: Lang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 29 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 6 +
2 files changed, 35 insertions(+)
diff --git
Replace the old ones with psp_execute_load_ip_fw_cmd_buf.
Signed-off-by: Lang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 31 -
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 --
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 9 +++
[AMD Official Use Only - General]
Thanks,
Lijo
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Wednesday, June 21, 2023 6:49 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma, Le ;
Kasiviswanathan, Harish ; Kamal, Asad
; Zhang, Hawking
Subject: [PATCH]
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Le Ma
Sent: Tuesday, June 27, 2023 11:56
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 1/1] drm/amdgpu: remove duplicated doorbell range init for sdma
v4.4.2
Handled in earlier phase
Signed-off-by: Le Ma
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
index 6be19ffc502b..f413898dda37 100644
---
[AMD Official Use Only - General]
> -Original Message-
> From: Lazar, Lijo
> Sent: Monday, June 26, 2023 7:54 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: Re: [PATCH 2/2] drm/amd/pm: avoid unintentional shutdown due to
> temperature momentary
Please ignore this patch, will send a new one.
Regards,
Lang
On 06/27/ , Lang Yu wrote:
> Rename psp_update_vcn_sram to psp_execute_ucode_loading
> so that other clients can feel free to use it.
>
> Signed-off-by: Lang Yu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 19
Rename psp_update_vcn_sram to psp_execute_ucode_loading
so that other clients can feel free to use it.
Signed-off-by: Lang Yu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 19 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 7 +--
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 7
On 6/23/23 11:05, Mario Limonciello wrote:
The same parade TCON issue can potentially happen on Phoenix, and the same
PSR resilience changes have been ported into the DMUB firmware.
Don't allow running PSR-SU unless on the newer firmware.
Cc: Sean Wang
Cc: Marc Rossi
Cc: Hamza Mahfooz
On 6/23/23 11:05, Mario Limonciello wrote:
A number of parade TCONs are causing system hangs when utilized with
older DMUB firmware and PSR-SU. Some changes have been introduced into
DMUB firmware to add resilience against these failures.
Don't allow running PSR-SU unless on the newer
On Mon, Jun 26, 2023 at 11:04 AM Mario Limonciello
wrote:
>
Needs a basic patch description. Even just "add documentation"
With that fixed, the series is:
Reviewed-by: Alex Deucher
> Signed-off-by: Mario Limonciello
> ---
> Documentation/gpu/amdgpu/flashing.rst | 33
This v4 removes the common DRM ioctl, and adds just the documentation for now,
giving the lack of a common "DRM context" infrascture make it hard to implement.
v3: https://lore.kernel.org/lkml/20230621005719.836857-1-andrealm...@igalia.com/
Changes:
- Drop the ioctl
- Addresed comments com
Create a section that specifies how to deal with DRM device resets for
kernel and userspace drivers.
Signed-off-by: André Almeida
---
Documentation/gpu/drm-uapi.rst | 68 ++
1 file changed, 68 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst
[Public]
> -Original Message-
> From: Limonciello, Mario
> Sent: Monday, June 26, 2023 12:45 PM
> To: Hersen Wu ; amd-gfx@lists.freedesktop.org;
> Wentland, Harry
> Cc: Wu, Hersen
> Subject: RE: [PATCH] Revert "drm/amd/display: edp do not add non-edid
> timings"
>
> > This change causes
[Public]
> This change causes regression when eDP and external display in mirror
> mode. When external display supports low resolution than eDP, use eDP
> timing to driver external display may cause corruption on external
> display.
>
> This reverts commit
This change causes regression when eDP and external display in mirror
mode. When external display supports low resolution than eDP, use eDP
timing to driver external display may cause corruption on external
display.
This reverts commit aa9704d5127f06c9ffedb0480d2788b87fecedfb.
Signed-off-by:
Em 22/06/2023 05:12, Pekka Paalanen escreveu:
On Wed, 21 Jun 2023 13:28:34 -0300
André Almeida wrote:
Em 21/06/2023 04:58, Pekka Paalanen escreveu:
On Tue, 20 Jun 2023 21:57:16 -0300
André Almeida wrote:
Create a section that specifies how to deal with DRM device resets for
kernel and
Am 26.06.23 um 16:50 schrieb Saleemkhan Jamadar:
add session context buffer to decoder ring test.
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 30 ++---
Am 26.06.23 um 14:43 schrieb Srinivasan Shanmugam:
Fixes the following category of checkpatch complaints:
WARNING: unnecessary cast may hide bugs, see
http://c-faq.com/malloc/mallocnocast.html
+ char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL);
Cc: Rodrigo Siqueira
On 6/26/2023 10:05 AM, Alex Deucher wrote:
On Mon, Jun 26, 2023 at 11:00 AM Mario Limonciello
wrote:
`pcie_index` and `pcie_data` aren't used by
amdgpu_device_indirect_wreg() since commit 65ba96e91b68
("drm/amdgpu: Move to common indirect reg access helper") but
the documentation wasn't
On Mon, Jun 26, 2023 at 11:00 AM Mario Limonciello
wrote:
>
> `pcie_index` and `pcie_data` aren't used by
> amdgpu_device_indirect_wreg() since commit 65ba96e91b68
> ("drm/amdgpu: Move to common indirect reg access helper") but
> the documentation wasn't updated. This causes a warning while
>
Signed-off-by: Mario Limonciello
---
Documentation/gpu/amdgpu/flashing.rst | 33 +
Documentation/gpu/amdgpu/index.rst | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 16
3 files changed, 50 insertions(+)
create mode 100644
Individually creating attributes can be racy, instead make attributes
using attribute groups and control their visibility with an is_visible
callback to only show when using appropriate products.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -
Rather than special casing the creation of the file, special case
the visibility to the supported dGPUs.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 1 -
2 files changed, 9 insertions(+),
Debug messages related to the kernel process of flashing an updated
IFWI are needlessly noisy and also confusing.
Downgrade them to debug instead and clarify what they are actually
doing.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8
1 file changed,
PSP functions are already set by psp_early_init() so initializing
them a second time is unnecessary.
No intended functional changes.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4
1 file changed, 4 deletions(-)
diff --git
`pcie_index` and `pcie_data` aren't used by
amdgpu_device_indirect_wreg() since commit 65ba96e91b68
("drm/amdgpu: Move to common indirect reg access helper") but
the documentation wasn't updated. This causes a warning while
building documentation.
Fixes: 65ba96e91b68 ("drm/amdgpu: Move to common
add session context buffer to decoder ring test fro vcn v1 to v3.
Signed-off-by: Saleemkhan Jamadar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 43 ++---
1 file changed, 38 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
add session context buffer to decoder ring test.
v2 - put the buffer at the end of the IB (Christian)
Signed-off-by: Saleemkhan Jamadar
Acked-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 30 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++
2 files
On Mon, Jun 26, 2023 at 9:58 AM Christian König
wrote:
>
> Hi guys,
>
> Vitaly and Jasber have been recently working on disabling the IGT tests
> for the TSC query on RV/RV2 (which I'm not very keen on).
>
> And additional to that we have this RADV merge request here:
>
On 6/23/23 23:49, Srinivasan Shanmugam wrote:
> Fix the following warnings reported by checkpatch:
>
> WARNING: Missing a blank line after declarations
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Cc: Rodrigo Siqueira
> Cc: Aurabindo Pillai
> Signed-off-by: Srinivasan
Hi guys,
Vitaly and Jasber have been recently working on disabling the IGT tests
for the TSC query on RV/RV2 (which I'm not very keen on).
And additional to that we have this RADV merge request here:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23481
What exactly is going on
Acked-by: Alex Deucher
On Mon, Jun 26, 2023 at 8:35 AM Lijo Lazar wrote:
>
> on APUs with GFX v9.4.3
>
> Signed-off-by: Lijo Lazar
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
>
Am 31.05.23 um 16:39 schrieb Alex Deucher:
This reverts commit f57a74f5b42d1627bd5366f88952d42819e91146.
After talking this over with Christian, the original programming
sequence was correct. The enable bit needs to be set before
programming the rest of the context.
Signed-off-by: Alex
Fixes the following category of checkpatch complaints:
WARNING: unnecessary cast may hide bugs, see
http://c-faq.com/malloc/mallocnocast.html
+ char *buf = (char *)kvcalloc(total, sizeof(char), GFP_KERNEL);
Cc: Rodrigo Siqueira
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan
on APUs with GFX v9.4.3
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 9ec51f50fc52..9ef88a0b1b57 100644
---
[Public]
Thanks Christian for the review. I'll remove the leading blanks before
submitting the patch.
Pierre-Eric
From: Koenig, Christian
Sent: Wednesday, June 21, 2023 5:00 PM
To: Pelloux-Prayer, Pierre-Eric ;
amd-gfx@lists.freedesktop.org
Subject: Re:
On 6/26/2023 1:17 PM, Evan Quan wrote:
An intentional delay is added on soft ctf triggered. Then there will
be a double check for the GPU temperature before taking further
action. This can avoid unintended shutdown due to temperature
momentary fluctuation.
Signed-off-by: Evan Quan
---
Am 25.05.23 um 18:52 schrieb Alex Deucher:
Add a interface to query the last GPU page fault for the process.
Useful for debugging context lost errors.
v2: split vmhub representation between kernel and userspace
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238
libdrm MR:
[AMD Official Use Only - General]
Reviewed-and-tested-by: Jiadong Zhu
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Saturday, June 17, 2023 5:10 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/2] drm/amdgpu: enable mcbp by default on
[AMD Official Use Only - General]
Reviewed-and-tested-by: Jiadong Zhu
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Saturday, June 17, 2023 5:10 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu: make mcbp a per device
Hi
Am 25.06.23 um 07:09 schrieb Sui Jingfeng:
As this function can be replaced with drm_dev_unregister() + drm_dev_put(),
it is already marked as deprecated, so remove it. No functional change.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_drv.c | 28
On Sun, 25 Jun 2023, Sui Jingfeng wrote:
> As this function can be replaced with drm_dev_unregister() + drm_dev_put(),
> it is already marked as deprecated, so remove it. No functional change.
>
> Signed-off-by: Sui Jingfeng
> ---
> drivers/gpu/drm/drm_drv.c | 28
An intentional delay is added on soft ctf triggered. Then there will
be a double check for the GPU temperature before taking further
action. This can avoid unintended shutdown due to temperature
momentary fluctuation.
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h |
Preparation for coming optimization which eliminates the influence of
GPU temperature momentary fluctuation.
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h| 2 ++
.../gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c | 4 +++-
[AMD Official Use Only - General]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Chai, Thomas
Sent: Monday, June 26, 2023 13:39
To: amd-gfx@lists.freedesktop.org
Cc: Chai, Thomas ; Zhang, Hawking ;
Zhou1, Tao ; Li, Candice ; Yang, Stanley
; Chai, Thomas
51 matches
Mail list logo
