Re: [PATCH v2] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

2023-07-04 Thread Lazar, Lijo
On 7/5/2023 11:16 AM, Yang Wang wrote: v1: the dceflck sysnode is not aviable on GFX v9.4.3 chip. v2: simplify code logic using helper function: amdgpu_device_has_display_hardware(). Signed-off-by: Yang Wang Reviewed-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +--- 1

[PATCH v2] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

2023-07-04 Thread Yang Wang
v1: the dceflck sysnode is not aviable on GFX v9.4.3 chip. v2: simplify code logic using helper function: amdgpu_device_has_display_hardware(). Signed-off-by: Yang Wang Reviewed-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH] drm/ttm: fix one use-after-free

2023-07-04 Thread Lang Yu
[ 67.399887] refcount_t: underflow; use-after-free. [ 67.399901] WARNING: CPU: 0 PID: 3172 at lib/refcount.c:28 refcount_warn_saturate+0xc2/0x110 [ 67.400124] RIP: 0010:refcount_warn_saturate+0xc2/0x110 [ 67.400173] Call Trace: [ 67.400176] [ 67.400181]

[PATCH] drm/amdgpu: Remove redundant GFX v9.4.3 sequence

2023-07-04 Thread Lijo Lazar
Programming of XCC id is already taken care with partition mode change. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

Re: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

2023-07-04 Thread Lazar, Lijo
On 7/5/2023 7:55 AM, Wang, Yang(Kevin) wrote: [AMD Official Use Only - General] [AMD Official Use Only - General] Ping... -Original Message- From: Wang, Yang(Kevin) Sent: Friday, June 30, 2023 7:22 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) Subject: [PATCH]

[PATCH] virtio-gpu: Remove stride and layer_stride check for dGPU prime on VM

2023-07-04 Thread Julia Zhang
Remove stride and layer_stride check in virtio-gpu so that virgl can send transfer data command with non zero stride to sync up data from guest to host for dGPU prime on VM. Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23896 Signed-off-by: Julia Zhang ---

RE: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

2023-07-04 Thread Feng, Kenneth
[AMD Official Use Only - General] Reviewed-by: Kenneth Feng -Original Message- From: amd-gfx On Behalf Of Wang, Yang(Kevin) Sent: Wednesday, July 5, 2023 10:25 AM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

RE: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip

2023-07-04 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Ping... -Original Message- From: Wang, Yang(Kevin) Sent: Friday, June 30, 2023 7:22 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) Subject: [PATCH] drm/amd/pm: disbale dcefclk device sysnode on GFX v9.4.3 chip the dceflck sysnode is not

Re: [PATCH] drm/amdgpu: Prefer dev_warn over printk

2023-07-04 Thread Christian König
Am 04.07.23 um 17:43 schrieb Srinivasan Shanmugam: Fix the below warning: WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Acked-by:

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-07-04 Thread Simon Ser
On Tuesday, July 4th, 2023 at 19:06, Sebastian Wick wrote: > > + * When used with atomic uAPI, the driver will return an error if the > > hardware > > + * doesn't support performing an asynchronous page-flip for this update. > > + * User-space should handle this, e.g. by falling back to a

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-07-04 Thread Sebastian Wick
On Sat, Jul 1, 2023 at 4:09 AM André Almeida wrote: > > From: Simon Ser > > If the driver supports it, allow user-space to supply the > DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. > Set drm_crtc_state.async_flip accordingly. > > Document that drivers will reject atomic commits

RE: [PATCH 4/5] drm/amdkfd: add xcc instance for debugger APIs

2023-07-04 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Wednesday, June 28, 2023 5:23 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Huang, JinHuiEric > > Subject: [PATCH 4/5] drm/amdkfd: add xcc instance for debugger APIs > > Since GFX9 GPU has multiple xcc

RE: [PATCH 2/5] drm/amdkfd: add multi-process debugging support for GC v9.4.3

2023-07-04 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Wednesday, June 28, 2023 5:23 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Kim, Jonathan > ; Kuehling, Felix ; > Huang, JinHuiEric > Subject: [PATCH 2/5] drm/amdkfd: add multi-process debugging support for >

[PATCH] drm/amdgpu: Prefer dev_warn over printk

2023-07-04 Thread Srinivasan Shanmugam
Fix the below warning: WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +-

RE: [PATCH 1/5] drm/amdgpu: add debugger support for GC v9.4.3

2023-07-04 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Wednesday, June 28, 2023 5:23 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Kim, Jonathan > ; Huang, JinHuiEric > Subject: [PATCH 1/5] drm/amdgpu: add debugger support for GC v9.4.3 This patch doesn't add

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

2023-07-04 Thread Christian König
Am 04.07.23 um 16:31 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 14:33, Christian König wrote: Am 04.07.23 um 14:24 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 08:54, Christian König wrote: Am 03.07.23 um 14:35 schrieb Arnd Bergmann: Not sure I understand the specific requirement. Do

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

2023-07-04 Thread Christian König
Am 04.07.23 um 14:24 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 08:54, Christian König wrote: Am 03.07.23 um 14:35 schrieb Arnd Bergmann: From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning:

RE: [PATCH] drm/amdgpu: Change golden settings for GFX v9.4.3

2023-07-04 Thread Gadre, Mangesh
[AMD Official Use Only - General] Acked-and-tested-by: Gadre, Mangesh -Original Message- From: Lazar, Lijo Sent: Tuesday, July 4, 2023 9:09 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Gadre, Mangesh Subject: [PATCH]

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Michel Dänzer
On 7/4/23 04:34, Marek Olšák wrote: > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > On 6/30/23 22:32, Marek Olšák wrote: > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > mailto:michel.daen...@mailbox.org> >

RE: [PATCH] drm/amdgpu: Change golden settings for GFX v9.4.3

2023-07-04 Thread Kamal, Asad
[AMD Official Use Only - General] Reviewed-by: Asad Kamal -Original Message- From: Lazar, Lijo Sent: Tuesday, July 4, 2023 9:09 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Ma, Le ; Gadre, Mangesh Subject: [PATCH] drm/amdgpu: Change

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Pekka Paalanen
On Mon, 3 Jul 2023 12:00:22 -0300 André Almeida wrote: > Em 03/07/2023 05:49, Pekka Paalanen escreveu: > > If an application freezes, that's "no problem"; the end user can just > > continue using everything else. Alt-tab away etc. if the app was > > fullscreen. I do that already with games on

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Randy Dunlap
On 7/3/23 19:44, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 22:38 Randy Dunlap > wrote: > > > > On 7/3/23 19:34, Marek Olšák wrote: > > > > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-07-04 Thread Randy Dunlap
On 7/3/23 19:34, Marek Olšák wrote: > > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > Marek, Please stop sending html emails to the mailing lists. The mailing list software drops them. Please set your email interface to use plain text mode

[PATCH] drm/amdgpu: Use local64_try_cmpxchg in amdgpu_perf_read

2023-07-04 Thread Uros Bizjak
Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old in amdgpu_perf_read. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). Also, try_cmpxchg implicitly assigns old *ptr value

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

2023-07-04 Thread Christian König
Am 03.07.23 um 14:35 schrieb Arnd Bergmann: From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1344:18: error: result of comparison of constant 4294967296 with expression of type