RE: [PATCH v3] drm/amdgpu: load sdma ucode in the guest machine

2023-07-20 Thread Chen, Horace
[AMD Official Use Only - General] Reviewed-By: Horace Chen -Original Message- From: YuanShang Mao (River) Sent: Tuesday, July 18, 2023 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: YuanShang Mao (River) ; Chen, Horace ; YuanShang Mao (River) Subject: [PATCH v3] drm/amdgpu: load sdma

AMDGPU crash - request for assistance triaging / reporting

2023-07-20 Thread Matthew Hall
Hello, I see you are listed in the MAINTAINERS for Radeon / AMDGPU. I would greatly appreciate your advice in the best route to a triage and fix for the following: https://bugzilla.kernel.org/show_bug.cgi?id=217690 It makes it difficult to have a consistently stable Lenovo ThinkPad Z16 which I

RE: [PATCH] drm/amdgpu: set sw state to gfxoff after SR-IOV reset

2023-07-20 Thread Chang, HaiJun
[AMD Official Use Only - General] Reviewed-by: HaiJun Chang -Original Message- From: Horace Chen Sent: Wednesday, July 19, 2023 5:07 PM To: amd-gfx@lists.freedesktop.org Cc: Andrey Grodzovsky ; Quan, Evan ; Chen, Horace ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, H

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-20 Thread Bjorn Helgaas
On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > And in the case of upstream bridge, the driver does not even own the > device it's changing

Re: [PATCH] drm/amdgpu: Always emit GDS switch when GDS/GWS/OA is used

2023-07-20 Thread Friedrich Vock
Hi, On 07.07.23 10:21, Christian König wrote: Am 07.07.23 um 09:28 schrieb Friedrich Vock: Hi Christian, On 07.07.23 08:56, Christian König wrote: Am 07.07.23 um 08:28 schrieb Friedrich Vock: During gfxoff, the per-VMID GDS registers are reset and not restored afterwards. Hui? Since when

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-20 Thread Paul Moore
On Thu, Jul 20, 2023 at 4:28 AM Kefeng Wang wrote: > On 2023/7/19 23:25, Paul Moore wrote: > > On Wed, Jul 19, 2023 at 6:23 AM Kefeng Wang > > wrote: > >> On 2023/7/19 17:02, Christian Göttsche wrote: > >>> On Wed, 19 Jul 2023 at 09:40, Kefeng Wang > >>> wrote: > > Use the helpers to

[PATCH 7/7] drm/amdgpu/vcn: change end doorbell index for vcn_v4_0_3

2023-07-20 Thread Samir Dhume
For sriov, doorbell index for vcn0 for AID needs to be on 32 byte boundary so we need to move the vcn end doorbell Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 2/7] drm/amdgpu/vcn : Skip vcn power-gating change for sriov

2023-07-20 Thread Samir Dhume
Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c index 550ac040b4be..411c1d802823 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_

[PATCH 6/7] drm/amdgpu/jpeg: mmsch_v3_0_4 requires doorbell on 32 byte boundary

2023-07-20 Thread Samir Dhume
Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c index 85ee74fdb7e3..896e2f895884 100644 --- a/drivers

[PATCH 5/7] drm/amdgpu/jpeg: sriov support for jpeg_v4_0_3

2023-07-20 Thread Samir Dhume
initialization table handshake with mmsch Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 171 --- 1 file changed, 150 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c i

[PATCH 3/7] drm/amdgpu/vcn: sriov support for vcn_v4_0_3

2023-07-20 Thread Samir Dhume
initialization table handshake with mmsch Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 261 +--- 1 file changed, 237 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c ind

[PATCH 4/7] drm/amdgpu/vcn: mmsch_v3_0_4 requires doorbell on 32 byte boundary

2023-07-20 Thread Samir Dhume
Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c index 8650e3c6288d..09b3fa707af6 100644 --- a/drivers/gpu/dr

[PATCH 1/7] drm/amdgpu/vcn: Add MMSCH v4_0_3 support for sriov

2023-07-20 Thread Samir Dhume
The structures are the same as v4_0 except for the init header Signed-off-by: Samir Dhume --- drivers/gpu/drm/amd/amdgpu/mmsch_v4_0_3.h | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/mmsch_v4_0_3.h diff --git a/drivers/gpu/d

RE: [PATCH 3/7] drm/amdgpu/vcn: sriov support for vcn_v4_0_3

2023-07-20 Thread Dhume, Samir
[Public] Fair point. I'll follow up with another patch. Thanks, Samir -Original Message- From: Chen, Guchun Sent: Tuesday, July 18, 2023 1:54 AM To: Dhume, Samir ; amd-gfx@lists.freedesktop.org Cc: Dhume, Samir Subject: RE: [PATCH 3/7] drm/amdgpu/vcn: sriov support for vcn_v4_0_3 [Pu

Patch "drm/client: Send hotplug event after registering a client" has been added to the 6.1-stable tree

2023-07-20 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/client: Send hotplug event after registering a client to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/client: Send hotplug event after registering a client" has been added to the 6.4-stable tree

2023-07-20 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/client: Send hotplug event after registering a client to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-20 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 19, 2023 at 9:27 PM Randy Dunlap wrote: > > > > On 7/19/23 18:05, Yang Li wrote: > > Use colon to separate parameter name from their specific meaning. > > silence the warning: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter > > or

Re: [PATCH v2] drm/amd/amdgpu: Fix warnings in amdgpu/amdgpu_display.c

2023-07-20 Thread Alex Deucher
On Wed, Jul 19, 2023 at 10:42 PM Srinivasan Shanmugam wrote: > > Fixes the below checkpatch.pl warnings: > > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line > WARNING: suspect code indent for conditional statements (8, 12) > WARNING:

[PATCH 6.4] drm/client: Send hotplug event after registering a client

2023-07-20 Thread Mario Limonciello
From: Thomas Zimmermann Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core

[PATCH 6.1] drm/client: Send hotplug event after registering a client

2023-07-20 Thread Mario Limonciello
From: Thomas Zimmermann Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core

[pull] amdgpu drm-fixes-6.5

2023-07-20 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.5. The following changes since commit fdf0eaf11452d72945af31804e2a1048ee1b574c: Linux 6.5-rc2 (2023-07-16 15:10:37 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.5-2023-07-20 for you to fetch

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-20 Thread Michel Dänzer
On 7/17/23 15:09, Michel Dänzer wrote: > On 5/10/23 23:23, Alex Deucher wrote: >> From: Philip Yang >> >> Rename smv_migrate_init to a better name kgd2kfd_init_zone_device >> because it setup zone devive pgmap for page migration and keep it in >> kfd_migrate.c to access static functions svm_migrat

[PATCH v2] drm/radeon: Prefer dev_* variant over printk

2023-07-20 Thread Srinivasan Shanmugam
Changed from pr_err/info to dev_* variants so that we get better debug info when there are multiple GPUs in the system. 'Fixes: 8e2503972912c ("drm/radeon: Prefer pr_err/_info over printk")' Suggested-by: Alex Deucher Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam ---

[PATCH] vt: remove spaces after '*'

2023-07-20 Thread sunran001
remove redundant spaces to clear checkpatch errors. ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- include/linux/kbd_kern.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/kbd_kern.h b/include/linux/kbd_kern.h index c

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-20 Thread Kefeng Wang
On 2023/7/19 23:25, Paul Moore wrote: On Wed, Jul 19, 2023 at 6:23 AM Kefeng Wang wrote: On 2023/7/19 17:02, Christian Göttsche wrote: On Wed, 19 Jul 2023 at 09:40, Kefeng Wang wrote: Use the helpers to simplify code. Cc: Paul Moore Cc: Stephen Smalley Cc: Eric Paris Acked-by: Paul M

Re: [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection

2023-07-20 Thread Sui Jingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: drm/amdgpu: Implement the is_primary_gpu callback of vga_client_register() drm/radeon: Add an implement for the is_primary_gpu function callback drm/i915: Add an implement for the is_primary_gpu hook drm/ast: Register as a vga client

[bug report] drm/amd/display: Reduce stack size

2023-07-20 Thread Dan Carpenter
Hello Rodrigo Siqueira, The patch 135fd1b35690: "drm/amd/display: Reduce stack size" from Jun 21, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8785 amdgpu_dm_atomic_commit_tail() error: potent

[PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-20 Thread Yang Li
Use colon to separate parameter name from their specific meaning. silence the warning: drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags' Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-20 Thread Randy Dunlap
On 7/19/23 18:05, Yang Li wrote: > Use colon to separate parameter name from their specific meaning. > silence the warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or > member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags' > > Signed-off-by

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-20 Thread Sui Jingfeng
On 2023/7/20 06:32, suijingfeng wrote: it will be works no matter CONFIG_DRM_AST=m or CONFIG_DRM_AST=y It will be works regardless of CONFIG_DRM_AST=m or CONFIG_DRM_AST=y. When vgaarb call to the device driver, device driver already loaded successfully. and the PCI(e) device emulation al

RE: [PATCH 2/2] drm/amdgpu: not update the same version ras ta

2023-07-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, July 19, 2023 8:40 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Yang, Stanley ; Chai, Thomas > > Subject: [PATCH 2/2] drm/amdgpu:

RE: [PATCH 1/2] drm/amdgpu: add ta initialization failure check condition

2023-07-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, July 19, 2023 8:40 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Yang, Stanley ; Chai, Thomas > > Subject: [PATCH 1/2] drm/amdgpu:

RE: [PATCH] drm/amdgpu: Program xcp_ctl registers as needed

2023-07-20 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, July 20, 2023 13:56 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Zhang, Morris Subject: [PATCH] drm/amdgpu: Program xcp_ctl