Re: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran

2023-07-27 Thread Lazar, Lijo
On 7/28/2023 1:21 AM, Powell, Darren wrote: Hi all,   Just looking for anyone who could RB or ACK this patch set so I can submit it? Apart from a few nits mentioned, the series looks good to me. Reviewed-by: Lijo Lazar Thanks, Lijo Thanks Darren

Re: [PATCH 8/8] amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3

2023-07-27 Thread Lazar, Lijo
On 4/27/2023 11:57 AM, Darren Powell wrote: split switch statement into two and consolidate the common code for printing most of the types of clock speeds Signed-off-by: Darren Powell --- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 82 ++- 1 file changed, 27

Re: [PATCH 5/8] amdgpu/pm: Replace print_clock_levels with emit_clock_levels for aldebaran

2023-07-27 Thread Lazar, Lijo
On 4/27/2023 11:57 AM, Darren Powell wrote: Replace print_clock_levels with emit_clock_levels for aldebaran * replace .print_clk_levels with .emit_clk_levels in aldebaran_ppt_funcs * added extra parameter int *offset * removed var size, uses arg *offset instead * removed call to

Re: [PATCH 4/8] amdgpu/pm: Optimize emit_clock_levels for arcturus - part 3

2023-07-27 Thread Lazar, Lijo
On 4/27/2023 11:57 AM, Darren Powell wrote: split switch statement into two and consolidate the common code for printing most of the types of clock speeds Signed-off-by: Darren Powell --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 77 ++- 1 file changed, 24

Re: [PATCH 3/8] amdgpu/pm: Optimize emit_clock_levels for arcturus - part 2

2023-07-27 Thread Lazar, Lijo
On 4/27/2023 11:57 AM, Darren Powell wrote: Use variables to remove ternary expression in print statement and improve readability. This will help to optimize the code duplication in the switch statement Also Changed: replaced single_dpm_table->count as iterator in for loops with

[PATCH v2] drm/amdgpu: Move vram, gtt & flash defines to amdgpu_ ttm & _psp.h

2023-07-27 Thread Srinivasan Shanmugam
As amdgpu.h is getting decomposed, move vram and gtt extern defines into amdgpu_ttm.h & flash extern to amdgpu_psp.h 'Fixes: 35488e44ed48 ("drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c")' Suggested-by: Christian König Cc: Mario Limonciello Cc: Christian König Cc: Alex Deucher

[PATCH] drm/amdgpu: Sort the includes in amdgpu/amdgpu_drv.c

2023-07-27 Thread Srinivasan Shanmugam
Sort the include files that are included in amdgpu_drv.c alphabetically. Suggested-by: Mario Limonciello Cc: Mario Limonciello Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 25 - 1 file changed,

Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Huang, Tim
[AMD Official Use Only - General] From: Limonciello, Mario Sent: Friday, July 28, 2023 10:39 AM To: Huang, Tim ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan Subject: Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11 On 7/27/23 21:21,

RE: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran

2023-07-27 Thread Quan, Evan
[AMD Official Use Only - General] The series looks good to me. Reviewed-by: Evan Quan evan.q...@amd.com However better to split the changes of patch1 into two separate patches on your submission. Replace print_clock_levels with emit_clock_levels for arcturus *

Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Mario Limonciello
On 7/27/23 21:21, Huang, Tim wrote: [AMD Official Use Only - General] *From:* Limonciello, Mario *Sent:* Friday, July 28, 2023 9:14 AM *To:* Huang, Tim ; amd-gfx@lists.freedesktop.org *Cc:* Deucher, Alexander ; Zhang, Yifan *Subject:* Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3

Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Huang, Tim
[AMD Official Use Only - General] From: Limonciello, Mario Sent: Friday, July 28, 2023 9:14 AM To: Huang, Tim ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan Subject: Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11 On 7/27/23 20:05, Tim

RE: [PATCH] drm/amdgpu: only save and restore GPU device config at GPU error

2023-07-27 Thread Liang, Prike
[Public] Hi, Lijo > -Original Message- > From: Lazar, Lijo > Sent: Thursday, July 27, 2023 6:49 PM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: only save and restore GPU device config > at GPU error > > > > On 7/27/2023

Re: iommu/amd: fix the address translation issue when do detach

2023-07-27 Thread Mario Limonciello
On 7/27/23 04:55, Jesse Zhang wrote: From: Jesse Zhang iGpu driver fail to read/write register by iommu when start X. kernel: [ 433.296634] audit: type=1400 audit(1690403823.130:64): apparmor="DENIED" operation="capable" class="cap" profile="/snap/snapd/19457/usr/lib/snapd/snap-confine"

RE: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Kenneth Feng > Sent: Thursday, July 27, 2023 7:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Feng, Kenneth > > Subject: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0 > >

RE: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-27 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - General] Hi Michel, Could you try the patch again ? That work for me. https://patchwork.freedesktop.org/patch/549605/ Thanks Jesse From: amd-gfx On Behalf Of Zhang, Jesse(Jie) Sent: Thursday, July 27, 2023 2:11 PM To: Yang, Philip ; Michel Dänzer ; Yang, Philip

Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Mario Limonciello
On 7/27/23 20:05, Tim Huang wrote: From: Tim Huang For SMU v13.0.4/11, driver does not need to stop RLC for S0i3, the firmwares will handle that properly. Conceptually I'm aligned to this. But, just to confirm, have you already run some testing with this with current GPU F/W, BIOS and either

[PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11

2023-07-27 Thread Tim Huang
From: Tim Huang For SMU v13.0.4/11, driver does not need to stop RLC for S0i3, the firmwares will handle that properly. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amdkfd: avoid unmap dma address when svm_ranges are split

2023-07-27 Thread Alex Sierra
DMA address reference within svm_ranges should be unmapped only after the memory has been released from the system. In case of range splitting, the DMA address information should be copied to the corresponding range after this has split. But leaving dma mapping intact. Signed-off-by: Alex Sierra

Re: [PATCH v3] drm/amdgpu: Add EXT_COHERENCE memory allocation flags

2023-07-27 Thread Felix Kuehling
In amdgpu_dma_buf_create_obj we copy the coherence-related flags to the SG BO that's used to attach the BO to the importer device. You need to add the new flag to the list. Some more nit-picks inline. Am 2023-07-26 um 09:34 schrieb David Francis: These flags (for GEM and SVM allocations)

Re: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran

2023-07-27 Thread Powell, Darren
Hi all, Just looking for anyone who could RB or ACK this patch set so I can submit it? Thanks Darren From: Powell, Darren Sent: Thursday, April 27, 2023 2:27 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Quan, Evan ; Yu, Lang ; Huang, Ray ;

Re: [PATCH v3] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Alex Deucher
On Thu, Jul 27, 2023 at 2:37 PM Mario Limonciello wrote: > > Users report a white flickering screen on multiple systems that > is tied to having 64GB or more memory. When S/G is enabled pages > will get pinned to both VRAM carve out and system RAM leading to > this. > > Until it can be fixed

[PATCH v3] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Mario Limonciello
Users report a white flickering screen on multiple systems that is tied to having 64GB or more memory. When S/G is enabled pages will get pinned to both VRAM carve out and system RAM leading to this. Until it can be fixed properly, disable S/G when 64GB of memory or more is detected. This will

Re: [PATCH v2] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Alex Deucher
On Thu, Jul 27, 2023 at 2:14 PM Mario Limonciello wrote: > > On 7/27/2023 13:02, Alex Deucher wrote: > > On Thu, Jul 27, 2023 at 1:29 PM Mario Limonciello > > wrote: > >> > >> Users report a white flickering screen on multiple systems that > >> is tied to having 64GB or more memory. When S/G is

Re: [PATCH] drm/amdgpu: Move vram, gtt & flash defines to amdgpu_ ttm & _psp.h

2023-07-27 Thread Mario Limonciello
On 7/27/2023 11:31, Srinivasan Shanmugam wrote: As amdgpu.h is getting decomposed, move vram and gtt extern defines into amdgpu_ttm.h & flash extern to amdgpu_psp.h 'Fixes: 35488e44ed48 ("drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c")' Suggested-by: Christian König Cc: Mario

Re: [PATCH v2] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Mario Limonciello
On 7/27/2023 13:02, Alex Deucher wrote: On Thu, Jul 27, 2023 at 1:29 PM Mario Limonciello wrote: Users report a white flickering screen on multiple systems that is tied to having 64GB or more memory. When S/G is enabled pages will get pinned to both VRAM carve out and system RAM leading to

[PATCH 4/4] drm/amdgpu: refine fault cache updates

2023-07-27 Thread Alex Deucher
Don't update the fault cache if status is 0. In the multiple fault case, subsequent faults will return a 0 status which is useless for userspace and replaces the useful fault status, so only update if status is non-0. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7

[PATCH 2/4] drm/amdgpu: cache gpuvm fault information for gmc7+

2023-07-27 Thread Alex Deucher
Cache the current fault info in the vm struct. This can be queried by userspace later to help debug UMDs. Cc: samuel.pitoi...@gmail.com Acked-by: Guchun Chen Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 +++

[PATCH 1/4] drm/amdgpu: add cached GPU fault structure to vm struct

2023-07-27 Thread Alex Deucher
When we get a GPU page fault, cache the fault for later analysis. Cc: samuel.pitoi...@gmail.com Acked-by: Guchun Chen Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 31 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 18 +++ 2 files

[PATCH 3/4] drm/amdgpu: add new INFO ioctl query for the last GPU page fault

2023-07-27 Thread Alex Deucher
Add a interface to query the last GPU page fault for the process. Useful for debugging context lost errors. v2: split vmhub representation between kernel and userspace v3: add locking when fetching fault info in INFO IOCTL Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238

[PATCH v3 0/4] Add GPU page fault query interface

2023-07-27 Thread Alex Deucher
This patch set adds support for an application to query GPU page faults. It's useful for debugging and there are vulkan extensions that could make use of this. Preliminary user space code which uses this can be found here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238

Re: [PATCH v2] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Alex Deucher
On Thu, Jul 27, 2023 at 1:29 PM Mario Limonciello wrote: > > Users report a white flickering screen on multiple systems that > is tied to having 64GB or more memory. When S/G is enabled pages > will get pinned to both VRAM carve out and system RAM leading to > this. > > Until it can be fixed

[PATCH v2] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Mario Limonciello
Users report a white flickering screen on multiple systems that is tied to having 64GB or more memory. When S/G is enabled pages will get pinned to both VRAM carve out and system RAM leading to this. Until it can be fixed properly, disable S/G when 64GB of memory or more is detected. This will

Re: [PATCH] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Alex Deucher
On Thu, Jul 27, 2023 at 1:06 PM Mario Limonciello wrote: > > Users report a white flickering screen on multiple systems that > is tied to having 64GB or more memory. When S/G is enabled pages > will get pinned to both VRAM carve out and system RAM leading to > this. > > Until it can be fixed

RE: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, July 27, 2023 9:30 AM To: Feng, Kenneth ; amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: Re: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

[PATCH] drm/amd: Disable S/G for APUs when 64GB or more host memory

2023-07-27 Thread Mario Limonciello
Users report a white flickering screen on multiple systems that is tied to having 64GB or more memory. When S/G is enabled pages will get pinned to both VRAM carve out and system RAM leading to this. Until it can be fixed properly, disable S/G when 64GB of memory or more is detected. This will

[PATCH] drm/amdgpu: Move vram, gtt & flash defines to amdgpu_ ttm & _psp.h

2023-07-27 Thread Srinivasan Shanmugam
As amdgpu.h is getting decomposed, move vram and gtt extern defines into amdgpu_ttm.h & flash extern to amdgpu_psp.h 'Fixes: 35488e44ed48 ("drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c")' Suggested-by: Christian König Cc: Mario Limonciello Cc: Christian König Cc: Alex Deucher

[PATCH] drm/amdgpu: Clean up style problems in mmhub_v2_3.c

2023-07-27 Thread Srinivasan Shanmugam
Fixes the following: ERROR: code indent should use tabs where possible WARNING: Missing a blank line after declarations WARNING: Prefer 'unsigned int' to bare use of 'unsigned' WARNING: suspect code indent for conditional statements (8, 24) + if (!(data &

Re: [PATCH] drm/amdkfd: start_cpsch don't map queues

2023-07-27 Thread Michel Dänzer
On 7/25/23 19:06, Michel Dänzer wrote: > On 7/24/23 19:52, Philip Yang wrote: >> start_cpsch map queues when kfd_init_node have race condition with >> IOMMUv2 init, and cause the gfx ring test failed later. Remove it >> from start_cpsch because map queues will be done when creating queues >> and

[PATCH] drm/radeon: Remove the references of radeon_gem_ pread & pwrite ioctls

2023-07-27 Thread Srinivasan Shanmugam
Removing the functions of pread & pwrite & IOCTL defines, as their existence allows an authorized client to spam the system logs. 'Fixes: 6f9e0e87b71f ("drm/radeon: Fix ENOSYS with better fitting error codes in radeon_gem.c")' Suggested-by: Christian König Cc: Christian König Cc: Alex Deucher

Re: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Deucher, Alexander
[AMD Official Use Only - General] Acked-by: Alex Deucher From: amd-gfx on behalf of Kenneth Feng Sent: Thursday, July 27, 2023 7:41 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: correct the pcie width for

Re: [PATCH] drm/amdgpu: enable SDMA MGCG for SDMA 5.2.x

2023-07-27 Thread Alex Deucher
On Thu, Jul 27, 2023 at 5:49 AM Prike Liang wrote: > > Now the SDMA firmware support SDMA MGCG properly, > so let's enable it from the driver side. > > Signed-off-by: Prike Liang Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nv.c| 6 -- >

Re: [PATCH 1/6] drm: execution context for GEM buffers v7

2023-07-27 Thread Naresh Kamboju
On Sun, 23 Jul 2023 at 03:36, Nathan Chancellor wrote: > > Hi Christian, > > On Tue, Jul 11, 2023 at 03:31:17PM +0200, Christian König wrote: > > This adds the infrastructure for an execution context for GEM buffers > > which is similar to the existing TTMs execbuf util and intended to replace >

Re: [PATCH 1/2] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-07-27 Thread Lang Yu
On 07/27/ , Christian König wrote: > Am 27.07.23 um 10:15 schrieb Lang Yu: > > On 07/27/ , Christian König wrote: > > > Am 27.07.23 um 09:56 schrieb Lang Yu: > > > > amdgpu_bo_create_kernel_at() is used to create a physical > > > > contiguous VRAM BO at the specific offset. It calls > > > >

[PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Kenneth Feng
correct the pcie width value in pp_dpm_pcie for smu 13.0.0 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c

Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indentings

2023-07-27 Thread Christian König
Am 27.07.23 um 03:03 schrieb Yang Li: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:622 amdgpu_gfx_enable_kcq() warn: inconsistent indenting Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5992 Signed-off-by: Yang Li Reviewed-by: Christian König ---

Re: [PATCH 1/2] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-07-27 Thread Christian König
Am 27.07.23 um 10:15 schrieb Lang Yu: On 07/27/ , Christian König wrote: Am 27.07.23 um 09:56 schrieb Lang Yu: amdgpu_bo_create_kernel_at() is used to create a physical contiguous VRAM BO at the specific offset. It calls amdgpu_bo_create_reserved() to create a VRAM BO first, then frees its old

Re: [PATCH] drm/amdgpu: only save and restore GPU device config at GPU error

2023-07-27 Thread Lazar, Lijo
On 7/27/2023 3:20 PM, Prike Liang wrote: There's need a check on the GPU error state before save and restore GPU device config space. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] iommu/amd: fix the address translation issue when do detach

2023-07-27 Thread Jesse Zhang
From: Jesse Zhang iGpu driver fail to read/write register by iommu when start X. kernel: [ 433.296634] audit: type=1400 audit(1690403823.130:64): apparmor="DENIED" operation="capable" class="cap" profile="/snap/snapd/19457/usr/lib/snapd/snap-confine" pid=12344 comm="snap-confine"

[PATCH] drm/amdgpu: only save and restore GPU device config at GPU error

2023-07-27 Thread Prike Liang
There's need a check on the GPU error state before save and restore GPU device config space. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH] drm/amdgpu: enable SDMA MGCG for SDMA 5.2.x

2023-07-27 Thread Prike Liang
Now the SDMA firmware support SDMA MGCG properly, so let's enable it from the driver side. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/nv.c| 6 -- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 27 +- 2 files changed, 30 insertions(+), 3 deletions(-)

Re: [PATCH] drm/radeon: Fix ENOSYS with better fitting error codes in radeon_gem.c

2023-07-27 Thread Christian König
Am 26.07.23 um 16:16 schrieb Srinivasan Shanmugam: Replace the error code from 'ENOSYS' to 'EOPNOTSUPP' for unimplemented radeon_gem_pread_ioctl & radeon_gem_pwrite_ioctl Fixes the following: WARNING: ENOSYS means 'invalid syscall nr' and nothing else. Mhm, it might be better to just

RE: [PATCH] drm/amdgpu: correct vmhub index in GMC v10/11

2023-07-27 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Yu, Lang Sent: Thursday, July 27, 2023 11:02 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Chai, Thomas ; Yu, Lang Subject: [PATCH] drm/amdgpu: correct vmhub index in GMC

Re: [PATCH 2/2] drm/amdgpu: use amdgpu_bo_create_kernel_at() to create large TMR for APU

2023-07-27 Thread Lang Yu
On 07/27/ , Christian König wrote: > Am 27.07.23 um 09:56 schrieb Lang Yu: > > TMR requires physical contiguous memory, amdgpu_bo_create_kernel() > > can't satisfy large(>128MB) physical contiguous memory allocation > > request with default 512MB VRAM on APU. > > > > When requested TMR size >

Re: [PATCH 1/2] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-07-27 Thread Lang Yu
On 07/27/ , Christian König wrote: > Am 27.07.23 um 09:56 schrieb Lang Yu: > > amdgpu_bo_create_kernel_at() is used to create a physical > > contiguous VRAM BO at the specific offset. It calls > > amdgpu_bo_create_reserved() to create a VRAM BO first, > > then frees its old memory and allocates

Re: [PATCH 2/2] drm/amdgpu: use amdgpu_bo_create_kernel_at() to create large TMR for APU

2023-07-27 Thread Christian König
Am 27.07.23 um 09:56 schrieb Lang Yu: TMR requires physical contiguous memory, amdgpu_bo_create_kernel() can't satisfy large(>128MB) physical contiguous memory allocation request with default 512MB VRAM on APU. When requested TMR size > 128MB, use amdgpu_bo_create_kernel_at() to create the TMR

Re: [PATCH 1/2] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-07-27 Thread Christian König
Am 27.07.23 um 09:56 schrieb Lang Yu: amdgpu_bo_create_kernel_at() is used to create a physical contiguous VRAM BO at the specific offset. It calls amdgpu_bo_create_reserved() to create a VRAM BO first, then frees its old memory and allocates new memory at the specific offset. But

[PATCH 2/2] drm/amdgpu: use amdgpu_bo_create_kernel_at() to create large TMR for APU

2023-07-27 Thread Lang Yu
TMR requires physical contiguous memory, amdgpu_bo_create_kernel() can't satisfy large(>128MB) physical contiguous memory allocation request with default 512MB VRAM on APU. When requested TMR size > 128MB, use amdgpu_bo_create_kernel_at() to create the TMR BO at offset 64MB. Signed-off-by: Lang

[PATCH 1/2] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-07-27 Thread Lang Yu
amdgpu_bo_create_kernel_at() is used to create a physical contiguous VRAM BO at the specific offset. It calls amdgpu_bo_create_reserved() to create a VRAM BO first, then frees its old memory and allocates new memory at the specific offset. But amdgpu_bo_create_reserved() would fail if requested

Re: [PATCH v2] drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

2023-07-27 Thread Christian König
Am 25.07.23 um 06:51 schrieb Srinivasan Shanmugam: Fixes the following: WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_vram_mgr_attr_group; WARNING: externs should be avoided in .c files +extern const struct attribute_group amdgpu_gtt_mgr_attr_group;

[PATCH -next] drm/amdgpu: clean up some inconsistent indentings

2023-07-27 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:622 amdgpu_gfx_enable_kcq() warn: inconsistent indenting Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5992 Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- 1 file changed, 1 insertion(+), 2

RE: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-07-27 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - General] Hi Philip and Michel, The following issue can reproduce on my side. https://gitlab.freedesktop.org/drm/amd/-/issues/2659 when load gpu driver , disable iommu can workaround this issue. sudo modprobe amdgpu ignore_crat=1 Thanks Jesse From: amd-gfx On Behalf