[PATCH] drm/buddy: Fix drm buddy info output format

2023-08-03 Thread Ma Jun
[1] Change pages to blocks to avoid confusion. [2] Fix output format to align the output info. Signed-off-by: Ma Jun --- drivers/gpu/drm/drm_buddy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index 3d1f50f

[PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-03 Thread Wayne Lin
[Why] Now in drm_dp_remove_payload_part2(), it utilizes the time slot number of the payload in old state to represent the one in the payload table at the moment. It would be better to clarify the idea by using the latest allocated time slot number for the port at the moment instead and which info

[PATCH 1/3] drm/mst: delete unnecessary case in drm_dp_add_payload_part2()

2023-08-03 Thread Wayne Lin
[Why] There is no need to consider payload->delete case since we won't call drm_dp_add_payload_part2() to create a payload when we're about to remove it. [How] Delete unnecessary case to simplify the code. Signed-off-by: Wayne Lin --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 8 ++--

[PATCH 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-03 Thread Wayne Lin
[Why] Today, the allocation/deallocation steps and status is a bit unclear. For instance, payload->vc_start_slot = -1 stands for "the failure of updating DPCD payload ID table" and can also represent as "payload is not allocated yet". These two cases should be handled differently and hence better

[PATCH 0/3] Refactor and clean up codes of mst

2023-08-03 Thread Wayne Lin
This patch set is mainly trying to organize the mst code today a bit. Like to clarify and organize the sequence of mst payload allocation and removement.And also clean up some redundant codes today. The main refactor one is the patch "drm/mst: Refactor the flow for payload allocation/removement" w

[PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

2023-08-03 Thread Srinivasan Shanmugam
Instead of declaring pointers use READ_ONCE(), when accessing those values to make sure that the compiler doesn't voilate any cache coherences Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Cc: Le Ma Cc: Hawking Zhang Signed-off-by: Srinivasan Shanmugam --- drivers/

[PATCH] Revert "drm/amdgpu: don't modify num_doorbells for mes"

2023-08-03 Thread Yifan Zhang
This reverts commit f46644aa8de6d5efeff8d8c7fbf3ed58a89c765c. THe doorbell index could go beyond the first page for mes queues, this patch breaks the mes self test on gfx11. [ 23.212740] [drm] ring gfx_32768.1.1 was added [ 23.213147] [drm] ring compute_32768.2.2 was added [ 23.213540] [drm

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 22:44, Laurent Pinchart wrote: > On Thu, Aug 03, 2023 at 03:31:16PM +, Simon Ser wrote: > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr wrote: > > > > > The KMS docs describe "subconnector" to be defined as "downstream port" > >

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Laurent Pinchart
On Thu, Aug 03, 2023 at 03:31:16PM +, Simon Ser wrote: > On Thursday, August 3rd, 2023 at 17:22, Simon Ser wrote: > > > The KMS docs describe "subconnector" to be defined as "downstream port" for > > DP. > > Can USB-C (or USB) be seen as a DP downstream port? > > To expand on this a bit: I'

Re: [Intel-gfx] [PATCH v5 19/22] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2023-08-03 Thread jim . cromie
On Thu, Aug 3, 2023 at 1:14 AM kernel test robot wrote: > > > hi, Jim Cromie, > > we send this report to you to consult that if there is any limitation to use > this CONFIG_DRM_USE_DYNAMIC_DEBUG? > attached config is a randconfig which has CONFIG_DRM_USE_DYNAMIC_DEBUG, the > kernel built with it f

Re: [Intel-gfx] [PATCH v5 19/22] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2023-08-03 Thread jim . cromie
6f5d/3 BOOT_IMAGE=/pkg/linux/x86_64-randconfig-x015-20230731/gcc-12/fb82a8bb4e30dcf042c48563987ad3a24a416f5d/vmlinuz-6.5.0-rc2-00390-gfb82a8bb4e30 branch=linux-review/Jim-Cromie/drm-use-correct-ccflags-y-syntax/20230802-010749 job=/lkp/jobs/scheduled/vm-meta-58/boot-1-yocto-i386-minimal-2019052

Re: [PATCH] drm/amdkfd: avoid svm dump when dynamic debug disabled

2023-08-03 Thread Felix Kuehling
Is your kernel configured without dynamic debugging? Maybe we need to wrap this in some #if defined(CONFIG_DYNAMIC_DEBUG_CORE). Regards,   Felix Am 2023-08-03 um 15:38 schrieb Mike Lothian: Hi I'm seeing a compiler failure with Clang 16 CC drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_sv

Re: [PATCH] drm/amdkfd: avoid svm dump when dynamic debug disabled

2023-08-03 Thread Mike Lothian
Hi I'm seeing a compiler failure with Clang 16 CC drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.o drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:3568:2: error: call to undeclared function '_dynamic_func_call_no_desc'; ISO C99 and later do not support implicit function declarations [-Wimplic

Re: [PATCH] drm/amdgpu: add support to create large TMR BO for APU

2023-08-03 Thread Yu, Lang
[Public] Good. You can just send that to amd gfx list directly. Regards, Lang 发件人: Paneer Selvam, Arunpravin 发送时间: Friday, August 4, 2023 12:01:08 AM 收件人: Yu, Lang ; amd-gfx@lists.freedesktop.org 抄送: Koenig, Christian ; Zhang, Yifan 主题: Re: [PATCH] drm/amdgp

Re: [PATCH] drm/amdgpu: add support to create large TMR BO for APU

2023-08-03 Thread Arunpravin Paneer Selvam
Hi Lang, This is not the right method to allocate memory if you dont have a specific offset for TMR. I will send a patch for your testing in drm buddy which could fix this problem. Regards, Arun. On 8/3/2023 8:58 PM, Yu, Lang wrote: [Public] Ping ---

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 17:36, Dmitry Baryshkov wrote: > On Thu, 3 Aug 2023 at 18:31, Simon Ser cont...@emersion.fr wrote: > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr wrote: > > > > > The KMS docs describe "subconnector" to be defined as "downstream por

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 17:22, Simon Ser wrote: > The KMS docs describe "subconnector" to be defined as "downstream port" for > DP. > Can USB-C (or USB) be seen as a DP downstream port? To expand on this a bit: I'm wondering if we're mixing apples and oranges here. The current values o

Re: [PATCH] drm/amdgpu: add support to create large TMR BO for APU

2023-08-03 Thread Yu, Lang
[Public] Ping 发件人: Yu, Lang 发送时间: Tuesday, August 1, 2023 3:38:32 PM 收件人: amd-gfx@lists.freedesktop.org 抄送: Koenig, Christian ; Paneer Selvam, Arunpravin ; Zhang, Yifan ; Yu, Lang 主题: [PATCH] drm/amdgpu: add support to create large TMR BO for APU TMR requires

Re: [PATCH v3] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-08-03 Thread Yu, Lang
[Public] Ping 发件人: Yu, Lang 发送时间: 星期二, 八月 1, 2023 15:16 收件人: amd-gfx@lists.freedesktop.org 抄送: Koenig, Christian ; Paneer Selvam, Arunpravin ; Zhang, Yifan ; Yu, Lang 主题: [PATCH v3] drm/amdgpu: refine amdgpu_bo_create_kernel_at() Use amdgpu_bo_create_reserve

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Wednesday, August 2nd, 2023 at 21:23, Dmitry Baryshkov wrote: > >> >> + { DRM_MODE_SUBCONNECTOR_USB, "USB" }, /* DP */ > >> > > >> > Should this be DRM_MODE_SUBCONNECTOR_USB_C and "USB-C", in case we get > >> > another USB type later ? > >> > >> Hmm, which id should I use

Re: [PATCH] drm/amdgpu: fix possible UAF in amdgpu_cs_pass1()

2023-08-03 Thread Christian König
Am 31.07.23 um 03:41 schrieb Chen, Guchun: [Public] -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, July 28, 2023 11:23 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: fix possible UAF in amdgpu_cs_pass1() Since the ga

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-08-03 Thread Christian König
Am 03.08.23 um 07:23 schrieb SHANMUGAM, SRINIVASAN: On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harm

Re: [PATCH 4/4] drm/amdgpu: use a macro to define no xcp partition case

2023-08-03 Thread Christian König
Yeah, perfectly fine for me. I was out of office for a few days as well. Christian. Am 18.07.23 um 04:16 schrieb Chen, Guchun: [Public] Thank you for review, Felix. Hi Christian, I forgot to add your RB in patch 2/patch3 when posting this series for review. I will add it back when pushing.

[PATCH] drm/amdgpu: Clean up errors in vcn_v3_0.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' ERROR: "foo * bar" should be "foo *bar" ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/a

[PATCH] drm/amdgpu: Clean up errors in amdgpu_atombios.h

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atom

[PATCH] drm/amdgpu: Clean up errors in dce_v8_0.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: code indent should use tabs where possible ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 37 ++

[PATCH] drm/amdgpu: Clean up errors in uvd_v3_1.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c b/drivers/gpu/dr

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Dmitry Baryshkov
2 августа 2023 г. 22:13:51 GMT+03:00, Laurent Pinchart пишет: >On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: >> On 02/08/2023 21:55, Laurent Pinchart wrote: >> > Hi Dmitry, >> > >> > Thank you for the patch. >> > >> > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshko

[PATCH] drm/amdgpu: Clean up errors in mxgpu_vi.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: spaces required around that '-=' (ctx:WxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c b/drivers/gpu/drm/amd/am

[PATCH] drm/amdgpu: Clean up errors in amdgpu_virt.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/

Re: [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

2023-08-03 Thread Dmitry Baryshkov
On 02/08/2023 21:54, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:10AM +0300, Dmitry Baryshkov wrote: In the embedded usecases the default subtype depends on the bridge chain, so it is easier to specify the subtype at the proprety attachment s/pro

[PATCH] drm/amdgpu: Clean up errors in soc21.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/soc21.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-03 Thread Dmitry Baryshkov
On 02/08/2023 21:46, Laurent Pinchart wrote: On Wed, Aug 02, 2023 at 12:05:50PM +0300, Dmitry Baryshkov wrote: On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach co

[PATCH] drm/amdgpu: Clean up errors in gfx_v7_0.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: trailing statements should be on next line ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before that '++' (ctx:WxB) Signed-off-by: Ran Sun --- dri

[PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: spaces required around that '==' (ctx:VxV) ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11 +-- 1 file cha

[PATCH] drm/amdgpu: Clean up errors in amdgpu_trace.h

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: Clean up errors in tonga_ih.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c b/drivers/gpu/dr

[PATCH] drm/amdgpu: Clean up errors in nv.c

2023-08-03 Thread Ran Sun
Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/nv.c | 48 +++-- 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Dmitry Baryshkov
On 02/08/2023 21:55, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: To properly define the USB-C DP altmode connectors, add the USB subconnector type. Suggested-by: Simon Ser Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-03 Thread Dmitry Baryshkov
On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: > > On 29/07/2023 02:49, Dmitry Baryshkov wrote: > > If the created connector type supports subconnector type property, > > create and attach corresponding it. The default subtype value is 0, > > which maps to the DRM_MODE_SUBCONNECTOR_Unknown typ